Page MenuHomePhabricator
Feed Advanced Search

Dec 5 2015

epriestley updated subscribers of T4863: Allow Workboard Cards to be customized for display.
Dec 5 2015, 11:48 PM · Projects, Wikimedia, Workboards
epriestley merged task T6005: Allow remarkup syntax for tasks to extract specific fields like assignee or due date into T4863: Allow Workboard Cards to be customized for display.
Dec 5 2015, 11:48 PM · Remarkup, Maniphest
epriestley added a comment to T6005: Allow remarkup syntax for tasks to extract specific fields like assignee or due date.

I assume the use case for this is building tables in, e.g., Phriction documents with the status of various tasks.

Dec 5 2015, 11:48 PM · Remarkup, Maniphest
epriestley moved T6132: Negative Maniphest priorities can be created, but not used from Backlog to vNext on the Maniphest board.
Dec 5 2015, 11:46 PM · Maniphest
epriestley closed T8707: Task descriptions with leading newlines are not preserved correctly across edits as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 11:46 PM · Maniphest
epriestley moved T8666: When a task is resolved with "Resolves T123", Phrequent should stop tracking time from Backlog to Far Future on the Maniphest board.
Dec 5 2015, 11:43 PM · Maniphest, Phrequent
epriestley moved T8480: Support querying for tasks where a user has tracked time against them from Backlog to Far Future on the Maniphest board.
Dec 5 2015, 11:43 PM · Phrequent, Maniphest
epriestley moved T8707: Task descriptions with leading newlines are not preserved correctly across edits from Backlog to vNext on the Maniphest board.
Dec 5 2015, 11:42 PM · Maniphest
epriestley added a revision to T8707: Task descriptions with leading newlines are not preserved correctly across edits: Unknown Object (Differential Revision).
Dec 5 2015, 11:39 PM · Maniphest
epriestley claimed T8707: Task descriptions with leading newlines are not preserved correctly across edits.
Dec 5 2015, 11:38 PM · Maniphest
epriestley added a comment to T8707: Task descriptions with leading newlines are not preserved correctly across edits.

Apparently this is just how <textarea> works. Here's a test case in WebKit explicitly testing this behavior:

Dec 5 2015, 11:35 PM · Maniphest
epriestley moved T8740: Batch edit Add Project does not perform the action requested from Backlog to vNext on the Maniphest board.
Dec 5 2015, 11:03 PM · Maniphest
epriestley moved T9905: Upgrading: ApplicationEditor changes in Maniphest from Backlog to vNext on the Maniphest board.
Dec 5 2015, 11:03 PM · Maniphest, Installing & Upgrading
epriestley renamed T9077: Some applications don't support the "Quote" action on comments properly from Quotes don't work in paste and audit to Some applications don't support the "Quote" action on comments properly.
Dec 5 2015, 9:26 PM · Restricted Project, Transactions
epriestley added a comment to T9077: Some applications don't support the "Quote" action on comments properly.

I also made them work in Paste, so generalizing this task per D14416.

Dec 5 2015, 9:26 PM · Restricted Project, Transactions
epriestley closed T8676: Easy raw link for pastes as Resolved.

I implemented this a while ago:

Dec 5 2015, 9:25 PM · Paste
epriestley closed T6270: Search inside Paste as Invalid.

This task doesn't describe a root problem. See Contributing Feature Requests for modern documentation on feature requests.

Dec 5 2015, 9:24 PM · Paste
epriestley closed T8556: Pastes index fails to load. as Invalid.

In any case, we can't reproduce this and aren't sure if it reproduces at HEAD. See Contributing Bug Reports.

Dec 5 2015, 9:22 PM · Paste
epriestley added a comment to T9077: Some applications don't support the "Quote" action on comments properly.

See also D14665 for EditEngine integration, which slightly changes one call.

Dec 5 2015, 9:21 PM · Restricted Project, Transactions
epriestley closed T8853: Allow "Administrator" to be used in Herald rules for "pusher" as Wontfix.

We haven't seen other requests for this and I think putting administrators in a project and using "Pusher's projects ..." is a pretty reasonable workaround. This can also now reasonably be written as an extension.

Dec 5 2015, 9:16 PM · Diffusion, Herald
epriestley merged task T7833: Allow merge commits to be excluded in Herald rules for Audit into T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules.
Dec 5 2015, 9:11 PM · Audit, Herald
epriestley updated subscribers of T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules.
Dec 5 2015, 9:11 PM · Diffusion, Herald
epriestley merged task T7026: Add "Run build plan" to commit hooks into T9821: Allow Harbormaster build plans to run on branch push instead of per-commit.
Dec 5 2015, 9:10 PM · Harbormaster, Herald
epriestley updated subscribers of T9821: Allow Harbormaster build plans to run on branch push instead of per-commit.
Dec 5 2015, 9:10 PM · Restricted Project, Harbormaster
epriestley closed T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 9:08 PM · Diffusion, Herald
epriestley closed T6763: Allow herald rules to filter on branch/tag creation in Subversion as Wontfix.

We haven't seen other requests for this in a year, and our behavior is technically correct and I think it is broadly reasonable.

Dec 5 2015, 9:07 PM · Subversion, Herald
epriestley added a revision to T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules: Unknown Object (Differential Revision).
Dec 5 2015, 8:58 PM · Diffusion, Herald
epriestley added a project to T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules: Diffusion.
Dec 5 2015, 8:57 PM · Diffusion, Herald
epriestley claimed T5788: Support "Commit is a merge" in Herald "Commit" (post-commit) rules.
Dec 5 2015, 8:57 PM · Diffusion, Herald
epriestley closed T5274: Herald Rules - Trigger when Diff content contains as Wontfix.

I don't think this is a good fit for the upstream: it's inherently a bit unreliable, can't be made reliable, and I don't think the use case described here is a particularly robust one even if it's reasonable for some organizations.

Dec 5 2015, 8:47 PM · Herald
epriestley closed T5162: Add Herald action value for content creator / author as Wontfix.

This doesn't describe a use case (per Contributing Feature Requests) except by reference to requiring projects (which is covered by T6030).

Dec 5 2015, 8:42 PM · Herald
epriestley closed T9206: Herald unable to place task up for grabs as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 8:39 PM · Typeahead, Herald
epriestley added a revision to T9206: Herald unable to place task up for grabs: Unknown Object (Differential Revision).
Dec 5 2015, 8:38 PM · Typeahead, Herald
epriestley added a comment to T9352: Write some custom Herald glue for driving builds through Owners.

At HEAD, you can now edit this field via the owners.edit Conduit API method.

Dec 5 2015, 8:27 PM · Harbormaster, Herald, Owners, Prioritized
epriestley closed T9601: Herald rule not working as expected as Invalid.

No clue how to reproduce. If you see it again, grab the field value too? My guess is that it's something like the reviewer PHID ending up as the project PHID instead of your PHID and "Reviewer" needing to be updated to "Reviewers" or similar.

Dec 5 2015, 8:26 PM · Herald
epriestley added a comment to T7661: Object creation is often accompanied by transaction records which aren't of much use.

This is related to T5158, I'm going to split things up like this:

Dec 5 2015, 7:27 PM · Transactions, Maniphest
epriestley reopened T5158: Maniphest custom field refuses to use non-empty default value as "Open".

Ah, I figured out how to reproduce this.

Dec 5 2015, 7:25 PM · Maniphest, Custom Fields, Transactions
epriestley renamed T7661: Object creation is often accompanied by transaction records which aren't of much use from Custom field default isn't populated at creation to Object creation is often accompanied by transaction records which aren't of much use.
Dec 5 2015, 7:22 PM · Transactions, Maniphest
epriestley closed T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 7:20 PM · Maniphest, Herald
epriestley added a comment to T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions.

I think it wasn't that bad thanks to a similar set of changes elsewhere from D14669, which I wrote yesterday.

Dec 5 2015, 7:19 PM · Maniphest, Herald
epriestley added a revision to T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions: Unknown Object (Differential Revision).
Dec 5 2015, 7:17 PM · Maniphest, Herald
epriestley added a revision to T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions: Unknown Object (Differential Revision).
Dec 5 2015, 7:12 PM · Maniphest, Herald
epriestley closed T9496: Allow Maniphest custom statuses (and priorities) to be disabled as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 7:01 PM · Maniphest
epriestley reopened T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions as "Open".
Dec 5 2015, 6:59 PM · Maniphest, Herald
epriestley added a comment to T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions.

Oh, I should have read that comment more carefully. You tested more thoroughly than I did.

Dec 5 2015, 6:59 PM · Maniphest, Herald
epriestley closed T7848: Allow herald rules to change task status in HeraldManiphestTaskAdapter Actions as Resolved.
Dec 5 2015, 6:56 PM · Maniphest, Herald
epriestley closed T7250: Actions in wrong order after merging duplicates + reopening as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 6:51 PM · Maniphest
epriestley added a revision to T9496: Allow Maniphest custom statuses (and priorities) to be disabled: Unknown Object (Differential Revision).
Dec 5 2015, 6:44 PM · Maniphest
epriestley claimed T9496: Allow Maniphest custom statuses (and priorities) to be disabled.
Dec 5 2015, 6:41 PM · Maniphest
epriestley claimed T7250: Actions in wrong order after merging duplicates + reopening.
Dec 5 2015, 6:09 PM · Maniphest
epriestley added a revision to T7250: Actions in wrong order after merging duplicates + reopening: Unknown Object (Differential Revision).
Dec 5 2015, 6:08 PM · Maniphest
epriestley closed T5158: Maniphest custom field refuses to use non-empty default value as Resolved.

This no longer reproduces for me at HEAD in EditEngine (see T9905), although I can't immediately reproduce it in the old editor either. Since it seems like it got fixed somewhere I'm not going to worry about it too much.

Dec 5 2015, 5:57 PM · Maniphest, Custom Fields, Transactions
epriestley updated the task description for T9905: Upgrading: ApplicationEditor changes in Maniphest.
Dec 5 2015, 5:53 PM · Maniphest, Installing & Upgrading
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

Defining permissions for newbies that may be distinct from the "got the hang of it" crowd

Dec 5 2015, 5:37 PM · ApplicationEditor
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 5 2015, 5:14 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a comment to T9897: Unbeta Feedback on Phame.

(You could put more ignore stuff in the route too if you want the blog title.)

Dec 5 2015, 3:21 PM · Phame
epriestley added a comment to T9897: Unbeta Feedback on Phame.

You can probably just do that by adding a route like this:

Dec 5 2015, 3:11 PM · Phame
epriestley added a comment to T9897: Unbeta Feedback on Phame.

Yes, but blogs don't have slugs right now and blog post slugs are editable.

Dec 5 2015, 3:06 PM · Phame
epriestley updated the post content for Blog Post: Development Notes (2015 Week 49).
Dec 5 2015, 2:39 PM
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

The interaction between Maniphest "Can Edit X" fields and the new form stuff is also currently quite bad. I've restored 'Can Prioritize Tasks' to "All Users" on this install, since users otherwise can not create tasks with the new forms.

Dec 5 2015, 2:21 PM · ApplicationEditor
epriestley closed T9911: test as Spite.
Dec 5 2015, 2:20 PM · Feature Request
epriestley added a comment to T9360: Unbeta Phame.

The story on SNI actually looks pretty reasonable (we're mostly just losing IE on XP and very old mobile devices), and should be more reasonable by the time we're thinking about whitelabeling main instances.

Dec 5 2015, 2:02 PM · Phame
epriestley added a comment to T9360: Unbeta Phame.

It's also possible that we can roll our own loadbalancers by assigning a lot of elastic IPs to a single host. This currently allows us to put ~240 domains on a host, at a cost of ~$4 per domain per month (for the elastic IP) instead of ~$20 per domain per month, but is more work. In contrast, SNI would let us put thousands of domains on a host with no cost per domain.

Dec 5 2015, 1:52 PM · Phame
epriestley added a comment to T9360: Unbeta Phame.

One other thing is that custom domains won't work on Phacility by default, and I don't think we can easily make them work (we can't just have users CNAME their DNS because we won't have the right SSL certificate). So maybe that's an argument for removing the feature or adding an option (ugh) to disable it.

Dec 5 2015, 1:46 PM · Phame
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

I'm consistently not seeing a comment preview on T9910. Likely trace:

Dec 5 2015, 12:56 PM · ApplicationEditor
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

The major product issue I'm now unsure about is what form we should use when you interact with the create/edit flow from places other than Maniphest → Create Task. Exhaustively, I believe these are:

Dec 5 2015, 12:45 PM · ApplicationEditor
tycho.tatitscheff awarded T9905: Upgrading: ApplicationEditor changes in Maniphest a Love token.
Dec 5 2015, 12:08 PM · Maniphest, Installing & Upgrading
epriestley triaged T9898: `git branch --contains X` has cost in the realm of O(commits * branches) as Low priority.

That makes sense, and should work well if you're able to convince developers to use arc feature (or the underlying branch flags, or I think branch.autosetupmerge in Git config?) consistently. You might also consider leaving git:branch-unique(...) in the ruleset after arc:upstream -- it should behave well in more situations than git:merge-base(...) will, I think, and it might be preferable if the penalty for not using --track is "things work, but are slow" instead of "things don't work".

Dec 5 2015, 11:55 AM · Restricted Project, Restricted Project, Arcanist
epriestley added a comment to T9905: Upgrading: ApplicationEditor changes in Maniphest.

Just to be clear, after this week - sites that upgrade but are tracking the stable branch will be affected by these changes?

Dec 5 2015, 11:28 AM · Maniphest, Installing & Upgrading
epriestley renamed Blog Post: Development Notes (2015 Week 49) blog post from to Development Notes (2015 Week 49).
Dec 5 2015, 1:08 AM
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

Policy junk should be fixed.

Dec 5 2015, 1:06 AM · ApplicationEditor
epriestley added a comment to T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.

The basics of the ApplicationEditor stuff are now live on this install, and T9908 has some discussion of the direction I think we can pursue for the "Security" use case.

Dec 5 2015, 1:01 AM · Maniphest, Installing & Upgrading
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

Edit forms are causing some policy checks to apply incorrectly so tasks (which should be public) currently aren't. Looking into that...

Dec 5 2015, 12:54 AM · ApplicationEditor
epriestley added a comment to T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.

One severe regression is that the description textarea in the create form is tiny now. I need to make that gigantic again.

Dec 5 2015, 12:52 AM · ApplicationEditor
epriestley added a comment to T9905: Upgrading: ApplicationEditor changes in Maniphest.

I landed what I've got so far, pushed it here, configured it a bit, and described what I've done in T9908, for the curious.

Dec 5 2015, 12:51 AM · Maniphest, Installing & Upgrading
epriestley created T9908: Temporary Guide to Edit Forms / ApplicationEditor Chatter.
Dec 5 2015, 12:50 AM · ApplicationEditor
epriestley closed T9907: Testing feature request form as Spite.
Dec 5 2015, 12:42 AM · Feature Request
epriestley created T9907: Testing feature request form.
Dec 5 2015, 12:42 AM · Feature Request
epriestley closed T9906: Testing bug report form as Invalid.
Dec 5 2015, 12:42 AM · Bug Report
epriestley created T9906: Testing bug report form.
Dec 5 2015, 12:41 AM · Bug Report
epriestley set the image for Feature Request to F1014086: project.png.
Dec 5 2015, 12:40 AM
epriestley set the image for Bug Report to F1014085: project.png.
Dec 5 2015, 12:40 AM
epriestley set the icon for Bug Report to fa-bug.
Dec 5 2015, 12:39 AM
epriestley created Feature Request.
Dec 5 2015, 12:39 AM
epriestley created Bug Report.
Dec 5 2015, 12:39 AM
epriestley closed T4580: Auto saving forms doesn't save dynamic form visibility state as Resolved by committing Restricted Diffusion Commit.
Dec 5 2015, 12:31 AM · Maniphest
epriestley edited the content of Changelog.
Dec 5 2015, 12:14 AM
epriestley created 2015 Week 49 (Very Early December).
Dec 5 2015, 12:14 AM

Dec 4 2015

epriestley created T9905: Upgrading: ApplicationEditor changes in Maniphest.
Dec 4 2015, 11:59 PM · Maniphest, Installing & Upgrading
epriestley closed T9904: The Paste app doesn't work as Resolved.

Cool, let us know if you run into anything else.

Dec 4 2015, 11:47 PM · Paste
epriestley added a comment to T9904: The Paste app doesn't work.

(At the least, I can't reproduce these issues at HEAD.)

Dec 4 2015, 11:43 PM · Paste
epriestley edited P1902 (An Untitled Masterwork).
Dec 4 2015, 11:43 PM
epriestley added a comment to T9904: The Paste app doesn't work.

You're a few days out of date -- I believe both of these issues are fixed at HEAD. Can you upgrade and let me know if you're still seeing issues?

Dec 4 2015, 11:43 PM · Paste
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 11:01 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T4580: Auto saving forms doesn't save dynamic form visibility state: Unknown Object (Differential Revision).
Dec 4 2015, 11:01 PM · Maniphest
epriestley added a comment to T9903: Header buttons on dashboard panels are lost when panels are embedded in a tab panel.

Specifically, you're talking about this?

Dec 4 2015, 10:21 PM · Dashboards
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 10:19 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 4 2015, 10:13 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a comment to T9901: Provide self-contained Arcanist executable.

will the patch be reviewed and merged

Dec 4 2015, 9:12 PM · Arcanist
epriestley added a comment to T9898: `git branch --contains X` has cost in the realm of O(commits * branches).

That's the workflow I use, but I --amend "feature" when updating it.

Dec 4 2015, 8:14 PM · Restricted Project, Restricted Project, Arcanist