Page MenuHomePhabricator
Feed Advanced Search

Dec 2 2015

epriestley added a revision to T5031: Draft Comment Persists After Submission: Unknown Object (Differential Revision).
Dec 2 2015, 8:58 PM · Restricted Project, Support Impact, Mobile
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 2 2015, 8:58 PM · Restricted Project, ApplicationEditor, Transactions
epriestley moved T9887: Builds do not recover properly if a build step has an invalid build plan (e.g., a removed class) from Backlog to Far Future on the Harbormaster board.
Dec 2 2015, 8:54 PM · Restricted Project, Harbormaster
epriestley triaged T9887: Builds do not recover properly if a build step has an invalid build plan (e.g., a removed class) as Wishlist priority.
Dec 2 2015, 8:54 PM · Restricted Project, Harbormaster
epriestley added a comment to T9875: Build hosts run out of disk space because Drydock doesn't clean up working copies automatically.

still won't get cleaned up and instead Drydock will just fail to allocate.

Dec 2 2015, 8:46 PM · Bug Report, Drydock
epriestley added a comment to T9875: Build hosts run out of disk space because Drydock doesn't clean up working copies automatically.

So you have a machine full of unused working copies, and Drydock is failing every build instead of reusing them?

Dec 2 2015, 8:45 PM · Bug Report, Drydock
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Restricted Differential Revision.
Dec 2 2015, 7:38 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 2 2015, 7:17 PM · Restricted Project, ApplicationEditor, Transactions
epriestley closed T9874: Documentation references to "restart your webserver" do not explicitly tell you to restart both HTTP and PHP server processes as Resolved by committing Restricted Diffusion Commit.
Dec 2 2015, 5:16 PM · Setup, Documentation
epriestley added a revision to T9874: Documentation references to "restart your webserver" do not explicitly tell you to restart both HTTP and PHP server processes: Unknown Object (Differential Revision).
Dec 2 2015, 5:13 PM · Setup, Documentation
epriestley renamed T9874: Documentation references to "restart your webserver" do not explicitly tell you to restart both HTTP and PHP server processes from Need better instructions to fix the issue related to post_max_size to Documentation references to "restart your webserver" do not explicitly tell you to restart both HTTP and PHP server processes.
Dec 2 2015, 5:11 PM · Setup, Documentation
epriestley claimed T9874: Documentation references to "restart your webserver" do not explicitly tell you to restart both HTTP and PHP server processes.
Dec 2 2015, 4:33 PM · Setup, Documentation
epriestley added a comment to T9875: Build hosts run out of disk space because Drydock doesn't clean up working copies automatically.

When this happens, there'll be hundreds of builds all running at the same time, which can result in hundreds of working copies for the same repository.

Dec 2 2015, 4:31 PM · Bug Report, Drydock
epriestley added a comment to T9876: Arcanist filename linter's regex should be configurable.

I'm concerned that it's difficult to give users a descriptive error message if the pattern is an arbitrary regular expression. What does your patch do when a filename fails a custom regular expression? Specifically, how does it help the user fix their filename?

Dec 2 2015, 4:23 PM · Lint, Arcanist
epriestley closed T9887: Builds do not recover properly if a build step has an invalid build plan (e.g., a removed class) as Invalid.

I don't know how to reproduce the behavior this report describes. See Contributing Bug Reports.

Dec 2 2015, 3:57 PM · Restricted Project, Harbormaster
epriestley changed the edit policy for T9889: Object selector dialog does not work in Elasticsearch 2.0.
Dec 2 2015, 3:53 PM · Elasticsearch
epriestley added a comment to T9890: Version and lock search index rebuilds to reduce the cost of runaway writes.

I can't reproduce this. Here's what I did:

Dec 2 2015, 3:42 PM · Search
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 2 2015, 2:18 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Dec 2 2015, 2:06 PM · Restricted Project, ApplicationEditor, Transactions
epriestley created T9888: Provide guidance in the documentation about PHP7.
Dec 2 2015, 12:27 PM · Documentation
epriestley added a comment to T5096: Create a phabricator authentication provider that uses mediawiki oauth.

Aaah! That makes sense.

Dec 2 2015, 3:18 AM · Auth, Wikimedia
epriestley updated subscribers of T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Dec 2 2015, 1:21 AM · Restricted Project, FreeBSD, Arcanist
epriestley merged task T9885: Support custom task status values in Conduit query method into T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Dec 2 2015, 1:21 AM · Conduit, Maniphest
epriestley added a comment to T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.

I'm not 100% sure it actually works, but you'd just do this:

Dec 2 2015, 12:55 AM · Maniphest, Installing & Upgrading
epriestley added a comment to T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.

I believe if you include a transaction which sets the CCs to the current CCs, it is guaranteed to run after any personal rules and will entirely undo the effects of any sneaky rules anyone might write.

Dec 2 2015, 12:43 AM · Maniphest, Installing & Upgrading

Dec 1 2015

epriestley added a comment to P1897 find-unaccepted-revisions.php.

We also probably need to implement Phabricator Credits before we can add ᵐᶦᶜʳᵒᵖᵃʸᵐᵉᶰᵗˢ because otherwise we'll just be paying Stripe for the privilege of having ᵐᶦᶜʳᵒᵖᵃʸᵐᵉᶰᵗˢ.

Dec 1 2015, 11:28 PM
epriestley added a comment to P1897 find-unaccepted-revisions.php.

My major concern with pursuing that (or, say, "$1 to file a task") is that user expectations will be like billion times higher if something costs $0.25 than if it's free.

Dec 1 2015, 11:22 PM
epriestley updated the title for P1897 find-unaccepted-revisions.php from untitled to find-unaccepted-revisions.php.
Dec 1 2015, 10:54 PM
epriestley added a comment to T9881: Call to undefined method PhabricatorProjectBoardViewController::addExtraQuickSandConfig().

I think that'll fix it, let us know if you're still seeing issues? Thanks for the report!

Dec 1 2015, 9:41 PM
epriestley closed T9881: Call to undefined method PhabricatorProjectBoardViewController::addExtraQuickSandConfig() as Resolved by committing Restricted Diffusion Commit.
Dec 1 2015, 9:41 PM
epriestley added a revision to T9881: Call to undefined method PhabricatorProjectBoardViewController::addExtraQuickSandConfig(): Unknown Object (Differential Revision).
Dec 1 2015, 9:40 PM
epriestley updated subscribers of T9881: Call to undefined method PhabricatorProjectBoardViewController::addExtraQuickSandConfig().

This is from D14622, probably just a missed grep (likely because the method name is spelled QuickSand instead of Quicksand at this callsite).

Dec 1 2015, 9:32 PM
epriestley added a comment to T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.

Broadly, we're in no rush to get rid of these events -- definitely no need to panic. I just wanted to push things in the right direction after T9851 was filed, which originally asked for the scope of these events to be substantially expanded.

Dec 1 2015, 9:25 PM · Maniphest, Installing & Upgrading
epriestley added a comment to T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.

My recollection, at least, is that Herald wasn't originally suitable because of T6367. Prior to that task, an "attacker" could write a rule like this:

Dec 1 2015, 9:19 PM · Maniphest, Installing & Upgrading
epriestley added a comment to T9880: Confused by direction of blocking relationship between tasks.

See prior discussion in T5021 / D9270.

Dec 1 2015, 9:08 PM · Maniphest
epriestley added a comment to T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed.

What are you doing which can't be covered by Herald?

Dec 1 2015, 8:15 PM · Maniphest, Installing & Upgrading
20after4 awarded T9860: Upgrading: TYPE_MANIPHEST_WILLEDITTASK and TYPE_MANIPHEST_DIDEDITTASK are deprecated and will be removed a Dislike token.
Dec 1 2015, 8:09 PM · Maniphest, Installing & Upgrading
epriestley added a comment to T9724: "ssh-exec" sometimes hangs when git cloning larger repos .

I can't reproduce this. Here's what I did:

Dec 1 2015, 12:38 PM · Git
renannp awarded T5132: Document the special syntax you can use in commit messages to cause effects a The World Burns token.
Dec 1 2015, 3:21 AM · Guides, Diffusion
epriestley added a comment to T9853: Support comments in Herald Actions .

That's expected if you've written an "every time" rule.

Dec 1 2015, 2:29 AM · Restricted Project
epriestley added a comment to T9875: Build hosts run out of disk space because Drydock doesn't clean up working copies automatically.

so I end up with lots of copies of the same thing

Dec 1 2015, 12:42 AM · Bug Report, Drydock

Nov 30 2015

epriestley added a comment to T9874: Documentation references to "restart your webserver" do not explicitly tell you to restart both HTTP and PHP server processes.

Which instructions were you looking at which you found confusing? Can you point me at the document? (Or was it the setup warning itself?)

Nov 30 2015, 11:44 PM · Setup, Documentation
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 30 2015, 10:25 PM · Restricted Project, ApplicationEditor, Transactions
niedzielski awarded T929: Allow two arbitrary revisions to be compared in Diffusion a Love token.
Nov 30 2015, 7:15 PM · Diffusion (v3), Restricted Project
epriestley added a comment to T9873: arc alias outputs a confusing message when adding a shell command alias.

Aliased 'arc foo' to 'foo'.

Nov 30 2015, 6:36 PM · Arcanist
epriestley triaged T9873: arc alias outputs a confusing message when adding a shell command alias as Wishlist priority.
Nov 30 2015, 6:34 PM · Arcanist
epriestley moved T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml) from Backlog to Far Future on the Harbormaster board.
Nov 30 2015, 4:48 PM · Restricted Project, Harbormaster
epriestley renamed T9608: Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml) from Implement POST request body text field to Implement complex variable replacement DSLs in Harbormaster (application/json, application/xml).
Nov 30 2015, 4:48 PM · Restricted Project, Harbormaster
epriestley closed T9663: improve builds/buildables search as Invalid.

There's no description of what problems this is trying to solve. I don't want to just add random fields in the hope that some will be useful; see Contributing Feature Requests.

Nov 30 2015, 4:47 PM · Harbormaster
epriestley added a subtask for T6455: Implement support for dynamically building new AMI / disk image blueprints in Drydock: T5544: Implement EC2 blueprint for Drydock.
Nov 30 2015, 4:45 PM · Drydock
epriestley added a parent task for T5544: Implement EC2 blueprint for Drydock: T6455: Implement support for dynamically building new AMI / disk image blueprints in Drydock.
Nov 30 2015, 4:45 PM · Drydock
epriestley triaged T6455: Implement support for dynamically building new AMI / disk image blueprints in Drydock as Wishlist priority.
Nov 30 2015, 4:45 PM · Drydock
epriestley closed T9872: Give Drydock Working Copies useful names as Invalid.

I'll need to at some point go and clean these up.

Nov 30 2015, 4:44 PM · Drydock
epriestley closed T9698: Allow bots to have email addresses assigned to them as Invalid.
  • I believe username association works correctly.
  • Assigning an email is already mandatory when creating a bot:
Nov 30 2015, 4:42 PM · Drydock, People, Diffusion
epriestley moved T1816: Support downloading a compressed working copy (tar/zip) of a repository at a specific commit or tag from Backlog to Future on the Drydock board.
Nov 30 2015, 4:40 PM · Drydock, Diffusion
epriestley merged task T9760: Autoscaling for Almanac devices into T5544: Implement EC2 blueprint for Drydock.
Nov 30 2015, 4:40 PM · Drydock, Almanac
epriestley merged T9760: Autoscaling for Almanac devices into T5544: Implement EC2 blueprint for Drydock.
Nov 30 2015, 4:40 PM · Drydock
epriestley added a comment to T9760: Autoscaling for Almanac devices.

I don't plan Almanac to ever autoscale. Autoscaling would be via a new, non-Almanac EC2 blueprint (or similar blueprints, which permit creation of new host resources). I'm just going to merge this into T5544.

Nov 30 2015, 4:39 PM · Drydock, Almanac
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 30 2015, 4:39 PM · Restricted Project, ApplicationEditor, Transactions
epriestley moved T9872: Give Drydock Working Copies useful names from Backlog to Future on the Drydock board.
Nov 30 2015, 4:39 PM · Drydock
josetesan awarded T9378: Build Projects v3 a Love token.
Nov 30 2015, 3:15 PM · Projects (v3), Prioritized
epriestley closed T9869: Certain transactions not viewable while logged out? as Resolved by committing Restricted Diffusion Commit.
Nov 30 2015, 2:55 PM · Policy, Transactions
epriestley added a revision to T9869: Certain transactions not viewable while logged out?: Unknown Object (Differential Revision).
Nov 30 2015, 2:52 PM · Policy, Transactions
epriestley added a comment to T9869: Certain transactions not viewable while logged out?.

Perfect! This should be easy to fix.

Nov 30 2015, 2:50 PM · Policy, Transactions
epriestley added a comment to T9869: Certain transactions not viewable while logged out?.

I can reproduce the bug on what I think is a relatively up-to-date production installation.

Nov 30 2015, 2:40 PM · Policy, Transactions
epriestley added a comment to T9869: Certain transactions not viewable while logged out?.

You need to give us steps we can actually follow in a development environment to reproduce the issue. We can not examine database data, logs, etc, on the WMF install.

Nov 30 2015, 2:36 PM · Policy, Transactions
epriestley added a comment to T9869: Certain transactions not viewable while logged out?.

Here's what I get. Note:

Nov 30 2015, 2:33 PM · Policy, Transactions
epriestley added a comment to T9869: Certain transactions not viewable while logged out?.

I can't reproduce, those steps work fine for me on this install. I can click "Show Details" on the transaction above while logged out and get a dialog showing the details.

Nov 30 2015, 2:32 PM · Policy, Transactions
epriestley updated the task description for T9869: Certain transactions not viewable while logged out?.
Nov 30 2015, 2:31 PM · Policy, Transactions
epriestley added a comment to T9869: Certain transactions not viewable while logged out?.

Here's my guess at how to reproduce:

Nov 30 2015, 2:31 PM · Policy, Transactions
epriestley added a comment to T6889: Evaluate PHP alternatives to NodeJS for Aphlict.

This is very unlikely to happen.

Nov 30 2015, 2:26 PM · Aphlict
epriestley updated subscribers of T6889: Evaluate PHP alternatives to NodeJS for Aphlict.
Nov 30 2015, 1:46 PM · Aphlict
epriestley renamed T6889: Evaluate PHP alternatives to NodeJS for Aphlict from Remove NodeJS dependency to Evaluate PHP alternatives to NodeJS for Aphlict.
Nov 30 2015, 1:46 PM · Aphlict

Nov 29 2015

epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 29 2015, 9:45 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 29 2015, 7:31 PM · Restricted Project, ApplicationEditor, Transactions
featherless awarded T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges a Like token.
Nov 29 2015, 6:26 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 29 2015, 6:14 PM · Restricted Project, ApplicationEditor, Transactions
epriestley created T9871: Some PHUI form controls do not have identifiable "disabled" states.
Nov 29 2015, 5:40 PM · ApplicationEditor
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 29 2015, 5:37 PM · Restricted Project, ApplicationEditor, Transactions

Nov 28 2015

epriestley added a comment to T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction.

D14589 should fix the immediate issue. I've also cherry-picked it into stable.

Nov 28 2015, 9:43 PM · Differential
epriestley renamed T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction from `metamta.differential.unified-comment-context` not working at HEAD? to Straighten out addTextSection() / addRemarkupSection() in mail body construction.
Nov 28 2015, 9:42 PM · Differential
epriestley added a revision to T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction: Unknown Object (Differential Revision).
Nov 28 2015, 9:33 PM · Differential
epriestley added a comment to T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction.

Context here is:

Nov 28 2015, 8:44 PM · Differential
epriestley added a comment to T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction.

I think this is just junked up and I hadn't pushed this server when I claimed it works.

Nov 28 2015, 8:37 PM · Differential
epriestley added a comment to T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction.

This is likely the next cause up the line:

Nov 28 2015, 8:34 PM · Differential
epriestley added a comment to T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction.

I just saw this happen on this install (no metamta.differential.unified-comment-context) so my guess was probably incorrect.

Nov 28 2015, 8:29 PM · Differential
epriestley claimed T9845: Straighten out addTextSection() / addRemarkupSection() in mail body construction.
Nov 28 2015, 8:29 PM · Differential
epriestley closed T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune as Resolved by committing Restricted Diffusion Commit.
Nov 28 2015, 5:14 PM · Phacility, Phortune
epriestley added a revision to T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune: Unknown Object (Differential Revision).
Nov 28 2015, 5:01 PM · Phacility, Phortune
epriestley added a comment to T9862: Harbormaster fails to queue lease .

Can you point out which parts of Contributing Bug Reports, User Guide: Prototype Applications and Support Resources are unclear to you with respect to this report so we can improve the documentation?

Nov 28 2015, 4:25 PM · Drydock, Harbormaster
epriestley renamed Blog Post: Development Notes (2015 Week 48) blog post from to Development Notes (2015 Week 48).
Nov 28 2015, 1:51 PM
epriestley edited the content of Changelog.
Nov 28 2015, 1:29 PM
epriestley created 2015 Week 48 (Very Late November).
Nov 28 2015, 1:28 PM
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 28 2015, 1:02 PM · Restricted Project, ApplicationEditor, Transactions

Nov 27 2015

epriestley added a comment to T9756: Allow Blogs and Posts to be archived.

Yeah, consistency and like "attacker gets into your account and deletes all your stuff and it's gone forever and you are so very sad" and such.

Nov 27 2015, 9:59 PM · Phame
epriestley added a comment to T9756: Allow Blogs and Posts to be archived.

We could probably just do unpublished for now and wait until we have a stronger use case for a real "archive".

Nov 27 2015, 9:56 PM · Phame
epriestley awarded T9866: Preambles in Legalpad aren't clearly visually distinguished from document text a Mountain of Wealth token.
Nov 27 2015, 9:35 PM · PHUI
epriestley added a comment to T9866: Preambles in Legalpad aren't clearly visually distinguished from document text.

Way better on my monitor now, thanks!

Nov 27 2015, 9:35 PM · PHUI
epriestley added a comment to T9867: Articulate meaningful corporate values.

I am also fine with articulating meaningless corporate values.

Nov 27 2015, 9:34 PM · Phacility
epriestley created T9867: Articulate meaningful corporate values.
Nov 27 2015, 9:26 PM · Phacility