Page MenuHomePhabricator

"Blocks" instead of "Dependent Tasks"
Closed, ResolvedPublic

Description

Today in a meeting we have realized that a bunch of seasoned bug reporters were all regularly confused by the combo "Dependent Tasks" / "Depends On", just because of the choice of words.

In Bugzilla it is clear:

  • "Depends on"
  • "Blocks"

Two verbs in third person with opposite/complementary meaning. Yin Yang ---> Tao.

You can see it in action e.g. at http://fab.wmflabs.org/T58

Event Timeline

qgil raised the priority of this task from to Needs Triage.
qgil updated the task description. (Show Details)
qgil added projects: Phabricator, Badge Awarded.
qgil updated the task description. (Show Details)
qgil added a subscriber: qgil.

I would like to second some sort of change, as I often get lost as to which I need to do from where. We say "subtask" in most create flows, so I'd lean towards something in that direction.

If we implement T4207 ("Subtask" and "Dependency" being different relationships) it would be confusing to call a graph relationship "Subtask".

I'd maybe lean more toward "Blocks" / "Blocked By"?

epriestley triaged this task as Normal priority.

In Maniphest, change the names of the "Dependencies" and "Depends on" relationships to "Blocks" and "Blocked By", to reduce ambiguity (or suggest alternatives if you think this idea is junk). Offhand, they appear in:

  • UI labels for the fields;
  • "Edit Dependencies" in the action list
  • transaction strings ("added dependent tasks", etc)
  • UI strings in the dependencies dialog (title/submit/etc)

We currently use "dependencies" in Differential too, but let's leave that one for the moment, I suppose. It's a more technical domain and is used much more rarely, and interacts with some other code. In the long run, we should probably make it consistent.