Page MenuHomePhabricator
Feed Advanced Search

Aug 6 2015

epriestley removed a subtask for T8097: Allow external systems to report results into Harbormaster: T5822: Implement garbage collection / automatic archiving for Harbormaster logs.
Aug 6 2015, 5:25 PM · Harbormaster
epriestley closed T5854: User reporting Herald claims it triggered a build plan, but buildable and plan are nowhere to be found, a subtask of T8096: Improve Harbormaster UI/UX (v1), as Wontfix.
Aug 6 2015, 5:24 PM · Harbormaster
epriestley closed T5854: User reporting Herald claims it triggered a build plan, but buildable and plan are nowhere to be found as Wontfix.

This report is about a year old, things have changed a lot, and I haven't seen other reports and can't immediately reproduce it.

Aug 6 2015, 5:24 PM · Herald, Harbormaster
epriestley closed T5058: Improve diagnostics around waiting targets in Harbormaster as Wontfix.

This has changed a bunch and I haven't experienced any difficulty with it in the last year or so.

Aug 6 2015, 5:23 PM · Harbormaster
epriestley closed T5058: Improve diagnostics around waiting targets in Harbormaster, a subtask of T8096: Improve Harbormaster UI/UX (v1), as Wontfix.
Aug 6 2015, 5:23 PM · Harbormaster
epriestley added a comment to T7013: Support bulk transmission of notification frames in internal Aphlict protocol.

Well, no level other than 0.

Aug 6 2015, 5:21 PM · Aphlict, Conpherence
epriestley added a comment to T7013: Support bulk transmission of notification frames in internal Aphlict protocol.

Yeah -- we can pursue that stuff, but I'm strongly suspicious that user complaints about mail volume aren't meaningfully correlated to actual mail volume and that there is no level we can drive it down to which will meaningfully reduce user frustration.

Aug 6 2015, 5:19 PM · Aphlict, Conpherence
epriestley added a comment to T5055: Distribution mechanism for arc extensions.

And I generally agree about dependencies and externals getting ignored for now, but I'd like to assume we'll eventually support both and plan around that.

Aug 6 2015, 5:17 PM · Arcanist
epriestley added a comment to T5055: Distribution mechanism for arc extensions.

On these things:

Aug 6 2015, 5:02 PM · Arcanist
epriestley closed T8657: Harbormaster v1 Errata, a subtask of T8089: Unprototype Harbormaster (v1), as Resolved.
Aug 6 2015, 4:54 PM · Prioritized, Harbormaster
epriestley closed T8657: Harbormaster v1 Errata as Resolved by committing Restricted Diffusion Commit.
Aug 6 2015, 4:54 PM · Harbormaster
epriestley updated subscribers of T7013: Support bulk transmission of notification frames in internal Aphlict protocol.

@chad, do you have any particular objections to disabling all mail (other than welcome / password reset mail, which we obviously need to send) by default-default after we give administrators tools to selectively adjust the defaults in T5791 / T4103? It feels a little extreme to me, but I think we're going to be dealing with this forever if we don't do it.

Aug 6 2015, 4:52 PM · Aphlict, Conpherence
epriestley added a comment to T7013: Support bulk transmission of notification frames in internal Aphlict protocol.

Put another way, the one case of this which I've conclusively pinned on a root cause was "user is wildly sensitive about email and also would rather complain about it over and over again than spend much less energy fixing the problem", and the fix was "look up volume statistics, roll eyes out of sockets".

Aug 6 2015, 4:47 PM · Aphlict, Conpherence
epriestley added a comment to T7013: Support bulk transmission of notification frames in internal Aphlict protocol.

Product reasons normally, although technical reasons if metamta.one-mail-per-recipient is enabled (we can't batch mail which must be delivered to multiple distinct recipients).

Aug 6 2015, 4:38 PM · Aphlict, Conpherence
epriestley added a comment to T8090: Allow Harbormaster to perform change handoff in a defensible way.

For example, suppose A is on B, which is on master.

Aug 6 2015, 4:16 PM · Haskell.org, Restricted Project, Harbormaster
epriestley added a comment to T8090: Allow Harbormaster to perform change handoff in a defensible way.

As a reviewer, I expect the code that lands to be the code from the revision web page

Aug 6 2015, 3:43 PM · Haskell.org, Restricted Project, Harbormaster
epriestley added a revision to T8657: Harbormaster v1 Errata: Unknown Object (Differential Revision).
Aug 6 2015, 3:36 PM · Harbormaster
epriestley added a comment to T5055: Distribution mechanism for arc extensions.

Yeah, that's exactly what I'm imagining (I mean, maybe not exactly that command, but that workflow). Then I can sign your packages as Phacility and users can see that they're trusting your claim about the package, but that Phacility also supports your claims about who you are and your claims about the package.

Aug 6 2015, 3:19 PM · Arcanist
epriestley closed T8726: Modularize Herald fields and actions as Resolved.

Thing seem quiet now.

Aug 6 2015, 2:52 PM · Herald
epriestley closed T8726: Modularize Herald fields and actions, a subtask of T5016: Allow Herald rules for Maniphest to act on custom task fields, as Resolved.
Aug 6 2015, 2:52 PM · Custom Fields, Herald
epriestley closed T8726: Modularize Herald fields and actions, a subtask of T655: Integrate CustomField into Herald, as Resolved.
Aug 6 2015, 2:52 PM · Herald, Custom Fields
epriestley closed T8726: Modularize Herald fields and actions, a subtask of T5791: Write Herald rules for outbound mail, as Resolved.
Aug 6 2015, 2:52 PM · Restricted Project, Restricted Project, FreeBSD, Mail
epriestley closed T8726: Modularize Herald fields and actions, a subtask of T5889: Allow herald rules to act on existence of auditors, as Resolved.
Aug 6 2015, 2:52 PM · Restricted Project, Audit, Herald
epriestley closed T8726: Modularize Herald fields and actions, a subtask of T7804: Implement an "Acting User" Herald condition, as Resolved.
Aug 6 2015, 2:52 PM · Restricted Project, Herald, Mail
epriestley closed T8726: Modularize Herald fields and actions, a subtask of T6919: Add Herald support to Ponder, as Resolved.
Aug 6 2015, 2:52 PM · Herald, Ponder
epriestley closed T8726: Modularize Herald fields and actions, a subtask of T8434: Accommodate the "Security" workflow, as Resolved.
Aug 6 2015, 2:52 PM · Wikimedia, Policy, Prioritized
epriestley added a revision to T8089: Unprototype Harbormaster (v1): Unknown Object (Differential Revision).
Aug 6 2015, 2:35 PM · Prioritized, Harbormaster
epriestley added a comment to T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.

I think we could pick any available UTF8 locale here safely, as they should only differ in collation rules (I think?) and I don't think we ever rely on VCS commands to sort text. I'd also favor a setup warning if only a small number of user are affected and it's easy to install/generate locales, though.

Aug 6 2015, 2:12 PM · Diffusion (v3)
epriestley added a comment to T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.

How do you detect that a locale is missing? Parse locale -a?

Aug 6 2015, 2:08 PM · Diffusion (v3)
epriestley added a comment to T9082: `arc land` creates unnecessary local `master` branch in Git.

The broad issue with making this process have fewer side effects is that it potentially makes it much harder for less experienced users to understand what's happening and what state they're in. My experience at Facebook was that a majority of engineers learned as little about Git as they could in order to do their jobs, and I would not have expected many of them to understand concepts like a "detached HEAD". I'd guess less than 20% knew about or were comfortable with git reflog.

Aug 6 2015, 2:01 PM · Arcanist
epriestley added a comment to T5055: Distribution mechanism for arc extensions.

I think we can just take the tree hash (git show -s --format=%T) and sign that [1].

Aug 6 2015, 1:32 PM · Arcanist
epriestley added a comment to T9090: Create task button is greyed out.

See also T6502. Our handling of permissions here has changed a couple of times and this should never be greyed out, I think.

Aug 6 2015, 11:12 AM · Workboards
epriestley added a comment to T9077: Some applications don't support the "Quote" action on comments properly.

Modernizing -- the timeline needs setQuoteTargetID() and setQuoteRef() to activate "Quote". This should be more automatic than it is, but the comment boxes are custom per app right now. If you want to go manually add the calls now that'll work, or we can wait until this gets a general modernization pass and should pick it up for free.

Aug 6 2015, 4:36 AM · Restricted Project, Transactions
epriestley added a comment to T9086: Hide "Edit Query" if there are no fields to search on.

Some SearchEngines don't provide any fields.

Aug 6 2015, 1:05 AM · ApplicationSearch
epriestley added a comment to T9082: `arc land` creates unnecessary local `master` branch in Git.

Would this solve your problem?

Aug 6 2015, 1:01 AM · Arcanist

Aug 5 2015

epriestley added a revision to T8089: Unprototype Harbormaster (v1): Unknown Object (Differential Revision).
Aug 5 2015, 9:42 PM · Prioritized, Harbormaster
epriestley added a comment to T6920: Move Voting in Ponder to "Helpfuls".

Yeah, I generally agree with that direction. I'm not really even sure if we need anything, or could maybe get away with a binary thing (like "good", which makes the answer gold and promotes it to the top of the page) since a lot of the "such wow" stuff can probably be covered with tokens.

Aug 5 2015, 9:14 PM · Ponder
epriestley closed T2628: Add project tags to Pholio, Ponder, Differential, and other applications as Resolved.

I think everything actually implements PhabricatorPolicyInterface now, and the rest of this is covered by T8633 / T8634 (when modernized, project filtering happens for free).

Aug 5 2015, 8:59 PM · Projects
epriestley closed T2628: Add project tags to Pholio, Ponder, Differential, and other applications, a subtask of T4264: Implement Repo/Project Herald rules to provide a middle ground between personal and global rules, as Resolved.
Aug 5 2015, 8:59 PM · Repositories, Herald, Projects
epriestley closed T2628: Add project tags to Pholio, Ponder, Differential, and other applications, a subtask of T5595: Allow all applications to filter results by project, as Resolved.
Aug 5 2015, 8:59 PM · Projects, ApplicationSearch
epriestley reopened T9077: Some applications don't support the "Quote" action on comments properly as "Open".
Aug 5 2015, 7:50 PM · Restricted Project, Transactions
epriestley added a comment to T9082: `arc land` creates unnecessary local `master` branch in Git.

Particularly, I would expect the total cost of ignoring master to be that git branch has one extra line. At least for me, git branch is useless as a routine command anyway:

Aug 5 2015, 7:33 PM · Arcanist
epriestley added a comment to T9082: `arc land` creates unnecessary local `master` branch in Git.

I'd like to see reports from at least a few other users before pursuing this. I believe this workflow is highly unorthodox, and accommodating it would require special casing almost every step of arc land, make the workflow more complex for everyone else, and replace some errors with potentially confusing behaviors under normal use.

Aug 5 2015, 7:25 PM · Arcanist
epriestley added a parent task for T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same: T9082: `arc land` creates unnecessary local `master` branch in Git.
Aug 5 2015, 6:54 PM · Restricted Project, Arcanist
epriestley added a subtask for T9082: `arc land` creates unnecessary local `master` branch in Git: T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.
Aug 5 2015, 6:54 PM · Arcanist
epriestley triaged T9082: `arc land` creates unnecessary local `master` branch in Git as Wishlist priority.
Aug 5 2015, 6:54 PM · Arcanist
epriestley renamed T9080: Service-based repositories in Phacility cluster fail too abruptly if cloning fails from ConduitClientException for new repository in Diffusion to Service-based repositories in Phacility cluster fail too abruptly if cloning fails.
Aug 5 2015, 4:16 PM · Diffusion, Phacility
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Aug 5 2015, 4:15 PM
epriestley added a comment to T9080: Service-based repositories in Phacility cluster fail too abruptly if cloning fails.

Awesome! I'll keep this around as context for getting the root issue fixed. Thanks for the report, and let us know if you run into anything else.

Aug 5 2015, 4:15 PM · Diffusion, Phacility
epriestley added a comment to T9080: Service-based repositories in Phacility cluster fail too abruptly if cloning fails.

Another possible workaround would be to go find the credential in Passphrase and just update that, assuming the rest of the configuration is correct.

Aug 5 2015, 4:14 PM · Diffusion, Phacility
epriestley added a comment to T9080: Service-based repositories in Phacility cluster fail too abruptly if cloning fails.

Er, sorry, had the wrong URL in the previous comment. Should be correct now, I think.

Aug 5 2015, 4:12 PM · Diffusion, Phacility
epriestley added a comment to T9080: Service-based repositories in Phacility cluster fail too abruptly if cloning fails.

If you manually go to /diffusion/COLP/edit/ does that work?

Aug 5 2015, 4:12 PM · Diffusion, Phacility
epriestley added a comment to T9080: Service-based repositories in Phacility cluster fail too abruptly if cloning fails.

We should improve the error handling behavior here. Because this is a clustered repository, we're failing more abruptly than we would with a non-service repository, but we should make the behavior more similar.

Aug 5 2015, 4:04 PM · Diffusion, Phacility
epriestley updated subscribers of T9066: Add logic in AphrontDefaultApplicationConfiguration to check for and parse application/json Content-Type.

I am not asking for "support" per se, so I am not sure the referenced link is applicable for this task.

Aug 5 2015, 3:54 PM · Aphront
epriestley closed T9079: TestOne as Invalid.
Aug 5 2015, 1:42 PM
epriestley added a comment to T9073: The "PHPCS" linter gets out of memory error on large files.

Why do you have a memory limit configured on the CLI? Do you legitimately want scripts to exit after consuming 128MB of RAM, or is this just a default you haven't changed?

Aug 5 2015, 1:11 PM · Lint
epriestley closed T9072: Arc diff support to set the dependent status as Resolved.

Type Depends on D123. in your summary. See T5132.

Aug 5 2015, 1:07 PM · Arcanist
epriestley closed T9072: Arc diff support to set the dependent status , a subtask of T9071: Herald rule supports Differential Revision dependent processing, as Resolved.
Aug 5 2015, 1:07 PM · Differential, Herald
epriestley added a comment to T9070: Re-evaluate "slowness" linter rule.

Yeah, basically strncmp has worst-case runtime O(length(needle)) while strpos has worst-case runtime O(length(haystack) * length(needle)).

Aug 5 2015, 1:05 PM · Lint
• kwk awarded T4171: Building reporting and data systems a Like token.
Aug 5 2015, 7:36 AM · Restricted Project, FreeBSD, Wikimedia, Facts
epriestley added a comment to T9070: Re-evaluate "slowness" linter rule.

Try with a 10MB haystack.

Aug 5 2015, 5:00 AM · Lint

Aug 4 2015

epriestley closed T7419: Provide a straightforward way to create and update CI test statuses for a revision as Resolved by committing Restricted Diffusion Commit.
Aug 4 2015, 8:05 PM · Differential, Harbormaster
epriestley closed T7419: Provide a straightforward way to create and update CI test statuses for a revision, a subtask of T8097: Allow external systems to report results into Harbormaster, as Resolved.
Aug 4 2015, 8:05 PM · Harbormaster
epriestley added a revision to T7419: Provide a straightforward way to create and update CI test statuses for a revision: Unknown Object (Differential Revision).
Aug 4 2015, 7:35 PM · Differential, Harbormaster
epriestley added a revision to T7419: Provide a straightforward way to create and update CI test statuses for a revision: Unknown Object (Differential Revision).
Aug 4 2015, 7:30 PM · Differential, Harbormaster
epriestley added a revision to T8973: Encoding JSON for presentation could use more human-friendly escaping rules: Unknown Object (Differential Revision).
Aug 4 2015, 7:28 PM · Customer Impact
epriestley added a revision to T7419: Provide a straightforward way to create and update CI test statuses for a revision: Unknown Object (Differential Revision).
Aug 4 2015, 7:28 PM · Differential, Harbormaster
epriestley added a comment to T9066: Add logic in AphrontDefaultApplicationConfiguration to check for and parse application/json Content-Type.

See also:

Aug 4 2015, 7:19 PM · Aphront
epriestley closed T9066: Add logic in AphrontDefaultApplicationConfiguration to check for and parse application/json Content-Type as Invalid.

Sorry, we do not support third-party application development. See T5447 for discussion.

Aug 4 2015, 7:18 PM · Aphront
epriestley added a comment to T8531: Duplicate column name "spacePHID".

Comcastic!

Aug 4 2015, 6:46 PM
epriestley added a comment to T8531: Duplicate column name "spacePHID".

(If you immediately get another error, there's some more serious problem with state tracking. This usually means you imported/exported awkwardly or mucked with the data somehow, and recovery depends on exactly what state you're in and how you got there.)

Aug 4 2015, 6:44 PM
epriestley added a comment to T8531: Duplicate column name "spacePHID".

(If you immediately get another error, there's some more serious problem with state tracking. This usually means you imported/exported awkwardly or mucked with the data somehow, and recovery depends on exactly what state you're in and how you got there.)

Aug 4 2015, 6:43 PM
epriestley added a comment to T8531: Duplicate column name "spacePHID".

Delete all the text in 20150609.spaces.1.pholio.sql (but not the file itself), then run bin/storage upgrade again.

Aug 4 2015, 6:41 PM
epriestley added a comment to T7419: Provide a straightforward way to create and update CI test statuses for a revision.

Ah, thanks! I think we're probably in fairly good shape once everything is properly documented so I'll plan to close this out and we can look at placeholder results in the future if there's a compelling need for it from somewhere else.

Aug 4 2015, 5:44 PM · Differential, Harbormaster
epriestley added a comment to T7419: Provide a straightforward way to create and update CI test statuses for a revision.

I'll add one thing to Evan's comments there, which is that it would be useful to be able to create a test before the results are available. That way reviewers can see that such and such tests are still running and their results are pending.

Aug 4 2015, 4:57 PM · Differential, Harbormaster
epriestley merged task T9061: Can't change view in UIExamples into T5752: Navigation menus should work correctly on mobile by default.
Aug 4 2015, 4:39 PM · Mobile, PHUI
epriestley merged T9061: Can't change view in UIExamples into T5752: Navigation menus should work correctly on mobile by default.
Aug 4 2015, 4:39 PM · ApplicationEditor, Infrastructure, PHUI, Mobile
epriestley closed T9060: Herald Transcript error after updating Phabricator as Resolved by committing Restricted Diffusion Commit.
Aug 4 2015, 2:32 PM · Herald
epriestley added a revision to T9060: Herald Transcript error after updating Phabricator: Unknown Object (Differential Revision).
Aug 4 2015, 8:20 AM · Herald
epriestley added a comment to T9057: Searching the wiki takes too many clicks.

See T4213 for "we change CSS all the time and your stuff will break every few months if you mess with it".

Aug 4 2015, 2:32 AM · Phriction, Restricted Project
epriestley added a comment to T9056: Project templates.

Can you give me a better idea of what these huge, extremely similar projects are? I can't come up with any guesses from my experience, and the categories don't precisely sound like operations or software engineering. I've never heard the term "Fitout" before and Google is only giving me hits in the context of interior design.

Aug 4 2015, 2:25 AM · FreeBSD, Restricted Project
epriestley added a comment to T9054: Undefined class constant ACTION_BLOCK.

I pushed this host, should be all set now?

Aug 4 2015, 2:07 AM · Herald
epriestley added a comment to T9056: Project templates.

Broadly, we're much more able to solve problems if you describing the problem you're facing rather than just the solution you're interested in:

Aug 4 2015, 12:39 AM · FreeBSD, Restricted Project
epriestley added a comment to T9056: Project templates.

There's some prior discussion of something similar in T7190. Is your use case a lot like that, or a lot different, or somewhere in between?

Aug 4 2015, 12:33 AM · FreeBSD, Restricted Project
epriestley closed T9054: Undefined class constant ACTION_BLOCK as Resolved by committing Restricted Diffusion Commit.
Aug 4 2015, 12:05 AM · Herald
epriestley closed T9054: Undefined class constant ACTION_BLOCK, a subtask of T8726: Modularize Herald fields and actions, as Resolved.
Aug 4 2015, 12:05 AM · Herald
epriestley added a comment to T8830: `bin/remove destroy` is dangerous and leaves dangling edges.

Put another way, there is no scenario where running bin/remove destroy is desirable:

Aug 4 2015, 12:00 AM · Infrastructure, Restricted Project

Aug 3 2015

epriestley added a comment to T8830: `bin/remove destroy` is dangerous and leaves dangling edges.

It is difficult to concisely communicate what bin/remove destroy does.

Aug 3 2015, 11:43 PM · Infrastructure, Restricted Project
epriestley added a comment to T8830: `bin/remove destroy` is dangerous and leaves dangling edges.

Whoops, that's half a draft. Ignore that, I'll write a proper version...

Aug 3 2015, 11:15 PM · Infrastructure, Restricted Project
epriestley added a comment to T8830: `bin/remove destroy` is dangerous and leaves dangling edges.
Aug 3 2015, 11:14 PM · Infrastructure, Restricted Project
epriestley closed T9055: Weird Herald spacing, a subtask of T8726: Modularize Herald fields and actions, as Resolved.
Aug 3 2015, 10:49 PM · Herald
epriestley closed T9055: Weird Herald spacing as Resolved by committing Restricted Diffusion Commit.
Aug 3 2015, 10:49 PM · Herald
epriestley added subtasks for T8726: Modularize Herald fields and actions: T9055: Weird Herald spacing, T9054: Undefined class constant ACTION_BLOCK.
Aug 3 2015, 10:46 PM · Herald
epriestley added a parent task for T9054: Undefined class constant ACTION_BLOCK: T8726: Modularize Herald fields and actions.
Aug 3 2015, 10:46 PM · Herald
epriestley added a revision to T9054: Undefined class constant ACTION_BLOCK: Unknown Object (Differential Revision).
Aug 3 2015, 10:45 PM · Herald
epriestley claimed T9054: Undefined class constant ACTION_BLOCK.
Aug 3 2015, 10:44 PM · Herald
epriestley added a revision to T9055: Weird Herald spacing: Unknown Object (Differential Revision).
Aug 3 2015, 10:36 PM · Herald
epriestley claimed T9055: Weird Herald spacing.
Aug 3 2015, 10:34 PM · Herald
epriestley updated subscribers of T731: Allow revisions to have alternate acceptance conditions.
Aug 3 2015, 10:21 PM · Restricted Project, Restricted Project, Differential
epriestley merged task T9053: Fix asymmetry between Project Reviewers and normal Reviewers into T731: Allow revisions to have alternate acceptance conditions.
Aug 3 2015, 10:21 PM · Differential, Restricted Project