Page MenuHomePhabricator

Hide "Edit Query" if there are no fields to search on
Closed, WontfixPublic

Description

There are a bunch of applications which show an "Edit Query" button but don't provide any fields to query on. This seems odd to me and maybe we should just hide the button?

See /drydock/log/, for example:

Screenshot_2015-08-06-09-43-19.png (1×1 px, 207 KB)

Event Timeline

joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence updated the task description. (Show Details)
joshuaspence added a subscriber: joshuaspence.
chad claimed this task.

We should always have something to search, otherwise there isn't a reason to use application search.

Some SearchEngines don't provide any fields.

I think they're all prototypes though (screenshot is from Drydock), and this probably isn't really worth fixing since they pretty much inevitably get fields before they unprototype.

I couldn't think of any non prototypes. Dashboards recently got them.