Page MenuHomePhabricator
Feed Advanced Search

May 4 2015

epriestley updated subscribers of T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
May 4 2015, 10:28 PM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
epriestley merged task T8063: [Feature Request] Server default time-format configuration into T4103: Implement "Role Profiles" to provide search, homepage and application defaults.
May 4 2015, 10:28 PM · Localization
epriestley added a comment to T7904: InvalidArgumentException in ManiphestTaskSearchEngine.php.

Is it possible that you didn't restart Apache (or PHP-FPM, if running nginx + php-fpm) and the old code is stuck in APC?

May 4 2015, 10:28 PM · Dashboards
anda awarded T3179: Importing data from external systems (like GitHub, JIRA, Trac, Asana, Trello, etc.) a Love token.
May 4 2015, 8:46 PM · Guides, Doorkeeper
epriestley added a comment to T6859: It is difficult to keep track of used PhabricatorEdgeType IDs.

Yeah, real apps might be overkill for this.

May 4 2015, 8:35 PM · Infrastructure
epriestley added a comment to T8016: Exception using search: "Invalid UTF-8 string passed to phutil_utf8v()".

Nope, sorry.

May 4 2015, 8:15 PM · Restricted Project, Search
epriestley added a comment to T5700: Improve panel queries to support multiple conditions.

We have this; I'm not sure if it's helpful or not (not much specifically about search filters):

May 4 2015, 7:52 PM · Dashboards
epriestley closed T8061: When following an anchor to an inline comment, highlight the comment as Resolved by committing Restricted Diffusion Commit.
May 4 2015, 7:21 PM · Differential
epriestley added a revision to T8061: When following an anchor to an inline comment, highlight the comment: Unknown Object (Differential Revision).
May 4 2015, 7:16 PM · Differential
epriestley created T8061: When following an anchor to an inline comment, highlight the comment.
May 4 2015, 7:01 PM · Differential
epriestley added a revision to T7447: Bring inline comments forward across revision updates: Unknown Object (Differential Revision).
May 4 2015, 6:55 PM · Prioritized, Differential
epriestley added a comment to T7477: Handle inbound email with phabricator address in the CC.

One of the subscribers (person A) accidentally replies-to-all with a comment. This sends two emails -- the first is from:A, to:phabricator, cc:subscribers, and the second (a few minutes later) is from:phabricator to:subscribers.

May 4 2015, 5:27 PM · llvm, Restricted Project, Restricted Project, Mail
epriestley added a comment to T7447: Bring inline comments forward across revision updates.

Also, I'm missing a button to "see comment in original context", in cases where the current context is confusing.

May 4 2015, 5:21 PM · Prioritized, Differential
epriestley added a comment to T7447: Bring inline comments forward across revision updates.

Fold “Done” comments only. Leave “Not Done” open.

May 4 2015, 5:20 PM · Prioritized, Differential
epriestley created T8060: Let the date control swap between text and selector modes?.
May 4 2015, 5:03 PM · Calendar
epriestley closed T8058: Unit tests failing at HEAD as Resolved by committing Restricted Diffusion Commit.
May 4 2015, 4:15 PM · Celerity
epriestley reopened T7108: high server load due to continuous hg calls as "Open".

Hmm, okay. I'll take another look at this and see if I can reproduce it.

May 4 2015, 4:10 PM · Mercurial
epriestley added a comment to T6859: It is difficult to keep track of used PhabricatorEdgeType IDs.

Now that PhabricatorApplicationConfigurationPanel is modular, I'm inclined to do this:

May 4 2015, 4:04 PM · Infrastructure
epriestley added a comment to T7108: high server load due to continuous hg calls.

Are those processes old, from before your most recent restart? (e.g., "STARTED" column in ps auxwww) I think <defunct> usually indicates that the process is not in good shape. Maybe try this:

May 4 2015, 4:00 PM · Mercurial
epriestley added a comment to T7108: high server load due to continuous hg calls.

There's no way to limit the number of processes, no. What are the processes you're still seeing? We shouldn't generally be running the same hg log command anymore, so it would be surprising to me if you're seeing a smaller number of very similar processes.

May 4 2015, 3:49 PM · Mercurial
epriestley closed T6735: launching daemons (phd) locks server (high load) or start is failing as Resolved.

With autoscaling pools and reduced overseer memory requirements this is probably indirectly fixed -- phd start is ~3x less memory hungry or something in that vein. Haven't seen any more reports of it recently.

May 4 2015, 3:48 PM · Documentation, Daemons
epriestley closed T7108: high server load due to continuous hg calls as Resolved.

Presuming this is fixed since no one's yelling, but let us know if you're still seeing issues.

May 4 2015, 3:44 PM · Mercurial
epriestley closed T7235: Phortune queries exception for no results. as Resolved.

They have canUseInPanelContext() now so I think this got fixed somewhere.

May 4 2015, 3:42 PM · Phortune, Dashboards
epriestley closed T8059: Differential inline comments show on incorrent lines if the file contents changed as Wontfix.

"Older Comment" no longer exists at HEAD. Please see T7447 for discussion of this feature.

May 4 2015, 3:35 PM · Differential
epriestley closed T7498: Phragment application has an empty title as Wontfix.

I'm just going to kill this under the "no bug reports on prototypes" rule since I imagine we'll fix it the next time Phragment gets touched and Phragment has one trillion other problems.

May 4 2015, 3:28 PM · Phragment
epriestley closed T5700: Improve panel queries to support multiple conditions as Invalid.

I don't understand what this is asking for. You can build a panel which shows open tasks you are subscribed to like this:

May 4 2015, 3:26 PM · Dashboards
epriestley added a comment to T7447: Bring inline comments forward across revision updates.

Are people who have had chance to use the auto-folding inlines finding that they're an improvement?

May 4 2015, 3:24 PM · Prioritized, Differential
epriestley closed T8059: Differential inline comments show on incorrent lines if the file contents changed as Wontfix.

See discussion in T7447.

May 4 2015, 3:18 PM · Differential
epriestley updated subscribers of T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.
May 4 2015, 3:12 PM · Restricted Project, Auth, Conduit
epriestley merged task T7343: arc install-certificate doesn't work with bot users into T5955: Refactor Conduit auth to be stateless, token-based, and support wire encodings.
May 4 2015, 3:12 PM · Arcanist
epriestley added a comment to T7343: arc install-certificate doesn't work with bot users.

I'm just going to merge this into T5955 -- this is going to become:

May 4 2015, 3:12 PM · Arcanist
epriestley added a revision to T8058: Unit tests failing at HEAD: Unknown Object (Differential Revision).
May 4 2015, 3:07 PM · Celerity
epriestley added a comment to T8002: Diffusion "Locate File" typeahead silently failing.

Hmm, I'm not sure then. It doesn't look like it's producing that much output, either ("... (10,110 more bytes) ..."), so I can't imagine it's any sort of resource exhaustion or OOM-killer kind of issue.

May 4 2015, 3:04 PM · Diffusion
epriestley created T8057: Allow creation of Calendar events by sending mail to an address.
May 4 2015, 3:01 PM · Calendar
epriestley added a comment to T7477: Handle inbound email with phabricator address in the CC.

I'm just not sure what the expected behavior is if there are multiple valid addresses (I'd say: reject the mail, but maybe that's not what anyone else would expect).

May 4 2015, 2:54 PM · llvm, Restricted Project, Restricted Project, Mail
epriestley added a comment to T7533: Tasks created through ManiphestReplyHandler::receiveEmail no longer send emails to subscribers.

I think we should possibly make an exception for creating objects -- for normal replies on existing objects you get two copies of basically the same mail, but for creating objects you're losing out on the link to the created object. But we're going to hit this again soon in Calendar and can take another look at it then.

May 4 2015, 2:50 PM · Maniphest
epriestley closed T7549: Differential patch access policy via arcconfig file as Wontfix.

Access is automatically set to require access to the containing repository if Phabricator knows about the repository (use arc which to check).

May 4 2015, 2:46 PM · Differential, Arcanist
epriestley closed T7091: Grep Linter as Wontfix.

ScriptAndRegexLinter needs to be modernized, but is strictly more powerful than the proposed linter. Something like this will implement your desired lint rule after the linter modernizes:

May 4 2015, 2:43 PM · Lint, Arcanist
epriestley added a comment to T7593: Allow administrators to disable files to prevent "l33t w4r3z" abuse cases.

I think it's reasonable to always let administrators disable files they can see. We don't run into any problems by supporting that and it makes cleanup a bit easier for a reasonable set of low-sophistication attacks / nuisance users (disable the user and then disable the l33t w4r3z they uploaded).

May 4 2015, 2:34 PM · Abuse, Files
epriestley closed T7595: Not able to call phabricator api's through svn pre-commit script. as Wontfix.

Closing for lack of feedback. See also T7674.

May 4 2015, 2:30 PM
epriestley closed T7597: Unable to access the previous commits from a phabricator repo after changing the hosting parameter to host repo on GitHub, then revrted it back to phabricator itself as Invalid.

We don't have enough information to reproduce this problem.

May 4 2015, 2:28 PM
epriestley added a comment to T4267: Support alias accounts.

T7908 is somewhat similar.

May 4 2015, 2:19 PM · Restricted Project, FreeBSD
epriestley added a comment to T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.

I think the HGTEST repo works now.

May 4 2015, 2:15 PM · Diffusion (v3)
epriestley closed T6516: Diffusion pings accidentally tasks because the same task numbers are mentioned in cloned commit messages as Resolved.

I think this is fixed now. In particular, the behavior today would be:

May 4 2015, 2:13 PM · Wikimedia, Diffusion
epriestley closed T7734: consider hiding email commands from help menu if inbound email is disabled as Wontfix.

This has been in HEAD for about a month and we haven't seen any other installs reporting issues with it. If it's still causing problems, you could disable it locally like this until inbound mail gets set up:

May 4 2015, 2:05 PM · Setup, Mail
epriestley added a comment to T7908: Implement aliases for objects.

Another possible attack on this is Phurl (T6049), a planned URL shortener application, which has the U monogram. We'll probably support named URLs (e.g., https://your.install.com/u/corp can be a named short URL which takes you to the corporate site or whatever) and we could reasonably let Phurl URLs also resolve into objects (i.e., store "the object D123" instead of "the URL http://x.y/z"). Maybe named short URLs end up with a monogram like U/corp (generically, they'd be U/8anf1X for randomly-assigned short URLs) and perhaps that covers things.

May 4 2015, 1:52 PM · Maniphest
epriestley closed T7962: Make it easier to find inactive projects as Wontfix.

We haven't seen other requests for this and it doesn't seem very valuable to most installs. The definition of "inactive" is also subjective, and seems likely to vary from one user to another.

May 4 2015, 1:47 PM · Projects
epriestley closed T7968: Add the ability to 'request to join' a project; add approval for projects as Wontfix.

We haven't seen other requests for this and it doesn't seem likely to be especially valuable to very many installs. As a workaround, you could perhaps use a task or conpherence room to collect join requests instead ("comment on this task if you want to be added to project X" + link to the task in the project description).

May 4 2015, 1:40 PM · Projects
epriestley updated subscribers of T4279: Improve auth/LDAP import tools to assist in linking/merging accounts and migrations across providers.
May 4 2015, 1:35 PM · Auth
epriestley merged task T6267: Ignore already existing phabricator users when listing ldap results into T4279: Improve auth/LDAP import tools to assist in linking/merging accounts and migrations across providers.
May 4 2015, 1:35 PM · Auth, LDAP
epriestley merged task T4137: user_externalaccount table goes out of sync when user try to login before adding it using "import from LDAP" into T4279: Improve auth/LDAP import tools to assist in linking/merging accounts and migrations across providers.
May 4 2015, 1:35 PM · Support Impact, Auth, LDAP
epriestley merged task T7970: When new users are created with "Import from LDAP" they are required to be approved into T4279: Improve auth/LDAP import tools to assist in linking/merging accounts and migrations across providers.
May 4 2015, 1:35 PM · LDAP
epriestley renamed T7978: Persist document scroll position across "back" navigation in Quicksand from browser BACK jumps to top of page to Persist document scroll position across "back" navigation in Quicksand.
May 4 2015, 1:33 PM · Quicksand, PHUI
epriestley renamed T8047: Differential inline reticle can persist across Quicksand navigations from Odd Div on page to Differential inline reticle can persist across Quicksand navigations.
May 4 2015, 1:31 PM · Inline Comments, Quicksand
epriestley renamed T8049: Improve parsing of variables embedded in strings in XHPAST from Improve parsing of strings to Improve parsing of variables embedded in strings in XHPAST.
May 4 2015, 1:31 PM · XHPAST
psychomieze awarded T3980: Support "Bind to External Thing" to define project membership a Like token.
May 4 2015, 1:27 PM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects
brablc awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
May 4 2015, 9:40 AM · Workboards (v3), Restricted Project
epriestley added a comment to T8044: On /people/query make it possible to query for only non-disabled users.

I want to be able to see every user that has access to my phabricator install.

May 4 2015, 2:17 AM · People

May 3 2015

epriestley added a comment to T8002: Diffusion "Locate File" typeahead silently failing.

Does this command work properly when run from /var/repo/XYZ, where 'XYZ' is the repository callsign?

May 3 2015, 11:18 PM · Diffusion
epriestley updated subscribers of T6707: 'Attaching' two external accounts of the same type results in AphrontCountQueryException.
May 3 2015, 11:16 PM · Wikimedia, Auth
epriestley merged task T8005: Unhandled Exception in auth providers when trying to refresh/remove external LDAP provider from account with updated username attribute into T6707: 'Attaching' two external accounts of the same type results in AphrontCountQueryException.
May 3 2015, 11:16 PM · Auth
epriestley renamed T6707: 'Attaching' two external accounts of the same type results in AphrontCountQueryException from 'Attaching' two Mediawiki accounts results in AphrontCountQueryException to 'Attaching' two external accounts of the same type results in AphrontCountQueryException.
May 3 2015, 11:15 PM · Wikimedia, Auth
epriestley added a revision to T8013: @font-face cross origin request in Internet Explorer: Unknown Object (Differential Revision).
May 3 2015, 11:15 PM · PHUI, Internet Explorer
epriestley closed T8015: Permit limiting auth types for certain users (or email domain names) as Wontfix.

This use case is very far outside the mainstream and not a good fit for the upstream.

May 3 2015, 11:12 PM · Auth
epriestley added a comment to T8033: Inform editor when panels have more restrictive policy than dashboard.

T6560 is essentially the same issue, but specifically with tabbed panels.

May 3 2015, 11:06 PM · Dashboards
epriestley updated subscribers of T8033: Inform editor when panels have more restrictive policy than dashboard.
May 3 2015, 11:06 PM · Dashboards
epriestley merged task T6560: Tabbed dashboard return (Invalid Panel) for panel less visible than the tabbed one. into T8033: Inform editor when panels have more restrictive policy than dashboard.
May 3 2015, 11:06 PM · Dashboards
epriestley added a comment to T8033: Inform editor when panels have more restrictive policy than dashboard.

T8034 is half of the "similar, less-severe" issue I mention above.

May 3 2015, 11:05 PM · Dashboards
epriestley merged task T8034: Exception for logged out users when showing a query for "active" diffs into T8033: Inform editor when panels have more restrictive policy than dashboard.
May 3 2015, 11:04 PM · Dashboards
epriestley merged T8034: Exception for logged out users when showing a query for "active" diffs into T8033: Inform editor when panels have more restrictive policy than dashboard.
May 3 2015, 11:04 PM · Dashboards
epriestley added a comment to T8042: PhutilUnitTestEngine can't execute a single test path.

Easiest fix is probably for files in /__tests__/ directories to not trigger inclusion of other files. I think it's reasonable in the general case that if you only touched /__tests__/x.php, we only run that file, rather than doing the full cascade into all adjacent/parent tests.

May 3 2015, 11:02 PM · Arcanist
epriestley created T8046: Convert "Created By" and "Invited" to use PhabricatorPeopleUserFunctionDatasource in Calendar ApplicationSearch.
May 3 2015, 10:38 PM · Calendar
epriestley created T8045: Make "Invited" on Calendar ApplicationSearch actually work.
May 3 2015, 10:33 PM · Calendar
epriestley added a revision to T6881: Implement subscription cancellation, past-due callbacks, and Merchant review of invoices in Phortune: Unknown Object (Differential Revision).
May 3 2015, 9:16 PM · Phacility, Phortune
epriestley added a comment to T8044: On /people/query make it possible to query for only non-disabled users.

What problem are you trying to solve?

May 3 2015, 8:31 PM · People
epriestley added a revision to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Unknown Object (Differential Revision).
May 3 2015, 5:32 PM · Restricted Project, Performance, Infrastructure, Phacility
epriestley added a revision to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Unknown Object (Differential Revision).
May 3 2015, 5:28 PM · Restricted Project, Performance, Infrastructure, Phacility
epriestley added a revision to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Unknown Object (Differential Revision).
May 3 2015, 5:24 PM · Restricted Project, Performance, Infrastructure, Phacility
epriestley added a revision to T8024: Update Calendar event date selection controls: Unknown Object (Differential Revision).
May 3 2015, 3:22 PM · Infrastructure
epriestley added a revision to T8024: Update Calendar event date selection controls: Unknown Object (Differential Revision).
May 3 2015, 2:56 PM · Infrastructure
epriestley added a revision to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Unknown Object (Differential Revision).
May 3 2015, 1:47 PM · Restricted Project, Performance, Infrastructure, Phacility
epriestley renamed T6930: Build Multimeter, a "why is Phabricator slow?" toolset from Create a "why is Phabricator slow?" toolset to Build Multimeter, a "why is Phabricator slow?" toolset.
May 3 2015, 1:47 PM · Restricted Project, Performance, Infrastructure, Phacility
nemobis awarded T4768: Phabricator silently overwrites concurrent changes (no conflict detection) a The World Burns token.
May 3 2015, 1:23 PM · Restricted Project, ApplicationEditor, Wikimedia, Maniphest, Phriction
epriestley added a comment to T8043: Maybe interpret monograms that are provided as a URL.

I think (2) is the right way to go so I kicked this into T5378. I'd maybe still render them as URLs but they should definitely trigger mentions.

May 3 2015, 12:56 AM · Remarkup
epriestley merged T8043: Maybe interpret monograms that are provided as a URL into T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
May 3 2015, 12:55 AM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley merged task T8043: Maybe interpret monograms that are provided as a URL into T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
May 3 2015, 12:55 AM · Remarkup

May 2 2015

epriestley created T8041: Order Calendar events by start date in the list view.
May 2 2015, 11:26 PM · Calendar
epriestley added a comment to T8033: Inform editor when panels have more restrictive policy than dashboard.

I think the original proposal was to make the panel disappear. This isn't something we'd be likely to implement, for the reasons @chad gave: it's super confusing and doesn't give users any tools to understand the behavior.

May 2 2015, 8:57 PM · Dashboards
epriestley added a comment to T7919: Actions dropdown in Phriction immediately closes with Quicksand active.

Yeah, I think you have to write a bit of JS since every other menu we have either gets generated via JS or has at least one item in it that needs JS.

May 2 2015, 8:33 PM · Phriction, Conpherence, Quicksand
epriestley added a comment to T8037: documentation for arc diff --base is incomplete, and missing possibly wrong.

the svn / no svn issue should be fixed

May 2 2015, 5:08 PM · Documentation, Arcanist
epriestley created T8039: Rotate daemon logs when performing deployments in the Phacility cluster.
May 2 2015, 12:35 PM · Phacility
epriestley edited the content of 2015 Week 18 (April - May).
May 2 2015, 12:18 PM
epriestley edited the content of Changelog.
May 2 2015, 12:16 PM
epriestley created 2015 Week 18 (April - May).
May 2 2015, 12:16 PM
epriestley added a revision to T6930: Build Multimeter, a "why is Phabricator slow?" toolset: Unknown Object (Differential Revision).
May 2 2015, 11:45 AM · Restricted Project, Performance, Infrastructure, Phacility
epriestley added a comment to T8037: documentation for arc diff --base is incomplete, and missing possibly wrong.

For (1), what output do you expect?

May 2 2015, 11:40 AM · Documentation, Arcanist
epriestley added a comment to T7941: Figure out what non-list Calendar views we're going to support.

such mentions

May 2 2015, 4:56 AM · Calendar
epriestley added a comment to T8035: Clicking "Open Tasks" from a user page results in buggy search.

I can't reproduce it either, including on Firefox/OSX.

May 2 2015, 4:54 AM · People
epriestley created T8032: Calendar description should render with Remarkup.
May 2 2015, 2:04 AM · Calendar
epriestley added a comment to T8031: Set better start and end time defaults for new Calendar events..

prevents typing "tea time", not acceptable

May 2 2015, 1:48 AM · Calendar