Page MenuHomePhabricator
Create Task
Maniphest T7904

InvalidArgumentException in ManiphestTaskSearchEngine.php
Closed, ResolvedPublic
Actions

Description

Since an update yesterday im seeing an exception on my dashboard inside the recent tasks block:

InvalidArgumentException: Argument 1 passed to PhabricatorTypeaheadDatasource::evaluateTokens() must be of the type array, null given, called in /srv/http/phabricator/src/applications/maniphest/query/ManiphestTaskSearchEngine.php on line 145 and defined

Revisions and Commits

rP Phabricator
D12539rPcdb8ea27e5a6 Default statuses and priorities to `array()` correctly

Related Objects

Event Timeline

wienczny created this task.Apr 24 2015, 2:27 PM
wienczny raised the priority of this task from to Needs Triage.
wienczny updated the task description. (Show Details)
wienczny added a subscriber: wienczny.
chad added a project: Dashboards.Apr 24 2015, 2:31 PM
chad added a subscriber: epriestley.
marceldegraaf added a subscriber: marceldegraaf.Apr 24 2015, 2:31 PM

This breaks the built-in "Authored" and "All Tasks" queries.

chad added a subscriber: chad.Apr 24 2015, 2:34 PM

Since an update yesterday

Can you update to HEAD and see if it reproduces, please.

marceldegraaf added a comment.Apr 24 2015, 2:37 PM

Issue doesn't seem to be present in rP3a2c2ae3c3ae3d88427ec96787840119508c2e73, and appears in rPb49645d25b60329cfdd181d7b1dd1dbce30d349f (and in HEAD)

chad added a comment.Apr 24 2015, 2:37 PM

OK, I got a local install at HEAD and it's reproducing "Authored" as failing. Thanks for the report!

marceldegraaf added a comment.Apr 24 2015, 2:41 PM

Sorry, those commit hashes are not correct. Issue seems to have been introduced in rPf64ca87bfea01a355f3fbf4fa03c460995b5da99

epriestley added a comment.Apr 24 2015, 3:29 PM

Does someone have detailed repro steps? Here's what I tried:

  • Go to Maniphest.
  • Type a username in the "Authors" field.
  • Search for tasks.

This works fine for me at HEAD, though.

epriestley added a comment.Apr 24 2015, 3:29 PM

Oh, it's the "authored" prebuilt query specifically.

chad added a comment.Apr 24 2015, 3:30 PM

I clicked on the "Authored" built-in

epriestley added a revision: D12539: Default statuses and priorities to `array()` correctly.Apr 24 2015, 3:38 PM
epriestley closed this task as Resolved by committing rPcdb8ea27e5a6: Default statuses and priorities to `array()` correctly.Apr 24 2015, 3:39 PM
epriestley added a commit: rPcdb8ea27e5a6: Default statuses and priorities to `array()` correctly.
putnam added a subscriber: putnam.May 4 2015, 10:23 PM

I'm up to date with your patch, Evan, but I'm still getting this error. I have a live repro if you want to see it.

epriestley added a comment.May 4 2015, 10:28 PM

Is it possible that you didn't restart Apache (or PHP-FPM, if running nginx + php-fpm) and the old code is stuck in APC?

putnam added a comment.May 4 2015, 10:29 PM

It was APC. Sorry. I thought I had restarted lighttpd after the pull but apparently I've lost my mind.

Phabricator · Built by Phacility