Page MenuHomePhabricator
Create Task
Maniphest T8059

Differential inline comments show on incorrent lines if the file contents changed
Closed, WontfixPublic
Actions

Description

If an inline comment was added on a previous diff, it shows as Older Comment on the current diff.

If the file contents changed between the diffs (line numbers changed), the previous comment is still showing on the line number it was originally added on, even if the line's position changed.

The inline comment should show under the original line it was added for.

Related Objects

Event Timeline

duraseb created this task.May 4 2015, 3:12 PM
duraseb raised the priority of this task from to Needs Triage.
duraseb updated the task description. (Show Details)
duraseb added a project: Differential.
duraseb added a subscriber: duraseb.
epriestley closed this task as Wontfix.May 4 2015, 3:18 PM
epriestley claimed this task.
epriestley added a subscriber: epriestley.

See discussion in T7447.

duraseb reopened this task as Open.May 4 2015, 3:33 PM

Thanks,

Can Older Comment label link to the original revision then?
At the moment I can't see a way to get to the original revision the comment was added on. If you click on the comment inside the Comments secction, the comment is shown on the current diff, not the original one as previously,

If there was a link to the original revision it would help a lot.

epriestley closed this task as Wontfix.May 4 2015, 3:35 PM

"Older Comment" no longer exists at HEAD. Please see T7447 for discussion of this feature.

Phabricator · Built by Phacility