Ubuntu 14.10 with PHP 5.5

I have a few ideas on how to improve this.

I think I fixed this in D11423, particularly:

I think that this is already achievable with the ScriptAndRegexLinter. In addition, ArcanistXHPASTLinter also has this functionality (for PHP only). I feel that language specific linters would be better than just simply grep.

I can't reproduce that unfortunately:

I am not able to replicate this. What version of phpcs are you using?

I approve.

Actually, this is perfectly fine in PHP 5.6 I believe.

Update libphutil, it seems that you are not using the latest version.

I'm sure this question has been asked previously, but why can't the daemons read the updated configuration themselves? I imagine that the configuration would be cached, but surely it could be purged periodically?

I have half a diff for this.

I haven't been able to make any progress on this.

Serializing into a hidden field sounds like the correct approach to me.

In T7029#92850, @epriestley wrote:

You can reproduce this in a normal web browser (at least, in Safari):

• Click "Edit Task" on any task.
• Add a project to the "Projects" field.
• Type some text in the "Description" field.
• Click a link on the page, like the Phabricator logo.
• Press the browser back button.

The description change persists, but the field change does not.

This is probably fixable, but also probably involves some stupid garbage nonsense where we serialize tokens into a hidden field value.

Actually, it seems that the subscribers field doesn't persist either (I originally thought that it did, but it seems that only the default subscriber of myself persists). So yeah, this may not be fixable.

Seeing as the other fields persist, I suspect that it should be fixable.

As an aside, I still think it would be nice to send the notification contents rather than just the key (to avoid the extra request to /notification/individual/). Possibly this would be easier with WebSockets than it would have been with Flash.

Does that solve the scaling issue though? Essentially, all Aphlict servers need to be aware of (I.e. store in memory) all clients and all subscriptions. Realistically, I wouldn't expect this to cause any issues for any installs today, but possibly as Aphlict receives more usage it might?

I was able to reproduce this behavior with the following diff:

I was able to get this to work (i.e. the files were collapsed), but I had to purge the cache first.

What exactly does arc patch --trace D489 output?

Before

It seems like this was broken in D10865.

Interesting. So ./bin/aphlict debug exits with 1 but running node './support/aphlict/server/aphlict_server.js' '--client-port=22280' '--admin-port=22281' '--admin-host=localhost' '--log=/var/log/aphlict.log' exits with 0.

Didn't realize that @epriestley stole this one.

I think this is done now (with the exception of the super-secret Phacility classes)