Page MenuHomePhabricator

Fix methods which override other methods with the wrong visibility
Closed, ResolvedPublic

Description

In PHP, when you override a method, you are permitted to increase its visibility (for example, from protected to public).

I believe this is absolutely never desirable and always a mistake. (If we really wanted to expose some protected/private functionality from subclasses, it would be better in every situation I can imagine to define a new public method which is implemented by calling the existing protected/private method).

See D11049 for a concrete issue this causes: an incorrect piece of code appeared to be correct, and worked correctly because a protected method in the parent had become public in the subclass by accident.

We can write a unit/acceptance test to identify these issues, although we need to fix them first. Here are the issues I was able to identify with a test:

ClassMethodCurrent VisibilityParentCorrect Visibility
LinesOfALargeFilereadMorepublicLinesOfALargeprotected
PhutilExcessiveServiceCallsDaemonrunpublicPhutilTortureTestDaemonprotected
PhutilFatalDaemonrunpublicPhutilTortureTestDaemonprotected
PhutilHangForeverDaemonrunpublicPhutilTortureTestDaemonprotected
PhutilNiceDaemonrunpublicPhutilTortureTestDaemonprotected
PhutilOAuth1FuturegetProxiedFuturepublicFutureProxyprotected
PhutilProcessGroupDaemonrunpublicPhutilTortureTestDaemonprotected
PhutilSaturateStdoutDaemonrunpublicPhutilTortureTestDaemonprotected
ArcanistCSSLintLintergetMandatoryFlagspublicArcanistExternalLinterprotected
ArcanistCSSLintLintergetDefaultFlagspublicArcanistExternalLinterprotected
ArcanistCSharpLintergetLintCodeFromLinterConfigurationKeypublicArcanistLinterprotected
ArcanistCallConduitWorkflowshouldShellCompletepublicArcanistWorkflowprotected
ArcanistChmodLintershouldLintBinaryFilespublicArcanistLinterprotected
ArcanistConfigurationDrivenLintEnginebuildLinterspublicArcanistLintEngineprotected
ArcanistFilenameLintershouldLintBinaryFilespublicArcanistLinterprotected
ArcanistFilenameLintershouldLintDirectoriespublicArcanistLinterprotected
ArcanistFilenameLintershouldLintSymbolicLinkspublicArcanistLinterprotected
ArcanistFlake8LintergetDefaultFlagspublicArcanistExternalLinterprotected
ArcanistGitHookPreReceiveWorkflowshouldShellCompletepublicArcanistWorkflowprotected
ArcanistHLintLintergetMandatoryFlagspublicArcanistExternalLinterprotected
ArcanistInstallCertificateWorkflowshouldShellCompletepublicArcanistWorkflowprotected
ArcanistMercurialAPIdidReloadCommitRangepublicArcanistRepositoryAPIprotected
ArcanistPEP8LintergetDefaultFlagspublicArcanistExternalLinterprotected
ArcanistPatchWorkflowgetShellCompletionspublicArcanistWorkflowprotected
ArcanistPhpLintergetMandatoryFlagspublicArcanistExternalLinterprotected
ArcanistPhpcsLintergetMandatoryFlagspublicArcanistExternalLinterprotected
ArcanistPhpcsLintergetDefaultFlagspublicArcanistExternalLinterprotected
ArcanistShellCompleteWorkflowshouldShellCompletepublicArcanistWorkflowprotected
ArcanistSingleLintEnginebuildLinterspublicArcanistLintEngineprotected
ArcanistSvnHookPreCommitWorkflowshouldShellCompletepublicArcanistWorkflowprotected
ComprehensiveLintEnginebuildLinterspublicArcanistLintEngineprotected
AlmanacBindinggetConfigurationpublicAlmanacDAOprotected
AlmanacBindinggeneratePHIDpublicAlmanacDAOprotected
AlmanacDevicegetConfigurationpublicAlmanacDAOprotected
AlmanacDevicegeneratePHIDpublicAlmanacDAOprotected
AlmanacDeviceControllerbuildApplicationCrumbspublicAlmanacControllerprotected
AlmanacDeviceSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
AlmanacInterfacegetConfigurationpublicAlmanacDAOprotected
AlmanacInterfacegeneratePHIDpublicAlmanacDAOprotected
AlmanacManagementLockWorkflowdidConstructpublicAlmanacManagementWorkflowprotected
AlmanacManagementTrustKeyWorkflowdidConstructpublicAlmanacManagementWorkflowprotected
AlmanacManagementUnlockWorkflowdidConstructpublicAlmanacManagementWorkflowprotected
AlmanacManagementUntrustKeyWorkflowdidConstructpublicAlmanacManagementWorkflowprotected
AlmanacNetworkgetConfigurationpublicAlmanacDAOprotected
AlmanacNetworkgeneratePHIDpublicAlmanacDAOprotected
AlmanacNetworkControllerbuildApplicationCrumbspublicAlmanacControllerprotected
AlmanacNetworkSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
AlmanacServicegetConfigurationpublicAlmanacDAOprotected
AlmanacServicegeneratePHIDpublicAlmanacDAOprotected
AlmanacServiceControllerbuildApplicationCrumbspublicAlmanacControllerprotected
AlmanacServiceSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
AphrontGlyphBarViewgetDefaultColorpublicAphrontBarViewprotected
AphrontProgressBarViewgetDefaultColorpublicAphrontBarViewprotected
CelerityManagementMapWorkflowdidConstructpublicCelerityManagementWorkflowprotected
ConduitSSHWorkflowdidConstructpublicPhabricatorSSHWorkflowprotected
ConpherenceControllerbuildApplicationMenupublicPhabricatorControllerprotected
ConpherenceControllerbuildApplicationCrumbspublicPhabricatorControllerprotected
ConpherenceParticipantgetConfigurationpublicConpherenceDAOprotected
ConpherenceThreadgetConfigurationpublicConpherenceDAOprotected
ConpherenceThreadgeneratePHIDpublicConpherenceDAOprotected
DifferentialAffectedPathgetConfigurationpublicDifferentialDAOprotected
DifferentialChangesetQuerywillExecutepublicPhabricatorCursorPagedPolicyAwareQueryprotected
DifferentialChangesetQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
DifferentialChangesetQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
DifferentialChangesetQuerydidFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
DifferentialControllerbuildApplicationCrumbspublicPhabricatorControllerprotected
DifferentialControllerbuildApplicationMenupublicPhabricatorControllerprotected
DifferentialDiffgetConfigurationpublicDifferentialDAOprotected
DifferentialDiffgeneratePHIDpublicDifferentialDAOprotected
DifferentialDiffQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
DifferentialDiffQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
DifferentialDraftgetConfigurationpublicDifferentialDAOprotected
DifferentialHunkLegacygetConfigurationpublicDifferentialHunkprotected
DifferentialHunkModerngetConfigurationpublicDifferentialHunkprotected
DifferentialHunkQuerywillExecutepublicPhabricatorCursorPagedPolicyAwareQueryprotected
DifferentialHunkQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
DifferentialHunkQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
DifferentialHunkQuerydidFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
DifferentialManiphestTasksFieldreadValueFromRevisionpublicDifferentialCoreCustomFieldprotected
DifferentialRevisiongetConfigurationpublicDifferentialDAOprotected
DifferentialRevisiongeneratePHIDpublicDifferentialDAOprotected
DifferentialRevisionQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
DifferentialRevisionQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
DifferentialRevisionSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
DifferentialRevisionSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
DiffusionCommitQuerydidFilterResultspublicPhabricatorCursorPagedPolicyAwareQueryprotected
DiffusionLowLevelCommitFieldsQueryexecuteQuerypublicDiffusionLowLevelQueryprotected
DiffusionLowLevelCommitQueryexecuteQuerypublicDiffusionLowLevelQueryprotected
DiffusionLowLevelParentsQueryexecuteQuerypublicDiffusionLowLevelQueryprotected
DiffusionLowLevelResolveRefsQueryexecuteQuerypublicDiffusionLowLevelQueryprotected
DiffusionRepositoryEditControllerbuildApplicationCrumbspublicDiffusionControllerprotected
DiffusionRepositoryListControllerbuildApplicationCrumbspublicDiffusionControllerprotected
DiffusionSSHGitReceivePackWorkflowdidConstructpublicDiffusionSSHGitWorkflowprotected
DiffusionSSHGitUploadPackWorkflowdidConstructpublicDiffusionSSHGitWorkflowprotected
DiffusionSSHMercurialServeWorkflowdidConstructpublicDiffusionSSHMercurialWorkflowprotected
DiffusionSSHSubversionServeWorkflowdidConstructpublicDiffusionSSHSubversionWorkflowprotected
DivinerAtomSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
DivinerAtomSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
DivinerAtomizeWorkflowdidConstructpublicDivinerWorkflowprotected
DivinerBookItemViewgetTagNamepublicAphrontTagViewprotected
DivinerBookItemViewgetTagAttributespublicAphrontTagViewprotected
DivinerBookItemViewgetTagContentpublicAphrontTagViewprotected
DivinerGenerateWorkflowdidConstructpublicDivinerWorkflowprotected
DivinerLiveAtomgetConfigurationpublicDivinerDAOprotected
DivinerLiveBookgetConfigurationpublicDivinerDAOprotected
DivinerLiveBookgeneratePHIDpublicDivinerDAOprotected
DivinerLiveSymbolgetConfigurationpublicDivinerDAOprotected
DivinerLiveSymbolgeneratePHIDpublicDivinerDAOprotected
DivinerParameterTableViewgetTagNamepublicAphrontTagViewprotected
DivinerParameterTableViewgetTagAttributespublicAphrontTagViewprotected
DivinerParameterTableViewgetTagContentpublicAphrontTagViewprotected
DivinerReturnTableViewgetTagNamepublicAphrontTagViewprotected
DivinerReturnTableViewgetTagAttributespublicAphrontTagViewprotected
DivinerReturnTableViewgetTagContentpublicAphrontTagViewprotected
DivinerSectionViewgetTagNamepublicAphrontTagViewprotected
DivinerSectionViewgetTagAttributespublicAphrontTagViewprotected
DivinerSectionViewgetTagContentpublicAphrontTagViewprotected
DoorkeeperExternalObjectgetConfigurationpublicDoorkeeperDAOprotected
DoorkeeperExternalObjectgeneratePHIDpublicDoorkeeperDAOprotected
DoorkeeperExternalObjectQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
DrydockBlueprintgetConfigurationpublicDrydockDAOprotected
DrydockBlueprintgeneratePHIDpublicDrydockDAOprotected
DrydockBlueprintControllerbuildApplicationCrumbspublicDrydockControllerprotected
DrydockBlueprintQueryloadPagepublicDrydockQueryprotected
DrydockBlueprintSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
DrydockBlueprintSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
DrydockBlueprintSearchEnginerenderResultListpublicPhabricatorApplicationSearchEngineprotected
DrydockControllerbuildApplicationMenupublicPhabricatorControllerprotected
DrydockLeasegetConfigurationpublicDrydockDAOprotected
DrydockLeasegeneratePHIDpublicDrydockDAOprotected
DrydockLeaseControllerbuildApplicationCrumbspublicDrydockControllerprotected
DrydockLeaseQueryloadPagepublicDrydockQueryprotected
DrydockLeaseQuerywillFilterPagepublicDrydockQueryprotected
DrydockLeaseSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
DrydockLeaseSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
DrydockLoggetConfigurationpublicDrydockDAOprotected
DrydockLogControllerbuildApplicationCrumbspublicDrydockControllerprotected
DrydockLogQueryloadPagepublicDrydockQueryprotected
DrydockLogQuerywillFilterPagepublicDrydockQueryprotected
DrydockLogSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
DrydockLogSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
DrydockManagementCloseWorkflowdidConstructpublicDrydockManagementWorkflowprotected
DrydockManagementCreateResourceWorkflowdidConstructpublicDrydockManagementWorkflowprotected
DrydockManagementLeaseWorkflowdidConstructpublicDrydockManagementWorkflowprotected
DrydockManagementReleaseWorkflowdidConstructpublicDrydockManagementWorkflowprotected
DrydockResourcegetConfigurationpublicDrydockDAOprotected
DrydockResourcegeneratePHIDpublicDrydockDAOprotected
DrydockResourceControllerbuildApplicationCrumbspublicDrydockControllerprotected
DrydockResourceQueryloadPagepublicDrydockQueryprotected
DrydockResourceSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
DrydockResourceSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
FundBackergetConfigurationpublicFundDAOprotected
FundBackergeneratePHIDpublicFundDAOprotected
FundBackerSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
FundBackerSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
FundInitiativegetConfigurationpublicFundDAOprotected
FundInitiativegeneratePHIDpublicFundDAOprotected
FundInitiativeListControllerbuildApplicationCrumbspublicFundControllerprotected
FundInitiativeSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
FundInitiativeSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
HarbormasterBuildgetConfigurationpublicHarbormasterDAOprotected
HarbormasterBuildgeneratePHIDpublicHarbormasterDAOprotected
HarbormasterBuildArtifactgetConfigurationpublicHarbormasterDAOprotected
HarbormasterBuildCommandgetConfigurationpublicHarbormasterDAOprotected
HarbormasterBuildItemgetConfigurationpublicHarbormasterDAOprotected
HarbormasterBuildItemgeneratePHIDpublicHarbormasterDAOprotected
HarbormasterBuildLoggetConfigurationpublicHarbormasterDAOprotected
HarbormasterBuildLoggeneratePHIDpublicHarbormasterDAOprotected
HarbormasterBuildMessagegetConfigurationpublicHarbormasterDAOprotected
HarbormasterBuildPlangetConfigurationpublicHarbormasterDAOprotected
HarbormasterBuildPlangeneratePHIDpublicHarbormasterDAOprotected
HarbormasterBuildPlanSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
HarbormasterBuildPlanSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
HarbormasterBuildStepgetConfigurationpublicHarbormasterDAOprotected
HarbormasterBuildStepgeneratePHIDpublicHarbormasterDAOprotected
HarbormasterBuildTargetgetConfigurationpublicHarbormasterDAOprotected
HarbormasterBuildTargetgeneratePHIDpublicHarbormasterDAOprotected
HarbormasterBuildWorkerdoWorkpublicHarbormasterWorkerprotected
HarbormasterBuildablegetConfigurationpublicHarbormasterDAOprotected
HarbormasterBuildablegeneratePHIDpublicHarbormasterDAOprotected
HarbormasterBuildableListControllerbuildApplicationMenupublicHarbormasterControllerprotected
HarbormasterBuildableSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
HarbormasterBuildableSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
HarbormasterControllerbuildApplicationCrumbspublicPhabricatorControllerprotected
HarbormasterManagementBuildWorkflowdidConstructpublicHarbormasterManagementWorkflowprotected
HarbormasterManagementUpdateWorkflowdidConstructpublicHarbormasterManagementWorkflowprotected
HarbormasterObjectgetConfigurationpublicHarbormasterDAOprotected
HarbormasterObjectgeneratePHIDpublicHarbormasterDAOprotected
HarbormasterPlanListControllerbuildApplicationMenupublicHarbormasterPlanControllerprotected
HarbormasterScratchTablegetConfigurationpublicHarbormasterDAOprotected
HarbormasterTargetWorkerdoWorkpublicHarbormasterWorkerprotected
HeraldControllerbuildApplicationMenupublicPhabricatorControllerprotected
HeraldControllerbuildApplicationCrumbspublicPhabricatorControllerprotected
HeraldRulegetConfigurationpublicHeraldDAOprotected
HeraldRulegeneratePHIDpublicHeraldDAOprotected
HeraldRuleEditgetConfigurationpublicHeraldDAOprotected
HeraldRuleQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
HeraldRuleQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
HeraldRuleSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
HeraldRuleSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
HeraldTranscriptgeneratePHIDpublicHeraldDAOprotected
HeraldTranscriptQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
HeraldTranscriptQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
HeraldTranscriptSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
HeraldTranscriptSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
LegalpadControllerbuildApplicationMenupublicPhabricatorControllerprotected
LegalpadDocumentgetConfigurationpublicLegalpadDAOprotected
LegalpadDocumentgeneratePHIDpublicLegalpadDAOprotected
LegalpadDocumentBodygetConfigurationpublicLegalpadDAOprotected
LegalpadDocumentBodygeneratePHIDpublicLegalpadDAOprotected
LegalpadDocumentListControllerbuildApplicationCrumbspublicLegalpadControllerprotected
LegalpadDocumentSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
LegalpadDocumentSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
LegalpadDocumentSignaturegetConfigurationpublicLegalpadDAOprotected
LegalpadDocumentSignatureListControllerbuildApplicationCrumbspublicLegalpadControllerprotected
LegalpadDocumentSignatureSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
LegalpadDocumentSignatureSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
LiskFixtureTestCasegetPhabricatorTestCaseConfigurationpublicPhabricatorTestCaseprotected
LiskIsolationTestDAOgetConfigurationpublicLiskDAOprotected
LiskIsolationTestDAOgeneratePHIDpublicLiskDAOprotected
LiskIsolationTestDAOestablishLiveConnectionpublicLiskDAOprotected
LiskIsolationTestDAOgetConnectionNamespacepublicLiskDAOprotected
ManiphestControllerbuildApplicationMenupublicPhabricatorControllerprotected
ManiphestNameIndexgetConfigurationpublicManiphestDAOprotected
ManiphestTaskgetConfigurationpublicManiphestDAOprotected
ManiphestTaskgeneratePHIDpublicManiphestDAOprotected
ManiphestTaskQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
ManiphestTaskSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
ManiphestTaskSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
ManiphestTaskSubscribergetConfigurationpublicManiphestDAOprotected
NuanceItemgetConfigurationpublicNuanceDAOprotected
NuanceItemgeneratePHIDpublicNuanceDAOprotected
NuanceItemQueryloadPagepublicNuanceQueryprotected
NuanceQueuegetConfigurationpublicNuanceDAOprotected
NuanceQueuegeneratePHIDpublicNuanceDAOprotected
NuanceQueueItemgetConfigurationpublicNuanceDAOprotected
NuanceQueueQueryloadPagepublicNuanceQueryprotected
NuanceRequestorgetConfigurationpublicNuanceDAOprotected
NuanceRequestorgeneratePHIDpublicNuanceDAOprotected
NuanceRequestorQueryloadPagepublicNuanceQueryprotected
NuanceRequestorSourcegetConfigurationpublicNuanceDAOprotected
NuanceSourcegetConfigurationpublicNuanceDAOprotected
NuanceSourcegeneratePHIDpublicNuanceDAOprotected
NuanceSourceQueryloadPagepublicNuanceQueryprotected
PHUIBoxViewgetTagNamepublicAphrontTagViewprotected
PHUIBoxViewgetTagContentpublicAphrontTagViewprotected
PHUIButtonBarViewgetTagNamepublicAphrontTagViewprotected
PHUIButtonBarViewgetTagContentpublicAphrontTagViewprotected
PHUIButtonViewgetTagNamepublicAphrontTagViewprotected
PHUICalendarListViewgetTagNamepublicAphrontTagViewprotected
PHUICalendarListViewgetTagAttributespublicAphrontTagViewprotected
PHUICalendarWidgetViewgetTagNamepublicAphrontTagViewprotected
PHUICalendarWidgetViewgetTagAttributespublicAphrontTagViewprotected
PHUIDocumentViewgetTagAttributespublicAphrontTagViewprotected
PHUIDocumentViewgetTagContentpublicAphrontTagViewprotected
PHUIIconViewgetTagNamepublicAphrontTagViewprotected
PHUIIconViewgetTagAttributespublicAphrontTagViewprotected
PHUIImageMaskViewgetTagNamepublicAphrontTagViewprotected
PHUIImageMaskViewgetTagAttributespublicAphrontTagViewprotected
PHUIImageMaskViewgetTagContentpublicAphrontTagViewprotected
PHUIListViewgetTagNamepublicAphrontTagViewprotected
PHUIObjectItemViewgetTagContentpublicAphrontTagViewprotected
PHUIPagedFormViewgetTagContentpublicAphrontTagViewprotected
PHUIRemarkupPreviewPanelgetTagNamepublicAphrontTagViewprotected
PHUIRemarkupPreviewPanelgetTagAttributespublicAphrontTagViewprotected
PHUIStatusListViewgetTagNamepublicAphrontTagViewprotected
PHUITagViewgetTagContentpublicAphrontTagViewprotected
PHUITextViewgetTagNamepublicAphrontTagViewprotected
PHUITextViewgetTagAttributespublicAphrontTagViewprotected
PHUIWorkboardViewgetTagAttributespublicAphrontTagViewprotected
PHUIWorkboardViewgetTagContentpublicAphrontTagViewprotected
PHUIWorkpanelViewgetTagAttributespublicAphrontTagViewprotected
PHUIWorkpanelViewgetTagContentpublicAphrontTagViewprotected
PassphraseControllerbuildApplicationMenupublicPhabricatorControllerprotected
PassphraseControllerbuildApplicationCrumbspublicPhabricatorControllerprotected
PassphraseCredentialgetConfigurationpublicPassphraseDAOprotected
PassphraseCredentialgeneratePHIDpublicPassphraseDAOprotected
PassphraseCredentialSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PassphraseCredentialSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PassphraseSecretgetConfigurationpublicPassphraseDAOprotected
PhabricatorAphlictManagementBuildWorkflowdidConstructpublicPhabricatorAphlictManagementWorkflowprotected
PhabricatorAphlictManagementDebugWorkflowdidConstructpublicPhabricatorAphlictManagementWorkflowprotected
PhabricatorAphlictManagementRestartWorkflowdidConstructpublicPhabricatorAphlictManagementWorkflowprotected
PhabricatorAphlictManagementStartWorkflowdidConstructpublicPhabricatorAphlictManagementWorkflowprotected
PhabricatorAphlictManagementStatusWorkflowdidConstructpublicPhabricatorAphlictManagementWorkflowprotected
PhabricatorAphlictManagementStopWorkflowdidConstructpublicPhabricatorAphlictManagementWorkflowprotected
PhabricatorAppSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhabricatorAppSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorApplicationQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorApplicationTransactiongeneratePHIDpublicPhabricatorLiskDAOprotected
PhabricatorApplicationTransactiongetConfigurationpublicPhabricatorLiskDAOprotected
PhabricatorApplicationTransactionCommentgeneratePHIDpublicPhabricatorLiskDAOprotected
PhabricatorApplicationTransactionCommentgetConfigurationpublicPhabricatorLiskDAOprotected
PhabricatorApplicationsControllerbuildApplicationMenupublicPhabricatorControllerprotected
PhabricatorAuditControllerbuildApplicationMenupublicPhabricatorControllerprotected
PhabricatorAuditManagementDeleteWorkflowdidConstructpublicPhabricatorAuditManagementWorkflowprotected
PhabricatorAuthFactorConfiggetConfigurationpublicPhabricatorAuthDAOprotected
PhabricatorAuthFactorConfiggeneratePHIDpublicPhabricatorAuthDAOprotected
PhabricatorAuthProviderConfiggeneratePHIDpublicPhabricatorAuthDAOprotected
PhabricatorAuthProviderConfiggetConfigurationpublicPhabricatorAuthDAOprotected
PhabricatorAuthProviderConfigControllerbuildApplicationMenupublicPhabricatorAuthControllerprotected
PhabricatorAuthSSHKeygetConfigurationpublicPhabricatorAuthDAOprotected
PhabricatorAuthSessiongetConfigurationpublicPhabricatorAuthDAOprotected
PhabricatorAuthTemporaryTokengetConfigurationpublicPhabricatorAuthDAOprotected
PhabricatorBitbucketAuthProvidergetProviderConfigurationHelppublicPhabricatorOAuth1AuthProviderprotected
PhabricatorBotrunpublicPhabricatorDaemonprotected
PhabricatorCalendarControllerbuildApplicationMenupublicPhabricatorControllerprotected
PhabricatorCalendarControllerbuildApplicationCrumbspublicPhabricatorControllerprotected
PhabricatorCalendarEventgetConfigurationpublicPhabricatorCalendarDAOprotected
PhabricatorCalendarEventgeneratePHIDpublicPhabricatorCalendarDAOprotected
PhabricatorCalendarEventSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhabricatorCalendarEventSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorCalendarHolidaygetConfigurationpublicPhabricatorCalendarDAOprotected
PhabricatorChatLogChannelgetConfigurationpublicPhabricatorChatLogDAOprotected
PhabricatorChatLogEventgetConfigurationpublicPhabricatorChatLogDAOprotected
PhabricatorChatLogQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorCommitSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorConduitCertificateTokengetConfigurationpublicPhabricatorConduitDAOprotected
PhabricatorConduitConnectionLoggetConfigurationpublicPhabricatorConduitDAOprotected
PhabricatorConduitLogQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorConduitMethodCallLoggetConfigurationpublicPhabricatorConduitDAOprotected
PhabricatorConduitMethodQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorConduitSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhabricatorConduitSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorConduitTokengetConfigurationpublicPhabricatorConduitDAOprotected
PhabricatorConduitTokenQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorConfigColumnSchemacompareToSimilarSchemapublicPhabricatorConfigStorageSchemaprotected
PhabricatorConfigControllerbuildApplicationMenupublicPhabricatorControllerprotected
PhabricatorConfigDatabaseSchemacompareToSimilarSchemapublicPhabricatorConfigStorageSchemaprotected
PhabricatorConfigEntrygetConfigurationpublicPhabricatorConfigEntryDAOprotected
PhabricatorConfigEntrygeneratePHIDpublicPhabricatorConfigEntryDAOprotected
PhabricatorConfigEntryQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorConfigKeySchemacompareToSimilarSchemapublicPhabricatorConfigStorageSchemaprotected
PhabricatorConfigServerSchemacompareToSimilarSchemapublicPhabricatorConfigStorageSchemaprotected
PhabricatorConfigTableSchemacompareToSimilarSchemapublicPhabricatorConfigStorageSchemaprotected
PhabricatorCountdowngetConfigurationpublicPhabricatorCountdownDAOprotected
PhabricatorCountdowngeneratePHIDpublicPhabricatorCountdownDAOprotected
PhabricatorCountdownApplicationgetCustomCapabilitiespublicPhabricatorApplicationprotected
PhabricatorCountdownControllerbuildApplicationMenupublicPhabricatorControllerprotected
PhabricatorCountdownControllerbuildApplicationCrumbspublicPhabricatorControllerprotected
PhabricatorCountdownSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhabricatorCountdownSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorCountdownViewgetTagContentpublicAphrontTagViewprotected
PhabricatorCustomFieldIndexStoragegetConfigurationpublicPhabricatorLiskDAOprotected
PhabricatorCustomFieldStoragegetConfigurationpublicPhabricatorLiskDAOprotected
PhabricatorDaemonLoggetConfigurationpublicPhabricatorDaemonDAOprotected
PhabricatorDaemonLogEventgetConfigurationpublicPhabricatorDaemonDAOprotected
PhabricatorDaemonLogQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorDaemonLogQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorDaemonManagementDebugWorkflowdidConstructpublicPhabricatorDaemonManagementWorkflowprotected
PhabricatorDaemonManagementLaunchWorkflowdidConstructpublicPhabricatorDaemonManagementWorkflowprotected
PhabricatorDaemonManagementListWorkflowdidConstructpublicPhabricatorDaemonManagementWorkflowprotected
PhabricatorDaemonManagementLogWorkflowdidConstructpublicPhabricatorDaemonManagementWorkflowprotected
PhabricatorDaemonManagementRestartWorkflowdidConstructpublicPhabricatorDaemonManagementWorkflowprotected
PhabricatorDaemonManagementStartWorkflowdidConstructpublicPhabricatorDaemonManagementWorkflowprotected
PhabricatorDaemonManagementStatusWorkflowdidConstructpublicPhabricatorDaemonManagementWorkflowprotected
PhabricatorDaemonManagementStopWorkflowdidConstructpublicPhabricatorDaemonManagementWorkflowprotected
PhabricatorDashboardgetConfigurationpublicPhabricatorDashboardDAOprotected
PhabricatorDashboardgeneratePHIDpublicPhabricatorDashboardDAOprotected
PhabricatorDashboardInstallgetConfigurationpublicPhabricatorDashboardDAOprotected
PhabricatorDashboardListControllerbuildApplicationCrumbspublicPhabricatorDashboardControllerprotected
PhabricatorDashboardPanelgetConfigurationpublicPhabricatorDashboardDAOprotected
PhabricatorDashboardPanelgeneratePHIDpublicPhabricatorDashboardDAOprotected
PhabricatorDashboardPanelListControllerbuildApplicationCrumbspublicPhabricatorDashboardControllerprotected
PhabricatorDashboardPanelSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhabricatorDashboardPanelSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorDashboardSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhabricatorDashboardSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorDashboardViewControllerbuildApplicationCrumbspublicPhabricatorDashboardControllerprotected
PhabricatorDraftgetConfigurationpublicPhabricatorDraftDAOprotected
PhabricatorExternalAccountgeneratePHIDpublicPhabricatorUserDAOprotected
PhabricatorExternalAccountgetConfigurationpublicPhabricatorUserDAOprotected
PhabricatorExternalAccountQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorExternalAccountQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorFactDAOgetConfigurationpublicPhabricatorLiskDAOprotected
PhabricatorFactDaemonrunpublicPhabricatorDaemonprotected
PhabricatorFactManagementAnalyzeWorkflowdidConstructpublicPhabricatorFactManagementWorkflowprotected
PhabricatorFactManagementCursorsWorkflowdidConstructpublicPhabricatorFactManagementWorkflowprotected
PhabricatorFactManagementDestroyWorkflowdidConstructpublicPhabricatorFactManagementWorkflowprotected
PhabricatorFactManagementListWorkflowdidConstructpublicPhabricatorFactManagementWorkflowprotected
PhabricatorFactManagementStatusWorkflowdidConstructpublicPhabricatorFactManagementWorkflowprotected
PhabricatorFeedSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorFeedStoryDatagetConfigurationpublicPhabricatorFeedDAOprotected
PhabricatorFeedStoryDatageneratePHIDpublicPhabricatorFeedDAOprotected
PhabricatorFeedStoryNotificationgetConfigurationpublicPhabricatorFeedDAOprotected
PhabricatorFeedStoryReferencegetConfigurationpublicPhabricatorFeedDAOprotected
PhabricatorFilegetConfigurationpublicPhabricatorFileDAOprotected
PhabricatorFilegeneratePHIDpublicPhabricatorFileDAOprotected
PhabricatorFileImageMacrogetConfigurationpublicPhabricatorFileDAOprotected
PhabricatorFileImageMacrogeneratePHIDpublicPhabricatorFileDAOprotected
PhabricatorFileListControllerbuildApplicationCrumbspublicPhabricatorFileControllerprotected
PhabricatorFileSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhabricatorFileSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorFileStorageBlobgetConfigurationpublicPhabricatorFileDAOprotected
PhabricatorFileTestCasegetPhabricatorTestCaseConfigurationpublicPhabricatorTestCaseprotected
PhabricatorFilesManagementCompactWorkflowdidConstructpublicPhabricatorFilesManagementWorkflowprotected
PhabricatorFilesManagementEnginesWorkflowdidConstructpublicPhabricatorFilesManagementWorkflowprotected
PhabricatorFilesManagementMigrateWorkflowdidConstructpublicPhabricatorFilesManagementWorkflowprotected
PhabricatorFilesManagementPurgeWorkflowdidConstructpublicPhabricatorFilesManagementWorkflowprotected
PhabricatorFilesManagementRebuildWorkflowdidConstructpublicPhabricatorFilesManagementWorkflowprotected
PhabricatorFlaggetConfigurationpublicPhabricatorFlagDAOprotected
PhabricatorFlagQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorFlagQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorFlagSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhabricatorFlagSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorFlagSelectControlgetCustomControlClasspublicAphrontFormControlprotected
PhabricatorFlagSelectControlrenderInputpublicAphrontFormControlprotected
PhabricatorGarbageCollectorDaemonrunpublicPhabricatorDaemonprotected
PhabricatorHandleQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorHarbormasterApplicationgetCustomCapabilitiespublicPhabricatorApplicationprotected
PhabricatorInternationalizationManagementExtractWorkflowdidConstructpublicPhabricatorInternationalizationManagementWorkflowprotected
PhabricatorLiskDAOestablishLiveConnectionpublicLiskDAOprotected
PhabricatorMacroControllerbuildApplicationMenupublicPhabricatorControllerprotected
PhabricatorMacroSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhabricatorMacroSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorMailingListQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorMailingListSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhabricatorMailingListSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorMailingListsControllerbuildApplicationMenupublicPhabricatorControllerprotected
PhabricatorMailingListsControllerbuildApplicationCrumbspublicPhabricatorControllerprotected
PhabricatorMarkupCachegetConfigurationpublicPhabricatorCacheDAOprotected
PhabricatorMetaMTAMailgetConfigurationpublicPhabricatorMetaMTADAOprotected
PhabricatorMetaMTAMailingListgeneratePHIDpublicPhabricatorMetaMTADAOprotected
PhabricatorMetaMTAMailingListgetConfigurationpublicPhabricatorMetaMTADAOprotected
PhabricatorMetaMTAReceivedMailgetConfigurationpublicPhabricatorMetaMTADAOprotected
PhabricatorMetaMTAWorkerdoWorkpublicPhabricatorWorkerprotected
PhabricatorNamedQuerygetConfigurationpublicPhabricatorSearchDAOprotected
PhabricatorNotificationSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhabricatorNotificationSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorOAuthClientAuthorizationgetConfigurationpublicPhabricatorOAuthServerDAOprotected
PhabricatorOAuthClientAuthorizationgeneratePHIDpublicPhabricatorOAuthServerDAOprotected
PhabricatorOAuthClientAuthorizationQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorOAuthClientAuthorizationQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorOAuthClientListControllerbuildApplicationCrumbspublicPhabricatorOAuthClientControllerprotected
PhabricatorOAuthServerAccessTokengetConfigurationpublicPhabricatorOAuthServerDAOprotected
PhabricatorOAuthServerAuthorizationCodegetConfigurationpublicPhabricatorOAuthServerDAOprotected
PhabricatorOAuthServerClientgetConfigurationpublicPhabricatorOAuthServerDAOprotected
PhabricatorOAuthServerClientgeneratePHIDpublicPhabricatorOAuthServerDAOprotected
PhabricatorOAuthServerClientQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorOAuthServerClientSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhabricatorOAuthServerClientSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorObjectQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorOwnersControllerbuildApplicationMenupublicPhabricatorControllerprotected
PhabricatorOwnersOwnergetConfigurationpublicPhabricatorOwnersDAOprotected
PhabricatorOwnersPackagegetConfigurationpublicPhabricatorOwnersDAOprotected
PhabricatorOwnersPackagegeneratePHIDpublicPhabricatorOwnersDAOprotected
PhabricatorOwnersPathgetConfigurationpublicPhabricatorOwnersDAOprotected
PhabricatorPastegetConfigurationpublicPhabricatorPasteDAOprotected
PhabricatorPastegeneratePHIDpublicPhabricatorPasteDAOprotected
PhabricatorPasteControllerbuildApplicationMenupublicPhabricatorControllerprotected
PhabricatorPasteControllerbuildApplicationCrumbspublicPhabricatorControllerprotected
PhabricatorPasteSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorPeopleControllerbuildApplicationMenupublicPhabricatorControllerprotected
PhabricatorPeopleControllerbuildApplicationCrumbspublicPhabricatorControllerprotected
PhabricatorPeopleLogQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorPeopleLogSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhabricatorPeopleLogSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorPeopleQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorPeopleSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhabricatorPeopleSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorPolicygetConfigurationpublicPhabricatorPolicyDAOprotected
PhabricatorPolicygeneratePHIDpublicPhabricatorPolicyDAOprotected
PhabricatorPolicyAwareTestQuerynextPagepublicPhabricatorPolicyAwareQueryprotected
PhabricatorPolicyQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorProjectgetConfigurationpublicPhabricatorProjectDAOprotected
PhabricatorProjectgeneratePHIDpublicPhabricatorProjectDAOprotected
PhabricatorProjectColumngetConfigurationpublicPhabricatorProjectDAOprotected
PhabricatorProjectColumngeneratePHIDpublicPhabricatorProjectDAOprotected
PhabricatorProjectColumnPositiongetConfigurationpublicPhabricatorProjectDAOprotected
PhabricatorProjectListControllerbuildApplicationMenupublicPhabricatorProjectControllerprotected
PhabricatorProjectListControllerbuildApplicationCrumbspublicPhabricatorProjectControllerprotected
PhabricatorProjectSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhabricatorProjectSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorProjectSluggetConfigurationpublicPhabricatorProjectDAOprotected
PhabricatorRepositorygetConfigurationpublicPhabricatorRepositoryDAOprotected
PhabricatorRepositorygeneratePHIDpublicPhabricatorRepositoryDAOprotected
PhabricatorRepositoryArcanistProjectgetConfigurationpublicPhabricatorRepositoryDAOprotected
PhabricatorRepositoryArcanistProjectgeneratePHIDpublicPhabricatorRepositoryDAOprotected
PhabricatorRepositoryArcanistProjectQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorRepositoryAuditRequestgetConfigurationpublicPhabricatorRepositoryDAOprotected
PhabricatorRepositoryBranchgetConfigurationpublicPhabricatorRepositoryDAOprotected
PhabricatorRepositoryCommitgetConfigurationpublicPhabricatorRepositoryDAOprotected
PhabricatorRepositoryCommitgeneratePHIDpublicPhabricatorRepositoryDAOprotected
PhabricatorRepositoryCommitDatagetConfigurationpublicPhabricatorRepositoryDAOprotected
PhabricatorRepositoryCommitHeraldWorkerparseCommitpublicPhabricatorRepositoryCommitParserWorkerprotected
PhabricatorRepositoryCommitParserWorkerdoWorkpublicPhabricatorWorkerprotected
PhabricatorRepositoryGitCommitMessageParserWorkerparseCommitpublicPhabricatorRepositoryCommitMessageParserWorkerprotected
PhabricatorRepositoryManagementCacheWorkflowdidConstructpublicPhabricatorRepositoryManagementWorkflowprotected
PhabricatorRepositoryManagementDiscoverWorkflowdidConstructpublicPhabricatorRepositoryManagementWorkflowprotected
PhabricatorRepositoryManagementEditWorkflowdidConstructpublicPhabricatorRepositoryManagementWorkflowprotected
PhabricatorRepositoryManagementImportingWorkflowdidConstructpublicPhabricatorRepositoryManagementWorkflowprotected
PhabricatorRepositoryManagementListWorkflowdidConstructpublicPhabricatorRepositoryManagementWorkflowprotected
PhabricatorRepositoryManagementLookupUsersWorkflowdidConstructpublicPhabricatorRepositoryManagementWorkflowprotected
PhabricatorRepositoryManagementMarkImportedWorkflowdidConstructpublicPhabricatorRepositoryManagementWorkflowprotected
PhabricatorRepositoryManagementMirrorWorkflowdidConstructpublicPhabricatorRepositoryManagementWorkflowprotected
PhabricatorRepositoryManagementParentsWorkflowdidConstructpublicPhabricatorRepositoryManagementWorkflowprotected
PhabricatorRepositoryManagementPullWorkflowdidConstructpublicPhabricatorRepositoryManagementWorkflowprotected
PhabricatorRepositoryManagementRefsWorkflowdidConstructpublicPhabricatorRepositoryManagementWorkflowprotected
PhabricatorRepositoryManagementUpdateWorkflowdidConstructpublicPhabricatorRepositoryManagementWorkflowprotected
PhabricatorRepositoryMercurialCommitMessageParserWorkerparseCommitpublicPhabricatorRepositoryCommitMessageParserWorkerprotected
PhabricatorRepositoryMirrorgetConfigurationpublicPhabricatorRepositoryDAOprotected
PhabricatorRepositoryMirrorgeneratePHIDpublicPhabricatorRepositoryDAOprotected
PhabricatorRepositoryMirrorQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorRepositoryPullLocalDaemonrunpublicPhabricatorDaemonprotected
PhabricatorRepositoryPushEventgetConfigurationpublicPhabricatorRepositoryDAOprotected
PhabricatorRepositoryPushEventgeneratePHIDpublicPhabricatorRepositoryDAOprotected
PhabricatorRepositoryPushEventQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorRepositoryPushEventQuerydidFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorRepositoryPushLoggetConfigurationpublicPhabricatorRepositoryDAOprotected
PhabricatorRepositoryPushLoggeneratePHIDpublicPhabricatorRepositoryDAOprotected
PhabricatorRepositoryPushLogQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorRepositoryPushLogSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhabricatorRepositoryPushLogSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorRepositoryPushMailWorkerdoWorkpublicPhabricatorWorkerprotected
PhabricatorRepositoryQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorRepositoryQuerydidFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorRepositoryQuerygetReversePagingpublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorRepositoryRefCursorgetConfigurationpublicPhabricatorRepositoryDAOprotected
PhabricatorRepositoryRefCursorQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorRepositorySearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhabricatorRepositorySearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorRepositoryStatusMessagegetConfigurationpublicPhabricatorRepositoryDAOprotected
PhabricatorRepositorySvnCommitMessageParserWorkerparseCommitpublicPhabricatorRepositoryCommitMessageParserWorkerprotected
PhabricatorRepositorySymbolgetConfigurationpublicPhabricatorRepositoryDAOprotected
PhabricatorRepositoryVCSPasswordgetConfigurationpublicPhabricatorRepositoryDAOprotected
PhabricatorSMSgetConfigurationpublicPhabricatorSMSDAOprotected
PhabricatorSMSDemultiplexWorkerdoWorkpublicPhabricatorSMSWorkerprotected
PhabricatorSMSSendWorkerdoWorkpublicPhabricatorSMSWorkerprotected
PhabricatorSavedQuerygetConfigurationpublicPhabricatorSearchDAOprotected
PhabricatorSearchApplicationSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhabricatorSearchApplicationSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorSearchDocumentgetConfigurationpublicPhabricatorSearchDAOprotected
PhabricatorSearchDocumentFieldgetConfigurationpublicPhabricatorSearchDAOprotected
PhabricatorSearchDocumentRelationshipgetConfigurationpublicPhabricatorSearchDAOprotected
PhabricatorSearchWorkerdoWorkpublicPhabricatorWorkerprotected
PhabricatorSettingsMainControllerbuildApplicationMenupublicPhabricatorControllerprotected
PhabricatorSlowvoteApplicationgetCustomCapabilitiespublicPhabricatorApplicationprotected
PhabricatorSlowvoteChoicegetConfigurationpublicPhabricatorSlowvoteDAOprotected
PhabricatorSlowvoteControllerbuildApplicationMenupublicPhabricatorControllerprotected
PhabricatorSlowvoteControllerbuildApplicationCrumbspublicPhabricatorControllerprotected
PhabricatorSlowvoteOptiongetConfigurationpublicPhabricatorSlowvoteDAOprotected
PhabricatorSlowvotePollgetConfigurationpublicPhabricatorSlowvoteDAOprotected
PhabricatorSlowvotePollgeneratePHIDpublicPhabricatorSlowvoteDAOprotected
PhabricatorSlowvoteQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorSlowvoteQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorSlowvoteSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhabricatorSlowvoteSearchEnginegetRequiredHandlePHIDsForResultListpublicPhabricatorApplicationSearchEngineprotected
PhabricatorStorageManagementAdjustWorkflowdidConstructpublicPhabricatorStorageManagementWorkflowprotected
PhabricatorStorageManagementDatabasesWorkflowdidConstructpublicPhabricatorStorageManagementWorkflowprotected
PhabricatorStorageManagementDestroyWorkflowdidConstructpublicPhabricatorStorageManagementWorkflowprotected
PhabricatorStorageManagementDumpWorkflowdidConstructpublicPhabricatorStorageManagementWorkflowprotected
PhabricatorStorageManagementProbeWorkflowdidConstructpublicPhabricatorStorageManagementWorkflowprotected
PhabricatorStorageManagementQuickstartWorkflowdidConstructpublicPhabricatorStorageManagementWorkflowprotected
PhabricatorStorageManagementStatusWorkflowdidConstructpublicPhabricatorStorageManagementWorkflowprotected
PhabricatorStorageManagementUpgradeWorkflowdidConstructpublicPhabricatorStorageManagementWorkflowprotected
PhabricatorSystemActionLoggetConfigurationpublicPhabricatorSystemDAOprotected
PhabricatorSystemDestructionLoggetConfigurationpublicPhabricatorSystemDAOprotected
PhabricatorSystemRemoveDestroyWorkflowdidConstructpublicPhabricatorSystemRemoveWorkflowprotected
PhabricatorSystemRemoveLogWorkflowdidConstructpublicPhabricatorSystemRemoveWorkflowprotected
PhabricatorTaskmasterDaemonrunpublicPhabricatorDaemonprotected
PhabricatorTokengetConfigurationpublicPhabricatorTokenDAOprotected
PhabricatorTokenControllerbuildApplicationMenupublicPhabricatorControllerprotected
PhabricatorTokenControllerbuildApplicationCrumbspublicPhabricatorControllerprotected
PhabricatorTokenCountgetConfigurationpublicPhabricatorTokenDAOprotected
PhabricatorTokenGivengetConfigurationpublicPhabricatorTokenDAOprotected
PhabricatorTokenGivenQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorTokenReceiverQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhabricatorTransformedFilegetConfigurationpublicPhabricatorFileDAOprotected
PhabricatorTrivialTestCasewillRunOneTestpublicPhabricatorTestCaseprotected
PhabricatorUsergetConfigurationpublicPhabricatorUserDAOprotected
PhabricatorUsergeneratePHIDpublicPhabricatorUserDAOprotected
PhabricatorUserEmailgetConfigurationpublicPhabricatorUserDAOprotected
PhabricatorUserLoggetConfigurationpublicPhabricatorUserDAOprotected
PhabricatorUserPreferencesgetConfigurationpublicPhabricatorUserDAOprotected
PhabricatorUserProfilegetConfigurationpublicPhabricatorUserDAOprotected
PhabricatorWorkerManagementCancelWorkflowdidConstructpublicPhabricatorWorkerManagementWorkflowprotected
PhabricatorWorkerManagementFloodWorkflowdidConstructpublicPhabricatorWorkerManagementWorkflowprotected
PhabricatorWorkerManagementFreeWorkflowdidConstructpublicPhabricatorWorkerManagementWorkflowprotected
PhabricatorWorkerManagementRetryWorkflowdidConstructpublicPhabricatorWorkerManagementWorkflowprotected
PhabricatorWorkerTaskgetConfigurationpublicPhabricatorWorkerDAOprotected
PhabricatorWorkerTaskDatagetConfigurationpublicPhabricatorWorkerDAOprotected
PhabricatorXHPASTViewParseTreegetConfigurationpublicPhabricatorXHPASTViewDAOprotected
PhabricatorXHProfSamplegetConfigurationpublicPhabricatorXHProfDAOprotected
PhameBloggetConfigurationpublicPhameDAOprotected
PhameBloggeneratePHIDpublicPhameDAOprotected
PhameControllerbuildApplicationMenupublicPhabricatorControllerprotected
PhamePostgetConfigurationpublicPhameDAOprotected
PhamePostgeneratePHIDpublicPhameDAOprotected
PhluxVariablegetConfigurationpublicPhluxDAOprotected
PhluxVariablegeneratePHIDpublicPhluxDAOprotected
PholioControllerbuildApplicationCrumbspublicPhabricatorControllerprotected
PholioControllerbuildApplicationMenupublicPhabricatorControllerprotected
PholioImagegetConfigurationpublicPholioDAOprotected
PholioImagegeneratePHIDpublicPholioDAOprotected
PholioMockgetConfigurationpublicPholioDAOprotected
PholioMockgeneratePHIDpublicPholioDAOprotected
PholioMockSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PholioMockSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhortuneAccountgetConfigurationpublicPhortuneDAOprotected
PhortuneAccountgeneratePHIDpublicPhortuneDAOprotected
PhortuneCartgetConfigurationpublicPhortuneDAOprotected
PhortuneCartgeneratePHIDpublicPhortuneDAOprotected
PhortuneCartListControllerbuildApplicationCrumbspublicPhortuneControllerprotected
PhortuneCartSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhortuneChargegetConfigurationpublicPhortuneDAOprotected
PhortuneChargegeneratePHIDpublicPhortuneDAOprotected
PhortuneChargeListControllerbuildApplicationCrumbspublicPhortuneControllerprotected
PhortuneChargeSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhortuneMerchantgetConfigurationpublicPhortuneDAOprotected
PhortuneMerchantgeneratePHIDpublicPhortuneDAOprotected
PhortuneMerchantControllerbuildApplicationCrumbspublicPhortuneControllerprotected
PhortuneMerchantSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhortunePaymentMethodgetConfigurationpublicPhortuneDAOprotected
PhortunePaymentMethodgeneratePHIDpublicPhortuneDAOprotected
PhortunePaymentProviderConfiggetConfigurationpublicPhortuneDAOprotected
PhortunePaymentProviderConfiggeneratePHIDpublicPhortuneDAOprotected
PhortuneProductgetConfigurationpublicPhortuneDAOprotected
PhortuneProductgeneratePHIDpublicPhortuneDAOprotected
PhortunePurchasegetConfigurationpublicPhortuneDAOprotected
PhortunePurchasegeneratePHIDpublicPhortuneDAOprotected
PhragmentFragmentgetConfigurationpublicPhragmentDAOprotected
PhragmentFragmentgeneratePHIDpublicPhragmentDAOprotected
PhragmentFragmentQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhragmentFragmentVersiongetConfigurationpublicPhragmentDAOprotected
PhragmentFragmentVersiongeneratePHIDpublicPhragmentDAOprotected
PhragmentFragmentVersionQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhragmentSnapshotgetConfigurationpublicPhragmentDAOprotected
PhragmentSnapshotgeneratePHIDpublicPhragmentDAOprotected
PhragmentSnapshotChildgetConfigurationpublicPhragmentDAOprotected
PhragmentSnapshotChildQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhragmentSnapshotQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PhrequentSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PhrequentSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PhrequentUserTimegetConfigurationpublicPhrequentDAOprotected
PhrictionContentgetConfigurationpublicPhrictionDAOprotected
PhrictionControllerbuildApplicationMenupublicPhabricatorControllerprotected
PhrictionControllerbuildApplicationCrumbspublicPhabricatorControllerprotected
PhrictionDocumentgetConfigurationpublicPhrictionDAOprotected
PhrictionDocumentgeneratePHIDpublicPhrictionDAOprotected
PhrictionSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
PonderAnswergetConfigurationpublicPonderDAOprotected
PonderAnswergeneratePHIDpublicPonderDAOprotected
PonderAnswerQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PonderAnswerQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PonderControllerbuildApplicationCrumbspublicPhabricatorControllerprotected
PonderQuestiongetConfigurationpublicPonderDAOprotected
PonderQuestiongeneratePHIDpublicPonderDAOprotected
PonderQuestionQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
PonderQuestionSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
PonderQuestionSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
ReleephBranchgetConfigurationpublicReleephDAOprotected
ReleephBranchgeneratePHIDpublicReleephDAOprotected
ReleephBranchwillWriteDatapublicReleephDAOprotected
ReleephBranchPreviewViewgetCustomControlClasspublicAphrontFormControlprotected
ReleephBranchPreviewViewrenderInputpublicAphrontFormControlprotected
ReleephBranchQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
ReleephBranchQuerywillExecutepublicPhabricatorCursorPagedPolicyAwareQueryprotected
ReleephBranchQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
ReleephBranchSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
ReleephBranchViewControllerbuildApplicationCrumbspublicReleephBranchControllerprotected
ReleephControllerbuildApplicationMenupublicPhabricatorControllerprotected
ReleephProductEditorgetCustomTransactionOldValuepublicPhabricatorApplicationTransactionEditorprotected
ReleephProductEditorgetCustomTransactionNewValuepublicPhabricatorApplicationTransactionEditorprotected
ReleephProductEditorapplyCustomInternalTransactionpublicPhabricatorApplicationTransactionEditorprotected
ReleephProductListControllerbuildApplicationCrumbspublicReleephControllerprotected
ReleephProductQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
ReleephProductQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
ReleephProductQuerydidFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
ReleephProductSearchEnginegetApplicationClassNamepublicPhabricatorApplicationSearchEngineprotected
ReleephProductSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
ReleephProductViewControllerbuildApplicationCrumbspublicReleephProductControllerprotected
ReleephProjectgetConfigurationpublicReleephDAOprotected
ReleephProjectgeneratePHIDpublicReleephDAOprotected
ReleephRequestgetConfigurationpublicReleephDAOprotected
ReleephRequestgeneratePHIDpublicReleephDAOprotected
ReleephRequestQueryloadPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
ReleephRequestQuerywillFilterPagepublicPhabricatorCursorPagedPolicyAwareQueryprotected
ReleephRequestSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
ReleephRequestTransactionalEditorgetCustomTransactionOldValuepublicPhabricatorApplicationTransactionEditorprotected
ReleephRequestTransactionalEditorgetCustomTransactionNewValuepublicPhabricatorApplicationTransactionEditorprotected
ReleephRequestTransactionalEditorapplyCustomInternalTransactionpublicPhabricatorApplicationTransactionEditorprotected
ReleephRequestTypeaheadControlgetCustomControlClasspublicAphrontFormControlprotected
ReleephRequestTypeaheadControlrenderInputpublicAphrontFormControlprotected
TokenGiveConduitAPIMethodexecutepublicTokenConduitAPIMethodprotected
TokenGivenConduitAPIMethodexecutepublicTokenConduitAPIMethodprotected
TokenQueryConduitAPIMethodexecutepublicTokenConduitAPIMethodprotected
InstancesInstancegetConfigurationpublicInstancesDAOprotected
InstancesInstancegeneratePHIDpublicInstancesDAOprotected
InstancesInstanceSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
InstancesListControllerbuildApplicationCrumbspublicInstancesControllerprotected
InstancesSyncWorkerdoWorkpublicInstancesWorkerprotected
InstancesUpgradeDatabaseWorkerdoWorkpublicInstancesWorkerprotected
InstancesUpgradeWorkerdoWorkpublicInstancesWorkerprotected

Some caveats:

  • Some of these are in extensions or Phacility libraries (e.g., the Instances stuff).
  • Not 100% sure this is accurate, although spot checking it looks correct.
  • Some code may rely on these incorrect visibilities, so we can't necessarily just find/replace all of these and call it a day.
    • But, realistically, testing them exhaustively would be a huge amount of work.
    • We can probably do one "low risk" pass on the 95% of them that are very unlikely to cause problems, and then test a few in more detail.

Revisions and Commits

rPHU libphutil
D11052
D11404
D11408
D11236
rARC Arcanist
D11414
D11369
D11237
D11238
D11239
rP Phabricator
D11410
D11415
D11416
D11406
D11405
D11407
D11409
D11411
D11412
D11363
D11364
D11366
D11365
D11367
D11368
D11370
D11242
D11241
D11240
D11243
D11244
D11245
D11247
D11246
D11248
D11249

Event Timeline

epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Infrastructure.
epriestley added subscribers: epriestley, fabe, btrahan.

I've been able to knock out a bunch of these.

After my recent diffs, here is the following of the outstanding issues:

ClassMethodCurrent VisibilityParentCorrect Visibility
PhutilExcessiveServiceCallsDaemonrunpublicPhutilTortureTestDaemonprotected
PhutilFatalDaemonrunpublicPhutilTortureTestDaemonprotected
PhutilHangForeverDaemonrunpublicPhutilTortureTestDaemonprotected
PhutilNiceDaemonrunpublicPhutilTortureTestDaemonprotected
PhutilOAuth1FuturegetProxiedFuturepublicFutureProxyprotected
PhutilProcessGroupDaemonrunpublicPhutilTortureTestDaemonprotected
PhutilSaturateStdoutDaemonrunpublicPhutilTortureTestDaemonprotected
DiffusionLowLevelCommitFieldsQueryexecuteQuerypublicDiffusionLowLevelQueryprotected
DiffusionLowLevelCommitQueryexecuteQuerypublicDiffusionLowLevelQueryprotected
DiffusionLowLevelParentsQueryexecuteQuerypublicDiffusionLowLevelQueryprotected
DiffusionLowLevelResolveRefsQueryexecuteQuerypublicDiffusionLowLevelQueryprotected
HarbormasterBuildWorkerdoWorkpublicHarbormasterWorkerprotected
HarbormasterTargetWorkerdoWorkpublicHarbormasterWorkerprotected
LiskIsolationTestDAOestablishLiveConnectionpublicLiskDAOprotected
LiskIsolationTestDAOgetConnectionNamespacepublicLiskDAOprotected
PhabricatorBotrunpublicPhabricatorDaemonprotected
PhabricatorFactDaemonrunpublicPhabricatorDaemonprotected
PhabricatorGarbageCollectorDaemonrunpublicPhabricatorDaemonprotected
PhabricatorLiskDAOestablishLiveConnectionpublicLiskDAOprotected
PhabricatorMetaMTAWorkerdoWorkpublicPhabricatorWorkerprotected
PhabricatorRepositoryPullLocalDaemonrunpublicPhabricatorDaemonprotected
PhabricatorRepositoryPushMailWorkerdoWorkpublicPhabricatorWorkerprotected
PhabricatorSMSDemultiplexWorkerdoWorkpublicPhabricatorSMSWorkerprotected
PhabricatorSMSSendWorkerdoWorkpublicPhabricatorSMSWorkerprotected
PhabricatorSearchWorkerdoWorkpublicPhabricatorWorkerprotected
PhabricatorTaskmasterDaemonrunpublicPhabricatorDaemonprotected
ReleephBranchwillWriteDatapublicReleephDAOprotected
TokenGiveConduitAPIMethodexecutepublicTokenConduitAPIMethodprotected
TokenGivenConduitAPIMethodexecutepublicTokenConduitAPIMethodprotected
TokenQueryConduitAPIMethodexecutepublicTokenConduitAPIMethodprotected
InstancesInstancegetConfigurationpublicInstancesDAOprotected
InstancesInstancegeneratePHIDpublicInstancesDAOprotected
InstancesInstanceSearchEnginegetBuiltinQueryNamespublicPhabricatorApplicationSearchEngineprotected
InstancesListControllerbuildApplicationCrumbspublicInstancesControllerprotected
InstancesSyncWorkerdoWorkpublicInstancesWorkerprotected
InstancesUpgradeDatabaseWorkerdoWorkpublicInstancesWorkerprotected
InstancesUpgradeWorkerdoWorkpublicInstancesWorkerprotected

I think this is done now (with the exception of the super-secret Phacility classes)

I guess I can fix the super-secret Phacility stuff.