Description
Description
Revisions and Commits
Revisions and Commits
| Restricted Differential Revision | ||
| Restricted Differential Revision | Restricted Diffusion Commit |
Related Objects
Related Objects
- Duplicates Merged Here
- T5328: "Undefined offset" error in `DifferentialHunkParser`
Event Timeline
Comment Actions
I am able to consistently reproduce this now. It is happening on a particular diff, but only with "Ignore Most" or "Ignore All" whitespace modes.
[23-Jul-2014 09:27:24 UTC] [2014-07-23 19:27:24] ERROR 8: Undefined offset: 310 at [/usr/src/phabricator/src/applications/differential/parser/DifferentialHunkParser.php:99] [23-Jul-2014 09:27:24 UTC] #0 DifferentialHunkParser::setOldLineTypeMap(array) called at [<phabricator>/src/applications/differential/parser/DifferentialChangesetParser.php:582] [23-Jul-2014 09:27:24 UTC] #1 DifferentialChangesetParser::process() called at [<phabricator>/src/applications/differential/parser/DifferentialChangesetParser.php:512] [23-Jul-2014 09:27:24 UTC] #2 DifferentialChangesetParser::tryCacheStuff() called at [<phabricator>/src/applications/differential/parser/DifferentialChangesetParser.php:742] [23-Jul-2014 09:27:24 UTC] #3 DifferentialChangesetParser::render(NULL, NULL, array) called at [<phabricator>/src/applications/differential/controller/DifferentialChangesetViewController.php:217] [23-Jul-2014 09:27:24 UTC] #4 DifferentialChangesetViewController::processRequest() called at [<phabricator>/webroot/index.php:95]
Comment Actions
Also, a file in the diff has trailing whitespace... I think this might be the cause here.
Comment Actions
I was able to reproduce this behavior with the following diff:
diff --git a/test b/test index 0519ecb..8d1c8b6 100644 --- a/test +++ b/test @@ -1 +1 @@ - \ No newline at end of file +