Page MenuHomePhabricator
Create Task
Maniphest T6858

"Depends on Dx" generates a superfluous edge
Closed, ResolvedPublic
Actions

Description

I created D11188 and D11189, with D11189 having Depends on D11189 in the body. This has generated two edges on D11188:

  • joshuaspence added a dependent revision: D11189: Rename the `_phutil_date_format` function for consistency.
  • joshuaspence mentioned this in D11189: Rename the `_phutil_date_format` function for consistency.

This is possibly related to my recent diffs on modernizing edges?

superfluous_edge (744×1 px, 134 KB)

Revisions and Commits

rP Phabricator
D11460rPc429e4a22279 Don't create mentions for dependent diffs

Related Objects

Event Timeline

joshuaspence created this task.Jan 4 2015, 10:20 AM
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added subscribers: joshuaspence, epriestley.
chad added projects: Transactions, Differential.Jan 4 2015, 4:12 PM
epriestley added a comment.Jan 4 2015, 5:02 PM

Without looking, I don't think this is edge related. IIRC, there's a method to identify exempt PHIDs (PHIDs which should not be mentioned), and it might not be including dependent revisions properly.

It's also vaguely possible that D11049 interacts here, but I'd expect it to go the other way (preventing a mention which was expected) if there was a bug with it.

joshuaspence claimed this task.Jan 21 2015, 12:11 PM
joshuaspence added a revision: D11460: Don't create mentions for dependent diffs.Jan 21 2015, 12:14 PM
joshuaspence closed this task as Resolved by committing rPc429e4a22279: Don't create mentions for dependent diffs.Jan 22 2015, 8:12 PM
joshuaspence added a commit: rPc429e4a22279: Don't create mentions for dependent diffs.
Phabricator · Built by Phacility