Maniphest T7046

Add a linter rule for detecting missing variables for `pht`
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	joshuaspence
	Jan 26 2015, 7:56 PM

Tags

Referenced Files

None

Subscribers

Tokens

"Mountain of Wealth" token, awarded by epriestley.

Description

We should be able to detect the following error:

<?php

echo pht('This string is missing a %s');

See D11501#inline-42448.

Revisions and Commits

rPHU libphutil
	D11682	rPHU33d38a2f0abe Fix `pht` method calls
rARC Arcanist
	D11683	rARC17ec3859cd36 Fix `pht` method calls
	D11661	rARCd8ba7e6f719f Add a linter rule to detect mismatched parameters for formatted strings
rP Phabricator
	D11731	rP84b0c8e6db9e Fix a `pht` method call
	D11680	rPaaf8d73ec798 Fix `pht` method calls

Related Objects

Mentioned Here: D11501: `pht`ize a bunch of strings

Event Timeline

joshuaspence created this task.Jan 26 2015, 7:56 PM

joshuaspence claimed this task.

joshuaspence raised the priority of this task from to Needs Triage.

joshuaspence triaged this task as Low priority.

joshuaspence updated the task description. (Show Details)

joshuaspence added a project: Lint.

joshuaspence added a subscriber: joshuaspence.

epriestley awarded a token.Jan 26 2015, 8:23 PM

joshuaspence added a revision: D11661: Add a linter rule to detect mismatched parameters for formatted strings.Feb 3 2015, 9:14 PM

joshuaspence added a revision: D11680: Fix `pht` method calls.Feb 4 2015, 9:15 PM

joshuaspence added a revision: D11682: Fix `pht` method calls.Feb 4 2015, 10:42 PM

joshuaspence added a revision: D11683: Fix `pht` method calls.

joshuaspence added a commit: rPHU33d38a2f0abe: Fix `pht` method calls.Feb 9 2015, 7:59 PM

joshuaspence closed this task as Resolved by committing rARCd8ba7e6f719f: Add a linter rule to detect mismatched parameters for formatted strings.Feb 10 2015, 7:45 AM

joshuaspence added a commit: rARCd8ba7e6f719f: Add a linter rule to detect mismatched parameters for formatted strings.

joshuaspence added a commit: rARC17ec3859cd36: Fix `pht` method calls.Feb 10 2015, 7:49 AM

joshuaspence added a commit: rPaaf8d73ec798: Fix `pht` method calls.Feb 10 2015, 7:59 AM

joshuaspence added a revision: D11731: Fix a `pht` method call.Feb 10 2015, 8:18 AM

joshuaspence added a commit: rP84b0c8e6db9e: Fix a `pht` method call.Feb 10 2015, 7:54 PM