Page MenuHomePhabricator
Feed Advanced Search

Jan 8 2015

WikiChad added a comment to T6887: Emails sent for historical commits when importing repo to Diffusion.

Here you go: P1698

Jan 8 2015, 3:19 PM · Wikimedia, Audit, Diffusion
• chasemp added a comment to T6887: Emails sent for historical commits when importing repo to Diffusion.

Note: A user reported receiving the same types of emails form this repo https://phabricator.wikimedia.org/diffusion/EVED/

Jan 8 2015, 3:10 PM · Wikimedia, Audit, Diffusion
marutiborker added a comment to T6315: Unhandled EXCEPTION: (AphrontCharacterSetQueryException) when running "scripts/repository/reparse.php".

@TiTi were you able to get around this issue?

Jan 8 2015, 12:05 PM · Diffusion
marutiborker added a comment to T6891: Daemon fails to parse SVN Folder with Whitespace.

Hi, This is a svn client problem. Update the svn client to 1.8x and it should work fine.

Jan 8 2015, 6:36 AM · Diffusion, Subversion
chad updated the task description for T6891: Daemon fails to parse SVN Folder with Whitespace.
Jan 8 2015, 5:03 AM · Diffusion, Subversion
chad created T6891: Daemon fails to parse SVN Folder with Whitespace.
Jan 8 2015, 5:02 AM · Diffusion, Subversion
WikiChad added a comment to T6887: Emails sent for historical commits when importing repo to Diffusion.

Is it possible that the affected repos are being imported by creating a new hosted repo and then pushing to it, versus using "Import existing repository"?

I don't think so but let's ask @WikiChad ?

Jan 8 2015, 3:49 AM · Wikimedia, Audit, Diffusion

Jan 7 2015

epriestley added a comment to T6887: Emails sent for historical commits when importing repo to Diffusion.

Specifically, if you do that, the repo gets "imported" immediately and then the push is treated like new commits. We should probably fix/change that, but not sure if that's what is happening here.

Jan 7 2015, 11:39 PM · Wikimedia, Audit, Diffusion
• chasemp updated subscribers of T6887: Emails sent for historical commits when importing repo to Diffusion.
Jan 7 2015, 11:36 PM · Wikimedia, Audit, Diffusion
• chasemp added a comment to T6887: Emails sent for historical commits when importing repo to Diffusion.

Is it possible that the affected repos are being imported by creating a new hosted repo and then pushing to it, versus using "Import existing repository"?

Jan 7 2015, 11:36 PM · Wikimedia, Audit, Diffusion
epriestley added a comment to T6887: Emails sent for historical commits when importing repo to Diffusion.

Is it possible that the affected repos are being imported by creating a new hosted repo and then pushing to it, versus using "Import existing repository"?

Jan 7 2015, 11:19 PM · Wikimedia, Audit, Diffusion
• chasemp added a comment to T6887: Emails sent for historical commits when importing repo to Diffusion.

side note, we've imported some other repo's like https://phabricator.wikimedia.org/diffusion/OPUP/ and I have personally never gotten an email for my historical activity. So it's some repos only? It has taken us a bit to find the common thread on this.

Jan 7 2015, 7:39 PM · Wikimedia, Audit, Diffusion
• chasemp added a project to T6887: Emails sent for historical commits when importing repo to Diffusion: Wikimedia.
Jan 7 2015, 7:36 PM · Wikimedia, Audit, Diffusion
• chasemp updated the task description for T6887: Emails sent for historical commits when importing repo to Diffusion.
Jan 7 2015, 7:35 PM · Wikimedia, Audit, Diffusion
• chasemp created T6887: Emails sent for historical commits when importing repo to Diffusion.
Jan 7 2015, 7:34 PM · Wikimedia, Audit, Diffusion

Jan 6 2015

staticshock added a comment to T6878: Tagged commits which are not ancestors of any branch head don't get imported.

Yeah, sure. I'm going to assume you're at the root of an existing git repo with at least two commits.

Jan 6 2015, 8:34 PM · Wikimedia, Restricted Project, Diffusion
btrahan closed T5966: Move scripts/repository/reparse.php to bin/repository reparse as Resolved by committing Restricted Diffusion Commit.
Jan 6 2015, 7:42 PM · Diffusion
btrahan added a comment to T6878: Tagged commits which are not ancestors of any branch head don't get imported.

My git foo is somewhat weak. Can you provide a sequence of git, text editing, and arc commands to reproduce this?

Jan 6 2015, 6:08 PM · Wikimedia, Restricted Project, Diffusion
chad added a project to T6878: Tagged commits which are not ancestors of any branch head don't get imported: Diffusion.
Jan 6 2015, 3:09 PM · Wikimedia, Restricted Project, Diffusion
aristedes added a comment to T6866: Add setup check for missing QSA in rewrite rules.

Yeay! Fixed it. So the end result is:

Jan 6 2015, 4:17 AM · Setup
chad added a comment to T6866: Add setup check for missing QSA in rewrite rules.

Yeah our main vibe on this is it's an environment issue, not a Phabricator issue. Though we are always up for improving our 'you has bad environment' checks.

Jan 6 2015, 4:03 AM · Setup
aristedes added a comment to T6866: Add setup check for missing QSA in rewrite rules.

OK, thanks for your help. In the last few minutes I found where the PHP errors logs go (I'm more a Ruby/Java person) and found these logs:

Jan 6 2015, 3:57 AM · Setup
chad added a comment to T6866: Add setup check for missing QSA in rewrite rules.

Sorry, I mean full access (ie, root). If this machine is at your company, it's not something we can help with. If you have a clean AWS image or something, we can poke around, but without an easy case for us to locally reproduce an issue, we have no means of fixing any issue.

Jan 6 2015, 3:34 AM · Setup
aristedes added a comment to T6866: Add setup check for missing QSA in rewrite rules.

Sure. I can open some firewall rules. But I'll send the URL to you privately if that's OK so every web crawler/hacker in the world doesn't have a go at it.

Jan 6 2015, 3:10 AM · Setup
chad added a comment to T6866: Add setup check for missing QSA in rewrite rules.

Can you provide access to an install that exhibits the problem?

Jan 6 2015, 3:08 AM · Setup
aristedes added a comment to T6866: Add setup check for missing QSA in rewrite rules.

Woah... as explained in a previous comment I've already done that. Twice now. First I upgraded to master from github (just read up a few comments). Then I dropped all the databases and started again from scratch.

Jan 6 2015, 3:05 AM · Setup
chad closed T6866: Add setup check for missing QSA in rewrite rules as Invalid.
Jan 6 2015, 2:57 AM · Setup
chad added a comment to T6866: Add setup check for missing QSA in rewrite rules.

I would generally recommend removing the packaged version of Phabricator and installing from our source directly. We have no means of quality control over third party sources and providing support as you can see, is difficult.

Jan 6 2015, 2:57 AM · Setup
aristedes added a comment to T6866: Add setup check for missing QSA in rewrite rules.

No. That works fine.

Jan 6 2015, 2:37 AM · Setup
chad added a comment to T6866: Add setup check for missing QSA in rewrite rules.

Does this server (secure.phabricator.com) give you the same error?

Jan 6 2015, 1:57 AM · Setup
aristedes added a comment to T6866: Add setup check for missing QSA in rewrite rules.

Yes, I get the error after I choose the "password" option in /passphrase/create. Same error as when doing the same thing from the diffusion application.

Jan 6 2015, 1:52 AM · Setup
chad added a comment to T6866: Add setup check for missing QSA in rewrite rules.

https://secure.phabricator.com/passphrase/create gives you an error? I have not been able to reproduce the error you are describing. Does it reproduce on this install? What, specifically, are the steps to reproducing it here?

Jan 6 2015, 1:40 AM · Setup
aristedes added a comment to T6866: Add setup check for missing QSA in rewrite rules.

How do I do that differently to what I described above? Is there some other place in the UI I go to?

Jan 6 2015, 1:30 AM · Setup
chad added a comment to T6866: Add setup check for missing QSA in rewrite rules.

Do you get the same error creating a Passphrase on this instance?

Jan 6 2015, 1:25 AM · Setup
aristedes added a comment to T6866: Add setup check for missing QSA in rewrite rules.

Can you suggest where I should look? Is this the relevant code:

Jan 6 2015, 1:18 AM · Setup
epriestley closed T6637: Diffusion Autoclose should show value of "name.action" of relevant Maniphest status in transaction message. as Resolved.

Closed by commit rP204ae221d270.

Jan 6 2015, 12:22 AM · Transactions, Maniphest, Diffusion

Jan 5 2015

epriestley added a comment to T4801: Error with unclear next steps from `git push` to hosted repository.

We haven't seen other users having difficulty with this.

Jan 5 2015, 11:44 PM · Git, Diffusion
epriestley removed a project from T4801: Error with unclear next steps from `git push` to hosted repository: Support Impact.
Jan 5 2015, 11:44 PM · Git, Diffusion
lpriestley added a revision to T6637: Diffusion Autoclose should show value of "name.action" of relevant Maniphest status in transaction message. : Restricted Differential Revision.
Jan 5 2015, 11:44 PM · Transactions, Maniphest, Diffusion
chad renamed T6306: Add a "members of associated projects" visibility setting to repositories from add a "members of associated projects" visibility setting to repositories to Add a "members of associated projects" visibility setting to repositories.
Jan 5 2015, 6:08 PM · Projects, Diffusion
epriestley added a subtask for T6306: Add a "members of associated projects" visibility setting to repositories: T5681: Allow applications to provide custom policy rules.
Jan 5 2015, 6:06 PM · Projects, Diffusion
aristedes added a comment to T6866: Add setup check for missing QSA in rewrite rules.

Note that I get the same result when I create a new credential from this URL:

Jan 5 2015, 3:01 PM · Setup
aristedes added a comment to T6866: Add setup check for missing QSA in rewrite rules.

https

Jan 5 2015, 2:59 PM · Setup
epriestley added a comment to T6866: Add setup check for missing QSA in rewrite rules.

What protocol does the repository use? For example, if the URL looks like "svn+ssh://example.com/repo", the protocol would be "svn+ssh".

Jan 5 2015, 2:07 PM · Setup
aristedes added a comment to T6866: Add setup check for missing QSA in rewrite rules.

I have upgraded to the current master from the github repository and run
all upgrade scripts. There is no difference in behaviour.

Jan 5 2015, 12:27 PM · Setup
hach-que added a comment to T6866: Add setup check for missing QSA in rewrite rules.

You should install Phabricator using the instructions under https://secure.phabricator.com/book/phabricator/article/installation_guide/#installing-required-comp as that FreeBSD Phabricator package isn't official (as per T4200).

Jan 5 2015, 11:45 AM · Setup
aristedes created T6866: Add setup check for missing QSA in rewrite rules.
Jan 5 2015, 9:05 AM · Setup

Jan 2 2015

Krenair created T6848: It should be possible to view a repository's policies without necessarily being able to edit it.
Jan 2 2015, 3:53 AM · Diffusion (v3)

Jan 1 2015

• zext.zh added a comment to T6196: No Syntax Highlighting in Git Blame View.

我有测试了其他文件,不是必现的,发现有的文件有问题,而有的没有

Jan 1 2015, 2:44 PM · Diffusion
• zext.zh added a comment to T6196: No Syntax Highlighting in Git Blame View.

I also encountered the same problem,Non-probabilistic problem when switching Blame state

Jan 1 2015, 2:20 PM · Diffusion

Dec 31 2014

epriestley added a comment to T6840: Repository imported with some commits missing Herald step.

Tenatively, the easiest fix for this might be to add a Lisk property attribute which stops it from updating the importStatus field during a normal save().

Dec 31 2014, 6:38 PM · Phacility, Diffusion
epriestley added a comment to T6840: Repository imported with some commits missing Herald step.

epriestley: Oh, I thiiink it might be a race condition.
epriestley: Yeah.
epriestley: Your commits are different from mine.
epriestley: So I think what's happening is:
epriestley: Process A is parsing the message for the commit which mentions the problematic commit. It loads a copy of the commit object.
epriestley: Process B is parsing the herald rules for the mentioned commit. It sets the "herald is done" flag.
epriestley: Process A writes the mention and saves the object, reverting the "herald is done" flag.

Dec 31 2014, 6:38 PM · Phacility, Diffusion
epriestley created T6840: Repository imported with some commits missing Herald step.
Dec 31 2014, 6:28 PM · Phacility, Diffusion
btrahan closed T6591: Parsing commits that do not contain available users breaks the task as Invalid.

I went so far as to re-install Phabricator from scratch and was able to successfully fully import the Phabricator repository again.

Dec 31 2014, 6:27 PM · Support Impact, Diffusion, Herald
epriestley added a comment to T6839: Add a `repository reparse --importing X` mode.

Nah, this is just a nice-to-have some day. I haven't seen too many users hitting issues here recently.

Dec 31 2014, 5:57 PM · Diffusion
btrahan added a comment to T6839: Add a `repository reparse --importing X` mode.

Any rush on this / D10492? (There's an inline on D10492 I haven't addressed yet that's rigorous enough with regards to testing that I've been procrastinating...)

Dec 31 2014, 5:55 PM · Diffusion
epriestley created T6839: Add a `repository reparse --importing X` mode.
Dec 31 2014, 5:53 PM · Diffusion

Dec 30 2014

btrahan closed T6826: Initial Push In Log shows invalid hash as Resolved.

Closed by commit rP12c7c399ce14.

Dec 30 2014, 11:18 PM · Diffusion
btrahan claimed T6826: Initial Push In Log shows invalid hash.
Dec 30 2014, 11:08 PM · Diffusion
btrahan added a revision to T6826: Initial Push In Log shows invalid hash: Restricted Differential Revision.
Dec 30 2014, 11:07 PM · Diffusion
chad added projects to T6791: Side-by-side diff for source code is noisier than other tools: Differential, Diffusion.
Dec 30 2014, 5:23 PM · Diffusion, Differential
epriestley closed T6828: Repository import daemon repeatedly crashes and restarts if phabricator.base-uri is not configured as Resolved.

Closed by commit rP2fe553761ae7.

Dec 30 2014, 4:01 PM · Daemons, Diffusion
epriestley added a comment to T6828: Repository import daemon repeatedly crashes and restarts if phabricator.base-uri is not configured.

Possibly we should just prevent the daemons from launching if this isn't defined, although maybe that's too severe. We could look at that if more users run into trouble.

Dec 30 2014, 2:39 PM · Daemons, Diffusion
joshuaspence added a project to T6828: Repository import daemon repeatedly crashes and restarts if phabricator.base-uri is not configured: Daemons.
Dec 30 2014, 2:18 PM · Daemons, Diffusion
epriestley added a revision to T6828: Repository import daemon repeatedly crashes and restarts if phabricator.base-uri is not configured: Restricted Differential Revision.
Dec 30 2014, 11:30 AM · Daemons, Diffusion
epriestley added a comment to T6828: Repository import daemon repeatedly crashes and restarts if phabricator.base-uri is not configured.

Specifically, one of the features that will be enabled is repository imports.

Dec 30 2014, 11:28 AM · Daemons, Diffusion
chad removed projects from T6828: Repository import daemon repeatedly crashes and restarts if phabricator.base-uri is not configured: Differential, Repositories.
Dec 30 2014, 7:19 AM · Daemons, Diffusion
btrahan updated subscribers of T5646: Viewing a non-existent repository in Diffusion throws an unhandled exception.
Dec 30 2014, 7:13 AM · Diffusion
btrahan merged task T6827: Going to a (valid) repository URL that doesn't exist gives an HTTP 500 - Unhandled Exception into T5646: Viewing a non-existent repository in Diffusion throws an unhandled exception.
Dec 30 2014, 7:13 AM · Diffusion
chad added a comment to T6828: Repository import daemon repeatedly crashes and restarts if phabricator.base-uri is not configured.

base_uri breaks lots of random things, which is why we ask you to set it (though some people use it fine without, in limited ability). The full setup message also states scripts and daemons will likely have issues.

Dec 30 2014, 7:08 AM · Daemons, Diffusion
Krenair added a comment to T6828: Repository import daemon repeatedly crashes and restarts if phabricator.base-uri is not configured.

The text shown in the unresolved setup issues was "The base URI for this install is not configured. Configuring it will improve security and enable features." - I would expect it to tell me that this needs to be set up before I can import a repository, not silently fail in the background.

Dec 30 2014, 6:16 AM · Daemons, Diffusion
Krenair added projects to T6828: Repository import daemon repeatedly crashes and restarts if phabricator.base-uri is not configured: Differential, Diffusion.
Dec 30 2014, 6:10 AM · Daemons, Diffusion
Krenair updated the task description for T6827: Going to a (valid) repository URL that doesn't exist gives an HTTP 500 - Unhandled Exception.
Dec 30 2014, 5:35 AM · Diffusion
Krenair created T6827: Going to a (valid) repository URL that doesn't exist gives an HTTP 500 - Unhandled Exception.
Dec 30 2014, 5:34 AM · Diffusion
Mnkras created T6826: Initial Push In Log shows invalid hash.
Dec 30 2014, 4:04 AM · Diffusion

Dec 29 2014

fabe added a revision to T4245: Make repository URIs slightly prettier: Restricted Differential Revision.
Dec 29 2014, 3:32 PM · Prioritized, Diffusion (v3), KDE, Restricted Project

Dec 24 2014

• elastinuno added a comment to T6591: Parsing commits that do not contain available users breaks the task.

We had no herald rules it was a clean start.

Dec 24 2014, 4:47 PM · Support Impact, Diffusion, Herald

Dec 23 2014

btrahan added a comment to T6591: Parsing commits that do not contain available users breaks the task.

Yes, everything is fine. Just an FYI that importing the commits into Phabricator is done via the various worker parsing...

Dec 23 2014, 5:59 PM · Support Impact, Diffusion, Herald
• elastinuno added a comment to T6591: Parsing commits that do not contain available users breaks the task.

The issue is not to import the commits into phabricator. But when the workers start to parse the commits for "whatever". If you go to the deamons task list is everything fine ?

Dec 23 2014, 9:39 AM · Support Impact, Diffusion, Herald
epriestley renamed T6722: Support "Create similar repository..." in Diffusion from Set default settings for new repositories in Diffusion to Support "Create similar repository..." in Diffusion.
Dec 23 2014, 12:01 AM · Diffusion (v3), Restricted Project

Dec 22 2014

btrahan added a comment to T6591: Parsing commits that do not contain available users breaks the task.

I do not know how to reproduce this issue as reported. For example, I import the Phabricator production instance into my local dev install. I do have a btrahan account there, but otherwise there is no user account overlap. Commits seem to import fine:

Dec 22 2014, 7:58 PM · Support Impact, Diffusion, Herald
zorfling added a comment to T6160: Don't show closed branches of mercurial repository.

+1 on this one!
We have 100 odd closed feature branches that are clogging things up.

Dec 22 2014, 4:05 AM · Mercurial, Diffusion

Dec 20 2014

WikiChad added a comment to T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer.

Thanks for getting this so fast, we'll be sure to pull this into our next deployment.

Dec 20 2014, 1:40 AM · Wikimedia, Differential, Diffusion, Support Impact, Policy

Dec 19 2014

btrahan closed T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer as Resolved.

Closed by commit rP8ac73b2bf351.

Dec 19 2014, 10:54 PM · Wikimedia, Differential, Diffusion, Support Impact, Policy
btrahan added a revision to T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer: Restricted Differential Revision.
Dec 19 2014, 10:46 PM · Wikimedia, Differential, Diffusion, Support Impact, Policy
btrahan added a comment to T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer.

I can only reproduce this by setting the Differential application to a restrictive policy such as administrators only. With default policy, uninstalling the Differential application does not reproduce this. Updated the task.

Dec 19 2014, 10:23 PM · Wikimedia, Differential, Diffusion, Support Impact, Policy
btrahan updated the task description for T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer.
Dec 19 2014, 10:22 PM · Wikimedia, Differential, Diffusion, Support Impact, Policy
btrahan claimed T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer.

I peeped the IRC log so I'll take a stab at this now.

Dec 19 2014, 10:19 PM · Wikimedia, Differential, Diffusion, Support Impact, Policy
epriestley updated subscribers of T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer.
Dec 19 2014, 7:28 PM · Wikimedia, Differential, Diffusion, Support Impact, Policy
epriestley created T6790: DiffusionCommitController fails if Differential is uninstalled or not usable by the viewer.
Dec 19 2014, 7:27 PM · Wikimedia, Differential, Diffusion, Support Impact, Policy

Dec 18 2014

• mani added a comment to T5938: Unable to setup a clone of private git repo hosted on GitHub.

how to configure git repository in centos 6.6

Dec 18 2014, 8:46 AM · Diffusion
chad added projects to T6752: Improve functionality of rebasing commits with references in commit message: Diffusion, Transactions.
Dec 18 2014, 4:58 AM · Transactions, Diffusion

Dec 17 2014

chad edited projects for T6737: Task doesn't get "mentioned in revision N" log record if revision comment contains "fix" or "fixed" and auto-close is off for the repository, added: Transactions; removed Maniphest.
Dec 17 2014, 11:35 PM · Transactions, Diffusion
chad created T6775: Provide Remarkup Paste-like embed of Diffusion files/lines.
Dec 17 2014, 4:26 PM · Diffusion, Remarkup

Dec 16 2014

epriestley added a comment to T6742: Daemon tasks not processing, repository reports "Fully Imported".

I filed T6768 to eventually produce a cleaner fix for this issue; D10998 should work, it's just not very elegant.

Dec 16 2014, 11:22 PM · Daemons, Diffusion
epriestley added a revision to T6742: Daemon tasks not processing, repository reports "Fully Imported": Restricted Differential Revision.
Dec 16 2014, 11:14 PM · Daemons, Diffusion
beeerd closed T6742: Daemon tasks not processing, repository reports "Fully Imported" as Wontfix.

Confirmed this is a duplicate of D10998

Dec 16 2014, 11:14 PM · Daemons, Diffusion
beeerd added a comment to T6742: Daemon tasks not processing, repository reports "Fully Imported".

Perhaps I'm running into T6456?

Dec 16 2014, 8:19 PM · Daemons, Diffusion
beeerd added a project to T6742: Daemon tasks not processing, repository reports "Fully Imported": Daemons.
Dec 16 2014, 8:14 PM · Daemons, Diffusion
beeerd added a comment to T6742: Daemon tasks not processing, repository reports "Fully Imported".

I don't think so, I'm seeing this on every repo and I don't see any tracebacks in debug logs. The workers on this install have never processed a single task.

Dec 16 2014, 8:03 PM · Daemons, Diffusion