Page MenuHomePhabricator
Create Task
Maniphest T6637

Diffusion Autoclose should show value of "name.action" of relevant Maniphest status in transaction message.
Closed, ResolvedPublic
Actions

Description

We added a maniphest status "Reopened" with "closed": "false" and a prefix, and made use of Diffusion Autoclose to change the Maniphest status upon commits. The problem is, Maniphest transaction message always show "Closed by commit [commit object]" instead of "Reopened by commit [commit object]", which is misleading.

Revisions and Commits

rP Phabricator
D11230rP204ae221d270 Fixes T6637, "closing by commit" should update task status and specify…

Event Timeline

chokhsin created this task.Nov 25 2014, 3:27 PM
chokhsin renamed this task from Diffusion Autoclose should show value of "name.action" of relevant Maniphest status in maniphest transaction message. to Diffusion Autoclose should show value of "name.action" of relevant Maniphest status in transaction message. .
chokhsin raised the priority of this task from to Needs Triage.
chokhsin updated the task description. (Show Details)
chokhsin added projects: Diffusion, Maniphest.
chokhsin added a subscriber: chokhsin.
chad triaged this task as Low priority.Nov 25 2014, 6:09 PM
chad added a project: Transactions.
epriestley assigned this task to lpriestley.Dec 1 2014, 9:37 PM
epriestley added a subscriber: epriestley.
  • This actual change is straightforward (update getTitle() and getTitleForFeed() in DifferentialTransaction), but testing it isn't.
  • When you get here, let me know and I'll help you set up a repository you can push test commits to.
lpriestley added a revision: D11230: Fixes T6637, "closing by commit" should update task status and specify responsible commit, but drop the artificial comment..Jan 5 2015, 11:44 PM
epriestley closed this task as Resolved.Jan 6 2015, 12:22 AM
epriestley added a commit: rP204ae221d270: Fixes T6637, "closing by commit" should update task status and specify….

Closed by commit rP204ae221d270.

Phabricator · Built by Phacility