I filed T13687 as a followup for preventing this particular sort of error (where a Phobject is incorrectly serialized directly).
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Oct 26 2022
Oct 26 2022
epriestley closed T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization as Resolved.
epriestley triaged T13687: Consider implementing "JsonSerializable" in Phobject to forbid serialization as Wishlist priority.
I patched and partially deployed this in early August. Another unattended MySQL upgrade went out on Monday night, also didn't restart MySQL on affected hosts, and caused some downtime on hosts that didn't have the patch (to "disable unattended upgrades"). I've now deployed this everywhere, and am presuming this is fixed until evidence arises to the contrary.
Oct 25 2022
Oct 25 2022
Aug 8 2022
Aug 8 2022
| Feature | Dimension |
|---|---|
| Barrel | 6.8mm |
| Divot Size | 2.5mm H x 1.15mm W x 1.6mm D |
| Divot Distance | 7mm |
| Shaft | ~3mm |
Jul 29 2022
Jul 29 2022
Jul 8 2022
Jul 8 2022
epriestley added a comment to T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization.
That's very likely the same problem, and I think it should be fixed by updating to the current stable (rPf2a7db1 or newer).
Jun 14 2022
Jun 14 2022
epriestley committed rPf2a7db1b1a1c: (stable) Flatten "RemarkupValue" objects when setting field defaults for custom… (authored by epriestley).
(stable) Flatten "RemarkupValue" objects when setting field defaults for custom…
epriestley committed rP9426765a2c6a: Flatten "RemarkupValue" objects when setting field defaults for custom forms (authored by epriestley).
Flatten "RemarkupValue" objects when setting field defaults for custom forms
epriestley added a comment to T13685: "RemarkupField" returns "RemarkupValue" when editing defaults, which fails to survive serialization.
...ideally this sort of thing should fail loudly at serialization time...
Jun 13 2022
Jun 13 2022
epriestley added a comment to T13684: Drydock resource accounting may put significant stress on the MySQL binlog if a lease is unsatisfiable.
- The drydock_resource table could use a (status, ...) key to satisfy common/default queries.
Jun 7 2022
Jun 7 2022
Jun 3 2022
Jun 3 2022
epriestley committed rP2167016aebba: (stable) Fix repository URI generation for SVN commit identifiers represented… (authored by epriestley).
(stable) Fix repository URI generation for SVN commit identifiers represented…
epriestley committed rP1fc04e238f1d: Fix repository URI generation for SVN commit identifiers represented with… (authored by epriestley).
Fix repository URI generation for SVN commit identifiers represented with…
May 31 2022
May 31 2022
epriestley committed rP944b257d5df3: Fix a policy issue where permissions were not properly checked when disabling… (authored by epriestley).
Fix a policy issue where permissions were not properly checked when disabling…
epriestley committed rP3052ed14849c: Remove obsolete, policy-violating "owners.query" API method (authored by epriestley).
Remove obsolete, policy-violating "owners.query" API method
May 28 2022
May 28 2022
epriestley committed rP95481b5e3c49: (stable) Improve remarkup metadata robustness against debris in the database (authored by epriestley).
(stable) Improve remarkup metadata robustness against debris in the database
epriestley committed rP835cd7f2706f: Improve remarkup metadata robustness against debris in the database (authored by epriestley).
Improve remarkup metadata robustness against debris in the database
epriestley requested review of D21849: Improve remarkup metadata robustness against debris in the database.
May 27 2022
May 27 2022
(stable) Promote 2022 Week 21
(stable) Promote 2022 Week 21
epriestley committed rP809ae8175259: Update Slowvote poll status to use sensible string constants (authored by epriestley).
Update Slowvote poll status to use sensible string constants
epriestley committed rPc1887f0c1d55: Separate Slowvote poll status onto a dedicated object (authored by epriestley).
Separate Slowvote poll status onto a dedicated object
epriestley requested review of D21848: Update Slowvote poll status to use sensible string constants.
May 26 2022
May 26 2022
epriestley committed rP03d3d1889d60: Update Slowvote voting methods to use sensible string constants (authored by epriestley).
Update Slowvote voting methods to use sensible string constants
epriestley requested review of D21846: Update Slowvote voting methods to use sensible string constants.
epriestley committed rP9dad49472c04: Move Slowvote vote types to a separate object (authored by epriestley).
Move Slowvote vote types to a separate object
- Update some file/class names.
epriestley committed rP9f075839a23f: Update Slowvote to use sensible string constants for response visibility (authored by epriestley).
Update Slowvote to use sensible string constants for response visibility
epriestley committed rP23094b495024: Move Slowvote response visibility to a separate object (authored by epriestley).
Move Slowvote response visibility to a separate object
epriestley committed rPb1533e5468b1: Migrate "SlowvotePoll" to modern mailkey storage (authored by epriestley).
Migrate "SlowvotePoll" to modern mailkey storage
epriestley committed rPd91727e66ceb: Update nonstandard PHID key on "SlowvotePoll" (authored by epriestley).
Update nonstandard PHID key on "SlowvotePoll"
After recent changes, only DifferentialRevision and ManiphestTask still have onboard mail keys.
May 25 2022
May 25 2022
epriestley committed rP7e5f7b96404f: Update "Files" attachment table to show more attachment details and support… (authored by epriestley).
Update "Files" attachment table to show more attachment details and support…
epriestley added a comment to T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
"PhabricatorApplicationTransactionCommentView->setDraft()" has exactly two callers: one in Slowvote...
epriestley committed rP5aa159a83013: Pass "object" to modular transaction methods explicitly (authored by epriestley).
Pass "object" to modular transaction methods explicitly
May 24 2022
May 24 2022
epriestley committed rP8e703c8c351d: Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery" (authored by epriestley).
Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery"
epriestley updated the task description for T13682: Improve Remarkup file reference attachment behaviors after removal of "attach by default".
epriestley committed rP5493f028dca6: Provide a simple "Attach File" explicit workflow for files referenced but not… (authored by epriestley).
Provide a simple "Attach File" explicit workflow for files referenced but not…
epriestley updated the diff for D21837: Provide a simple "Attach File" explicit workflow for files referenced but not attached.
- Rebuild Celerity map.
epriestley updated the diff for D21837: Provide a simple "Attach File" explicit workflow for files referenced but not attached.
- Correct some translation strings.
May 23 2022
May 23 2022
epriestley committed rP021e5ab933e4: Provide a rudimentary "Attached Files" curtain UI panel (authored by epriestley).
Provide a rudimentary "Attached Files" curtain UI panel
epriestley committed rP5033ef6f88b3: Give "FileAttachment" policy support and a query object (authored by epriestley).
Give "FileAttachment" policy support and a query object
epriestley committed rP631c36aee326: Don't consider file references inside quoted text blocks to grant "attachment… (authored by epriestley).
Don't consider file references inside quoted text blocks to grant "attachment…
epriestley committed rP2a0feb3de0e2: Only attach files that are both referenced in Remarkup and attached by explicit… (authored by epriestley).
Only attach files that are both referenced in Remarkup and attached by explicit…