Page MenuHomePhabricator

Fix a policy issue where permissions were not properly checked when disabling global builtin queries
ClosedPublic

Authored by epriestley on Tue, May 31, 5:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 20, 5:17 PM
Unknown Object (File)
Thu, Jun 16, 10:30 AM
Unknown Object (File)
Thu, Jun 16, 10:30 AM
Unknown Object (File)
Thu, Jun 16, 10:30 AM
Unknown Object (File)
Mon, Jun 13, 1:55 PM
Unknown Object (File)
Thu, Jun 9, 9:45 AM
Subscribers
None

Details

Summary

See https://hackerone.com/reports/1573143. The pathway for disabling global builtin queries is missing a policy check. Add it.

Test Plan
  • Accessed the "/search/delete/id/.../" URI for a global builtin query as a non-administrator.
  • Before patch: could improperly disable queries. -After patch: proper policy exception.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Tue, May 31, 6:00 PM
This revision was automatically updated to reflect the committed changes.