Page MenuHomePhabricator

Fix a policy issue where permissions were not properly checked when disabling global builtin queries
ClosedPublic

Authored by epriestley on May 31 2022, 5:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 23 2025, 4:15 PM
Unknown Object (File)
Apr 18 2025, 9:14 AM
Unknown Object (File)
Apr 15 2025, 11:08 AM
Unknown Object (File)
Apr 12 2025, 5:23 PM
Unknown Object (File)
Apr 10 2025, 10:29 AM
Unknown Object (File)
Apr 9 2025, 12:02 PM
Unknown Object (File)
Mar 28 2025, 7:27 PM
Unknown Object (File)
Mar 28 2025, 7:26 PM
Subscribers
None

Details

Summary

See https://hackerone.com/reports/1573143. The pathway for disabling global builtin queries is missing a policy check. Add it.

Test Plan
  • Accessed the "/search/delete/id/.../" URI for a global builtin query as a non-administrator.
  • Before patch: could improperly disable queries. -After patch: proper policy exception.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.May 31 2022, 6:00 PM
This revision was automatically updated to reflect the committed changes.