Page MenuHomePhabricator

Fix repository URI generation for SVN commit identifiers represented with integer types
ClosedPublic

Authored by epriestley on Jun 3 2022, 10:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 7, 6:08 AM
Unknown Object (File)
Apr 25 2025, 1:45 AM
Unknown Object (File)
Apr 23 2025, 6:30 PM
Unknown Object (File)
Apr 13 2025, 8:29 PM
Unknown Object (File)
Apr 12 2025, 8:26 PM
Unknown Object (File)
Apr 11 2025, 2:58 PM
Unknown Object (File)
Mar 30 2025, 10:50 AM
Unknown Object (File)
Mar 29 2025, 4:40 PM
Subscribers
None

Details

Summary

Ref T13588. See PHI2198. Some pathways represent SVN commit identifiers (which are numeric) with integers; these raise an exception in phutil_nonempty_string(), which is strict.

(Ideally, commit identifiers wouldn't have mixed types, but that's a dramatically less practical change.)

Test Plan

Will deploy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable