Page MenuHomePhabricator

Fix repository URI generation for SVN commit identifiers represented with integer types
ClosedPublic

Authored by epriestley on Jun 3 2022, 10:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 5, 1:55 AM
Unknown Object (File)
Wed, Sep 4, 11:49 PM
Unknown Object (File)
Sun, Sep 1, 9:31 PM
Unknown Object (File)
Sun, Sep 1, 6:33 PM
Unknown Object (File)
Sat, Aug 31, 4:19 PM
Unknown Object (File)
Sat, Aug 31, 4:19 PM
Unknown Object (File)
Sat, Aug 31, 4:18 PM
Unknown Object (File)
Sat, Aug 31, 10:28 AM
Subscribers
None

Details

Summary

Ref T13588. See PHI2198. Some pathways represent SVN commit identifiers (which are numeric) with integers; these raise an exception in phutil_nonempty_string(), which is strict.

(Ideally, commit identifiers wouldn't have mixed types, but that's a dramatically less practical change.)

Test Plan

Will deploy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable