Page MenuHomePhabricator

Fix repository URI generation for SVN commit identifiers represented with integer types
ClosedPublic

Authored by epriestley on Fri, Jun 3, 10:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 25, 7:05 PM
Unknown Object (File)
Thu, Jun 23, 2:33 PM
Unknown Object (File)
Mon, Jun 20, 5:35 PM
Unknown Object (File)
Sat, Jun 18, 7:40 AM
Unknown Object (File)
Fri, Jun 17, 3:00 PM
Unknown Object (File)
Thu, Jun 16, 10:30 AM
Unknown Object (File)
Thu, Jun 16, 10:30 AM
Unknown Object (File)
Thu, Jun 16, 10:30 AM
Subscribers
None

Details

Summary

Ref T13588. See PHI2198. Some pathways represent SVN commit identifiers (which are numeric) with integers; these raise an exception in phutil_nonempty_string(), which is strict.

(Ideally, commit identifiers wouldn't have mixed types, but that's a dramatically less practical change.)

Test Plan

Will deploy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable