Page MenuHomePhabricator
Differential D21852

Fix repository URI generation for SVN commit identifiers represented with integer types
ClosedPublic
Actions

Authored by epriestley on Jun 3 2022, 10:00 PM.
Tags
None
Referenced Files
F14755330: D21852.id52082.diff
Tue, Jan 21, 4:00 PM
F14755214: D21852.id52083.diff
Tue, Jan 21, 3:57 PM
Unknown Object (File)
Tue, Jan 21, 12:57 PM
Unknown Object (File)
Sat, Jan 18, 12:29 AM
Unknown Object (File)
Fri, Jan 17, 10:24 PM
Unknown Object (File)
Fri, Jan 17, 8:33 PM
Unknown Object (File)
Fri, Jan 17, 10:41 AM
Unknown Object (File)
Mon, Jan 13, 8:30 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13588: PHP 8 Compatibility
Commits
rP2167016aebba: (stable) Fix repository URI generation for SVN commit identifiers represented…
rP1fc04e238f1d: Fix repository URI generation for SVN commit identifiers represented with…
Summary

Ref T13588. See PHI2198. Some pathways represent SVN commit identifiers (which are numeric) with integers; these raise an exception in phutil_nonempty_string(), which is strict.

(Ideally, commit identifiers wouldn't have mixed types, but that's a dramatically less practical change.)

Test Plan

Will deploy.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
storage/
2 lines

Diff 52083

View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility