Page MenuHomePhabricator
Feed Advanced Search

Jul 21 2017

chad added a comment to T12931: Fallback for incorrect default branch in Diffusion could be nicer.

Before we didn't render the table, so the link to visit said table as full screen, doesn't exist. I think I need... better fallback here.

Jul 21 2017, 9:29 PM · Feature Request, Diffusion
chad added a comment to T12931: Fallback for incorrect default branch in Diffusion could be nicer.

The reason I took navigation away is we throw exceptions instead of error messages when master isn't present (or have no commits yet). Do you remember the reasoning there (using Exception)?

Jul 21 2017, 9:28 PM · Feature Request, Diffusion
chad added a comment to T12931: Fallback for incorrect default branch in Diffusion could be nicer.

ok thanks for the nice and easy repo steps. I'll have something after lunch, got appt at 11

Jul 21 2017, 5:42 PM · Feature Request, Diffusion
epriestley added a comment to T12931: Fallback for incorrect default branch in Diffusion could be nicer.

I believe the issue here is:

Jul 21 2017, 5:41 PM · Feature Request, Diffusion
chad added a comment to T12931: Fallback for incorrect default branch in Diffusion could be nicer.

oic k thx

Jul 21 2017, 5:41 PM · Feature Request, Diffusion
epriestley renamed T12931: Fallback for incorrect default branch in Diffusion could be nicer from Diffusion doesn't render tabs if master isn't present in git to Diffusion doesn't render tabs if a repository has commits and a "Default Branch" set to a branch which does not exist.
Jul 21 2017, 5:38 PM · Feature Request, Diffusion
chad added a project to T12931: Fallback for incorrect default branch in Diffusion could be nicer: Bug Report.
Jul 21 2017, 5:32 PM · Feature Request, Diffusion

Jul 19 2017

jmeador added a comment to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs.

In the refcursor table, our current autoincrement is at 312,036,016. This is only 7% of the way to int unsigned, but the fact that we've made it to 7% in 18 months might suggest that column should be BIGINT, unless there are performance impacts of that.

Jul 19 2017, 11:09 PM · Customer Impact, Diffusion, Bug Report
chad added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

it might have something to do with appearance.

Jul 19 2017, 9:43 PM · Firefox, Bug Report
chad added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

All my firefox tests, as expected, look like 💩 😦

Jul 19 2017, 9:42 PM · Firefox, Bug Report
chad added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

The expected case doesn't reproduce for me

Jul 19 2017, 9:42 PM · Firefox, Bug Report
epriestley added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

I think (?) this reproduces for me, too:

Jul 19 2017, 9:41 PM · Firefox, Bug Report
cspeckmim added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

It seems like a bug in FF to me

Jul 19 2017, 9:38 PM · Firefox, Bug Report
cspeckmim added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

Hmm I've tried on two separate OSX machines using Firefox and can reproduce

Jul 19 2017, 9:32 PM · Firefox, Bug Report
chad added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

I still can't reproduce it locally. Tried colors, tried high-contrast.

Jul 19 2017, 9:10 PM · Firefox, Bug Report
chad added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

kk

Jul 19 2017, 8:58 PM · Firefox, Bug Report
cspeckmim added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

At least, change from 464C5C to 000 when using Default Mode (not High Contrast), caused the menu to appear in the same fashion as High Contrast

Jul 19 2017, 8:54 PM · Firefox, Bug Report
cspeckmim added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

It's the color of <select>

Jul 19 2017, 8:53 PM · Firefox, Bug Report
chad added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

I don't know, I mean, I'd like to understand what triggers it to look so much better, but it's not a regression it sounds.

Jul 19 2017, 8:50 PM · Firefox, Bug Report
cspeckmim added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

So this may be invalid? @cspeck just had to turn on High-Contrast on the test install~

Jul 19 2017, 8:46 PM · Firefox, Bug Report
cspeckmim added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

Disregard the different installs - I can reproduce on this install as well just by switching High-Contrast on/off.

Jul 19 2017, 8:44 PM · Firefox, Bug Report
cspeckmim added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

The difference appears when using High-Contrast vs. Regular-Type

Jul 19 2017, 8:41 PM · Firefox, Bug Report
cspeckmim added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

Errr I may need to investigate further - this install has the same "Mid-April" style using this same browser. I noticed this change on our test instance after upgrading to the latest. We don't inject any styles/js or anything so I'm not sure why that instance would be different.

Jul 19 2017, 8:39 PM · Firefox, Bug Report
chad added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

If we think it's a CSS change, and not a FF issue, going to have to bisect for it. No matter what I do, I can't get that menu to look like that on Firefox.

Jul 19 2017, 8:39 PM · Firefox, Bug Report
cspeckmim added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

Not particularly - I copied the select HTML into a "Tryit Editor" from W3:
https://www.w3schools.com/code/tryit.asp?filename=FHPUWOW4JNFN

Jul 19 2017, 8:36 PM · Firefox, Bug Report
chad added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

FWIW, ours looks the same as every dropdown I can find on other websites using Firefox 54, Mac. Do you have an example site that looks like your "Mid-April" install.

Jul 19 2017, 8:31 PM · Firefox, Bug Report
epriestley added a project to T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs: Customer Impact.

See PHI11. This has material impact when using PhabricatorRepositoryRefCursorQuery to query landing targets, and likely impacts the logic in DifferentialRevisionOperationController.

Jul 19 2017, 8:18 PM · Customer Impact, Diffusion, Bug Report
cspeckmim added a comment to T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.

I can't prove it but it feels like the new style is a bit sensitive to selecting an item -- sometimes when opening the dropdown menu the first item auto-selects and closes immediately. I can't prove it though.

Jul 19 2017, 8:09 PM · Firefox, Bug Report
cspeckmim created T12930: Firefox renders the open dropdown states for <select /> inputs with a "color" style in a primitive way.
Jul 19 2017, 8:00 PM · Firefox, Bug Report

Jul 18 2017

avivey closed T12924: Applications -> Search -> Configure is fataling as Resolved by committing Restricted Diffusion Commit.
Jul 18 2017, 5:45 PM · Bug Report
remusvrm updated subscribers of T12103: No active Drydock blueprint exists which can ever allocate a resource for lease, when there is one available.

Thanks @pooyajavan for your update. But in your solution, the Blueprint is cloning the repository, which I don't want to do that just for running a simple cmd.

Jul 18 2017, 2:21 PM · Bug Report
pouyana added a comment to T12103: No active Drydock blueprint exists which can ever allocate a resource for lease, when there is one available.

Hi I have found the solution, added in stackoverflow, forgot to post it here again.

Jul 18 2017, 1:54 PM · Bug Report
remusvrm added a comment to T12103: No active Drydock blueprint exists which can ever allocate a resource for lease, when there is one available.

I have exactly the same problem. Any update regarding this issue?

Jul 18 2017, 1:35 PM · Bug Report

Jul 17 2017

avivey added a revision to T12924: Applications -> Search -> Configure is fataling: Restricted Differential Revision.
Jul 17 2017, 11:43 PM · Bug Report
nickhutchinson added a comment to T11364: arc confused by HTTP->HTTPS redirects.

My install hit this today: we're trying to upgrade from http -> https, but don't want to break users with the old http:// address in their .arcconfig (either because they haven't pulled master recently, are working on a different branch, are bisecting to a commit prior to the .arcconfig being updated, etc).

Jul 17 2017, 11:40 PM · Arcanist, Bug Report
avivey created T12924: Applications -> Search -> Configure is fataling.
Jul 17 2017, 8:47 PM · Bug Report

Jul 13 2017

epriestley added a comment to T12920: Retracting requested changes can leave revision in "Needs Revision" state.

I think we end up more consistent overall if "Resign" and "Accept" have the same behavior in this case.

Jul 13 2017, 8:37 PM · Restricted Project, Differential, Bug Report
jboning added a comment to T12920: Retracting requested changes can leave revision in "Needs Revision" state.

That sounds less surprising to me, in the sense that it's not an explicit reversal of having requested changes. I can imagine arguments in both directions for the resign case.

Jul 13 2017, 8:32 PM · Restricted Project, Differential, Bug Report
epriestley added a comment to T12920: Retracting requested changes can leave revision in "Needs Revision" state.

From reading the code, resigning (instead of accepting) probably also leaves the revision in "Needs Revision".

Jul 13 2017, 8:29 PM · Restricted Project, Differential, Bug Report
20after4 added a comment to T12909: Calendar ignores email preferences if a user is invited via a project.

I've seen complaints about this on phabricator.wikimedia.org as well, so I can confirm that this is an issue.

Jul 13 2017, 7:29 PM · Calendar, Bug Report
chad added a comment to T12920: Retracting requested changes can leave revision in "Needs Revision" state.

O.O

Jul 13 2017, 7:20 PM · Restricted Project, Differential, Bug Report
jboning created T12920: Retracting requested changes can leave revision in "Needs Revision" state.
Jul 13 2017, 6:57 PM · Restricted Project, Differential, Bug Report

Jul 12 2017

avivey added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

Also, have you tried looking around the git community? I was always under the impression that SSH should be faster than HTTPS cloning, or possibly using the same protocol.

Jul 12 2017, 7:09 PM · Feature Request
chad closed T12915: SVN repositories give `Unhandled Exception ("RuntimeException")` in Diffusion as Resolved by committing Restricted Diffusion Commit.
Jul 12 2017, 2:05 PM · Subversion, Diffusion, Bug Report
keithzg added a comment to T12915: SVN repositories give `Unhandled Exception ("RuntimeException")` in Diffusion.

Solves things for my instances, cheers!

Jul 12 2017, 9:25 AM · Subversion, Diffusion, Bug Report
chad added a revision to T12915: SVN repositories give `Unhandled Exception ("RuntimeException")` in Diffusion: Restricted Differential Revision.
Jul 12 2017, 3:38 AM · Subversion, Diffusion, Bug Report
chad reopened T12915: SVN repositories give `Unhandled Exception ("RuntimeException")` in Diffusion as "Open".

Going to keep this Open and build out some proper blank states. This feel pretty janky.

Jul 12 2017, 3:00 AM · Subversion, Diffusion, Bug Report
chad added a comment to T12915: SVN repositories give `Unhandled Exception ("RuntimeException")` in Diffusion.

I pushed a hotfix up at HEAD of master, let us know if you're still having problems. Thanks for the report!

Jul 12 2017, 2:52 AM · Subversion, Diffusion, Bug Report
chad closed T12915: SVN repositories give `Unhandled Exception ("RuntimeException")` in Diffusion as Resolved by committing Restricted Diffusion Commit.
Jul 12 2017, 2:51 AM · Subversion, Diffusion, Bug Report
chad added a revision to T12915: SVN repositories give `Unhandled Exception ("RuntimeException")` in Diffusion: Restricted Differential Revision.
Jul 12 2017, 2:50 AM · Subversion, Diffusion, Bug Report
keithzg created T12915: SVN repositories give `Unhandled Exception ("RuntimeException")` in Diffusion.
Jul 12 2017, 1:31 AM · Subversion, Diffusion, Bug Report

Jul 11 2017

chad merged task T11152: Some workflows of arc are broken on Windows into T8291: arc version fails on Windows.
Jul 11 2017, 11:31 PM · Arcanist, Windows, Bug Report
chad merged task T12914: Arcanist in Windows: ERROR 8: Undefined offset into T8821: arc commands (diff, version) fails on Windows - terrible fix inside.
Jul 11 2017, 11:30 PM · Bug Report
chad merged task T12913: `arc version` throws exception into T8291: arc version fails on Windows.
Jul 11 2017, 11:29 PM · Bug Report
chad added a comment to T12913: `arc version` throws exception.

Please provide reproduction instructions. There aren't enough details here.

Jul 11 2017, 11:16 PM · Bug Report
dwilches created T12914: Arcanist in Windows: ERROR 8: Undefined offset.
Jul 11 2017, 11:07 PM · Bug Report
dwilches created T12913: `arc version` throws exception.
Jul 11 2017, 11:06 PM · Bug Report
Luke081515.2 added a comment to T12839: Can't create one day event.

Hm, this screenshot made me dig a bit into the whole thing, so here is what I've found:
First, my date format is different because of my settings:

Jul 11 2017, 9:10 PM · Calendar, Bug Report
chad added a comment to T12839: Can't create one day event.

Why does your date format look different than ours? Is that a local modification or do we support this somewhere I'm not aware of.

Jul 11 2017, 8:40 PM · Calendar, Bug Report
chad added a comment to T12912: Can't create one day event (again).

Merging over so there is one thread on this topic. We're happy to reopen if you have new reproduction steps we can follow or if you can verify on a Phacility test instance.

Jul 11 2017, 8:37 PM · Calendar, Bug Report
chad merged task T12912: Can't create one day event (again) into T12839: Can't create one day event.
Jul 11 2017, 8:36 PM · Calendar, Bug Report
chad merged T12912: Can't create one day event (again) into T12839: Can't create one day event.
Jul 11 2017, 8:36 PM · Calendar, Bug Report
chad added a comment to T12912: Can't create one day event (again).

I can't reproduce this (again)

Jul 11 2017, 8:30 PM · Calendar, Bug Report
Luke081515.2 added a comment to T12912: Can't create one day event (again).

Here's the proof: F5042439

Jul 11 2017, 8:24 PM · Calendar, Bug Report
Luke081515.2 created T12912: Can't create one day event (again).
Jul 11 2017, 8:22 PM · Calendar, Bug Report
chad added a comment to T10745: Emails are sent out about restricted changes.

FWIW, I don't think these are "pure" spam emails, as in, that they are 100% unwanted by everyone. Even if you cannot see the underlying diff, you've asked to be notified when work happens essentially on a task. I think it's difficult to have Phabricator assess whether this email is informative or not to each individual user who subscribed. To some who are waiting for the product, it's valuable, to you or others perhaps not at all. Client side filtering still seems like the correct workaround until T5791 (which is server side email filtering).

Jul 11 2017, 5:40 AM · Restricted Project, Bug Report
chad added a comment to T10745: Emails are sent out about restricted changes.

Hmm, what did you try for search, off hand, do you recall?

Jul 11 2017, 5:27 AM · Restricted Project, Bug Report
MZMcBride added a comment to T10745: Emails are sent out about restricted changes.
In T10745#229028, @chad wrote:

I'm not sure I follow what you're trying to tell us.

Jul 11 2017, 5:23 AM · Restricted Project, Bug Report
chad added a comment to T10745: Emails are sent out about restricted changes.

I'm not sure I follow what you're trying to tell us.

Jul 11 2017, 4:33 AM · Restricted Project, Bug Report
MZMcBride added a comment to T10745: Emails are sent out about restricted changes.

These types of e-mails are still being sent. Here's one from July 10, 2017:

Jul 11 2017, 4:01 AM · Restricted Project, Bug Report

Jul 10 2017

ivo created T12909: Calendar ignores email preferences if a user is invited via a project.
Jul 10 2017, 9:45 AM · Calendar, Bug Report
epriestley removed a project from T12907: Unable to download large files through alternative file domain: Phacility.
Jul 10 2017, 1:53 AM · Bug Report
joshuaspence renamed T12907: Unable to download large files through alternative file domain from Unable to download large files from secure.phabricator.com to Unable to download large files through alternative file domain.
Jul 10 2017, 12:12 AM · Bug Report
chad added a comment to T12907: Unable to download large files through alternative file domain.

👍🏻

Jul 10 2017, 12:11 AM · Bug Report
joshuaspence added a comment to T12907: Unable to download large files through alternative file domain.

Ah sorry, I should've made that clear. Yes, I am able to reproduce the issue on our installation.

Jul 10 2017, 12:09 AM · Bug Report
chad added a comment to T12907: Unable to download large files through alternative file domain.

Were you reproducing a local issue? That wasn't my impression, unless I'm misreading it. It seemed specific to secure.

Jul 10 2017, 12:07 AM · Bug Report
joshuaspence added a comment to T12907: Unable to download large files through alternative file domain.
In T12907#228951, @chad wrote:

This is not a test install.

Jul 10 2017, 12:03 AM · Bug Report
chad added a comment to T12907: Unable to download large files through alternative file domain.

This is not a test install.

Jul 10 2017, 12:01 AM · Bug Report

Jul 9 2017

joshuaspence created T12907: Unable to download large files through alternative file domain.
Jul 9 2017, 11:55 PM · Bug Report
chad removed the image for Bug Report.
Jul 9 2017, 7:28 PM
hskiba added a comment to T12905: Diffusion browsing is broken for SVN.

Awesome.. Thanks!

Jul 9 2017, 2:33 PM · Bug Report
chad added a comment to T12905: Diffusion browsing is broken for SVN.

I pushed this to HEAD of master, we'll cherry-pick it shortly to stable.

Jul 9 2017, 1:47 PM · Bug Report
chad closed T12905: Diffusion browsing is broken for SVN as Resolved by committing Restricted Diffusion Commit.
Jul 9 2017, 1:43 PM · Bug Report
chad added a revision to T12905: Diffusion browsing is broken for SVN: Restricted Differential Revision.
Jul 9 2017, 1:43 PM · Bug Report
chad added a revision to T12905: Diffusion browsing is broken for SVN: Restricted Differential Revision.
Jul 9 2017, 12:39 PM · Bug Report
chad added a comment to T12905: Diffusion browsing is broken for SVN.

This is fixed in D18189.

Jul 9 2017, 12:38 PM · Bug Report
hskiba created T12905: Diffusion browsing is broken for SVN.
Jul 9 2017, 5:41 AM · Bug Report

Jul 7 2017

chad added a comment to T12902: Connecting to Database.

I don't have any great thoughts here. I'd dig into MySQL and see what limits might be getting reached that it's turning away connections. I presume you did not set up clustering in the database? Unclear what "I even only have one master an replicas." means.

Jul 7 2017, 11:31 PM · Bug Report
gino.atlas added a comment to T12902: Connecting to Database.

I can supply more information, if Iknow what is necessary. But let me try to clarify the issue.

Jul 7 2017, 3:24 PM · Bug Report
chad added a comment to T12902: Connecting to Database.

To take a step back, the upstream has exceedingly limited "free support" resources. So in exchange for providing free support, we simply as users to read and follow guidelines before submission. This reduces support overhead on the upstream and means more time can be spent both providing support to other users or by developing new features. There are more detailed discussions on how we can continue "free support" and "paid support" under T9212 and T12681.

Jul 7 2017, 2:45 PM · Bug Report
chad added a comment to T12902: Connecting to Database.

And wow on your reply. Just ... wow.

Jul 7 2017, 2:37 PM · Bug Report
chad added a comment to T12902: Connecting to Database.

The document I linked (and also on the form you filled out for reporting a bug) state the requirements on what's required for a bug report. I marked this as invalid and directed you to a document on how to resolve it.

Jul 7 2017, 2:26 PM · Bug Report
gino.atlas updated subscribers of T12902: Connecting to Database.
Jul 7 2017, 2:09 PM · Bug Report
gino.atlas added a comment to T12902: Connecting to Database.

@chad It's more helpful. If you would have a template instead of a page long instruction.
+ If you tag it as invalid, it's also nice why it is invalid. I provided versions and logs.
+ if you leave user alone with her/his problems, they lose wish to use it.

Jul 7 2017, 2:07 PM · Bug Report
chad added a comment to T12902: Connecting to Database.

Please read and follow Contributing Bug Reports.

Jul 7 2017, 1:58 PM · Bug Report
chad closed T12902: Connecting to Database as Invalid.
Jul 7 2017, 1:55 PM · Bug Report
gino.atlas created T12902: Connecting to Database.
Jul 7 2017, 1:51 PM · Bug Report
pangff added a comment to T10705: You must use withSourcePHIDs() to query edges..

I get the same error after delete project by "bin/remove destory phid". I find that the phid has been removed from edge table in mysql but the phid exist in project table. so I delete the phid project record in project table just resovle it

Jul 7 2017, 5:07 AM · Bug Report

Jul 6 2017

epriestley closed T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors as Resolved.

That use case doesn't strike me as compelling enough to justify a separate field or a behavioral change so I don't plan to adjust our behavior here.

Jul 6 2017, 3:15 PM · Phame, Policy, Bug Report
stevex added a comment to T12900: Phame blog draft posts are visible to users who can edit the blog, but the UI states that they are visible to only authors.

Only you and users who have permission to edit <Blog Name> can see this draft until it is published. Use "Publish" to publish this post.

...would that resolve things in your case? Or does the rule we actually implement not work as well as "only the author" in your use case?

Jul 6 2017, 3:12 PM · Phame, Policy, Bug Report