Maniphest T12905

Diffusion browsing is broken for SVN
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	hskiba
	Jul 9 2017, 5:41 AM

Tags

Referenced Files

	F5038536: image.png
	Jul 9 2017, 5:41 AM

Subscribers

Description

I noticed after I upgraded our install to the latest stable that attempting to browse an SVN repository throws the following exception.

image.png (282×440 px, 16 KB)

The issue can be replicated on this install.

Revisions and Commits

rP Phabricator
	D18190	rP3480b3e7ef00 (stable) Fix comparison check for SVN in browsing Diffusion
	D18189	rP39e5da7ea700 Simplify Diffusion Browse Table
	D18190	rP0b3117bb684e Fix comparison check for SVN in browsing Diffusion

Related Objects

Mentioned Here: D18189: Simplify Diffusion Browse Table

Event Timeline

hskiba created this task.Jul 9 2017, 5:41 AM

This is fixed in D18189.

chad added a revision: D18189: Simplify Diffusion Browse Table.Jul 9 2017, 12:39 PM

chad added a revision: D18190: Fix comparison check for SVN in browsing Diffusion.Jul 9 2017, 1:43 PM

chad closed this task as Resolved by committing rP0b3117bb684e: Fix comparison check for SVN in browsing Diffusion.Jul 9 2017, 1:43 PM

chad added a commit: rP0b3117bb684e: Fix comparison check for SVN in browsing Diffusion.

I pushed this to HEAD of master, we'll cherry-pick it shortly to stable.

Awesome.. Thanks!

chad added a commit: rP39e5da7ea700: Simplify Diffusion Browse Table.Jul 9 2017, 4:44 PM

chad added a commit: rP3480b3e7ef00: (stable) Fix comparison check for SVN in browsing Diffusion.Jul 10 2017, 1:53 PM