Page MenuHomePhabricator
Feed Advanced Search

Mar 1 2017

epriestley closed T12336: 233 as Invalid.
Mar 1 2017, 1:43 PM · Maniphest, Feature Request
epriestley closed T12336: 233, a subtask of T12335: Ability to lock a task to prevent further edits, as Invalid.
Mar 1 2017, 1:43 PM · Maniphest, Feature Request
epriestley added a comment to T12335: Ability to lock a task to prevent further edits.

I have a few questions about this, and some ideas for how we could solve it:

Mar 1 2017, 1:43 PM · Maniphest, Feature Request
epriestley added a comment to T12237: Amazon SES has suspended outbound mail from secure.phabricator.com.

Earlier, I predicted:

Mar 1 2017, 12:56 PM · Mail, Phacility, Ops
epriestley added a comment to T12333: Arc diff is not creating a new revision when creating a new topic branch off a topic branch with already a revision associated.

I mean doesn't Arcanist track this?

Mar 1 2017, 12:39 AM · Bug Report
epriestley added a comment to T12235: Differential wrongly says I "Must Review" reviews rejected by group.

D17425 doesn't change my thinking here.

Mar 1 2017, 12:33 AM · Differential, Bug Report

Feb 28 2017

epriestley added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

Go ahead and file something separate for that, I don't think it interacts here.

Feb 28 2017, 9:03 PM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a comment to T12330: Subprojects link not grayed out in dark background of project workboards..

Go for it.

Feb 28 2017, 8:49 PM · Workboards, Projects, Bug Report
epriestley added a comment to T12333: Arc diff is not creating a new revision when creating a new topic branch off a topic branch with already a revision associated.

The description of the "git:branch-unique(...)" rule in the "Arcanist Commit Ranges" document may be helpful in understanding why this is hard, or at least hard enough for me that I was unsuccessful in producing a "do the right thing" or "do what users expect" behavior when I tried and we ended up with "base" instead:

Feb 28 2017, 8:12 PM · Bug Report
epriestley added a comment to T12333: Arc diff is not creating a new revision when creating a new topic branch off a topic branch with already a revision associated.

Maybe a better path forward is this:

Feb 28 2017, 7:51 PM · Bug Report
epriestley added a comment to T12333: Arc diff is not creating a new revision when creating a new topic branch off a topic branch with already a revision associated.

Also, how do you expect to arc to distinguish between these two use cases, each of which some users prefer?

Feb 28 2017, 7:37 PM · Bug Report
epriestley added a comment to T12332: Arc diff doesn't pick the right base commit and creates a new revision by mistake when working topic branch with merges .

The general "why of the why" is that if "git push = publish" is a valid assumption, and users "git push" a series of changes, they expect corresponding revisions to close -- even if they've rebased, amended, etc., those changes. We try very hard to find revisions to close when we discover new commits to meet that expectation.

Feb 28 2017, 7:35 PM · Bug Report
epriestley added a comment to T12333: Arc diff is not creating a new revision when creating a new topic branch off a topic branch with already a revision associated.

Arcanist understands this is a new topic branch which no associated revision yet,

Feb 28 2017, 7:31 PM · Bug Report
epriestley added a comment to T12332: Arc diff doesn't pick the right base commit and creates a new revision by mistake when working topic branch with merges .

By default, Phabricator assumes that git push means "publish", and that it is ONLY used to publish the final version of complete, reviewed changes. If you haven't already seen it, this post describes this in more detail:

Feb 28 2017, 7:30 PM · Bug Report
epriestley added a comment to T10319: Generate unique? profile images for each new user.

I think you can use imagecolorallocatealpha($img, $r, $g, $b, $a) to do it for you. Note that alpha is 0-255, not 0-1.

Feb 28 2017, 7:23 PM · Feature Request, People
epriestley added a comment to T12321: Create Task form not Editable..

Here's what I just did on a new Phacility instance:

Feb 28 2017, 7:07 PM · Bug Report
epriestley renamed T12314: Support formal task subtypes (like "bug" vs "feature") from Multilevel custom fields to Support formal task subtypes (like "bug" vs "feature").
Feb 28 2017, 6:59 PM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

Great, thanks! I haven't come up with any other major concerns myself after considering this for a couple of days, and expect to move forward shortly.

Feb 28 2017, 6:58 PM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a comment to T12333: Arc diff is not creating a new revision when creating a new topic branch off a topic branch with already a revision associated.

Or maybe a simpler question is: when you run arc diff without arguments, what is the complete algorithm you want arc to follow to figure out which commit range you intend to send for review?

Feb 28 2017, 6:55 PM · Bug Report
epriestley added a comment to T12332: Arc diff doesn't pick the right base commit and creates a new revision by mistake when working topic branch with merges .

Is this behavior clear after finding "Explain Why"? Which parts remain unclear?

Feb 28 2017, 6:50 PM · Bug Report
epriestley added a comment to T12333: Arc diff is not creating a new revision when creating a new topic branch off a topic branch with already a revision associated.

Based on the output, what do you believe arc is doing? What do you think it should do instead? Which part of the behavior do you believe to be a bug?

Feb 28 2017, 6:48 PM · Bug Report
epriestley closed T12331: Taskmasters on `admin.phacility.com` are not scaling up correctly as Resolved.

I've deployed everything so I believe this is now resolved. I'll keep an eye on it going forward.

Feb 28 2017, 4:37 PM · Daemons, Ops, Phacility
epriestley added a comment to T12331: Taskmasters on `admin.phacility.com` are not scaling up correctly.

The pool appears to be scaling up and down properly now. I'm going to deploy the fix to the secure and repo tiers since it may affect all instances.

Feb 28 2017, 4:21 PM · Daemons, Ops, Phacility
epriestley added a comment to T12331: Taskmasters on `admin.phacility.com` are not scaling up correctly.

I'm picking D17433 now and sending it to admin.

Feb 28 2017, 4:14 PM · Daemons, Ops, Phacility
epriestley added a revision to T12331: Taskmasters on `admin.phacility.com` are not scaling up correctly: Unknown Object (Differential Revision).
Feb 28 2017, 4:10 PM · Daemons, Ops, Phacility
epriestley added a comment to T12331: Taskmasters on `admin.phacility.com` are not scaling up correctly.

I'm picking those to stable and sending them to production now.

Feb 28 2017, 3:43 PM · Daemons, Ops, Phacility
epriestley added a revision to T12331: Taskmasters on `admin.phacility.com` are not scaling up correctly: Unknown Object (Differential Revision).
Feb 28 2017, 3:37 PM · Daemons, Ops, Phacility
epriestley added a revision to T12331: Taskmasters on `admin.phacility.com` are not scaling up correctly: Unknown Object (Differential Revision).
Feb 28 2017, 3:31 PM · Daemons, Ops, Phacility
epriestley added a comment to T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud).
  • The SQL templating should define some new variable like {$FULLTEXT_ENGINE} which evaluates to the appropriate engine at runtime.
  • The Quickstart SQL generator should replace the raw engine string output by the build + dump process with this variable in the affected tables. This piece will be a little hacky, but I think that's unavoidable.
  • The Quickstart SQL should be regenerated.
Feb 28 2017, 1:11 PM
epriestley created T12331: Taskmasters on `admin.phacility.com` are not scaling up correctly.
Feb 28 2017, 12:06 PM · Daemons, Ops, Phacility
epriestley added a comment to T12328: "Watching Projects" doc section seems wrong.

I believe the semantics are consistent, but let me know if I'm misunderstanding or you're seeing something different:

Feb 28 2017, 2:36 AM · Restricted Project, Documentation, Bug Report
epriestley added a comment to T10319: Generate unique? profile images for each new user.

crc32 would be fine in this use case too since the requirements are so lax. My version isn't particularly robust either, but should get the job done.

Feb 28 2017, 2:16 AM · Feature Request, People
epriestley added a comment to T10319: Generate unique? profile images for each new user.
diff --git a/src/infrastructure/util/PhabricatorHash.php b/src/infrastructure/util/PhabricatorHash.php
index 00d7cca63c..5dfbbe2617 100644
--- a/src/infrastructure/util/PhabricatorHash.php
+++ b/src/infrastructure/util/PhabricatorHash.php
@@ -78,6 +78,22 @@ final class PhabricatorHash extends Phobject {
     return $result;
   }
Feb 28 2017, 1:08 AM · Feature Request, People
epriestley merged T12327: ArcanistPuppetLintLinter doesn't work with puppet-lint 2.1.0 or later into T10038: Plan the mid-term pathway for unit-test/linter bindings.
Feb 28 2017, 12:06 AM · Lint, Arcanist
epriestley merged task T12327: ArcanistPuppetLintLinter doesn't work with puppet-lint 2.1.0 or later into T10038: Plan the mid-term pathway for unit-test/linter bindings.
Feb 28 2017, 12:06 AM · Bug Report

Feb 27 2017

epriestley added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

And the pencil icon on workboards, the pencil icon on the list view, and the "Edit Task" action from task detail pages would default to "Edit Plant Task", yeah. The workboard change would only pertain to creating new tasks directly on a workboard.

Feb 27 2017, 11:38 PM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley added a comment to T12314: Support formal task subtypes (like "bug" vs "feature").

Right now, this menu always says "Create Task..."

Feb 27 2017, 11:37 PM · EditEngine, Maniphest, Custom Fields, Feature Request
epriestley removed reviewers for D17414: Test: Blessed Reviewers, • dbansal-snk.
Feb 27 2017, 10:14 PM
epriestley closed T12319: Investigate an Owners-related performance issue on revision detail pages as Resolved.

Calling this resolved since the page is now tolerably bad (~5s) which more or less pulls this out of the realm of critical scaling issues.

Feb 27 2017, 9:46 PM · Owners, Differential, Performance
epriestley renamed T12325: Dynamically adjust the display precision of countdowns to increase dramatic tension from Allow to control units shown in countdowns to Dynamically adjust the display precision of countdowns to increase dramatic tension.
Feb 27 2017, 9:28 PM · Customer Impact, Countdown, Feature Request
epriestley added a revision to T12319: Investigate an Owners-related performance issue on revision detail pages: Unknown Object (Differential Revision).
Feb 27 2017, 8:11 PM · Owners, Differential, Performance
epriestley added a comment to T12325: Dynamically adjust the display precision of countdowns to increase dramatic tension.
  • If the date is a day or more in the future, show days + hours + minutes.
    • If the date is an hour or more in the future, show hours + minutes + seconds.
    • Otherwise, show minutes + seconds with THRILLING TENTHS OF A SECOND.
Feb 27 2017, 8:05 PM · Customer Impact, Countdown, Feature Request
epriestley added a member for Community: jmeador.
Feb 27 2017, 7:27 PM
epriestley closed T12323: Revisions show in Other Revisions when acceptance status is unclear as Resolved by committing Restricted Diffusion Commit.
Feb 27 2017, 6:47 PM · KDE, Differential, Bug Report
epriestley closed T12322: Support "tagged(...)" in Repository tokenizer for commit searches in Audit as Resolved by committing Restricted Diffusion Commit.
Feb 27 2017, 6:47 PM · Audit, KDE
epriestley closed T12316: Phacility Deploy Log 2017 Week 8, a subtask of T12217: Reduce the hardware cost of Phacility free instances, as Resolved.
Feb 27 2017, 6:46 PM · Ops, Phacility
epriestley closed T12316: Phacility Deploy Log 2017 Week 8 as Resolved.
Feb 27 2017, 6:46 PM · Phacility, Ops
epriestley closed T12321: Create Task form not Editable. as Invalid.

This does not describe a bug in Phabricator. I've reviewed the documentation and believe it is already sufficiently clear in describing how to accomplish what you're trying to accomplish. Particularly, I don't see anything in the documentation which is misleading, or suggests that the workflow you're using is the correct way to accomplish your goal -- it isn't, and the documentation describes the correct workflow. See Support Resources for other support resources.

Feb 27 2017, 6:45 PM · Bug Report
epriestley added a revision to T12322: Support "tagged(...)" in Repository tokenizer for commit searches in Audit: Unknown Object (Differential Revision).
Feb 27 2017, 6:35 PM · Audit, KDE
epriestley added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

(They could also go into the existing "Waiting on Review" bucket, but I dislike mixing authored and non-authored revisions in that bucket.)

Feb 27 2017, 6:18 PM · KDE, Differential, Bug Report
epriestley added a revision to T12323: Revisions show in Other Revisions when acceptance status is unclear: Unknown Object (Differential Revision).
Feb 27 2017, 6:17 PM · KDE, Differential, Bug Report
epriestley added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

The actual reproduction instructions are slightly more involved:

Feb 27 2017, 6:14 PM · KDE, Differential, Bug Report
20after4 awarded T12322: Support "tagged(...)" in Repository tokenizer for commit searches in Audit a Love token.
Feb 27 2017, 5:30 PM · Audit, KDE
epriestley added a comment to T12319: Investigate an Owners-related performance issue on revision detail pages.

@jmeador, I believe this is now resolved at HEAD. Let us know if you're still seeing issues after upgrading?

Feb 27 2017, 5:13 PM · Owners, Differential, Performance
epriestley added a comment to T12270: Unbeta Badges.

After D17422, I used bin/lipsum to generate about 20,000 badges. (They all have USERS permission so the permission checks are about as fast as possible.)

Feb 27 2017, 4:10 PM · Badges (v0)
epriestley added a revision to T12319: Investigate an Owners-related performance issue on revision detail pages: Unknown Object (Differential Revision).
Feb 27 2017, 4:05 PM · Owners, Differential, Performance
epriestley added a comment to T12319: Investigate an Owners-related performance issue on revision detail pages.

After implementing PHP7 support for XHProf and updating Lipsum, I used bin/lipsum to generate 4,000 packages owning 150,000 paths. I think I have an approximately-reasonable reproduction case locally now, which generates this profile (6.5s for a change affecting about 100 files):

Feb 27 2017, 3:47 PM · Owners, Differential, Performance
epriestley added a revision to T12319: Investigate an Owners-related performance issue on revision detail pages: Unknown Object (Differential Revision).
Feb 27 2017, 3:39 PM · Owners, Differential, Performance
epriestley added a comment to T12218: Reduce the operational cost of a larger Phacility cluster.

I did the last deploy (T12316) with Phage again and things went much more smoothly after the various bugfixes and improvements.

Feb 27 2017, 3:10 PM · Ops, Phacility
epriestley added a comment to T5508: Add branch name parameter to Harbormaster "Make HTTP Request" build step.

See Planning for information on timelines and priorities.

Feb 27 2017, 2:25 PM · Restricted Project, Harbormaster
epriestley added a revision to T12270: Unbeta Badges: Unknown Object (Differential Revision).
Feb 27 2017, 1:18 PM · Badges (v0)
epriestley added a revision to T12319: Investigate an Owners-related performance issue on revision detail pages: Unknown Object (Differential Revision).
Feb 27 2017, 1:18 PM · Owners, Differential, Performance
epriestley added a revision to T12319: Investigate an Owners-related performance issue on revision detail pages: Unknown Object (Differential Revision).
Feb 27 2017, 1:14 PM · Owners, Differential, Performance
epriestley added a revision to T12319: Investigate an Owners-related performance issue on revision detail pages: Unknown Object (Differential Revision).
Feb 27 2017, 12:20 PM · Owners, Differential, Performance
epriestley added a revision to T12319: Investigate an Owners-related performance issue on revision detail pages: Unknown Object (Differential Revision).
Feb 27 2017, 12:06 PM · Owners, Differential, Performance
siepkes awarded T550: Build an SSH conduit client a Like token.
Feb 27 2017, 8:08 AM · Prioritized, Arcanist, Restricted Project, Restricted Project, Conduit

Feb 26 2017

epriestley added a comment to T9805: XHProf will not build on PHP7.

I have a build of this that technically works now (produces profiles, passes tests, does not segfault when gently poked). It's still extremely really rough so I don't know when I'll clean it up enough to push upstream.

Feb 26 2017, 11:45 PM · XHProf
epriestley added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

@bcooksley, feel free to mention that you've talked with me about stuff when filing tasks in the future. Like 90% of what shows up here spontaneously is pretty questionable, so unannounced reports get fairly strict scrutiny.

Feb 26 2017, 11:00 PM · KDE, Differential, Bug Report
epriestley added a project to T12323: Revisions show in Other Revisions when acceptance status is unclear: KDE.

Here's the downstream task: https://phabricator.kde.org/T5406

Feb 26 2017, 10:58 PM · KDE, Differential, Bug Report
epriestley added a comment to T12323: Revisions show in Other Revisions when acceptance status is unclear.

Note that these steps depend on who is viewing the page (or, specifically, who "Responsible Users" are). More concise steps are likely:

Feb 26 2017, 10:58 PM · KDE, Differential, Bug Report
epriestley created T12322: Support "tagged(...)" in Repository tokenizer for commit searches in Audit.
Feb 26 2017, 8:23 PM · Audit, KDE
epriestley added a comment to T10319: Generate unique? profile images for each new user.

It looks like we currently allow usernames to begin with _, ., and - (PhabricatorUser->validateUsername()), but maybe just do a ? for anything-except-numbers-and-letters?

Feb 26 2017, 6:51 PM · Feature Request, People
epriestley added a comment to T12321: Create Task form not Editable..

Have you tried using Lock/Hide Fields to hide the "Status" field?

Feb 26 2017, 6:33 PM · Bug Report
epriestley added a comment to T12321: Create Task form not Editable..

What's an example of a specific change you're trying to make which you aren't able to figure out how to make?

Feb 26 2017, 6:21 PM · Bug Report
epriestley added a comment to T10319: Generate unique? profile images for each new user.

We can draw letters in GD, but I suspect they won't look very good compared to letters from Photoshop (bad antialiasing, limited font choices, weird alignment/kerning issues), so I'd guess it's not worth bothering and we might as well just jump straight to using generated images like Projects.

Feb 26 2017, 5:58 PM · Feature Request, People
epriestley closed T12320: Create Task form not Editable. as Invalid.

You are running an out-of-date version of Phabricator, from February 17th.

Feb 26 2017, 5:16 PM · Bug Report
epriestley added a comment to T12320: Create Task form not Editable..

Please provide version information for your install. See Providing Version Information.

Feb 26 2017, 5:05 PM · Bug Report
epriestley updated subscribers of T12319: Investigate an Owners-related performance issue on revision detail pages.
Feb 26 2017, 3:29 PM · Owners, Differential, Performance
epriestley created T12319: Investigate an Owners-related performance issue on revision detail pages.
Feb 26 2017, 3:29 PM · Owners, Differential, Performance
epriestley added a comment to T12318: Loading Symbols in Phacility (Conduit).

I think this (and lint/coverage) should move to Conduit, yeah.

Feb 26 2017, 3:26 PM · Customer Impact, Symbols, Feature Request
gabe awarded T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads a Like token.
Feb 26 2017, 4:55 AM · Mercurial, Arcanist
epriestley added a comment to T12296: Improve Phacility repository import performance.

(That said, my expectation is that behaviors around unreachable commits have not changed -- D17279 added the "Unreachable" option to solve this problem.)

Feb 26 2017, 4:43 AM · Customer Impact, Diffusion, Ops
epriestley added a comment to T12296: Improve Phacility repository import performance.

Likely somewhere in T9430 / T10978, which rewrote a big chunk of the audit code.

Feb 26 2017, 4:42 AM · Customer Impact, Diffusion, Ops
epriestley added a comment to T12296: Improve Phacility repository import performance.

If you don't want to see unreachable commits, use a query which hides them:

Feb 26 2017, 4:32 AM · Customer Impact, Diffusion, Ops
epriestley added a comment to T12296: Improve Phacility repository import performance.

It is expected that some deleted commits will import and others will not.

Feb 26 2017, 4:05 AM · Customer Impact, Diffusion, Ops
epriestley closed T12317: PhabricatorTriggerDaemon shows as "Waiting" but there are no errors as Resolved.

See T12298#213181.

Feb 26 2017, 4:01 AM · Bug Report
CodeMouse92 awarded T10350: Scripts to migrate old "points" fields and move projects beneath other projects a Mountain of Wealth token.
Feb 26 2017, 1:49 AM · Projects (v3)

Feb 25 2017

epriestley added a comment to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.

Total cost is about 1.6s. Of this:

Feb 25 2017, 4:09 PM · XHProf, Ops, Phacility
epriestley added a comment to T12297: Make Conduit API calls on `admin.phacility.com` reasonably easy to profile.

This is still a little bit of a pain but far more reasonable now, here's an actual profile:

Feb 25 2017, 4:03 PM · XHProf, Ops, Phacility
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I cycled the rest of the tier and things look better now.

Feb 25 2017, 4:00 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

After manually deploying that to repo001, I'm now seeing a consistent Taskmaster/PullLocal count. I'm redeploying the rest of the repo hosts.

Feb 25 2017, 3:05 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I think the issue is that the --reserve flag for reserving system memory now applies to even the first daemon in a pool, because all daemons are now part of pools. Previously, it only applied only to the 2nd..Nth daemon.

Feb 25 2017, 3:02 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

Some taskmasters failed to start on repo001 and perhaps elsewhere.

Feb 25 2017, 2:46 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I suspended and destroyed the largest instance on the shard, a free instance with one user and no logins for >30 days (the user appears to have imported a huge repository and then never logged back in). We still have backups, but this instance was way over reasonable resource use anyway. The volume is now 78% full.

Feb 25 2017, 2:45 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I pruned some very old backups (backup pruning is currently very conservative in several cases). The volume is now 72% full. This could easily be reduced much further by allowing bin/host prune to remove backups older than 90 days for suspended/terminated instances that have been out of service for 90 days, but backup utilization is generally relatively stable so I'm not concerned about this.

Feb 25 2017, 2:26 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I synchronized services for this shard and destroyed old instances. The volume is now 68% full.

Feb 25 2017, 2:13 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

I synchronized services for this shard and destroyed old instances. The volume is now 44% full.

Feb 25 2017, 1:44 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

This was a bunch of repository file data in /tmp. Each file was unique, so this doesn't look like any sort of buggy loop or anything. There's some actual bug here but since there's a long list of other issues here I just "fixed" this by clearing /tmp.

Feb 25 2017, 1:08 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

Some reserved instances ended on Feb 19th; I should make sure reserved instances match production instances.

Feb 25 2017, 1:02 PM · Phacility, Ops
epriestley added a comment to T12316: Phacility Deploy Log 2017 Week 8.

Shards 017 through 020 are now in production.

Feb 25 2017, 12:57 PM · Phacility, Ops