Page MenuHomePhabricator
Feed Advanced Search

Nov 10 2016

epriestley created T11845: Media with "autoplay" should possibly not autoplay in news feed.
Nov 10 2016, 7:48 PM · Prioritized, Remarkup
epriestley added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.
Nov 10 2016, 7:47 PM · Quicksand, Bug Report
epriestley added a project to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled: Quicksand.

Welcome to the wonderful, spooky world of Quicksand.

Nov 10 2016, 7:41 PM · Quicksand, Bug Report
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

We still do a pretty questionable job on the first case in T7643#180264, where a comma is removed from the middle of a sentence.

Nov 10 2016, 7:36 PM · Prioritized, Transactions
epriestley added a comment to T11843: Hitting "show older changes" throws an exception on DifferentialTransactionView::setLeftDiff() with Quicksand enabled.

Do you have the persistent chat pane open?

Nov 10 2016, 7:22 PM · Quicksand, Bug Report
20after4 awarded Blog Post: Encouraging Open Source Etiquette a Love token.
Nov 10 2016, 6:42 PM
epriestley added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

Would you fill out at least, like, 5 of them?

Nov 10 2016, 6:21 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

Yeah, I think it's pretty reasonable if people would actually fill it out. We could surface it in a few other places too (e.g., /projects/) without fallback. It just seems like there's a decent chance no one will ever fill it out and it will sort of just be cluttering up the UI. But the cost on our side is pretty small, so if some people claim that they'd probably want to fill it out I'm happy to move forward with it.

Nov 10 2016, 6:18 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley moved T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier from The Queue to Paused on the Prioritized board.

For reference, here's the current state of "discovery" downstream:

Nov 10 2016, 5:49 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley claimed T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.
Nov 10 2016, 5:13 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley removed a project from T9379: Build Phriction v3: Prioritized.

I'm going to kick this out of the queue for now and we'll reconsider it alongside other internal priorities once the queue clears. I think it's probably secondary to Conpherence now, at least, product-roadmap-wise, maybe?

Nov 10 2016, 5:12 PM · Phriction
epriestley removed a project from T9303: Improve Phacility Onboarding/NUX: Prioritized.

I'm going to kick this out of the queue for now and we can re-evaluate our internal priorities once the queue clears -- we got a decent iteration out and it looks like the next steps on NUX are probably a fair chunk of work.

Nov 10 2016, 5:10 PM · Phacility
epriestley removed a project from T7789: Support Git Large File Storage: Prioritized.

The driving install dropped off the grid a while ago, so this is no longer prioritized.

Nov 10 2016, 5:09 PM · Customer Impact, Restricted Project, Files, Diffusion
epriestley moved T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches from The Queue to Paused on the Prioritized board.

I believe this is now resolved, in the sense that I expect all specific, reproducible examples I'm aware of function in a way consistent with user expectation. In particular:

Nov 10 2016, 5:06 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley closed T11839: Invalid translation for diffusion.uri.edit display as Resolved by committing Restricted Diffusion Commit.
Nov 10 2016, 4:55 PM · Bug Report
epriestley added a revision to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches: Unknown Object (Differential Revision).
Nov 10 2016, 4:37 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a comment to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.

I have some possible approaches for cheating on the "more than 100 results" case, but I think we ultimately need to put the prefix paging rule on the server side, so we return all prefix matches and then all content matches. That's kind of a big mess, but all the ways we can cheat will break down at some point (e.g., when you have 100 "wikidata" projects that are alphabetically earlier than "wikidata") so I think it's not avoidable.

Nov 10 2016, 2:58 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a comment to T4190: Rebuild remarkup image proxying.
  • Prototype applications must be enabled.
  • security.outbound-blacklist must not blacklist the target server (build servers may be on an internal network and on the default blacklist).
  • The link protocol must be "http" or "https".
  • You must not have exceeded your fetch quota for the last hour.
  • You must have file storage configured.
  • The image MIME type must be part of files.image-mime-types and files.viewable-mime-types.
  • The Phabricator server must be able to make outbound requests on the network.
Nov 10 2016, 2:57 PM · Contributor Onboarding, Remarkup
epriestley added a comment to T4190: Rebuild remarkup image proxying.
{img https://static-cdn.jtvnw.net/jtv_user_pictures/doritos-profile_image-4328d01909178d94-300x300.png}
Nov 10 2016, 2:51 PM · Contributor Onboarding, Remarkup
epriestley moved T5267: Localize Phabricator from The Queue to Paused on the Prioritized board.

Pausing this from our perspective since we're waiting on guidance to move forward.

Nov 10 2016, 2:39 PM · Prioritized, Localization
epriestley added a parent task for T11050: Allow resigning from a review you are not directly responsible for: T10967: Move Differential reviewers back to a dedicated database storage table.
Nov 10 2016, 2:34 PM · Prioritized, Restricted Project, Differential, Feature Request
epriestley added a subtask for T10967: Move Differential reviewers back to a dedicated database storage table: T11050: Allow resigning from a review you are not directly responsible for.
Nov 10 2016, 2:34 PM · Restricted Project, Infrastructure, Differential
epriestley closed T11752: Drydock worker tasks should have higher priority as Resolved.

Presuming this is resolved since it hasn't been updated in about a month, but let us know if it's still an issue after the update.

Nov 10 2016, 2:33 PM · Drydock
epriestley claimed T11839: Invalid translation for diffusion.uri.edit display.

D16837 should clean this up. Thanks for the thorough report!

Nov 10 2016, 2:21 PM · Bug Report
epriestley added a revision to T11839: Invalid translation for diffusion.uri.edit display: Unknown Object (Differential Revision).
Nov 10 2016, 2:21 PM · Bug Report
epriestley added a comment to T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.

Some discussion of current context in T10448#186240.

Nov 10 2016, 2:18 PM · Customer Impact, Restricted Project, Mail
epriestley merged T11842: Create notification option for "someone mentions me" into T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.
Nov 10 2016, 2:16 PM · Customer Impact, Restricted Project, Mail
epriestley merged task T11842: Create notification option for "someone mentions me" into T4654: Add 'always email me' type option for direct mentions, ccs, assignments, etc.
Nov 10 2016, 2:16 PM
epriestley added a comment to T7577: Improve username mention rules for Conpherence.

Oh, no, T7579 / T7580 are very slightly different. These probably do need updates at some point but I'll leave 'em for now

Nov 10 2016, 2:14 PM · Conpherence (v4)
epriestley added a comment to T7577: Improve username mention rules for Conpherence.

I'm going to merge this into T7580 since I think that's the same task?

Nov 10 2016, 2:13 PM · Conpherence (v4)
epriestley added a comment to T8345: Add task tabs for "Mentions" and "Merged".

I added "Mentions" (and "Mocks") recently in connection with T4788.

Nov 10 2016, 2:10 PM · Restricted Project, FreeBSD, Maniphest
constantx awarded T8442: Build Space switching UI a Love token.
Nov 10 2016, 4:49 AM · Restricted Project, Spaces, Wikimedia, Policy
epriestley closed T11829: Fix all the circles as Resolved by committing Restricted Diffusion Commit.
Nov 10 2016, 1:13 AM · Design
epriestley added a revision to T11829: Fix all the circles: Unknown Object (Differential Revision).
Nov 10 2016, 1:11 AM · Design
epriestley added a comment to T11835: Diffs/Patches should optionally not be generated for generated files until the item is expanded..

This is sort-of-maybe related to T11482 but I'm also not exactly sure what's step in the process is slow here.

Nov 10 2016, 12:59 AM · Diffusion, Feature Request
epriestley closed T11833: "parent"/"child" relationship for Revisions is confusing as Wontfix.

I'm happy to change this if anyone comes up with good alternate wording, but I think this might be about the best we can do.

Nov 10 2016, 12:55 AM · Differential, Bug Report
epriestley added a comment to T11831: Add setup check for missing PCRE_UTF8 support.

never mind I love the text area

Nov 10 2016, 12:54 AM · Setup
epriestley added a comment to E1209: Pull that into png.

Yeah, the upper-right action thing is a little weird since we don't use it in other applications, but it has felt OK to me once I kind of got used to it / continued being too lazy to change it.

Nov 10 2016, 12:53 AM
epriestley changed the icon for E1209: Pull that into png from Default to Party.
Nov 10 2016, 12:51 AM
epriestley added a comment to E1209: Pull that into png.

Wouldn't miss it for the world!

Nov 10 2016, 12:50 AM
epriestley is attending E1209: Pull that into png.
Nov 10 2016, 12:50 AM
epriestley triaged T11831: Add setup check for missing PCRE_UTF8 support as Wishlist priority.

This is probably the required test:

Nov 10 2016, 12:47 AM · Setup

Nov 9 2016

epriestley closed T11836: Calendar Imports have the correct policy, but that policy is unclear, a subtask of T11809: Calendar v1 Errata Mark II, as Resolved.
Nov 9 2016, 11:05 PM · Calendar
epriestley closed T11836: Calendar Imports have the correct policy, but that policy is unclear as Resolved by committing Restricted Diffusion Commit.
Nov 9 2016, 11:05 PM · Calendar
epriestley added a parent task for T11836: Calendar Imports have the correct policy, but that policy is unclear: T11809: Calendar v1 Errata Mark II.
Nov 9 2016, 8:24 PM · Calendar
epriestley added a subtask for T11809: Calendar v1 Errata Mark II: T11836: Calendar Imports have the correct policy, but that policy is unclear.
Nov 9 2016, 8:24 PM · Calendar
epriestley edited projects for T11836: Calendar Imports have the correct policy, but that policy is unclear, added: Calendar; removed Bug Report.
Nov 9 2016, 8:24 PM · Calendar
epriestley added a revision to T11836: Calendar Imports have the correct policy, but that policy is unclear: Unknown Object (Differential Revision).
Nov 9 2016, 8:17 PM · Calendar
epriestley renamed T11836: Calendar Imports have the correct policy, but that policy is unclear from Calendar Imports have the wrong policy set to Calendar Imports have the correct policy, but that policy is unclear.
Nov 9 2016, 5:39 PM · Calendar

Nov 8 2016

epriestley added a comment to T11836: Calendar Imports have the correct policy, but that policy is unclear.

The policies work like you expect them to. This is just like a revision saying "All Users" but not being visible to users who can't see the corresponding repository.

Nov 8 2016, 10:19 PM · Calendar
epriestley closed T11834: PhabricatorGuideQuickStartModule duplicates quickstart entries in cluster mode as Resolved by committing Restricted Diffusion Commit.
Nov 8 2016, 9:27 PM · Clusters, NUX, Phacility, Bug Report
epriestley added a revision to T11834: PhabricatorGuideQuickStartModule duplicates quickstart entries in cluster mode: Unknown Object (Differential Revision).
Nov 8 2016, 9:21 PM · Clusters, NUX, Phacility, Bug Report
epriestley claimed T11834: PhabricatorGuideQuickStartModule duplicates quickstart entries in cluster mode.

It's just very
important to
thoroughly explore
the applications

Nov 8 2016, 9:19 PM · Clusters, NUX, Phacility, Bug Report
epriestley added a comment to T11833: "parent"/"child" relationship for Revisions is confusing.

(If we were better about figuring this out automatically -- which we may be soon -- would it be a problem at all?)

Nov 8 2016, 7:55 PM · Differential, Bug Report
epriestley added a comment to T11833: "parent"/"child" relationship for Revisions is confusing.

The distinction between "Earlier Revisions" and "Earlier Versions of This Revision" (e.g., earlier diffs) seems potentially confusing to me. That is, I could imagine a new user thinking "Earlier Revisions" meant "earlier versions of this change", not "prior changes which this change depends on".

Nov 8 2016, 7:51 PM · Differential, Bug Report
epriestley added a comment to T11833: "parent"/"child" relationship for Revisions is confusing.

Or, of course, we could do:

Nov 8 2016, 7:49 PM · Differential, Bug Report
epriestley added a comment to T11833: "parent"/"child" relationship for Revisions is confusing.

I think there was no web UI for this until T4788, which added both options. Prior to that, the only way to mark dependencies was by writing "Depends On" in text (which still works). So we didn't previously have anything else, unless I'm misremembering.

Nov 8 2016, 7:47 PM · Differential, Bug Report
epriestley added a revision to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches: Unknown Object (Differential Revision).
Nov 8 2016, 7:40 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a comment to T11833: "parent"/"child" relationship for Revisions is confusing.

Our use of "parent" and "child" are consistent with Git's use of "parent" and "child", if that helps: for example, git help log discusses the ideas of "parent commits" and "child commits" in many places, and "parent revisions" and "child revisions" have the same relationship order as commits do in Git.

Nov 8 2016, 7:37 PM · Differential, Bug Report
epriestley added a comment to T11833: "parent"/"child" relationship for Revisions is confusing.

What specific, totally unambiguous labels would you prefer these actions to have?

Nov 8 2016, 7:33 PM · Differential, Bug Report
epriestley added a comment to T5267: Localize Phabricator.

Sounds good, thanks!

Nov 8 2016, 5:42 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
Nov 8 2016, 4:43 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
Nov 8 2016, 4:43 PM · Prioritized, Localization
epriestley added a comment to T5267: Localize Phabricator.

%s cannot be repeated as far as I know.

Nov 8 2016, 4:32 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
Nov 8 2016, 4:16 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
Nov 8 2016, 3:31 PM · Prioritized, Localization
epriestley added a comment to T5267: Localize Phabricator.
"aBmeIEk": {
    "one": "%s star",
    "other": "%s stars"
},
Nov 8 2016, 3:22 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
Nov 8 2016, 2:50 PM · Prioritized, Localization
epriestley added a comment to T5267: Localize Phabricator.

Here are the current internal data formats:

Nov 8 2016, 2:21 PM · Prioritized, Localization
epriestley added a comment to T5267: Localize Phabricator.

Variables such as $1 are not part of the spec, and it makes no difference to us if you use %s instead. So unless this conversion is required by your system, you can drop it.

Nov 8 2016, 1:58 PM · Prioritized, Localization
epriestley closed T11830: ddz_test as Invalid.
Nov 8 2016, 12:22 PM
epriestley closed T11832: jkh as Invalid.
Nov 8 2016, 12:22 PM · Android
epriestley added a comment to T11801: Calendar: ICS Import Errata.

large.jpg (408×500 px, 26 KB)

Nov 8 2016, 1:51 AM · Bug Report, Calendar
epriestley added a comment to T11801: Calendar: ICS Import Errata.

Here's the XHProf link:

Nov 8 2016, 1:50 AM · Bug Report, Calendar

Nov 7 2016

epriestley triaged T11823: Split RefCursor into a "name" table and a "ref" table so ref names have stable PHIDs as Wishlist priority.

This self-healed (probably after another commit was pushed) so I don't expect to look at it for a while unless it happens again.

Nov 7 2016, 11:45 PM · Customer Impact, Diffusion, Bug Report
epriestley updated the task description for T7643: Improve prose diffs (was: description changes don't generate usable diffs).
Nov 7 2016, 11:09 PM · Prioritized, Transactions
epriestley created E1202: Advanced Pup Duty.
Nov 7 2016, 10:53 PM
epriestley changed the end date for E1201: On Pup Duty from Nov 7 2016, 11:00 PM to Nov 7 2016, 10:30 PM.
Nov 7 2016, 10:46 PM
epriestley added a comment to T11829: Fix all the circles.

• • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • • •
• Sorry, I've dropped my bag of Doritos™ brand perfect circles • • • • •
• • • • • • • • • • • • • • • • • • • • • • • • • •• • • •• • • • • • • •

Nov 7 2016, 10:46 PM · Design
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Unknown Object (Differential Revision).
Nov 7 2016, 10:44 PM · Prioritized, Transactions
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

The color should be fixed by D16819.

Nov 7 2016, 8:40 PM · Restricted Project, Calendar
epriestley added a comment to E1201: On Pup Duty.

So far the pup is sleeping a lot and doing very little mischief.

Nov 7 2016, 8:27 PM
epriestley added a revision to T11809: Calendar v1 Errata Mark II: Unknown Object (Differential Revision).
Nov 7 2016, 8:26 PM · Calendar
epriestley awarded E1201: On Pup Duty a Hungry Hippo token.
Nov 7 2016, 7:56 PM
chad awarded E1201: On Pup Duty a Hungry Hippo token.
Nov 7 2016, 7:56 PM
epriestley created E1201: On Pup Duty.
Nov 7 2016, 7:54 PM
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Unknown Object (Differential Revision).
Nov 7 2016, 7:39 PM · Prioritized, Transactions
epriestley added a revision to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Unknown Object (Differential Revision).
Nov 7 2016, 7:23 PM · Prioritized, Transactions
epriestley added a revision to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Unknown Object (Differential Revision).
Nov 7 2016, 7:08 PM · Prioritized, FreeBSD, User Delight, Wikimedia, Maniphest
epriestley added a comment to T11801: Calendar: ICS Import Errata.

At HEAD, I think the all-day issues with the French holidays above are fixed. You may need to reload the import for the change to take effect, but things seem OK for me locally now:

Nov 7 2016, 7:00 PM · Bug Report, Calendar
epriestley added a revision to T11801: Calendar: ICS Import Errata: Unknown Object (Differential Revision).
Nov 7 2016, 6:44 PM · Bug Report, Calendar
epriestley added a revision to T11801: Calendar: ICS Import Errata: Unknown Object (Differential Revision).
Nov 7 2016, 6:42 PM · Bug Report, Calendar
epriestley added a revision to T11801: Calendar: ICS Import Errata: Unknown Object (Differential Revision).
Nov 7 2016, 6:40 PM · Bug Report, Calendar
epriestley added a comment to T11801: Calendar: ICS Import Errata.

Ah, cool. I think that's a Zimbra issue, then.

Nov 7 2016, 5:40 PM · Bug Report, Calendar
epriestley added a comment to T11816: Calendar: Feedback and Suggestions.

@ivo, that's expected if you previously edited the Nov 8 instance. This is consistent with Calendar.app, although not with Google Calendar.

Nov 7 2016, 5:34 PM · Restricted Project, Calendar
epriestley added a revision to T11801: Calendar: ICS Import Errata: Unknown Object (Differential Revision).
Nov 7 2016, 5:25 PM · Bug Report, Calendar
epriestley added a comment to T11827: ssh-auth hangs on FreeBSD.

(mindrot.org is currently inaccessible for me so I wasn't able to read the details you linked, although I imagine they aren't too relevant to how we handle things.)

Nov 7 2016, 4:13 PM · Diffusion, Bug Report
epriestley added a comment to T11801: Calendar: ICS Import Errata.

I was trying to import the french holidays from google ICS file...

Nov 7 2016, 4:12 PM · Bug Report, Calendar
epriestley added a comment to T5267: Localize Phabricator.

The rTRANSLATEWIKI repository is now available. Here is an example of the en.json MediaWiki-style JSON string file we currently generate:

Nov 7 2016, 4:03 PM · Prioritized, Localization
epriestley merged T11828: LDAP username change does not update externalaccount table into T4279: Improve auth/LDAP import tools to assist in linking/merging accounts and migrations across providers.
Nov 7 2016, 3:08 PM · Auth