Page MenuHomePhabricator
Feed Advanced Search

Oct 6 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 6 2016, 7:52 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T11742: Payment due emails should contain a shortcut to adding a payment method.

I don't think we should change this.

Oct 6 2016, 7:19 PM · Phacility
epriestley added a comment to T11739: merge commit populated from phabricator fields shows "Summary" field tag in-line with its contents..

We'll accept this as a bug report if you describe the conditions which lead to a newline after "Summary:". The expected behavior is that there is no newline.

Oct 6 2016, 6:28 PM · Differential, Arcanist, Feature Request
epriestley closed T11737: can't return from "Show All Context" straight to "View Side-by-Side" for file diffs as Wontfix.

Oh, sorry, apparently @chad got this right then and I misunderstood.

Oct 6 2016, 6:25 PM · Bug Report (Needs Information), Differential
epriestley created T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud).
Oct 6 2016, 6:11 PM
epriestley edited projects for T11737: can't return from "Show All Context" straight to "View Side-by-Side" for file diffs, added: Bug Report (Needs Information); removed Feature Request.

Ah. From the workaround ("View Unified", then "View Side-by-Side") I'm guessing the menu maybe isn't refreshing properly somehow, but I'm not sure how to reproduce it given the provided steps.

Oct 6 2016, 6:02 PM · Bug Report (Needs Information), Differential
epriestley updated subscribers of T11737: can't return from "Show All Context" straight to "View Side-by-Side" for file diffs.

I can't immediately reproduce this -- were you able to, @chad?

Oct 6 2016, 5:57 PM · Bug Report (Needs Information), Differential
epriestley added a comment to T2920: Modularize the pipeline for producing final commit messages.

I merged T11740 and T11739 here since they're approximately the same problem from our perspective ("make messages adhere to project rules, where the project rules are immutable").

Oct 6 2016, 5:51 PM · Arcanist
epriestley merged task T11740: help limit summary fields to e.g. 80 chars wide into T2920: Modularize the pipeline for producing final commit messages.
Oct 6 2016, 5:48 PM · Differential, Feature Request
epriestley merged task T11739: merge commit populated from phabricator fields shows "Summary" field tag in-line with its contents. into T2920: Modularize the pipeline for producing final commit messages.
Oct 6 2016, 5:48 PM · Differential, Arcanist, Feature Request
epriestley merged tasks T11740: help limit summary fields to e.g. 80 chars wide, T11739: merge commit populated from phabricator fields shows "Summary" field tag in-line with its contents. into T2920: Modularize the pipeline for producing final commit messages.
Oct 6 2016, 5:48 PM · Arcanist
epriestley renamed T2920: Modularize the pipeline for producing final commit messages from Flatten remarkup back into commit messages on arc amend/land to Modularize the pipeline for producing final commit messages.
Oct 6 2016, 5:48 PM · Arcanist
epriestley renamed T11738: Improve the heuristic which guesses which function/method/class line best provides context for diff snippets from add function to diff context to Improve the heuristic which guesses which function/method/class line best provides context for diff snippets.
Oct 6 2016, 5:43 PM · Differential, Feature Request
epriestley triaged T11738: Improve the heuristic which guesses which function/method/class line best provides context for diff snippets as Wishlist priority.

We use a heuristic to guess which function, class, etc., the context is in. Git uses some similar heuristic.

Oct 6 2016, 5:42 PM · Differential, Feature Request
epriestley created T11735: Upgrading: Calendar Storage Migrations.
Oct 6 2016, 11:05 AM · Calendar
epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.

The code is a little better factored now and it's possible that the patch to DifferentialInlineCommentMailView is a pretty small one (and it may work in both text and HTML modes, as a possible benefit, although I suspect your install's use of HTML mail is much lower than most).

Oct 6 2016, 10:45 AM · Prioritized, Restricted Project, Differential, Mail
epriestley added a comment to T10694: Improve behavior of context for inline comments in mail.

@klimek Your install is the only install we're aware of that is interested in a rendering mode like that (feedback about the old rendering was generally negative; feedback about the new rendering has been generally positive). Unless we become aware of much wider interest in such a rendering mode, I don't plan to reintroduce it upstream.

Oct 6 2016, 10:35 AM · Prioritized, Restricted Project, Differential, Mail
Mr_Jones awarded T7125: Provide tooling to for periodic reminders (like renewing domains and update SSL certificates) a Like token.
Oct 6 2016, 8:46 AM · Calendar
epriestley created T11733: Calendar custom forms with modified start date / end date defaults don't work properly.
Oct 6 2016, 8:41 AM · Calendar
epriestley added a comment to T11713: `utf8_decode` is provided by XML extension, which may not be installed.

@HarryOtto, your message is off topic in this thread and is so tenuously related to anything here that it looks like it might be SEO linkbuilding spam, so I've removed it.

Oct 6 2016, 8:23 AM · libphutil, Bug Report

Oct 5 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 5 2016, 11:44 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T5307: UX for taking actions with search results.

Design atrocity incoming for T10747.

Oct 5 2016, 10:33 PM · Restricted Project, Dashboards (v2), ApplicationEditor, Design
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 5 2016, 10:31 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T11708: Daemons erroneously saying "Diff does not exist".

I think there is an extremely rare policy error somewhere in the policy code that we've occasionally seen in the form of sporadic unit test failures. I haven't been able to reproduce them in the same environment and they're false negatives (e.g., prevent access when it would be OK to allow access) so I haven't spent a ton of effort hunting them down, but it's possible that they have the same cause.

Oct 5 2016, 7:23 PM · Daemons, Differential, Bug Report
epriestley added a revision to T11326: Improve Calendar v1 Design/UI/UX: Unknown Object (Differential Revision).
Oct 5 2016, 6:35 PM · Design, Calendar
epriestley moved T11706: Retrieve event date from Calendar "calendar.event.search" method API from Backlog to Unprototype (v1) on the Calendar board.
Oct 5 2016, 6:31 PM · Calendar, Feature Request
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 5 2016, 6:26 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T11326: Improve Calendar v1 Design/UI/UX.

Rough overall state of the world is that "all the hard stuff" is mostly "done" but it's probably fairly buggy, so I'm going to push on exports and some UI stuff for a bit and try to catch all those bugs while I do. Also imports are probably hard but I'm going to imagine that they aren't for now.

Oct 5 2016, 5:25 PM · Design, Calendar
epriestley added a comment to T11326: Improve Calendar v1 Design/UI/UX.

Yeah, agreed.

Oct 5 2016, 5:21 PM · Design, Calendar
epriestley added a comment to T11326: Improve Calendar v1 Design/UI/UX.

I think I'm going to move the recurrence controls to a separate screen, so you'll make a recurring event in two parts:

Oct 5 2016, 5:19 PM · Design, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 5 2016, 5:07 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10737: Milestone project tags should inherit their parent project's tag colour: Unknown Object (Differential Revision).
Oct 5 2016, 4:53 PM · Feature Request

Oct 4 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 4 2016, 7:50 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 4 2016, 6:51 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 4 2016, 4:55 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 4 2016, 4:25 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T11730: Remove image crop from Conpherence.

I think it sort-of does something if you upload an irregularly-sized image (say, 100x200) instead of a square image. But I don't think it's particularly useful or works well even in that case, and I definitely support getting rid of it.

Oct 4 2016, 2:46 PM · Conpherence (v4)
epriestley added a comment to T3165: Provide Search in Conpherence.

Should basically just be UI, yeah.

Oct 4 2016, 1:58 AM · Conpherence (v4)

Oct 3 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 3 2016, 4:57 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 3 2016, 3:43 PM · Restricted Project, Prioritized, Calendar

Oct 2 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Oct 2 2016, 1:55 PM · Restricted Project, Prioritized, Calendar
epriestley closed T11724: One More as Spite.
Oct 2 2016, 11:22 AM · Feature Request
epriestley closed T11724: One More, a subtask of T11721: SR-45454, as Spite.
Oct 2 2016, 11:22 AM · Feature Request
epriestley closed T11723: DO Backend as Spite.
Oct 2 2016, 11:22 AM · Feature Request
epriestley closed T11723: DO Backend, a subtask of T11721: SR-45454, as Spite.
Oct 2 2016, 11:22 AM · Feature Request
epriestley closed T11722: DO UI task first, a subtask of T11721: SR-45454, as Spite.
Oct 2 2016, 11:22 AM · Feature Request
epriestley closed T11722: DO UI task first as Spite.
Oct 2 2016, 11:22 AM · Feature Request
epriestley closed T11721: SR-45454 as Spite.
Oct 2 2016, 11:22 AM · Feature Request
epriestley closed T11720: Test Feature as Spite.
Oct 2 2016, 11:21 AM · Feature Request
20after4 awarded T8238: Formally support side-band change handoff in external repositories a Doubloon token.
Oct 2 2016, 12:29 AM · Restricted Project, Restricted Project, Diffusion, Harbormaster

Oct 1 2016

epriestley edited the content of Changelog.
Oct 1 2016, 1:14 PM
epriestley created 2016 Week 40 (Very Late September).
Oct 1 2016, 1:13 PM

Sep 30 2016

epriestley added a comment to T11713: `utf8_decode` is provided by XML extension, which may not be installed.

Looks like we use the function to mean "codepoints" in some places in phabricator/.

Sep 30 2016, 12:01 AM · libphutil, Bug Report

Sep 29 2016

epriestley added a comment to T11714: Unified diffs don't allow selecting text in inline comments.

With no claim that this is the world's most elegant fix, I think this may be a fix:

Sep 29 2016, 11:59 PM · Differential, Bug Report
epriestley added a comment to T11713: `utf8_decode` is provided by XML extension, which may not be installed.

In the short term, I'll accept a patch to do this if you want to test it?

Sep 29 2016, 11:52 PM · libphutil, Bug Report
epriestley added a comment to T11713: `utf8_decode` is provided by XML extension, which may not be installed.

T9640 and T2383 are somewhat related.

Sep 29 2016, 11:47 PM · libphutil, Bug Report
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 29 2016, 11:13 PM · Restricted Project, Prioritized, Calendar
epriestley closed T11712: file chunks not encrypted when enabling file encryption as Resolved by committing Restricted Diffusion Commit.
Sep 29 2016, 10:47 PM · Bug Report
epriestley added a comment to T11712: file chunks not encrypted when enabling file encryption.

When you upload a file that is stored as chunks, the chunks are also files. For example, file F123 may have chunks F124, F125, F126, etc. These files are not normally visible in the web UI but you can see that the next file you upload will skip some numbers (e.g., be F127).

Sep 29 2016, 10:46 PM · Bug Report
epriestley added a revision to T11712: file chunks not encrypted when enabling file encryption: Unknown Object (Differential Revision).
Sep 29 2016, 10:42 PM · Bug Report
epriestley added a comment to T11712: file chunks not encrypted when enabling file encryption.

Why do you believe that files which are split into chunks don't get encrypted?

Sep 29 2016, 10:18 PM · Bug Report
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 29 2016, 9:54 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 29 2016, 8:09 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 29 2016, 7:12 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10747: Import and export ICS from Calendar.

The examples that use the BYSETPOS and WKST rules are omitted, because these rules are not supported by Oracle Application Server Containers for J2EE.

Sep 29 2016, 7:07 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 29 2016, 6:57 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T11709: Arc land fails: no commits on <feature-branch> which are not already present on target.

I'm sorry you feel that way. These kinds of requests are frustrating for us too, which is why we try to make it clear upfront in the documentation that this is not an appropriate forum for them.

Sep 29 2016, 6:49 PM · Bug Report
epriestley closed T11709: Arc land fails: no commits on <feature-branch> which are not already present on target as Invalid.

Since it doesn't seem like the documentation is incorrect anywhere, this doesn't appear to describe a bug in Phabricator which we can accept upstream. See Support Resources and Contributing Bug Reports for details on what we do and do not provide support for.

Sep 29 2016, 6:47 PM · Bug Report
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 29 2016, 6:39 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 29 2016, 6:17 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T10412: Change Milestone sort options.

Please file a new task following Contributing Feature Requests if you'd like us to consider your feature request. We do not track resolved tickets.

Sep 29 2016, 5:43 PM · Feature Request
epriestley closed T11707: Creating master branch by default in diffusion as Invalid.

Please see Contributing Feature Requests and Describing Root Problems for guidance on filing a valid feature request. You need to follow all the instructions in those documents before we can accept your request upstream.

Sep 29 2016, 4:54 PM · Diffusion, Feature Request
epriestley added a comment to T11709: Arc land fails: no commits on <feature-branch> which are not already present on target.

Additionally, coming to phabricator, my expectation is that arcanist would handle the front-end (i.e. phabricator), but not strong-arming my local development environment.

Sep 29 2016, 4:44 PM · Bug Report
epriestley added a comment to T11709: Arc land fails: no commits on <feature-branch> which are not already present on target.

That document says:

Sep 29 2016, 4:42 PM · Bug Report
epriestley added a comment to T11709: Arc land fails: no commits on <feature-branch> which are not already present on target.

What led you to arc land, specifically?

Sep 29 2016, 4:32 PM · Bug Report
epriestley added a comment to T11708: Daemons erroneously saying "Diff does not exist".

Also possible is stuff like "the diff has a custom policy which you destroyed", etc.

Sep 29 2016, 4:30 PM · Daemons, Differential, Bug Report
epriestley added a comment to T11708: Daemons erroneously saying "Diff does not exist".

If an object exists but is failing to load, it's usually because a required related object does not exist (in most cases, "required" means "required in order to evaluate policy checks").

Sep 29 2016, 4:29 PM · Daemons, Differential, Bug Report
epriestley added a comment to T11709: Arc land fails: no commits on <feature-branch> which are not already present on target.

This isn't a bug -- I think we've just set you up with the wrong expectations somehow. There's probably some sort of documentation we can improve to make it more clear what arc land does, and maybe I can figure out how where we led you astray by asking some questions:

Sep 29 2016, 4:16 PM · Bug Report
epriestley closed T11711: exm as Invalid.
Sep 29 2016, 11:14 AM · Bug Report

Sep 28 2016

epriestley closed T11705: Repositories are getting stuck as Resolved by committing Restricted Diffusion Commit.
Sep 28 2016, 10:02 PM · Diffusion, Daemons
epriestley added a revision to T11705: Repositories are getting stuck: Unknown Object (Differential Revision).
Sep 28 2016, 9:55 PM · Diffusion, Daemons
epriestley added a comment to T11705: Repositories are getting stuck.

Yeah, ON DUPLICATE KEY UPDATE is sensitive to order. Setup:

Sep 28 2016, 9:48 PM · Diffusion, Daemons
epriestley added a comment to T11705: Repositories are getting stuck.

I think this is:

Sep 28 2016, 9:39 PM · Diffusion, Daemons
sudoforge awarded T3569: Make Phrequent somewhat usable a Like token.
Sep 28 2016, 6:58 PM · Phrequent
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 2:46 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 2:32 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

(The major goal of using refs instead of tags wouldn't really be to hide them per se, just to make them extremely difficult to fetch by accident.)

Sep 28 2016, 2:07 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

Maybe my assumptions about default behaviors are off, or the more-recent base tags (but not necessarily the diff tags) are getting fetched because they're often ancestors of master?

Sep 28 2016, 2:04 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

I'm a little confused about how these tags are appearing so widely in developer working copies in the first place. Is git clone fetching them by default? Do you have unusual default options configured? Do users regularly explicitly fetch all tags present in the remote?

Sep 28 2016, 2:00 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

I think cleaning up closed tags probably isn't a particularly great long-term solution since some fraction of the revisions likely just get left open forever -- so you'd have 500 tags instead of 50000, but I assume that still causes about as many problems, and you'll be back to 50000 in just 100 more years anyway.

Sep 28 2016, 12:29 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T11706: Retrieve event date from Calendar "calendar.event.search" method API.

See some discussion in T7944, particularly T7944#194982.

Sep 28 2016, 12:10 PM · Calendar, Feature Request
epriestley added a comment to T9893: Support ElasticSearch 2.0 - 5.1.

We're planning to put application-level stemming on the MySQL index (see T6740). Are there problems with the InnoDB search that you're aware of that aren't fixable with application adjustments?

Sep 28 2016, 12:05 PM · Elasticsearch, Search
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 2:18 AM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 1:24 AM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 1:06 AM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 12:48 AM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 12:28 AM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 12:17 AM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 12:08 AM · Restricted Project, Prioritized, Calendar

Sep 27 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Restricted Differential Revision.
Sep 27 2016, 11:39 PM · Restricted Project, Prioritized, Calendar