Page MenuHomePhabricator
Feed Advanced Search

Apr 28 2016

epriestley closed T10888: 123 as Spite.
Apr 28 2016, 10:17 AM · Bug Report
epriestley closed T10887: [feed] Missing avatar for Herald authored feed entries as Invalid.

This should be fixed in Week 17. See T8952 / D15773. Let us know if you're still seeing issues after upgrading, or can reproduce the problem on this install.

Apr 28 2016, 10:17 AM · Bug Report

Apr 27 2016

epriestley added a comment to T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.

we'll get to it when we feel like it (ok not a totally fair paraphrase, but it's one way to read it)

Apr 27 2016, 11:45 PM · Restricted Project, User Delight, Maniphest
epriestley added a comment to T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.

Perhaps helpful for context is T6027, which was open for longer than this (about 18 months).

Apr 27 2016, 11:13 PM · Restricted Project, User Delight, Maniphest
epriestley added a comment to T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.

What isn't helpful about it? I believe it has a complete answer to your question, and a great deal of detail explaining why that's the answer. How could it be more helpful? Did I misunderstand what you're asking?

Apr 27 2016, 11:05 PM · Restricted Project, User Delight, Maniphest
epriestley closed T7177: Peculiar Authorization Issue in cloned repositories as Invalid.

I suspect this isn't a bug -- diffs have repository associations, and you must be able to see a repository to see associated diffs. You must be able to see the active diff to see a revision. So andy caused the active diff to belong to a repository that nuno can not see, which prevents nuno from seeing the revision.

Apr 27 2016, 10:58 PM
epriestley updated the task description for T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
Apr 27 2016, 10:51 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 27 2016, 10:47 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley merged T9679: Maybe rename "Import an Existing External Repository" in New Repo Wizard into T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
Apr 27 2016, 10:46 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley merged task T9679: Maybe rename "Import an Existing External Repository" in New Repo Wizard into T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
Apr 27 2016, 10:46 PM · Diffusion
epriestley added a comment to T9679: Maybe rename "Import an Existing External Repository" in New Repo Wizard.

I'm going to merge this into T10748, which is now more clearly the way forward.

Apr 27 2016, 10:46 PM · Diffusion
epriestley added a comment to T7820: Add "Closed, Duplicate" option to Status Action in Maniphest.

See Planning for information on timelines and progress.

Apr 27 2016, 10:38 PM · Restricted Project, User Delight, Maniphest
epriestley edited this Badge.
Apr 27 2016, 10:04 PM
epriestley added a member for Community: jparise.
Apr 27 2016, 10:04 PM
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 27 2016, 5:52 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 27 2016, 5:34 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley merged T9604: Creating an imported repository via Conduit results in filesystem error into T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
Apr 27 2016, 1:58 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley merged task T9604: Creating an imported repository via Conduit results in filesystem error into T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
Apr 27 2016, 1:58 PM · Restricted Project, Phacility Support, Diffusion, Conduit
epriestley added a comment to T9604: Creating an imported repository via Conduit results in filesystem error.

I'm going to merge this into T10748, since that's now clearly the way forward.

Apr 27 2016, 1:57 PM · Restricted Project, Phacility Support, Diffusion, Conduit
epriestley merged T6848: It should be possible to view a repository's policies without necessarily being able to edit it into T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
Apr 27 2016, 1:54 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley merged task T6848: It should be possible to view a repository's policies without necessarily being able to edit it into T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
Apr 27 2016, 1:54 PM · Diffusion (v3)
epriestley added a comment to T6848: It should be possible to view a repository's policies without necessarily being able to edit it.

I'm going to merge this into T10748 because that's clearly the pathway forward now. You can view the new UI at /diffusion/X/manage/, although it mostly doesn't work yet and there are no links to it in the UI.

Apr 27 2016, 1:53 PM · Diffusion (v3)
epriestley added a comment to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.

T10751 and T4292 are reaching a steadier state now and have some indirect/soft dependencies on this (for example, the new panel for monitoring the cluster status of a particular repository is part of this new UI) so I expect to drive this forward at least somewhat in the next few days. I'm not sure how ambitious I'll feel about meddling with the URI code before the release cut, but there's a good chunk of basic work remaining before that becomes an issue.

Apr 27 2016, 1:49 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10843: Don't write Celerity resources which aren't defined in the local map to cache: Unknown Object (Differential Revision).
Apr 27 2016, 1:46 PM · Infrastructure
epriestley added a comment to T10885: Arcanist Windows install docs - adding in additional php extensions.

See also Contributing Bug Reports:

Apr 27 2016, 1:39 PM · Documentation, Bug Report
epriestley closed T10885: Arcanist Windows install docs - adding in additional php extensions as Wontfix.

The instructions are correct as written, and are aimed at being as simple as possible for users who may not be familiar with PHP. We can not possibly include instructions for every imaginable installer, see also T4200.

Apr 27 2016, 1:37 PM · Documentation, Bug Report
epriestley added a comment to T10885: Arcanist Windows install docs - adding in additional php extensions.

In particular, the install instructions tell you to:

Apr 27 2016, 1:09 PM · Documentation, Bug Report
epriestley added a comment to T10885: Arcanist Windows install docs - adding in additional php extensions.

How did you install PHP, exactly?

Apr 27 2016, 1:08 PM · Documentation, Bug Report
epriestley renamed T10886: Unpublished, unauthored inline comments in Pholio are incorrectly counted on the image badge from Inline comments in Pholio are not visible anymore to Unpublished, unauthored inline comments in Pholio are incorrectly counted on the image badge.
Apr 27 2016, 1:06 PM · Pholio, Bug Report
epriestley added a comment to T10884: Sort repository, database and notification services better (by network distance).

Yeah, measuring latency and using it as a signal is tricky. If there's a long disruption and Oregon measures faster than N. California for "a while", we probably legitimately want to use it. If N. California completely goes down, we almost certainly want to keep things alive and send writes to Mars, even if Mars is at a huge network distance, since "slow write" is probably almost always better than "complete failure" (although maybe Mars bandwith is so much more expensive that we don't want to fail over to it, or the size of the link is small enough that it simply can't accommodate the failover traffic).

Apr 27 2016, 11:47 AM · Clusters
epriestley added a comment to T10884: Sort repository, database and notification services better (by network distance).

Ah, link speed vs latency is interesting.

Apr 27 2016, 11:36 AM · Clusters
epriestley added a comment to T10884: Sort repository, database and notification services better (by network distance).

Is "use measured latency" probably always the correct rule in your (hypothetical) cluster setup? Or do you have any cases offhand where it isn't the desired result, and you really want to send traffic to a more distant node on the network?

Apr 27 2016, 11:33 AM · Clusters
epriestley added a comment to T10884: Sort repository, database and notification services better (by network distance).

I don't currently expect anyone to be deploying multi-region clusters in the first iteration of real clustering, so this isn't high on my list of things to fix in this round.

Apr 27 2016, 11:23 AM · Clusters
epriestley added a comment to T10883: Allow repository cluster nodes to be read-only.

See also T10884 for related work: ranking similar nodes more intelligently.

Apr 27 2016, 11:17 AM · Restricted Project, Diffusion, Clusters
epriestley added a comment to T10884: Sort repository, database and notification services better (by network distance).

See also T10883 for related work: making some nodes read-only.

Apr 27 2016, 11:17 AM · Clusters
epriestley created T10884: Sort repository, database and notification services better (by network distance).
Apr 27 2016, 11:16 AM · Clusters
epriestley created T10883: Allow repository cluster nodes to be read-only.
Apr 27 2016, 11:13 AM · Restricted Project, Diffusion, Clusters
epriestley added Q379: notification.servers (Answer 370).
Apr 27 2016, 10:45 AM
epriestley closed T10882: test as Spite.
Apr 27 2016, 10:03 AM · Bug Report

Apr 26 2016

epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 26 2016, 11:11 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 26 2016, 10:55 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
robertkraig awarded T10778: ${NAMESPACE}_search is missing an edge and edgedata table a Like token.
Apr 26 2016, 6:34 PM · ApplicationEditor, Bug Report
epriestley added a comment to T10880: Cannot persist changes of visibility of Form Template.

Thanks -- T10778 had instructions which I was more successful with. This should be fixed in HEAD.

Apr 26 2016, 6:31 PM · Bug Report
epriestley closed T10778: ${NAMESPACE}_search is missing an edge and edgedata table as Resolved by committing Restricted Diffusion Commit.
Apr 26 2016, 6:26 PM · ApplicationEditor, Bug Report
epriestley added a revision to T10778: ${NAMESPACE}_search is missing an edge and edgedata table: Unknown Object (Differential Revision).
Apr 26 2016, 6:22 PM · ApplicationEditor, Bug Report
epriestley claimed T10778: ${NAMESPACE}_search is missing an edge and edgedata table.
Apr 26 2016, 6:16 PM · ApplicationEditor, Bug Report
epriestley added a comment to T10778: ${NAMESPACE}_search is missing an edge and edgedata table.

Oh, thanks. I can reproduce this variant of things. I thought I remembered seeing this...

Apr 26 2016, 6:15 PM · ApplicationEditor, Bug Report
epriestley added a comment to T10880: Cannot persist changes of visibility of Form Template.

Do you have a stack trace in your webserver error log? (Often /var/log/apache2/error.log or similar.) I can't immediately reproduce this myself, but that might help narrow down the cause.

Apr 26 2016, 6:14 PM · Bug Report
epriestley closed T10386: HTTP instructions in "Diffusion User Guide: Repository Hosting" are incomplete as Resolved by committing Restricted Diffusion Commit.
Apr 26 2016, 5:07 PM · Documentation, Bug Report
epriestley closed T10876: Make the setup warning count cache database-backed, a subtask of T10751: Make Phabricator Highly Available, as Resolved.
Apr 26 2016, 5:03 PM · Restricted Project, Infrastructure, Prioritized
epriestley closed T10876: Make the setup warning count cache database-backed as Resolved by committing Restricted Diffusion Commit.
Apr 26 2016, 5:03 PM · Clusters
epriestley added Q378: Read-only access on hosted Phabricator for non-login users (Answer 369).
Apr 26 2016, 3:05 PM
epriestley added a comment to T10877: Large sized GIF is not animated properly..

The GIF data is set to repeat the animation only once (see circled control in footer):

Apr 26 2016, 2:57 PM · Bug Report
epriestley added a revision to T10876: Make the setup warning count cache database-backed: Unknown Object (Differential Revision).
Apr 26 2016, 2:44 PM · Clusters
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 26 2016, 2:00 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley created T10876: Make the setup warning count cache database-backed.
Apr 26 2016, 1:32 PM · Clusters
epriestley added a revision to T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API: Unknown Object (Differential Revision).
Apr 26 2016, 12:45 PM · Prioritized, Restricted Project, Diffusion (v3), Feature Request
epriestley added a comment to T10868: Make a line-linkable view for individual build logs.
  • (T9516) Use the same copy/paste line number stuff that Paste, Diffusion, etc use.
    • (T10179) Make formatting smarter. For example, the "Run CircleCI Build" plan produces logs that we know to be HTTP headers (which we could format as a table) and (almost always) a JSON blob (which we could format as human-readable JSON).
    • (T8656) Make one of the smart formatters "ANSI".
    • I'd like to style this like other stuff (Paste, Diffusion) and let users pick dark themes globally with T5701 if they prefer.
    • Logic for loading the data is clunky, and fetches much more data than it needs.
    • Clicking pager links affects all build logs on the page, this should probably be JS-ish at some point.
    • Pager logic often feels clunky to me. For example, if a log is exactly 21 lines long, we still show pager controls. If a log is 27 lines long, we should probably show the whole thing. "Show more" would be more consistent with how other pagers work, etc.
    • (T6139) Not sure if this is really the right way to frame it, but we often have information about how useful a build log is and can do a better job of organizing them (e.g., successful build logs are usually uninteresting and could be folded by default).
Apr 26 2016, 12:32 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a comment to T10868: Make a line-linkable view for individual build logs.

@hach-que, that plan sounds good to me.

Apr 26 2016, 12:23 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a revision to T10849: Support query timeouts via `max_statement_time` or MYSLQI_ASYNC: Unknown Object (Differential Revision).
Apr 26 2016, 12:16 PM · Infrastructure, Phacility
epriestley merged T10875: Browse in Diffusion doesn't take branch into account into T3216: "Browse in Diffusion" always going to default branch.
Apr 26 2016, 11:56 AM · Differential
epriestley merged task T10875: Browse in Diffusion doesn't take branch into account into T3216: "Browse in Diffusion" always going to default branch.
Apr 26 2016, 11:56 AM · Bug Report
epriestley added a comment to T10874: Add repository or project to email subject.

Not directly to your point, but you can remove or shorten the [Differential] token by adjusting metamta.differential.subject-prefix, if you didn't stumble across that already.

Apr 26 2016, 11:28 AM · Restricted Project, Mail, Feature Request
epriestley closed T10873: New installation fails to create/setup database as Resolved.
Apr 26 2016, 11:27 AM · Bug Report
epriestley added a comment to T10751: Make Phabricator Highly Available.

I'm still not really thrilled with where the documentation situation on repositories is, but it's getting a little more manageable.

Apr 26 2016, 3:18 AM · Restricted Project, Infrastructure, Prioritized
epriestley added a revision to T4292: Implement repository replication: Unknown Object (Differential Revision).
Apr 26 2016, 2:47 AM · Restricted Project, Diffusion
epriestley added a comment to T10869: `arc test` sometimes picks an older (incorrect) parent to apply patch to.

Here are a few ideas that might shed some light on what's happening:

Apr 26 2016, 1:59 AM · Arcanist, Restricted Project, Bug Report
epriestley added a comment to T10869: `arc test` sometimes picks an older (incorrect) parent to apply patch to.

I can't reproduce this. Here's what I did:

Apr 26 2016, 12:49 AM · Arcanist, Restricted Project, Bug Report
epriestley added a comment to T10869: `arc test` sometimes picks an older (incorrect) parent to apply patch to.

arc diff is supported, but most of these reproduction instructions don't make much sense to me in the context of arc diff -- for example, arc diff does not apply patches.

Apr 26 2016, 12:42 AM · Arcanist, Restricted Project, Bug Report
epriestley added a comment to T10869: `arc test` sometimes picks an older (incorrect) parent to apply patch to.

Specifically, any effort to reproduce this in the upstream will meet this grizzly fate on the arc test step:

Apr 26 2016, 12:35 AM · Arcanist, Restricted Project, Bug Report
epriestley closed T10869: `arc test` sometimes picks an older (incorrect) parent to apply patch to as Invalid.

Yeah, arc test is not part of the upstream.

Apr 26 2016, 12:33 AM · Arcanist, Restricted Project, Bug Report
epriestley closed T10871: Aphlict does not properly guess root path of installation as Invalid.

This is a Bitnami issue, and you should report it to them. See Contributing Bug Reports:

Apr 26 2016, 12:30 AM · Bug Report

Apr 25 2016

epriestley added a comment to T10867: Version daemons more clearly in daemon console so it's clear when `phd reload` has taken effect.

Maybe also reasonable would be something like this:

Apr 25 2016, 10:08 PM · Daemons, Feature Request
epriestley renamed T10867: Version daemons more clearly in daemon console so it's clear when `phd reload` has taken effect from Gracefully handle builds when restarting daemons to Version daemons more clearly in daemon console so it's clear when `phd reload` has taken effect.
Apr 25 2016, 9:53 PM · Daemons, Feature Request
epriestley added a comment to T10867: Version daemons more clearly in daemon console so it's clear when `phd reload` has taken effect.

One thing we could do to improve this is version daemons in /daemon/, so your "go to sleep" routine could be more like:

Apr 25 2016, 9:52 PM · Daemons, Feature Request
epriestley added a comment to T10867: Version daemons more clearly in daemon console so it's clear when `phd reload` has taken effect.

You can use bin/phd reload -- instead of restart -- to instruct daemons to exit and restart only after completing their current tasks, with no time limit on task completion. The semantics on this are necessarily a little fuzzy, but basically:

Apr 25 2016, 9:39 PM · Daemons, Feature Request
epriestley added a revision to T10386: HTTP instructions in "Diffusion User Guide: Repository Hosting" are incomplete: Unknown Object (Differential Revision).
Apr 25 2016, 3:32 PM · Documentation, Bug Report
epriestley added a revision to T10866: Missing Information in Diffusion User Guide: Repo Hosting: Unknown Object (Differential Revision).
Apr 25 2016, 3:32 PM · Diffusion, Documentation, Bug Report
epriestley closed T10602: Adding client side private key addition information to Diffusion Repo Hosting Guide. as Wontfix.

This document is already large and complex and the source of many configuration mistakes. I worry including basic information like this could cause more harm than good, by making the document even larger and making it easy to miss something important.

Apr 25 2016, 3:23 PM · Feature Request
epriestley closed T10865: Remarkup is not rendered in Pholio Application as Resolved by committing Restricted Diffusion Commit.
Apr 25 2016, 3:16 PM · Remarkup, Pholio, Bug Report
epriestley closed T9560: dirname(phabricator-ssh-hook.sh) needs to be owned by root too as Resolved by committing Restricted Diffusion Commit.
Apr 25 2016, 3:16 PM · Diffusion, Documentation
epriestley added a comment to T10866: Missing Information in Diffusion User Guide: Repo Hosting.

That is, we normally navigate complex configuration by verifying every step and just telling you what's wrong and how to fix it (e.g., moving all the MySQL, etc., configuration from documentation to automatic setup issues was a huge step forward), but there's basically no test we can perform on most of this chain.

Apr 25 2016, 2:41 PM · Diffusion, Documentation, Bug Report
epriestley added a comment to T10866: Missing Information in Diffusion User Guide: Repo Hosting.

In general, this configuration is a huge horrible mess but I'm having a hard time coming up with ways to really fix it that don't just tell you to run everything as root.

Apr 25 2016, 2:39 PM · Diffusion, Documentation, Bug Report
epriestley added a comment to T10866: Missing Information in Diffusion User Guide: Repo Hosting.

Oh, I think I have a handle on the first issue -- you can ignore my questions about that.

Apr 25 2016, 2:34 PM · Diffusion, Documentation, Bug Report
epriestley added a comment to T10866: Missing Information in Diffusion User Guide: Repo Hosting.

It turned out that the git-user (aka vcs-user) created files as phd:phd

Apr 25 2016, 2:31 PM · Diffusion, Documentation, Bug Report
florianb awarded Blog Post: Development Notes (2016 Week 10) a Piece of Eight token.
Apr 25 2016, 2:22 PM
epriestley added a revision to T4292: Implement repository replication: Unknown Object (Differential Revision).
Apr 25 2016, 1:38 PM · Restricted Project, Diffusion
epriestley added a comment to T9560: dirname(phabricator-ssh-hook.sh) needs to be owned by root too.

This also reproduced locally for me (OS X Yosemite, openssh-6.7p1), and chmod on the parent directory alone was reliably sufficient to prevent SSH from working. The instructions already suggest a root-owned location, but D15794 notes this requirement explicitly.

Apr 25 2016, 12:42 PM · Diffusion, Documentation
epriestley added a revision to T9560: dirname(phabricator-ssh-hook.sh) needs to be owned by root too: Unknown Object (Differential Revision).
Apr 25 2016, 12:40 PM · Diffusion, Documentation
epriestley claimed T9560: dirname(phabricator-ssh-hook.sh) needs to be owned by root too.
Apr 25 2016, 12:33 PM · Diffusion, Documentation
epriestley added a comment to T5463: Could not stat AuthorizedKeysCommand .

I can confirm T9560 locally, at least, so that might be the problem or part of it -- maybe start there? If you can provide details we're happy to fix this properly.

Apr 25 2016, 12:32 PM · Diffusion
epriestley added a comment to T5463: Could not stat AuthorizedKeysCommand .

Yes, you should NOT set AuthorizedKeysCommandUser root, this is needlessly dangerous and gives the script substantially more permission than it needs.

Apr 25 2016, 12:28 PM · Diffusion
epriestley added a revision to T10865: Remarkup is not rendered in Pholio Application: Unknown Object (Differential Revision).
Apr 25 2016, 12:12 PM · Remarkup, Pholio, Bug Report
epriestley claimed T10865: Remarkup is not rendered in Pholio Application.
Apr 25 2016, 11:58 AM · Remarkup, Pholio, Bug Report
epriestley added a comment to T10865: Remarkup is not rendered in Pholio Application.

I also caught this vaguely related downstream report of markup list styles not rendering properly in mock descriptions:

Apr 25 2016, 11:58 AM · Remarkup, Pholio, Bug Report
c.mertins awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Apr 25 2016, 6:40 AM · Workboards (v3), Restricted Project

Apr 24 2016

epriestley lowered the priority of T10860: After an inconsistent cluster repository write, consider just ignoring the lock from Normal to Low.

After we receive a push, try very very very very hard to release the lock if we're the thread holding it, even if we lost the global lock

Apr 24 2016, 6:39 PM · Clusters, Diffusion
epriestley closed T10863: Aphlict fails to start when "logs" option is omitted as Resolved by committing Restricted Diffusion Commit.
Apr 24 2016, 6:20 PM · Aphlict, Bug Report
epriestley claimed T10863: Aphlict fails to start when "logs" option is omitted.
Apr 24 2016, 6:20 PM · Aphlict, Bug Report
epriestley added a revision to T10860: After an inconsistent cluster repository write, consider just ignoring the lock: Unknown Object (Differential Revision).
Apr 24 2016, 5:59 PM · Clusters, Diffusion