Page MenuHomePhabricator
Feed Advanced Search

Nov 1 2015

• mholden awarded T5891: Add button to notification panel to concatenate notifications on the same objects a Love token.
Nov 1 2015, 9:43 PM · Notifications
tycho.tatitscheff awarded T5891: Add button to notification panel to concatenate notifications on the same objects a Love token.
Nov 1 2015, 5:58 PM · Notifications
epriestley edited the content of Changelog.
Nov 1 2015, 1:31 PM
epriestley created 2015 Week 44 (Very Late October).
Nov 1 2015, 1:29 PM
epriestley closed T9676: Triangle workflows (pushing to a merge manager) as Wontfix.

The upstream pathway for this lies beyond T182.

Nov 1 2015, 12:12 PM · Restricted Project

Oct 30 2015

epriestley added a comment to T9670: Conflicting field mappings for phabricator index when upgrading to Elasticsearch 2.0.

Oh, I think I misremembered and it does foreground by default. You can use --background to improve performance, and monitor from /daemon/.

Oct 30 2015, 5:03 PM · Elasticsearch
epriestley added a comment to T9670: Conflicting field mappings for phabricator index when upgrading to Elasticsearch 2.0.

Note that index --all queues stuff into the background, so you may need to wait a while before it finishes. You can use --foreground (slower) or monitor progress from /daemon/ in the web UI.

Oct 30 2015, 5:03 PM · Elasticsearch
epriestley added a comment to T9670: Conflicting field mappings for phabricator index when upgrading to Elasticsearch 2.0.

D14370 likely fixes this, although I don't have ElasticSearch 2.0 locally and haven't tested it. I'd guess this will give you a clean bill of health:

Oct 30 2015, 5:02 PM · Elasticsearch
epriestley added a revision to T9670: Conflicting field mappings for phabricator index when upgrading to Elasticsearch 2.0: Unknown Object (Differential Revision).
Oct 30 2015, 5:00 PM · Elasticsearch
epriestley added a comment to T9665: my remote git repository Initializing Working Copy a long time.

Can you show me the output of this command?

Oct 30 2015, 4:57 PM · Diffusion
epriestley added a comment to T182: Commit into repository directly from differential.

I think the discussion is in T8090.

Oct 30 2015, 4:55 PM · Haskell.org, Restricted Project, Differential
epriestley added a comment to T9672: Make it possible to modify or disable differential's "next step" property.

I think that should clear the way for you, let me know if you hit issues.

Oct 30 2015, 4:23 PM · Custom Fields, Differential
epriestley closed T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository as Resolved by committing Restricted Diffusion Commit.
Oct 30 2015, 4:02 PM · Harbormaster, Drydock
epriestley closed T9672: Make it possible to modify or disable differential's "next step" property as Resolved by committing Restricted Diffusion Commit.
Oct 30 2015, 4:00 PM · Custom Fields, Differential
epriestley closed T9674: "Authorized By" links to a 404 as Resolved by committing Restricted Diffusion Commit.
Oct 30 2015, 3:54 PM · Drydock, Harbormaster
epriestley added a comment to T9671: Harbormaster builds and Drydock leases are stuck.

D14368 should fix the issue where you're required to set a dummy "Also Clone" repository.

Oct 30 2015, 3:02 PM · Harbormaster, Drydock
epriestley added a revision to T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository: Unknown Object (Differential Revision).
Oct 30 2015, 3:01 PM · Harbormaster, Drydock
epriestley triaged T9669: Harbormaster working copy build step shouldn't crash when user don't set any also clone repository as Normal priority.
Oct 30 2015, 2:53 PM · Harbormaster, Drydock
epriestley added a revision to T9672: Make it possible to modify or disable differential's "next step" property: Unknown Object (Differential Revision).
Oct 30 2015, 2:47 PM · Custom Fields, Differential
epriestley claimed T9672: Make it possible to modify or disable differential's "next step" property.
Oct 30 2015, 2:47 PM · Custom Fields, Differential
epriestley added a revision to T9674: "Authorized By" links to a 404: Unknown Object (Differential Revision).
Oct 30 2015, 2:35 PM · Drydock, Harbormaster
epriestley claimed T9674: "Authorized By" links to a 404.
Oct 30 2015, 2:32 PM · Drydock, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

Yeah -- that make sense, I'm just want to be mindful of how much complexity we're adding to the upstream in order to subvert barriers that have no technical reason to exist.

Oct 30 2015, 2:02 PM · Restricted Project, Harbormaster
epriestley added a comment to T9671: Harbormaster builds and Drydock leases are stuck.

"Lease Host" is not currently expected to work at all. It hasn't been updated for any of the changes, including authorizations. "Lease Working Copy" (under "Drydock") should.

Oct 30 2015, 1:51 PM · Harbormaster, Drydock
exp10r3r awarded T7924: Unprototype Calendar (v1) a Mountain of Wealth token.
Oct 30 2015, 1:22 PM · Restricted Project, Prioritized, Calendar

Oct 29 2015

epriestley added a comment to T9671: Harbormaster builds and Drydock leases are stuck.

Drydock is a prototype and all of the Harbormaster build steps which interact with it are prototypes. Much of this code has been substantially rewritten in the last two weeks. See:

Oct 29 2015, 9:10 PM · Harbormaster, Drydock
epriestley edited the content of Planning.
Oct 29 2015, 7:19 PM
epriestley edited the content of Planning.
Oct 29 2015, 7:16 PM
epriestley edited the content of Planning.
Oct 29 2015, 7:08 PM
epriestley added a comment to T9657: Upgrading: arc land flow has been rewritten in git.

If you do this:

Oct 29 2015, 6:56 PM · Installing & Upgrading, Arcanist
epriestley added a comment to T9657: Upgrading: arc land flow has been rewritten in git.

Can you show me this?

Oct 29 2015, 6:40 PM · Installing & Upgrading, Arcanist
tycho.tatitscheff awarded T9657: Upgrading: arc land flow has been rewritten in git a Evil Spooky Haunted Tree token.
Oct 29 2015, 5:42 PM · Installing & Upgrading, Arcanist
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

FWIW this would be useful in repositories where users can push branches (and maybe only to certain regex-matching branch names) and not tags.

Oct 29 2015, 4:57 PM · Restricted Project, Harbormaster
epriestley updated the task description for T9657: Upgrading: arc land flow has been rewritten in git.
Oct 29 2015, 4:31 PM · Installing & Upgrading, Arcanist
epriestley added a comment to T9661: arc land doesn't return to local tracking branch if it has a different name from the remote branch it's tracking.

There was one more followup in T3855 to fix a couple of bugs, but if you updated this morning you probably picked that up.

Oct 29 2015, 4:28 PM · Arcanist
epriestley added a comment to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.

D14365 should fix that too, now. Landing in a sec...

Oct 29 2015, 12:13 AM · Restricted Project, Arcanist

Oct 28 2015

epriestley added a comment to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.

Cool, that's an easy fix.

Oct 28 2015, 11:52 PM · Restricted Project, Arcanist
epriestley added a revision to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same: Unknown Object (Differential Revision).
Oct 28 2015, 11:47 PM · Restricted Project, Arcanist
epriestley added a comment to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.

Ah, okay. If we put a no-op "--ff" in that command, does it overwrite the configuration option and work locally?

Oct 28 2015, 11:40 PM · Restricted Project, Arcanist
epriestley added a comment to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.

Let's look at your second one first since I think that's a little simpler. I can't immediately reproduce it. Here's what I did:

Oct 28 2015, 11:33 PM · Restricted Project, Arcanist
epriestley added a member for Blessed Committers: 20after4.
Oct 28 2015, 9:03 PM
epriestley added a comment to T9661: arc land doesn't return to local tracking branch if it has a different name from the remote branch it's tracking.

I think that will fix things, let me know if you run into more cases.

Oct 28 2015, 9:02 PM · Arcanist
epriestley closed T9661: arc land doesn't return to local tracking branch if it has a different name from the remote branch it's tracking as Resolved by committing Restricted Diffusion Commit.
Oct 28 2015, 9:01 PM · Arcanist
epriestley added a comment to T9661: arc land doesn't return to local tracking branch if it has a different name from the remote branch it's tracking.

After D14361, the new behavior is so complicated that I don't think I can briefly explain it, but very roughly:

Oct 28 2015, 8:28 PM · Arcanist
epriestley added a comment to T9661: arc land doesn't return to local tracking branch if it has a different name from the remote branch it's tracking.

This is just a big mess to resolve in the general case because we need to identify a path from whatever was landed to the remote, then cascade changes down along it, because there may be an arbitrary number of local branches between the target and the remote.

Oct 28 2015, 7:42 PM · Arcanist
epriestley added a comment to T182: Commit into repository directly from differential.

Yes, that's what this refers to:

Oct 28 2015, 7:39 PM · Haskell.org, Restricted Project, Differential
epriestley added a revision to T9661: arc land doesn't return to local tracking branch if it has a different name from the remote branch it's tracking: Unknown Object (Differential Revision).
Oct 28 2015, 7:37 PM · Arcanist
epriestley edited P1879 post140.remarkup.
Oct 28 2015, 6:57 PM
epriestley added a revision to T9661: arc land doesn't return to local tracking branch if it has a different name from the remote branch it's tracking: Unknown Object (Differential Revision).
Oct 28 2015, 6:38 PM · Arcanist
epriestley added a comment to T9661: arc land doesn't return to local tracking branch if it has a different name from the remote branch it's tracking.

oh come on you're just making up new workflows at this point

Oct 28 2015, 6:02 PM · Arcanist
epriestley updated the task description for T9657: Upgrading: arc land flow has been rewritten in git.
Oct 28 2015, 5:33 PM · Installing & Upgrading, Arcanist
epriestley added a comment to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.

I'm planning to leave this open since it also contains a lot of discussion about Mercurial and none of the recent changes affect Mercurial (particularly, they do not resolve the branch/bookmark issues). Of relevance here:

Oct 28 2015, 5:23 PM · Restricted Project, Arcanist
epriestley updated the task description for T9657: Upgrading: arc land flow has been rewritten in git.
Oct 28 2015, 5:18 PM · Installing & Upgrading, Arcanist
epriestley added a comment to T9660: arc land does not delete landed branch when landing directly to remote.

(Let me know if I missed anything, and thanks for the report!)

Oct 28 2015, 5:11 PM · Arcanist
epriestley closed T9660: arc land does not delete landed branch when landing directly to remote as Resolved by committing Restricted Diffusion Commit.
Oct 28 2015, 5:10 PM · Arcanist
epriestley added a comment to T9660: arc land does not delete landed branch when landing directly to remote.

This does mean we can't distinguish between these cases:

Oct 28 2015, 5:10 PM · Arcanist
epriestley added a revision to T9660: arc land does not delete landed branch when landing directly to remote: Unknown Object (Differential Revision).
Oct 28 2015, 5:06 PM · Arcanist
epriestley added a comment to T9660: arc land does not delete landed branch when landing directly to remote.

That does look like a bug, let me take a peek.

Oct 28 2015, 4:50 PM · Arcanist
epriestley added a comment to T9660: arc land does not delete landed branch when landing directly to remote.

In your advanced workflow, you could sort of work around this by making sure your local branch always has a different name than the remote branch.

Oct 28 2015, 4:40 PM · Arcanist
epriestley closed T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote as Resolved by committing Restricted Diffusion Commit.
Oct 28 2015, 4:37 PM · Arcanist
epriestley closed T9658: arc land doesn't default --onto to a tracked branch if it is a remote as Resolved by committing Restricted Diffusion Commit.
Oct 28 2015, 4:37 PM · Arcanist
epriestley added a comment to T9660: arc land does not delete landed branch when landing directly to remote.

This behavior is intentional and I don't plan to change it.

Oct 28 2015, 4:33 PM · Arcanist
epriestley updated subscribers of T9132: Build an ApplicationEditor abstraction.
Oct 28 2015, 3:55 PM · Restricted Project, ApplicationEditor, Transactions
epriestley merged task T9659: Support custom field modification via "Weigh in" functionality in Maniphest into T9132: Build an ApplicationEditor abstraction.
Oct 28 2015, 3:55 PM · Maniphest, Custom Fields
epriestley added a comment to T9659: Support custom field modification via "Weigh in" functionality in Maniphest.

I'm going to merge this into T9132, as any pathway forward here runs through that.

Oct 28 2015, 3:54 PM · Maniphest, Custom Fields
epriestley added a revision to T9658: arc land doesn't default --onto to a tracked branch if it is a remote: Unknown Object (Differential Revision).
Oct 28 2015, 3:49 PM · Arcanist
epriestley added a comment to T9658: arc land doesn't default --onto to a tracked branch if it is a remote.

I think this is fixed by D14357, although I'm surprised by the original behavior. Here's what I get after D14357:

Oct 28 2015, 3:47 PM · Arcanist
epriestley added a comment to T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote.

D14357 fixes this. The new behavior is to recursively resolve upstreams until we:

Oct 28 2015, 3:40 PM · Arcanist
epriestley added a revision to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same: Unknown Object (Differential Revision).
Oct 28 2015, 3:34 PM · Restricted Project, Arcanist
epriestley added a revision to T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote: Unknown Object (Differential Revision).
Oct 28 2015, 3:34 PM · Arcanist
epriestley updated the task description for T9657: Upgrading: arc land flow has been rewritten in git.
Oct 28 2015, 2:11 PM · Installing & Upgrading, Arcanist
epriestley updated the task description for T9657: Upgrading: arc land flow has been rewritten in git.
Oct 28 2015, 2:11 PM · Installing & Upgrading, Arcanist
epriestley created T9657: Upgrading: arc land flow has been rewritten in git.
Oct 28 2015, 2:10 PM · Installing & Upgrading, Arcanist
epriestley closed T4333: `arc land` should provide a mechanism to land revisions by other authors while preserving authorship meta-data as Resolved by committing Restricted Diffusion Commit.
Oct 28 2015, 2:05 PM · Arcanist
epriestley closed T8620: support landing from a detached head in git as Resolved by committing Restricted Diffusion Commit.
Oct 28 2015, 2:05 PM · Arcanist
epriestley closed T9537: Support for landing without local tracking branch as Resolved by committing Restricted Diffusion Commit.
Oct 28 2015, 2:05 PM · Arcanist
epriestley edited P1878 comment_snippet.sql.
Oct 28 2015, 1:57 PM
epriestley added a comment to T9652: Request for test case management application.

I think we will probably build such an application eventually, but I doubt we'll build it until 2017 at the earliest (i.e., it is at least a year away).

Oct 28 2015, 1:56 PM · Restricted Project, Unnamed Manual Test Case Application
epriestley added a comment to T3670: Add subprojects.

In general, see Planning / Paid Prioritization / Roadmap / Starmap.

Oct 28 2015, 1:48 PM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia
epriestley added a comment to T4333: `arc land` should provide a mechanism to land revisions by other authors while preserving authorship meta-data.

In Git, after D14356, and ignoring any bugs, arc patch D123 && arc land should work (it should already have worked, just not preserved author metadata?).

Oct 28 2015, 1:16 PM · Arcanist
epriestley merged task T9653: Show a link to approval queue in unapproved user profile into T8029: make it possible to "approve" a user from the profile view.
Oct 28 2015, 12:30 PM · NUX
epriestley updated subscribers of T8029: make it possible to "approve" a user from the profile view.
Oct 28 2015, 12:30 PM · Auth, People
epriestley added a comment to T9537: Support for landing without local tracking branch.

After D14356, we ignore the local branch (if it exists) until we've pushed.

Oct 28 2015, 2:32 AM · Arcanist
epriestley renamed T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote from Unable to 'arc land' a branch if the target local branch has a different name than the remote branch to In "arc land", recursively resolve tracking branches until we reach one in a remote.
Oct 28 2015, 2:30 AM · Arcanist
epriestley added a comment to T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote.

Oh, sorry, D14356 doesn't actually fix this.

Oct 28 2015, 2:30 AM · Arcanist
epriestley added a comment to T8620: support landing from a detached head in git.

This should work after D14356.

Oct 28 2015, 2:28 AM · Arcanist
epriestley added a comment to T4333: `arc land` should provide a mechanism to land revisions by other authors while preserving authorship meta-data.

After D14356, arc land will preserve authorship and author date data. Since arc patch also preserves them, the net effect should be preserved authors.

Oct 28 2015, 2:26 AM · Arcanist
epriestley added a revision to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same: Unknown Object (Differential Revision).
Oct 28 2015, 2:14 AM · Restricted Project, Arcanist
epriestley added a revision to T4333: `arc land` should provide a mechanism to land revisions by other authors while preserving authorship meta-data: Unknown Object (Differential Revision).
Oct 28 2015, 2:14 AM · Arcanist
epriestley added a revision to T9537: Support for landing without local tracking branch: Restricted Differential Revision.
Oct 28 2015, 2:13 AM · Arcanist
epriestley added a revision to T9543: In "arc land", recursively resolve tracking branches until we reach one in a remote: Restricted Differential Revision.
Oct 28 2015, 2:13 AM · Arcanist
epriestley added a revision to T8620: support landing from a detached head in git: Restricted Differential Revision.
Oct 28 2015, 2:13 AM · Arcanist
epriestley closed T6728: `arc land` should update log message as Invalid.

No clue how to repro, no reports in nearly a year.

Oct 28 2015, 2:04 AM · Arcanist
epriestley merged T9649: Show project tags on workboards into T4863: Allow Workboard Cards to be customized for display.
Oct 28 2015, 12:32 AM · Projects, Wikimedia, Workboards
epriestley merged task T9649: Show project tags on workboards into T4863: Allow Workboard Cards to be customized for display.
Oct 28 2015, 12:32 AM · Workboards

Oct 27 2015

epriestley claimed T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.
Oct 27 2015, 10:17 PM · Restricted Project, Arcanist
epriestley added a comment to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.

About an hour.

Oct 27 2015, 10:15 PM · Restricted Project, Arcanist
epriestley added a comment to T3855: `arc land` should work when the current branch/bookmark and the target branch/bookmark are the same.

Yes: move it into the "Contract Fix" column on the Dropbox workboard.

Oct 27 2015, 10:09 PM · Restricted Project, Arcanist
epriestley closed T9252: Unprototype Drydock (v1) as Resolved.

I'm going to close this out as I think we're generally in good shape here and we're now hosting builds and doing server-side lands in the upstream, and don't anticipate much more Drydock-specific work in this iteration.

Oct 27 2015, 9:54 PM · Prioritized, Drydock
epriestley closed T9252: Unprototype Drydock (v1), a subtask of T182: Commit into repository directly from differential, as Resolved.
Oct 27 2015, 9:54 PM · Haskell.org, Restricted Project, Differential