Page MenuHomePhabricator
Feed Advanced Search

Jul 6 2015

epriestley added a comment to T8764: Reduce impact of backups on running instances.

I stopped storage upgrade from running on out-of-service instances (rCOREe9f998b109c1) and upgraded db002 and repo002 to verify this change. We don't need to keep out-of-service schemata up to date, and this reduces the ongoing cost of out-of-service instances.

Jul 6 2015, 5:01 PM · Phacility, Ops
epriestley added a revision to T8764: Reduce impact of backups on running instances: Unknown Object (Differential Revision).
Jul 6 2015, 4:52 PM · Phacility, Ops
epriestley added a comment to T8746: 20131121.repocredentials.2.mig.php fails.

ab7dc13c67fd (Sun, Jul 5, 12:28 PM) is after the earlier patch 92b73fed6b2c (Fri, Jul 3, 10:59 AM). This is still an error with the migration.

Jul 6 2015, 4:46 PM · Setup
epriestley added a revision to T8764: Reduce impact of backups on running instances: Unknown Object (Differential Revision).
Jul 6 2015, 4:31 PM · Phacility, Ops
epriestley closed T8759: Awkward first experience with Spaces as Resolved by committing Restricted Diffusion Commit.
Jul 6 2015, 4:20 PM · Spaces
epriestley added a comment to T8764: Reduce impact of backups on running instances.

I no-op'd the debian-start script and deployed db002 with the new changes (rCORE51d7570f5ddf) to verify it. I'm not going to restart db001 for the moment, since bringing it down is more disruptive and I only need confidence that the change is correct.

Jul 6 2015, 4:10 PM · Phacility, Ops
epriestley added a comment to T8764: Reduce impact of backups on running instances.

I've restarted the tier with a ~50% buffer pool configuration (4GB of 7.5GB) and 8GB swap (rCORE471d3a7acee1) and things seem to be holding stable. I'll pursue the other changes now.

Jul 6 2015, 3:56 PM · Phacility, Ops
epriestley added a comment to T8764: Reduce impact of backups on running instances.

Ubuntu also ships with some debian-sys-maint junk which runs huge, slow queries to check for problematic table data on every restart, which we should likely disable.

Jul 6 2015, 3:51 PM · Phacility, Ops
epriestley added a comment to T8764: Reduce impact of backups on running instances.

While I was writing this up, the host ran out of RAM and stopped working, so this is probably a memory management issue.

Jul 6 2015, 3:42 PM · Phacility, Ops
epriestley added a comment to T8764: Reduce impact of backups on running instances.

Some immediate observations:

Jul 6 2015, 3:41 PM · Phacility, Ops
epriestley added a comment to T4610: Implement robots.txt.

Since your code is mostly PHP, you could possibly just run Diviner on things to get something for Google to hit. That might be way off (and we may not be able to parse/atomize things in the MW codebase correctly), but I could see it being at least as good as indexing the source itself. If someone searches for a class or function name, I think getting the definition is almost always way more useful than getting callsites -- maybe even if the hit is shell docs with a link to the definition. And in some future world where everyone has infinite time to generate wonderful stable docs, the doc hit seems clearly preferable.

Jul 6 2015, 3:24 PM
epriestley added a comment to T4610: Implement robots.txt.

...so I could get a better idea of how these fields are used. In this case, sadly. I didn't find much at all, though it probably isn't because of the robots.txt exclusion in diffusion.

Jul 6 2015, 3:06 PM
epriestley created T8764: Reduce impact of backups on running instances.
Jul 6 2015, 2:46 PM · Phacility, Ops
epriestley added a revision to T8759: Awkward first experience with Spaces: Unknown Object (Differential Revision).
Jul 6 2015, 2:23 PM · Spaces
epriestley claimed T8759: Awkward first experience with Spaces.
Jul 6 2015, 2:13 PM · Spaces
epriestley closed T8762: Upgrade process should be more informative when unable to create new databases as Invalid.

https://secure.phabricator.com/book/phabflavor/article/please_please_please/

Jul 6 2015, 2:07 PM · Setup
epriestley closed T8761: Projects shouldn't allow setting "joinable by" to itself as Wontfix.

Generally, we prefer UI consistency and a simpler UI ruleset over preventing users from doing silly things.

Jul 6 2015, 2:05 PM · Projects
epriestley added a comment to T8763: Help arcanist keep track of which branch matches which review on Git.

The assumption is that you won't mix history.immutable (which compels arc not to mutate history) with rebasing (which mutates history): if you mutate history, we assume you're comfortable letting arc mutate history too. If you configure it as you have, you're locking us out of both commit messages (which we're forbidden from mutating) and commit/tree hashes (which may change after rebasing), so we don't have much to go on.

Jul 6 2015, 1:51 PM · Arcanist
epriestley added a comment to T8763: Help arcanist keep track of which branch matches which review on Git.

Mmmm, do you mean if I put "Differential Revision: DXXX" as the last line of the first commit of the branch, it'll be seen by arc and any subsequent arc diff will update the right review instead of creating a new one ?

Jul 6 2015, 1:44 PM · Arcanist
epriestley added a comment to T8762: Upgrade process should be more informative when unable to create new databases.

Can you paste the exact error message you received?

Jul 6 2015, 1:22 PM · Setup
epriestley added a comment to T8763: Help arcanist keep track of which branch matches which review on Git.

Use arc which to understand what arc diff will do and why.

Jul 6 2015, 1:21 PM · Arcanist
epriestley added a comment to T8759: Awkward first experience with Spaces.

(The more-correct remedy is likely for the administrator to disable policy.allow-public or set the visibility of at least one space to "Public (No Login Required)" so logged-out users can see some objects.)

Jul 6 2015, 3:55 AM · Spaces
epriestley added a comment to T8759: Awkward first experience with Spaces.

I just visited a site I don't have access to, so it should just say login or sign up.

Jul 6 2015, 3:54 AM · Spaces

Jul 5 2015

epriestley added a comment to T8759: Awkward first experience with Spaces.

Do you have one Space, which is available to "All Users" instead of "Public"?

Jul 5 2015, 7:20 PM · Spaces
epriestley added a comment to T8549: Feedback on 2015 Redesign.

This is now merged to master.

Jul 5 2015, 12:19 PM · Design
epriestley edited the content of Changelog.
Jul 5 2015, 12:14 PM
epriestley closed T8756: Just Test as Resolved.
Jul 5 2015, 11:52 AM
epriestley created 2015 Week 27 (Early July).
Jul 5 2015, 11:51 AM
epriestley added a comment to T8756: Just Test.

You can not delete tasks.

Jul 5 2015, 11:50 AM
epriestley added a comment to T8752: PhabricatorAuthProviderOAuthGoogle and PhabricatorAuthProviderPassword both show Provider Implementation Missing! .

Also note that 20140218.passwords.2.prefix.sql is not idempotent, so re-running it if it already ran could break things.

Jul 5 2015, 11:03 AM · Auth
epriestley added a comment to T8752: PhabricatorAuthProviderOAuthGoogle and PhabricatorAuthProviderPassword both show Provider Implementation Missing! .

The expectation is that 20140722.renameauth.php renamed provider classes, and 20140218.passwords.2.prefix.sql reformatted the passwords.

Jul 5 2015, 11:02 AM · Auth

Jul 4 2015

epriestley added a comment to T4610: Implement robots.txt.

Can you give me an example of the kind of integration you're interested in? For example, what's a good query I can plug into Google or Bing and get a reasonable result in a codebase for?

Jul 4 2015, 11:50 PM
epriestley placed T7343: arc install-certificate doesn't work with bot users up for grabs.
Jul 4 2015, 6:56 PM · Arcanist
epriestley added a comment to T8743: Unable to apply patch 'phabricator:20150116.maniphestapplicationemails.php': Table 'phabricator_spaces.spaces_namespace' doesn't exist.

See "Managing Storage Adjustments" in the documentation, which discusses this under "Troubleshooting":

Jul 4 2015, 10:24 AM · Maniphest

Jul 3 2015

epriestley added a comment to T8685: Move secure.phabriactor.com halfway into the cluster.

I don't want to install it on cluster hosts, see T7785.

Jul 3 2015, 8:41 PM · Ops
epriestley closed T8749: Remove PhabricatorEventType::TYPE_CONTROLLER_CHECKREQUEST as Resolved by committing Restricted Diffusion Commit.
Jul 3 2015, 8:03 PM · Infrastructure
epriestley added a comment to T8746: 20131121.repocredentials.2.mig.php fails.

I believe this should now be fixed in HEAD. Please let us know if you encounter further issues.

Jul 3 2015, 6:00 PM · Setup
epriestley added a comment to T8743: Unable to apply patch 'phabricator:20150116.maniphestapplicationemails.php': Table 'phabricator_spaces.spaces_namespace' doesn't exist.

I believe this should now be fixed in HEAD. Please let us know if you encounter further issues.

Jul 3 2015, 6:00 PM · Maniphest
epriestley closed T8746: 20131121.repocredentials.2.mig.php fails as Resolved by committing Restricted Diffusion Commit.
Jul 3 2015, 5:59 PM · Setup
epriestley closed T8743: Unable to apply patch 'phabricator:20150116.maniphestapplicationemails.php': Table 'phabricator_spaces.spaces_namespace' doesn't exist as Resolved by committing Restricted Diffusion Commit.
Jul 3 2015, 5:59 PM · Maniphest
epriestley added a revision to T8449: Spaces v1 Errata: Unknown Object (Differential Revision).
Jul 3 2015, 5:51 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8749: Remove PhabricatorEventType::TYPE_CONTROLLER_CHECKREQUEST: Unknown Object (Differential Revision).
Jul 3 2015, 5:47 PM · Infrastructure
epriestley added a revision to T8449: Spaces v1 Errata: Unknown Object (Differential Revision).
Jul 3 2015, 5:44 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley created T8749: Remove PhabricatorEventType::TYPE_CONTROLLER_CHECKREQUEST.
Jul 3 2015, 5:40 PM · Infrastructure
epriestley added a comment to T8685: Move secure.phabriactor.com halfway into the cluster.

I decommissioned the old .org host. I'll give the old secure host another week or so since we did hit a couple minor config things where it was useful to double-check that there was a config change.

Jul 3 2015, 5:25 PM · Ops
epriestley closed T8584: Start a numbered list at a given number as Resolved by committing Restricted Diffusion Commit.
Jul 3 2015, 5:19 PM · Phriction
epriestley closed T8748: don't parse differential fields inside of code blocks as Wontfix.
Jul 3 2015, 5:19 PM · Maniphest, Remarkup
epriestley added a revision to T8584: Start a numbered list at a given number: Unknown Object (Differential Revision).
Jul 3 2015, 4:39 PM · Phriction
epriestley added a comment to T8588: One instance has a severe, global performance issue.

If you have a chance, can you pull a Services/Profile on this too? Round trip time on this install is <50ms.

Jul 3 2015, 4:28 PM · Restricted Project
epriestley added a comment to T8593: Allow files to have a description.

If files had a directory structure on top of them instead, would that solve this problem?

Jul 3 2015, 4:26 PM · Restricted Project, Files
epriestley added a comment to T8607: Half-done comments on posted on arc diff.

Can you walk me through this? Why are you updating a revision after marking a bunch of things "Done", but not wanting the "Done" to publish?

Jul 3 2015, 4:26 PM · Restricted Project
epriestley closed T8614: Provide Assistive/Accessible UI options in User Settings as Resolved.

I think this is covered, now?

Jul 3 2015, 4:23 PM · PHUI
epriestley closed T8618: Symbol collision in Diviner publisher as Resolved.

Seems fixed.

Jul 3 2015, 4:22 PM · Diviner
epriestley closed T8631: Straighten out the fetch plan for feed stories as Resolved.

This seems to be stable now, I don't immediately see any more ridiculously dumb slow stuff in the /feed/ profile. Remarkup handle fetches are still a bit loopy but that's a topic for another task.

Jul 3 2015, 4:21 PM · Notifications, Feed, Performance
epriestley triaged T8643: List Bullets Don't Show After Checklist Item as Wishlist priority.
Jul 3 2015, 4:18 PM · Remarkup
epriestley closed T8645: Maniphest tasks title should strip whitespace as Wontfix.

This accurately reflects the user's action. We generally try to faithfully do what the user says, not what we think they mean. It is much more confusing if Phabricator ignores your edit without explanation than if it faithfully reflects an edit exactly as you made it, by accident.

Jul 3 2015, 4:17 PM · Maniphest
epriestley closed T8648: Herald rules block staging repo pushes as Invalid.
IMPORTANT: This feature is new, experimental, and not supported. Use it at your own risk.
Jul 3 2015, 4:12 PM · Diffusion, Herald
epriestley triaged T8650: DifferentialTransactionEditor may race HarbormasterBuildWorker as Low priority.
Jul 3 2015, 4:11 PM · Restricted Project, Harbormaster (v3), Differential
epriestley closed T8730: Special-case text sections with empty headers as Wontfix.

We aren't interested in bringing this upstream.

Jul 3 2015, 3:58 PM · Mail
epriestley merged task T8744: Code coverage reporting broken into T8096: Improve Harbormaster UI/UX (v1).
Jul 3 2015, 3:56 PM · Differential
epriestley merged T8744: Code coverage reporting broken into T8096: Improve Harbormaster UI/UX (v1).
Jul 3 2015, 3:56 PM · Harbormaster
epriestley added a comment to T8738: Allow server administrators to require a minimum version of Arcanist.

I believe there are currently no "bad" versions of arc against HEAD which don't already tell users to upgrade -- some recent versions of arc had issues with recent versions of phabricator, but all recent versions of arc work correctly with HEAD. Although this presumably won't always hold, I think the miss rate here is so low that I can't imagine building anything in advance of the stuff connected to T5055.

Jul 3 2015, 3:55 PM · Arcanist
epriestley updated subscribers of T5055: Distribution mechanism for arc extensions.
Jul 3 2015, 3:52 PM · Arcanist
epriestley merged task T8738: Allow server administrators to require a minimum version of Arcanist into T5055: Distribution mechanism for arc extensions.
Jul 3 2015, 3:52 PM · Arcanist
epriestley closed T8745: Change phabricator.base-uri as Resolved.

There are no other steps to do.

Jul 3 2015, 3:48 PM
epriestley added a revision to T8746: 20131121.repocredentials.2.mig.php fails: Unknown Object (Differential Revision).
Jul 3 2015, 3:47 PM · Setup
epriestley added a revision to T8743: Unable to apply patch 'phabricator:20150116.maniphestapplicationemails.php': Table 'phabricator_spaces.spaces_namespace' doesn't exist: Unknown Object (Differential Revision).
Jul 3 2015, 3:47 PM · Maniphest

Jul 2 2015

epriestley closed T8740: Batch edit Add Project does not perform the action requested as Resolved by committing Restricted Diffusion Commit.
Jul 2 2015, 9:24 PM · Maniphest
epriestley closed T8736: Unit tests failed but not submitted as Resolved by committing Restricted Diffusion Commit.
Jul 2 2015, 9:24 PM · Arcanist
epriestley claimed T8740: Batch edit Add Project does not perform the action requested.
Jul 2 2015, 9:12 PM · Maniphest
epriestley added a revision to T8740: Batch edit Add Project does not perform the action requested: Unknown Object (Differential Revision).
Jul 2 2015, 9:11 PM · Maniphest
epriestley updated subscribers of T7333: Empty commits get same revision as parent.
Jul 2 2015, 9:07 PM · Differential
epriestley merged task T8741: Diffusion lists incorrect revision for commits that are results of a merge with "ours" strategy into T7333: Empty commits get same revision as parent.
Jul 2 2015, 9:07 PM
epriestley added a revision to T8736: Unit tests failed but not submitted: Unknown Object (Differential Revision).
Jul 2 2015, 8:58 PM · Arcanist
epriestley added a comment to T8732: Exception whilst reindexing search documents.

This is probably fixed by rPd5e4d960.

Jul 2 2015, 3:38 PM · Search, Maniphest
epriestley added a comment to T8736: Unit tests failed but not submitted.

Thanks.

Jul 2 2015, 2:24 PM · Arcanist
epriestley added a comment to T8736: Unit tests failed but not submitted.

Does it repro if you upgrade arc past rARC29839e8?

Jul 2 2015, 3:51 AM · Arcanist
epriestley added a comment to T8736: Unit tests failed but not submitted.

What hashes are arcanist and phabricator at?

Jul 2 2015, 3:08 AM · Arcanist
epriestley closed T8735: It would be kind of neat if Differential allowed specifying priority of reviews as Wontfix.

This isn't something we're interested in pursuing in the upstream. You could add a Custom Field for it locally.

Jul 2 2015, 3:08 AM · Differential
epriestley added a comment to T8650: DifferentialTransactionEditor may race HarbormasterBuildWorker.
SELECT CONCAT('D', r.id) FROM differential_revision r
  LEFT JOIN differential_diff d
  ON d.revisionID = r.id
  WHERE d.revisionID IS NULL;
Jul 2 2015, 12:41 AM · Restricted Project, Harbormaster (v3), Differential

Jul 1 2015

epriestley closed T8731: Logged out secure.phabricator.com feed error, a subtask of T8631: Straighten out the fetch plan for feed stories, as Resolved.
Jul 1 2015, 10:07 PM · Notifications, Feed, Performance
epriestley closed T8731: Logged out secure.phabricator.com feed error as Resolved by committing Restricted Diffusion Commit.
Jul 1 2015, 10:07 PM · Projects
epriestley added a revision to T6817: Token given feed entry's target link is not struck through and greyed out when the target is closed: Unknown Object (Differential Revision).
Jul 1 2015, 9:49 PM · Feed, Tokens
epriestley added a revision to T8731: Logged out secure.phabricator.com feed error: Unknown Object (Differential Revision).
Jul 1 2015, 9:49 PM · Projects
epriestley added a comment to T8731: Logged out secure.phabricator.com feed error.

The exception is fixed; there's now a policy/filtering-related hang.

Jul 1 2015, 9:29 PM · Projects
epriestley added a revision to T8731: Logged out secure.phabricator.com feed error: Unknown Object (Differential Revision).
Jul 1 2015, 6:10 PM · Projects
epriestley added a parent task for T8731: Logged out secure.phabricator.com feed error: T8631: Straighten out the fetch plan for feed stories.
Jul 1 2015, 5:53 PM · Projects
epriestley added a subtask for T8631: Straighten out the fetch plan for feed stories: T8731: Logged out secure.phabricator.com feed error.
Jul 1 2015, 5:53 PM · Notifications, Feed, Performance
epriestley claimed T8731: Logged out secure.phabricator.com feed error.

Here's the trace. I don't think this is a dupe.

Jul 1 2015, 5:39 PM · Projects
epriestley added a comment to T8709: arc diff: option to just add Differential ref to commit message (middle ground between mutable and immutable workflows).

I don’t want to change my project’s established conventions and clutter my git logs because arc wants to scatter droppings all over my commit messages.

Jul 1 2015, 5:36 PM · Arcanist
Robmaister awarded T3980: Support "Bind to External Thing" to define project membership a Like token.
Jul 1 2015, 5:21 PM · Restricted Project, Restricted Project, KDE, Restricted Project, FreeBSD, Wikimedia, Projects
benjumanji awarded T8549: Feedback on 2015 Redesign a Love token.
Jul 1 2015, 4:37 PM · Design
epriestley added a revision to T8726: Modularize Herald fields and actions: Unknown Object (Differential Revision).
Jul 1 2015, 3:31 PM · Herald
epriestley added a comment to T8709: arc diff: option to just add Differential ref to commit message (middle ground between mutable and immutable workflows).

do not necessarily reflect reality by the time it actually gets committed.

Jul 1 2015, 3:23 PM · Arcanist
epriestley added a comment to T8709: arc diff: option to just add Differential ref to commit message (middle ground between mutable and immutable workflows).

For example, the project might handle testing differently, and not want the ‘Test Plan’ section.

Jul 1 2015, 3:10 PM · Arcanist
epriestley added a revision to T8726: Modularize Herald fields and actions: Unknown Object (Differential Revision).
Jul 1 2015, 3:05 PM · Herald
epriestley added a comment to T8729: Removing a Diviner book does not delete the documentation.

This behavior seems fairly expected/reasonable to me.

Jul 1 2015, 2:00 PM · Diviner
epriestley closed T8714: Obscure error when a UnitEngine returns wrong result type as Resolved by committing Restricted Diffusion Commit.
Jul 1 2015, 11:48 AM · Unit, Arcanist
epriestley added a comment to T1837: Implement correct send-as-user behavior..

This is a very low priority for the upstream.

Jul 1 2015, 11:34 AM · llvm, Restricted Project, Mail
epriestley added a comment to T1735: Improve implementation of "Re:" prefix by dropping it from messages which are unambiguously first-in-thread.

Please see Planning and Contributing Code. See also T8227.

Jul 1 2015, 11:32 AM · llvm, Restricted Project, Mail