@chad, did you wontfix this for any particular reason? It does look like a bug to me.

We go down a separate rendering pathway for this (not PhabricatorObjectHandle->renderLink() to add target="_top" for old /feed/public/ iframed feeds, but most stories don't do this and no one has complained, and the old "public feed" stuff should probably be removed (maybe it was already removed?) -- in the long run, that kind of thing should probably be API-driven.

(This actual issue is trivial, but the separate rendering pathway is somewhat likely to cause other problems in the future and I think we don't need it anymore.)

Haha, no problem. As best I can tell, the backstory was something like this:

• Long before policies, we added feed.public to let you create a (policy-bypassing) public view of every feed story, at /feed/public/. The expectation is that you could <iframe ...> this to include it elsewhere, and we embedded it on phabricator.org for a while (I think).
• Links in the iframe didn't have target="_top", so they'd open in the iframe, rather than redirecting the top-level page. So you'd get a task page inside a tiny iframe or whatever.
• We added a separate (non-Handle) rendering pathway for these links to add target="_top" to fix this issue.

But then:

• We implemented policies, including the "public" policy, which are at odds with a "view every story" feed.
  • I'd like to remove this option/interface, at least eventually. I think it sees very little use today.
• We made the Handle rendering pathway do more stuff (like strikethrough) for some handles.

So I think the fix is:

• Deprecate/remove the "public" feed mode (not sure if we can just nuke the whole thing, or if we need to improve the API first).
  • The fact that this is broken for most stories (no "_top", so almost all stories have busted/nonfunctional links) and no one has complained implies we might be able to just remove it.
• Make this code just use the standard rendering pathway (PhabricatorFeedStory->linkTo()).
• Converting Token feed stories into Transaction stories might effectively do this anyway, and give us less code overall.