Page MenuHomePhabricator
Create Task
Maniphest T8736

Unit tests failed but not submitted
Closed, ResolvedPublic
Actions

Assigned To
epriestley
Authored By
hach-que
Jul 2 2015, 2:10 AM
Tags
Referenced Files
F576444: pasted_file
Jul 2 2015, 2:10 AM
F576446: pasted_file
Jul 2 2015, 2:10 AM
F576448: pasted_file
Jul 2 2015, 2:10 AM
Subscribers
hach-que

Description

This issue is pretty bad. Basically a diff gets submitted and ends up like this:

pasted_file (188×596 px, 25 KB)

Clicking on "View Full Results" shows an empty table:

pasted_file (228×1 px, 33 KB)

Harbormaster shows that it is still waiting for the Arcanist unit test results:

pasted_file (560×764 px, 54 KB)

Revisions and Commits

rP Phabricator
D13531rP9623f9b5cf8a Allow unit test duration to be submitted as a float or an int

Related Objects

Event Timeline

hach-que created this task.Jul 2 2015, 2:10 AM
hach-que assigned this task to epriestley.
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a project: Arcanist.
hach-que added a subscriber: hach-que.
epriestley added a comment.Jul 2 2015, 3:08 AM

What hashes are arcanist and phabricator at?

hach-que added a comment.Jul 2 2015, 3:14 AM

On the server:

phabricator is at 28e0af5 + patches
arcanist is at b697a3b

epriestley added a comment.Jul 2 2015, 3:51 AM

Does it repro if you upgrade arc past rARC29839e8?

hach-que added a comment.Jul 2 2015, 5:07 AM

Upgrading server version of Arcanist didn't fix it; waiting to hear back from users whether or not upgrading client Arcanist fixes it.

hach-que added a comment.Jul 2 2015, 5:12 AM

User got this:

←[42m←[1m STAGING PUSHED ←[m←[49m Pushed a copy of the changes to tag "phabricator/diff/174179" in the staging area.
[2015-07-02 05:10:06] EXCEPTION: (ConduitClientException) ERR-CONDUIT-CORE: Parameter 'duration' has invalid type. Expected type 'optional float', got type 'int'. at [<phutil>\src\conduit\ConduitFuture.php:58]
arcanist(head=master, ref.master=d54cb072facd), pageupclient(), phutil(head=master, ref.master=462671e62909)
  #0 <#2> ConduitFuture::didReceiveResult(array) called at [<phutil>\src\future\FutureProxy.php:58]
  #1 <#2> FutureProxy::getResult() called at [<phutil>\src\future\FutureProxy.php:35]
  #2 <#2> FutureProxy::resolve() called at [<arcanist>\src\workflow\ArcanistDiffWorkflow.php:2786]
  #3 phlog(ConduitClientException) called at [<arcanist>\src\workflow\ArcanistDiffWorkflow.php:2792]
  #4 ArcanistDiffWorkflow::updateAutotargets(string, integer) called at [<arcanist>\src\workflow\ArcanistDiffWorkflow.php:530]
  #5 ArcanistDiffWorkflow::run() called at [<arcanist>\scripts\arcanist.php:382]
Updated an existing Differential revision:
epriestley added a comment.Jul 2 2015, 2:24 PM

Thanks.

epriestley added a revision: D13531: Allow unit test duration to be submitted as a float or an int.Jul 2 2015, 8:58 PM
epriestley closed this task as Resolved by committing rP9623f9b5cf8a: Allow unit test duration to be submitted as a float or an int.Jul 2 2015, 9:24 PM
epriestley added a commit: rP9623f9b5cf8a: Allow unit test duration to be submitted as a float or an int.
Phabricator · Built by Phacility