Page MenuHomePhabricator

Special-case text sections with empty headers
Closed, WontfixPublic

Description

One of the main customization points we have is the look and feel of emails. I can mostly get what I need by adding translations for the pht() texts for the headers. The main problem is that we do not want headers for many things (like the summary, the link to the differential patch, or the inline comments).
When I add a mapping from {"header-text": ""} the outcome looks weird though - it will feature an extra empty line, and then the indented section.
This seems to be solvable by special-casing text sections, so that if they have an empty header, it will just insert the unindented section text.
Would that have a chance of upstreaming or do you think this is not universally useful enough? Thanks!

Event Timeline

klimek raised the priority of this task from to Needs Triage.
klimek updated the task description. (Show Details)
klimek added a subscriber: eadler.
klimek added a subscriber: klimek.
epriestley claimed this task.
epriestley added a subscriber: epriestley.

We aren't interested in bringing this upstream.