Maniphest T8749

Remove PhabricatorEventType::TYPE_CONTROLLER_CHECKREQUEST
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	epriestley
	Jul 3 2015, 5:40 PM

Tags

Referenced Files

None

Subscribers

Description

We are removing the PhabricatorEventType::TYPE_CONTROLLER_CHECKREQUEST event.

This event was implemented in D2488 to provide some sort of unspecified "checking" of requests (IP-based?), but I believe no install other than Facebook has ever had a use case for it.

In modern Phabricator, the "Preamble Script" can perform this class of checks more broadly, and is required for other request adjustments (header fiddling, HTTPS tweaks):

https://secure.phabricator.com/book/phabricator/article/configuring_preamble/

Revisions and Commits

rP Phabricator
	D13546	rPbcfbc5cfbf27 Remove CHECKREQUEST event

Related Objects

Mentioned In: 2015 Week 27 (Early July)

Event Timeline

epriestley created this task.Jul 3 2015, 5:40 PM

epriestley raised the priority of this task from to Normal.

epriestley updated the task description. (Show Details)

epriestley added a project: Infrastructure.

epriestley added subscribers: epriestley, facebook-poc.

epriestley added a revision: D13546: Remove CHECKREQUEST event.Jul 3 2015, 5:47 PM

epriestley closed this task as Resolved by committing rPbcfbc5cfbf27: Remove CHECKREQUEST event.Jul 3 2015, 8:03 PM

epriestley added a commit: rPbcfbc5cfbf27: Remove CHECKREQUEST event.

epriestley mentioned this in 2015 Week 27 (Early July).Jul 5 2015, 11:51 AM