Page MenuHomePhabricator
Create Task
Maniphest T8749

Remove PhabricatorEventType::TYPE_CONTROLLER_CHECKREQUEST
Closed, ResolvedPublic
Actions

Description

We are removing the PhabricatorEventType::TYPE_CONTROLLER_CHECKREQUEST event.

This event was implemented in D2488 to provide some sort of unspecified "checking" of requests (IP-based?), but I believe no install other than Facebook has ever had a use case for it.

In modern Phabricator, the "Preamble Script" can perform this class of checks more broadly, and is required for other request adjustments (header fiddling, HTTPS tweaks):

https://secure.phabricator.com/book/phabricator/article/configuring_preamble/

Revisions and Commits

Restricted Differential RevisionRestricted Diffusion Commit

Related Objects

Event Timeline

epriestley created this task.Jul 3 2015, 5:40 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Infrastructure.
epriestley added subscribers: epriestley, facebook-poc.
epriestley added a revision: Restricted Differential Revision.Jul 3 2015, 5:47 PM
epriestley closed this task as Resolved by committing Restricted Diffusion Commit.Jul 3 2015, 8:03 PM
epriestley added a commit: Restricted Diffusion Commit.
epriestley mentioned this in 2015 Week 27 (Early July).Jul 5 2015, 11:51 AM
Phabricator · Built by Phacility