Page MenuHomePhabricator
Feed Advanced Search

Jun 21 2015

epriestley added a comment to T8442: Build Space switching UI.

In the newer design, the space name has a red callout so it should be pretty hard to miss. Here's an example on the detail view:

Jun 21 2015, 2:30 PM · Restricted Project, Spaces, Wikimedia, Policy
epriestley added a comment to T6787: Clarify UI for Objects with a non-default Policy.

I think this is a change we should probably pursue, and start with a color treatment as in T6787#88172. There are several technical challenges:

Jun 21 2015, 2:20 PM · Design, Policy, Wikimedia
epriestley added a subtask for T6787: Clarify UI for Objects with a non-default Policy: T6860: Allow creation of parameterized application policies.
Jun 21 2015, 2:05 PM · Design, Policy, Wikimedia
epriestley added a parent task for T6860: Allow creation of parameterized application policies: T6787: Clarify UI for Objects with a non-default Policy.
Jun 21 2015, 2:05 PM · Policy
epriestley closed T8498: Integrate Spaces into shared infrastructure as Resolved.

The clearly-desirable integrations now work. I want to wait for use cases for the others; they likely aren't technically hard, but are potentially bad/confusing/ambiguous.

Jun 21 2015, 2:04 PM · FreeBSD, Spaces, Wikimedia, Policy, Prioritized
epriestley closed T8498: Integrate Spaces into shared infrastructure, a subtask of T8376: Develop Spaces (v1), as Resolved.
Jun 21 2015, 2:03 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley closed T7447: Bring inline comments forward across revision updates as Resolved.

I'm going to close this since we seem to have made it to a state that no one hates too much. There are some followups in T8420 and T7870, and we'll adjust the UI a bit more and bring hiding to Diffusion in the future.

Jun 21 2015, 2:01 PM · Prioritized, Differential
epriestley removed a project from T7870: List of cases where ghost comments end up somewhere confusing or unexpected: Prioritized.
Jun 21 2015, 1:58 PM · Inline Comments, Restricted Project, Differential
epriestley added a comment to T8089: Unprototype Harbormaster (v1).

Development Log

Jun 21 2015, 1:58 PM · Prioritized, Harbormaster
epriestley added a comment to T8376: Develop Spaces (v1).

The "strongest policy" thing landed a few days ago and can be seen on T8514, for example (policy hint says "Space Test Users" even though the object policy is weaker, and clicking it explains why, although on the redesign the dialog formatting is a little messy). I think this is a pretty reasonable approach that adds clarity without being less powerful, but let me know how it feels. There's also a stronger color for the space name in headers now in the redesign. That's still in flux, but feels pretty good to me.

Jun 21 2015, 1:53 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley closed T8617: Write a guide for performance troubleshooting as Resolved.
Jun 21 2015, 1:11 PM · Performance, Documentation
epriestley added a comment to T7664: Moving a task on a workboard is very slow (and sometimes times out with a fatal error).

A broad guide for this stuff is available here now:

Jun 21 2015, 1:10 PM · Restricted Project, Workboards
epriestley added a revision to T8615: Write a guide for troubleshooting repository imports: Unknown Object (Differential Revision).
Jun 21 2015, 12:53 PM · Diffusion, Documentation
epriestley renamed T8632: warrrgbrlmblmblblblr from 72ss6vfcla6zxibvgsqcleid46ptw76igvh2ntkpjc6tsfrrmxdijhmbboq3mc3d4cw6bmqgbmhow5aek27dfney4lcbrueplcvrfyo4en3vr3tt2swho5igra3c3cshxyne4cs2vgkfyl5uab3coc2inzxjv7xkuhfcv6fyptc5hxudseiklfoummqqhtpuvcesxzefdwwqattskgymyl6f6bvxdvwo6plmtljm6trewfjawpu6pvpttaq3qib 72ss6vfcla6zxibvgsqcleid46ptw76igvh2ntkpjc6tsfrrmxdijhmbboq3mc3d4cw6bmqgbmhow5aek27dfney4lcbrueplcvrfyo4en3vr3tt2swho5igra3c3cshxyne4cs2vgkfyl5uab3coc2inzxjv7xkuhfcv6fyptc5hxudseiklfoummqqhtpuvcesxzefdwwqattskgymyl6f6bvxdvwo6plmtljm6trewfjawpu6pvpttaq3qib to warrrgbrlmblmblblblr.
Jun 21 2015, 11:48 AM
epriestley closed T8632: warrrgbrlmblmblblblr as Spite.

no thanks

Jun 21 2015, 11:47 AM
epriestley added a comment to T8549: Feedback on 2015 Redesign.

I don't think applications can ever show as feed actors today, although I'm not 100% sure about that.

Jun 21 2015, 11:46 AM · Design
epriestley added a comment to T8549: Feedback on 2015 Redesign.

For application actors, like Herald, we don't have a profile icon when they create feed stories:

Jun 21 2015, 11:38 AM · Design
epriestley created T8631: Straighten out the fetch plan for feed stories.
Jun 21 2015, 11:31 AM · Notifications, Feed, Performance
epriestley added a subtask for T8630: Prompt users when they login with an account that has changed email addresses: T8629: Create some kind of queue of profile/settings action items for users.
Jun 21 2015, 11:15 AM · Restricted Project, Auth
epriestley added a parent task for T8629: Create some kind of queue of profile/settings action items for users: T8630: Prompt users when they login with an account that has changed email addresses.
Jun 21 2015, 11:15 AM · Restricted Project, People
epriestley created T8630: Prompt users when they login with an account that has changed email addresses.
Jun 21 2015, 11:15 AM · Restricted Project, Auth
epriestley added a subtask for T4104: Implement "suggest profile edit" for recommending profile pictures, phone numbers, etc., to users: T8629: Create some kind of queue of profile/settings action items for users.
Jun 21 2015, 11:13 AM · Profile
epriestley added a parent task for T8629: Create some kind of queue of profile/settings action items for users: T4104: Implement "suggest profile edit" for recommending profile pictures, phone numbers, etc., to users.
Jun 21 2015, 11:13 AM · Restricted Project, People
epriestley created T8629: Create some kind of queue of profile/settings action items for users.
Jun 21 2015, 11:13 AM · Restricted Project, People
witrin awarded T8549: Feedback on 2015 Redesign a Like token.
Jun 21 2015, 12:58 AM · Design

Jun 20 2015

epriestley added a comment to T7950: Support Projects in Calendar.

This might not be fully correct, but it should get you a little further:

Jun 20 2015, 5:05 PM · Calendar
epriestley closed T8340: Make pretty feed titles for recurring event edits as Resolved by committing Restricted Diffusion Commit.
Jun 20 2015, 4:45 PM · Calendar
epriestley edited the content of Changelog.
Jun 20 2015, 2:15 PM
epriestley created 2015 Week 25 (Late June).
Jun 20 2015, 2:15 PM
epriestley created T8623: Upgrading: Differential Hunk Migration.
Jun 20 2015, 1:53 PM · Installing & Upgrading, Differential, Guides
epriestley added a comment to T8549: Feedback on 2015 Redesign.

After D13363, you can now select "Use High Contrast Colors" in Settings → Display Preferences → Accessibility. It currently looks like this:

Jun 20 2015, 1:26 PM · Design
epriestley closed T6839: Add a `repository reparse --importing X` mode as Resolved by committing Restricted Diffusion Commit.
Jun 20 2015, 12:25 PM · Diffusion
epriestley closed T6839: Add a `repository reparse --importing X` mode, a subtask of T8615: Write a guide for troubleshooting repository imports, as Resolved.
Jun 20 2015, 12:25 PM · Diffusion, Documentation
epriestley closed T8616: Write a guide for translatable strings as Resolved by committing Restricted Diffusion Commit.
Jun 20 2015, 12:25 PM · Documentation, Localization
epriestley added a comment to T8420: Hidden inlines don't work properly with anchor-based navigation.

I didn't really implement anchor integration properly because I wasn't sure that hiding was going to stick, but I think hiding is pretty good.

Jun 20 2015, 12:16 PM · Inline Comments, Restricted Project, Differential
epriestley renamed T8420: Hidden inlines don't work properly with anchor-based navigation from Hiding comments breaks inline comment navigation to Hidden inlines don't work properly with anchor-based navigation.
Jun 20 2015, 12:15 PM · Inline Comments, Restricted Project, Differential
epriestley merged T8622: Links to inline comments on older diffs are not working into T8420: Hidden inlines don't work properly with anchor-based navigation.
Jun 20 2015, 12:14 PM · Inline Comments, Restricted Project, Differential
epriestley merged task T8622: Links to inline comments on older diffs are not working into T8420: Hidden inlines don't work properly with anchor-based navigation.
Jun 20 2015, 12:14 PM · Differential

Jun 19 2015

tycho.tatitscheff awarded T8549: Feedback on 2015 Redesign a Love token.
Jun 19 2015, 9:49 PM · Design
epriestley added a revision to T6839: Add a `repository reparse --importing X` mode: Unknown Object (Differential Revision).
Jun 19 2015, 9:24 PM · Diffusion
epriestley added a comment to T8549: Feedback on 2015 Redesign.

Alright. I think that probably falls under T8614 more than being a core design constraint. We can do resource post-processors + more variables with relative ease for users with substantially different visual constraints, at some point in the future, but given that huge swaths of the internet are problematic for your particular constraint I don't think we should design around it for the majority of the userbase, for whom black text on a white background is easy to read.

Jun 19 2015, 9:14 PM · Design
epriestley added a comment to T8620: support landing from a detached head in git.

I use a stacked diff workflow without detaching heads. Can you walk me through your workflow in a little more detail?

Jun 19 2015, 9:08 PM · Arcanist
epriestley added a comment to T8549: Feedback on 2015 Redesign.

Do you have difficulty reading Wikipedia, NYTimes, etc? Other major web properties which primarily present large blocks of text in black on white backgrounds?

Jun 19 2015, 9:03 PM · Design
epriestley added a comment to T8549: Feedback on 2015 Redesign.

@CodeMouse92, I'm really confused about your feedback. Almost all of the text was on pure white in the old design, too. Here's a screenshot of the old design: all the text is black on white:

Jun 19 2015, 9:00 PM · Design
epriestley added a revision to T8617: Write a guide for performance troubleshooting: Unknown Object (Differential Revision).
Jun 19 2015, 7:10 PM · Performance, Documentation
epriestley added a comment to T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)".

"Making the effects ... more reversible" is the same as "deleting, disabling or hiding workboards"; they are not separate tasks.

Jun 19 2015, 6:17 PM · Projects, Wikimedia, Workboards
epriestley added a revision to T8616: Write a guide for translatable strings: Unknown Object (Differential Revision).
Jun 19 2015, 4:56 PM · Documentation, Localization
epriestley added a comment to T8619: Unable to get phabricator to send mail (except ./bin/mail send-test).

Can you show me the output of this command, when run from the server Phabricator is installed on?

Jun 19 2015, 4:37 PM
epriestley added a comment to T8618: Symbol collision in Diviner publisher.

@joshuaspence, pretty sure that's the right fix but yell if it looks suspicious?

Jun 19 2015, 4:04 PM · Diviner
epriestley added a comment to T8618: Symbol collision in Diviner publisher.

Hitting this locally too, and using --clean may have been inadvisable since it nuked all the docs.

Jun 19 2015, 3:55 PM · Diviner
epriestley claimed T8618: Symbol collision in Diviner publisher.
Jun 19 2015, 3:54 PM · Diviner
epriestley added a comment to T8549: Feedback on 2015 Redesign.

I merged/updated and now new 100x100 profile pictures look like background-size isn't being applied correctly:

Jun 19 2015, 3:42 PM · Design
epriestley added a comment to T8618: Symbol collision in Diviner publisher.

(Similar trace with --clean.)

Jun 19 2015, 3:41 PM · Diviner
epriestley created T8618: Symbol collision in Diviner publisher.
Jun 19 2015, 3:36 PM · Diviner
epriestley closed T8032: Calendar description should render with Remarkup as Resolved by committing Restricted Diffusion Commit.
Jun 19 2015, 3:33 PM · Calendar
epriestley closed T8032: Calendar description should render with Remarkup, a subtask of T7925: Calendar v1 Errata, as Resolved.
Jun 19 2015, 3:33 PM · Calendar
epriestley added a comment to T8549: Feedback on 2015 Redesign.

After using this for a while, I also find the UI very "bright", or I'd specifically say "unsaturated", or "washed-out" or "muted". Nothing is hard to read and the text contrast is great, the overall feeling of the UI for me is that all of the backgrounds and borders have the minimum level of saturation and contrast to be clear.

Jun 19 2015, 3:27 PM · Design
epriestley claimed T8615: Write a guide for troubleshooting repository imports.
Jun 19 2015, 12:59 PM · Diffusion, Documentation
epriestley claimed T8616: Write a guide for translatable strings.
Jun 19 2015, 12:59 PM · Documentation, Localization
epriestley created T8617: Write a guide for performance troubleshooting.
Jun 19 2015, 12:59 PM · Performance, Documentation
epriestley added a project to T8615: Write a guide for troubleshooting repository imports: Diffusion.
Jun 19 2015, 12:58 PM · Diffusion, Documentation
epriestley created T8616: Write a guide for translatable strings.
Jun 19 2015, 12:57 PM · Documentation, Localization
epriestley added a subtask for T8615: Write a guide for troubleshooting repository imports: T6839: Add a `repository reparse --importing X` mode.
Jun 19 2015, 12:55 PM · Diffusion, Documentation
epriestley added a parent task for T6839: Add a `repository reparse --importing X` mode: T8615: Write a guide for troubleshooting repository imports.
Jun 19 2015, 12:55 PM · Diffusion
epriestley created T8615: Write a guide for troubleshooting repository imports.
Jun 19 2015, 12:55 PM · Diffusion, Documentation
epriestley added a comment to T8427: Make owners typeahead browsable so installs can have more than 100 packages.

I think this is fixed now, but let me know if it's still acting up.

Jun 19 2015, 12:17 AM · Owners
epriestley closed T8427: Make owners typeahead browsable so installs can have more than 100 packages, a subtask of T8320: Bring Owners out of the dark ages, as Resolved.
Jun 19 2015, 12:16 AM · Prioritized, Owners
epriestley closed T8427: Make owners typeahead browsable so installs can have more than 100 packages as Resolved by committing Restricted Diffusion Commit.
Jun 19 2015, 12:16 AM · Owners

Jun 18 2015

epriestley added a revision to T8427: Make owners typeahead browsable so installs can have more than 100 packages: Unknown Object (Differential Revision).
Jun 18 2015, 10:14 PM · Owners
epriestley added a revision to T8320: Bring Owners out of the dark ages: Unknown Object (Differential Revision).
Jun 18 2015, 10:14 PM · Prioritized, Owners
epriestley closed T8601: Fatal when viewing Calendar application on this instance as Resolved by committing Restricted Diffusion Commit.
Jun 18 2015, 10:11 PM · Calendar
staticshock awarded T8549: Feedback on 2015 Redesign a Doubloon token.
Jun 18 2015, 8:44 PM · Design
epriestley closed T8609: Test TAsk as Resolved.

It worked!

Jun 18 2015, 8:35 PM
epriestley added a project to T5031: Draft Comment Persists After Submission: Restricted Project.
Jun 18 2015, 8:28 PM · Restricted Project, Support Impact, Mobile
epriestley updated subscribers of T5031: Draft Comment Persists After Submission.
Jun 18 2015, 8:28 PM · Restricted Project, Support Impact, Mobile
epriestley merged task T8608: Diff-level comment not cleared from input box after posting into T5031: Draft Comment Persists After Submission.
Jun 18 2015, 8:28 PM · Restricted Project
epriestley moved T8033: Inform editor when panels have more restrictive policy than dashboard from Lyuba to Backlog on the Dashboards board.
Jun 18 2015, 8:26 PM · Dashboards
epriestley added a comment to T4213: Provide custom themes, skinning, or custom CSS.

@paladox, please read the description carefully. The images are helping support the main point of the section, which is that Phabricator changes very quickly. Having old images which are very different from the modern UI helps reinforce this point.

Jun 18 2015, 8:25 PM · Design
epriestley updated the task description for T4213: Provide custom themes, skinning, or custom CSS.
Jun 18 2015, 8:23 PM · Design
epriestley merged T8606: Support customised skins and logo into T4213: Provide custom themes, skinning, or custom CSS.
Jun 18 2015, 8:18 PM · Design
epriestley merged task T8606: Support customised skins and logo into T4213: Provide custom themes, skinning, or custom CSS.
Jun 18 2015, 8:18 PM · Design
epriestley added a comment to T8597: PDF fails to display for download.

I think this is now fixed (in the sense of "not broken anymore", not in the sense of "working as nicely as it possibly could"). Let me know if that's not the case.

Jun 18 2015, 8:06 PM · Diffusion
epriestley closed T8597: PDF fails to display for download as Resolved by committing Restricted Diffusion Commit.
Jun 18 2015, 8:06 PM · Diffusion
epriestley closed T8603: repository.query is not returning required parameter `order` as Resolved by committing Restricted Diffusion Commit.
Jun 18 2015, 8:05 PM · Disqus, Conduit
epriestley added a comment to T4474: Improve Diffusion behavior for large files and changesets.

See also T8597. Two specific areas for improvement:

Jun 18 2015, 8:05 PM · Restricted Project, Diffusion
epriestley added a comment to T8597: PDF fails to display for download.

Two fixes here:

Jun 18 2015, 8:01 PM · Diffusion
epriestley added a revision to T8597: PDF fails to display for download: Unknown Object (Differential Revision).
Jun 18 2015, 7:53 PM · Diffusion
epriestley added a revision to T8597: PDF fails to display for download: Unknown Object (Differential Revision).
Jun 18 2015, 7:23 PM · Diffusion
epriestley added a revision to T8601: Fatal when viewing Calendar application on this instance: Unknown Object (Differential Revision).
Jun 18 2015, 7:14 PM · Calendar
epriestley claimed T8601: Fatal when viewing Calendar application on this instance.
Jun 18 2015, 7:10 PM · Calendar
epriestley added a comment to T8549: Feedback on 2015 Redesign.

To echo @chad's comments, we really want to drive accessibility changes by understanding problems and then solving them, just like we drive all other product changes.

Jun 18 2015, 7:05 PM · Design
epriestley added a revision to T8095: Let Harbormaster own Lint and Unit results: Unknown Object (Differential Revision).
Jun 18 2015, 6:02 PM · Harbormaster
epriestley added a revision to T8095: Let Harbormaster own Lint and Unit results: Unknown Object (Differential Revision).
Jun 18 2015, 5:33 PM · Harbormaster
epriestley added a revision to T8603: repository.query is not returning required parameter `order`: Restricted Differential Revision.
Jun 18 2015, 4:21 PM · Disqus, Conduit
epriestley added a comment to T8603: repository.query is not returning required parameter `order`.

yeah that does not make sense and would cause nothing to work I'm pretty sure

Jun 18 2015, 4:19 PM · Disqus, Conduit
epriestley added a comment to T8603: repository.query is not returning required parameter `order`.

This parameter is not required, although the hint should probably say "optional order".

Jun 18 2015, 4:00 PM · Disqus, Conduit
epriestley assigned T8601: Fatal when viewing Calendar application on this instance to lpriestley.

I have a repro for this if you don't.

Jun 18 2015, 1:04 PM · Calendar
epriestley added a comment to T8597: PDF fails to display for download.

Can you do this to get a stack trace?

Jun 18 2015, 2:17 AM · Diffusion
tiguchi awarded T7950: Support Projects in Calendar a Like token.
Jun 18 2015, 12:52 AM · Calendar

Jun 17 2015

sectioneight awarded T8549: Feedback on 2015 Redesign a Pterodactyl token.
Jun 17 2015, 8:42 PM · Design