Page MenuHomePhabricator
Feed Advanced Search

May 6 2015

joshuaspence added a subtask for T7604: Remove "Arcanist Projects": T7977: Associate Symbols with Repositories directly (Instead of arc projects).
May 6 2015, 11:00 AM · Diffusion
joshuaspence added a subtask for T7603: Remove the deprecated "Repositories" application: T7604: Remove "Arcanist Projects".
May 6 2015, 11:00 AM · Repositories, Diffusion
joshuaspence added a parent task for T7604: Remove "Arcanist Projects": T7603: Remove the deprecated "Repositories" application.
May 6 2015, 11:00 AM · Diffusion
nj2408zjw created T8086: Server certificate verification failed: certificate issued for a different hostname, issuer is not trusted.
May 6 2015, 7:02 AM · Diffusion, Subversion

May 5 2015

nj2408zjw added a comment to T7471: Unable to connect to SVN repo with invalid SSL cert.
In T7471#100638, @zzh wrote:

And the Subversion server is install over other machine, I'm not the administrator

May 5 2015, 9:05 AM · Subversion, Diffusion

May 4 2015

bblough added a comment to T4284: Temporary files are not removed when PHP double-fatals (e.g., method call on NULL).

I'm seeing this on the current version in my environment also. As oyvindselbek mentioned, everything seems to be working (updates are happening) except for the cleanup of the temp files.

May 4 2015, 7:34 PM · Diffusion, Passphrase
ftdysa added a comment to T8002: Diffusion "Locate File" typeahead silently failing.

And further, it seems to work fine as the web user.

May 4 2015, 3:31 PM · Diffusion
ftdysa added a comment to T8002: Diffusion "Locate File" typeahead silently failing.

Ok, I'll see if I can get a test case with LinesOfALargeExecFuture that reproduces it.

May 4 2015, 3:13 PM · Diffusion
epriestley added a comment to T8002: Diffusion "Locate File" typeahead silently failing.

Hmm, I'm not sure then. It doesn't look like it's producing that much output, either ("... (10,110 more bytes) ..."), so I can't imagine it's any sort of resource exhaustion or OOM-killer kind of issue.

May 4 2015, 3:04 PM · Diffusion
ftdysa added a comment to T8002: Diffusion "Locate File" typeahead silently failing.

Seems to work fine.

May 4 2015, 3:03 PM · Diffusion
devurandom added a comment to T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.

Seems to work here: rHGTEST0e1f30ecdecaf66a3da45a62b7c6af3ad7c5515a

May 4 2015, 2:54 PM · Diffusion (v3)
epriestley added a comment to T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.

I think the HGTEST repo works now.

May 4 2015, 2:15 PM · Diffusion (v3)
epriestley closed T6516: Diffusion pings accidentally tasks because the same task numbers are mentioned in cloned commit messages as Resolved.

I think this is fixed now. In particular, the behavior today would be:

May 4 2015, 2:13 PM · Wikimedia, Diffusion

May 3 2015

epriestley added a comment to T8002: Diffusion "Locate File" typeahead silently failing.

Does this command work properly when run from /var/repo/XYZ, where 'XYZ' is the repository callsign?

May 3 2015, 11:18 PM · Diffusion
joshuaspence claimed T7603: Remove the deprecated "Repositories" application.
May 3 2015, 9:51 PM · Repositories, Diffusion
joshuaspence claimed T7604: Remove "Arcanist Projects".
May 3 2015, 9:51 PM · Diffusion
joshuaspence closed T7220: Repository without Arcanist project fails for symbols import as Resolved by committing Restricted Diffusion Commit.
May 3 2015, 3:23 AM · Diffusion

May 2 2015

joshuaspence added a comment to T1751: Consider ways to improve revert handling.

One possibility here is to reopen a Maniphest task if a "fixes" commit is reverted. I'm not sure whether this behavior is desirable.

May 2 2015, 5:01 AM · Restricted Project, Differential, Diffusion
joshuaspence added a revision to T1751: Consider ways to improve revert handling: Restricted Differential Revision.
May 2 2015, 4:26 AM · Restricted Project, Differential, Diffusion

May 1 2015

joshuaspence merged T6888: Extending revert edges into T1751: Consider ways to improve revert handling.
May 1 2015, 8:02 AM · Restricted Project, Differential, Diffusion
joshuaspence added a comment to T8007: Commit was associated with unrelated diff.

There is no relevant "explain why" link because there is no transaction for someone added a commit: rPPfd5a74ad3fa1 on D19839 or someone added a differential revision: D19839 on rPPfd5a74ad3fa1.

May 1 2015, 12:04 AM · Differential, Diffusion

Apr 30 2015

epriestley added a comment to T8007: Commit was associated with unrelated diff.

Does clicking "Explain Why" explain why?

Apr 30 2015, 11:36 PM · Differential, Diffusion
joshuaspence created T8007: Commit was associated with unrelated diff.
Apr 30 2015, 11:34 PM · Differential, Diffusion
joshuaspence added a revision to T1751: Consider ways to improve revert handling: Restricted Differential Revision.
Apr 30 2015, 9:56 PM · Restricted Project, Differential, Diffusion
ftdysa created T8002: Diffusion "Locate File" typeahead silently failing.
Apr 30 2015, 1:13 PM · Diffusion

Apr 29 2015

epriestley closed T7982: DiffusionLowLevelResolveRefsQuery incorrectly identifies branch refs as commit refs as Resolved by committing Restricted Diffusion Commit.
Apr 29 2015, 8:21 PM · Diffusion
epriestley added a revision to T7982: DiffusionLowLevelResolveRefsQuery incorrectly identifies branch refs as commit refs: Restricted Differential Revision.
Apr 29 2015, 3:17 PM · Diffusion
epriestley claimed T7982: DiffusionLowLevelResolveRefsQuery incorrectly identifies branch refs as commit refs.
Apr 29 2015, 2:04 PM · Diffusion
joshuaspence added a revision to T7220: Repository without Arcanist project fails for symbols import: Restricted Differential Revision.
Apr 29 2015, 1:55 PM · Diffusion
epriestley created T7982: DiffusionLowLevelResolveRefsQuery incorrectly identifies branch refs as commit refs.
Apr 29 2015, 1:39 PM · Diffusion

Apr 28 2015

cspeckmim added a comment to T7972: Starting with 7f43cde, DiffusionRequest resolveRefs fails (only cached entries work).

After updating yesterday to check out changes with T7100, we started seeing this issue when creating a new hosted mercurial repository. After updating for this task, the hosted repository no longer shows this error.

Apr 28 2015, 9:52 PM · Diffusion
epriestley closed T7972: Starting with 7f43cde, DiffusionRequest resolveRefs fails (only cached entries work) as Resolved by committing Restricted Diffusion Commit.
Apr 28 2015, 3:56 PM · Diffusion
epriestley claimed T7972: Starting with 7f43cde, DiffusionRequest resolveRefs fails (only cached entries work).
Apr 28 2015, 3:07 PM · Diffusion
epriestley added a revision to T7972: Starting with 7f43cde, DiffusionRequest resolveRefs fails (only cached entries work): Restricted Differential Revision.
Apr 28 2015, 3:03 PM · Diffusion
maligree updated the task description for T7972: Starting with 7f43cde, DiffusionRequest resolveRefs fails (only cached entries work).
Apr 28 2015, 2:46 PM · Diffusion
maligree created T7972: Starting with 7f43cde, DiffusionRequest resolveRefs fails (only cached entries work).
Apr 28 2015, 2:45 PM · Diffusion
• TejaKesineni added a comment to T4754: "Accepted Differential Revision exists" Herald field is fairly meaningless.

If we return rule as follows

Apr 28 2015, 8:44 AM · Herald, Diffusion, Differential

Apr 27 2015

epriestley added a comment to T7959: Mercurial doesn't store HTTP passwords in config anymore.

Example working hgrc:

Apr 27 2015, 4:19 PM · Diffusion, Mercurial
epriestley created T7959: Mercurial doesn't store HTTP passwords in config anymore.
Apr 27 2015, 4:16 PM · Diffusion, Mercurial
cspeckmim added a comment to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads).

I have no immediate desire for the branches listing to resemble hg branches, I was just confused at the difference in output. I didn't realize the closed branches had multiple heads in my own repository :).

Apr 27 2015, 2:57 PM · Diffusion
epriestley added a comment to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads).

I think hg branches just picks one head to show when there are multiple heads of a branch. For example, if you're on rev 9 and hg up 8, then make a commit (creating a second local branch head for default), the hg branches command still shows only one head, even though your working copy has multiple open heads of the branch.

Apr 27 2015, 2:51 PM · Diffusion
cspeckmim added a comment to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads).

Yes they all show under hg heads -c as well. Looks like everything is set then as apparently there are multiple heads for the same branches, but all closed.

Apr 27 2015, 2:45 PM · Diffusion
epriestley added a comment to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads).

I'm guessing hg heads -c will also show them.

Apr 27 2015, 2:44 PM · Diffusion
cspeckmim added a comment to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads).

Yes it lists all the ones phabricator shows.

Apr 27 2015, 2:43 PM · Diffusion
epriestley added a comment to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads).

Does hg log --rev 'head()' give you the other heads?

Apr 27 2015, 2:41 PM · Diffusion
cspeckmim added a comment to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads).

Our repo has 4 closed branches and 1 open (being 'default'). The main repo page no longer shows the closed branches, but when viewing all branches, it looks like several are listed twice with different repo heads.

Screen Shot 2015-04-27 at 10.33.44 AM.png (314×895 px, 77 KB)

[cspeck@repo MS]$ hg branches -c
default                    93616:fade3df180a2
mim_4.2.0                  88329:eed05955c3cc (closed)
mim4x_trunk                88328:4dad86161093 (closed)
mim_4.1.0                  88325:02073e640fc3 (closed)
mv_1.1.0                   88324:d6e2fa29ad23 (closed)
Apr 27 2015, 2:39 PM · Diffusion
epriestley added a comment to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads).

I think this is in mostly reasonable shape now, but let us know if there are still issues.

Apr 27 2015, 2:32 PM · Diffusion
epriestley closed T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads) as Resolved by committing Restricted Diffusion Commit.
Apr 27 2015, 10:51 AM · Diffusion
epriestley closed T6160: Don't show closed branches of mercurial repository as Resolved by committing Restricted Diffusion Commit.
Apr 27 2015, 10:51 AM · Mercurial, Diffusion

Apr 26 2015

epriestley closed T7894: Give more specific error when git clone fails as Resolved by committing Restricted Diffusion Commit.
Apr 26 2015, 2:15 PM · Diffusion
chad edited projects for T7938: Do not allow users to enter things like "/" or ".." in the "Clone/Checkout" field in repositories, added: Diffusion; removed Phabricator.
Apr 26 2015, 2:12 PM · Restricted Project, Diffusion
epriestley added a revision to T7894: Give more specific error when git clone fails: Restricted Differential Revision.
Apr 26 2015, 2:09 PM · Diffusion

Apr 25 2015

epriestley renamed T5896: Mercurial fails to parse (A or B or ... or Z) revsets with more than about 300 items from Update error on mercurial repo with 11k+ commits to Mercurial fails to parse (A or B or ... or Z) revsets with more than about 300 items.
Apr 25 2015, 9:43 PM · Diffusion, Mercurial, Daemons
epriestley added a revision to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads): Restricted Differential Revision.
Apr 25 2015, 9:40 PM · Diffusion
epriestley added a revision to T6160: Don't show closed branches of mercurial repository: Restricted Differential Revision.
Apr 25 2015, 9:31 PM · Mercurial, Diffusion
epriestley added a revision to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads): Restricted Differential Revision.
Apr 25 2015, 9:31 PM · Diffusion
epriestley claimed T5896: Mercurial fails to parse (A or B or ... or Z) revsets with more than about 300 items.
Apr 25 2015, 9:29 PM · Diffusion, Mercurial, Daemons
epriestley added a revision to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads): Restricted Differential Revision.
Apr 25 2015, 9:18 PM · Diffusion
epriestley added a revision to T6160: Don't show closed branches of mercurial repository: Restricted Differential Revision.
Apr 25 2015, 9:18 PM · Mercurial, Diffusion
epriestley added a revision to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads): Restricted Differential Revision.
Apr 25 2015, 9:09 PM · Diffusion
epriestley added a revision to T6160: Don't show closed branches of mercurial repository: Restricted Differential Revision.
Apr 25 2015, 9:09 PM · Mercurial, Diffusion
epriestley added a comment to T5896: Mercurial fails to parse (A or B or ... or Z) revsets with more than about 300 items.

D12549 applies the strategy recursively, although we'll probably hit shell argument length limits before we hit 65K branch heads.

Apr 25 2015, 5:01 PM · Diffusion, Mercurial, Daemons
epriestley added a revision to T5896: Mercurial fails to parse (A or B or ... or Z) revsets with more than about 300 items: Restricted Differential Revision.
Apr 25 2015, 4:56 PM · Diffusion, Mercurial, Daemons
epriestley added a comment to T5896: Mercurial fails to parse (A or B or ... or Z) revsets with more than about 300 items.

This is rooted in a limitation with Mercurial. I've filed a report upstream:

Apr 25 2015, 4:46 PM · Diffusion, Mercurial, Daemons
epriestley added a comment to T5896: Mercurial fails to parse (A or B or ... or Z) revsets with more than about 300 items.

The change breaks "Track Only", breaks repositories without "Track Only", breaks new imports, runs 75x slower than necessary in the cases above, etc.

Apr 25 2015, 4:01 PM · Diffusion, Mercurial, Daemons
epriestley added a revision to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads): Restricted Differential Revision.
Apr 25 2015, 3:52 PM · Diffusion
epriestley added a revision to T6160: Don't show closed branches of mercurial repository: Restricted Differential Revision.
Apr 25 2015, 3:52 PM · Mercurial, Diffusion
epriestley added a revision to T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads): Restricted Differential Revision.
Apr 25 2015, 3:24 PM · Diffusion

Apr 24 2015

epriestley renamed T7100: Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads) from Getting 'Ref "default" is ambiguous or does not exist' error (multiple default branches) to Improve handling of ambiguous branch references (tags/branches with the same name, multiple branches heads).
Apr 24 2015, 7:23 PM · Diffusion
robertos added a comment to T6973: Associating Diffusion commits to Projects.

Thanks for implementing this! I will definitely make use of this feature.

Apr 24 2015, 1:44 PM · Feed, Projects, Diffusion

Apr 23 2015

epriestley closed T6973: Associating Diffusion commits to Projects as Resolved.

Global "Commit" rules in Herald can now add or remove projects, so you could write a rule like this:

Apr 23 2015, 10:41 PM · Feed, Projects, Diffusion
mevered added a comment to T929: Allow two arbitrary revisions to be compared in Diffusion.

It would be fantastic to get a view of Diffusion diff's with id and title between builds, to hand to QA with each testable build.

Apr 23 2015, 9:45 PM · Diffusion (v3), Restricted Project
epriestley triaged T7894: Give more specific error when git clone fails as Low priority.
Apr 23 2015, 8:28 PM · Diffusion
btrahan triaged T7852: A repository grep search with no results returns an Unhandled Exception ("ConduitException") as Low priority.

This was intentionally "kicked down the road" as an example of unhandled exceptions generally not being handled so well. See https://secure.phabricator.com/D11789#114084

Apr 23 2015, 8:08 PM · Diffusion
epriestley added a comment to T7894: Give more specific error when git clone fails.

In Git, we get fairly good control over error messages, although less so in Subversion/Mercurial. We emit this particular message ourselves:

Apr 23 2015, 6:33 PM · Diffusion
btrahan added a comment to T7894: Give more specific error when git clone fails.

Ah, okay. We call things applications here so its the "Diffusion application" or you can just say Diffusion.

Apr 23 2015, 5:47 PM · Diffusion
btrahan updated the task description for T7894: Give more specific error when git clone fails.
Apr 23 2015, 5:45 PM · Diffusion
btrahan updated the task description for T7894: Give more specific error when git clone fails.
Apr 23 2015, 5:44 PM · Diffusion
sascha-egerer added a comment to T7894: Give more specific error when git clone fails.

Create a bot User that has Access to a Repository but not to Diffusion. Try to clone which will fail.

Apr 23 2015, 5:41 PM · Diffusion
btrahan added a comment to T7894: Give more specific error when git clone fails.

Isn't this a problem with Docker? ("Diffusion module" is some Docker thing of organizing Phabricator?)

Apr 23 2015, 5:38 PM · Diffusion
chad added a project to T7894: Give more specific error when git clone fails: Diffusion.
Apr 23 2015, 3:33 PM · Diffusion

Apr 22 2015

Mnkras added a comment to T7882: Fatal when viewing commit or searching.

Damn you and your psychic powers!

Apr 22 2015, 3:07 AM · Search, Diffusion
epriestley added a comment to T7882: Fatal when viewing commit or searching.

psyduck

Apr 22 2015, 3:06 AM · Search, Diffusion
epriestley added a comment to T7882: Fatal when viewing commit or searching.

~~ psychic powers ~~

Apr 22 2015, 3:05 AM · Search, Diffusion
Mnkras changed the status of T7882: Fatal when viewing commit or searching from Resolved to Invalid.

whoops

Apr 22 2015, 3:02 AM · Search, Diffusion
Mnkras closed T7882: Fatal when viewing commit or searching as Resolved.

It did :/ thats random (would not have thought of that)

Apr 22 2015, 3:01 AM · Search, Diffusion
epriestley added a comment to T7882: Fatal when viewing commit or searching.

Restart apache or php-fpm and let me know if that fixes it?

Apr 22 2015, 2:59 AM · Search, Diffusion
Mnkras created T7882: Fatal when viewing commit or searching.
Apr 22 2015, 2:56 AM · Search, Diffusion

Apr 18 2015

chrisbolt created T7852: A repository grep search with no results returns an Unhandled Exception ("ConduitException").
Apr 18 2015, 12:03 AM · Diffusion

Apr 15 2015

jpoehls closed T7826: Configure what counts as a "dangerous change" as Resolved.

Well that was fast... And sounds perfect. Thanks!

Apr 15 2015, 12:00 PM · Diffusion
epriestley added a comment to T7826: Configure what counts as a "dangerous change".

You can configure branch-level protection by allowing dangerous changes and then writing a Herald rule to protect specific branches. For example:

Apr 15 2015, 8:43 AM · Diffusion
jpoehls renamed T7826: Configure what counts as a "dangerous change" from Additional "dangerous changes" config options to Configure what counts as a "dangerous change".
Apr 15 2015, 7:22 AM · Diffusion
jpoehls created T7826: Configure what counts as a "dangerous change".
Apr 15 2015, 7:21 AM · Diffusion

Apr 12 2015

chad merged task T7806: Viewing diff with anchor in url makes page jumpy into T7740: Chrome exhibits weird scrolling jumping with anchor in the URL.
Apr 12 2015, 1:12 AM · Google Chrome, Diffusion
Mnkras created T7806: Viewing diff with anchor in url makes page jumpy.
Apr 12 2015, 1:03 AM · Google Chrome, Diffusion

Apr 10 2015

bcran added a comment to T5896: Mercurial fails to parse (A or B or ... or Z) revsets with more than about 300 items.

This appears to solve the problem for me, though Phabricator appears to ignore the 'Track Only' setting and instead imports all hundred or so branches; I don't know if that's at all related to @Jaraill's change though. And I'm also running into T7100.

Apr 10 2015, 11:30 PM · Diffusion, Mercurial, Daemons
epriestley added a comment to T4245: Make repository URIs slightly prettier.

We can prioritize this immediately, I'll follow up in a private thread.

Apr 10 2015, 7:03 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
nickz added a comment to T4245: Make repository URIs slightly prettier.

We'd like this to be done soon as well. People have been complaining about using callsigns.

Apr 10 2015, 6:28 PM · Prioritized, Diffusion (v3), KDE, Restricted Project
m1cha3lf added a project to T7796: Import from SVN is running forever: Diffusion.
Apr 10 2015, 6:44 AM · Diffusion

Apr 9 2015

michaelf added a comment to T929: Allow two arbitrary revisions to be compared in Diffusion.

This will be a very good feature to have considering Github can allow you to do it.

Apr 9 2015, 2:49 AM · Diffusion (v3), Restricted Project