Page MenuHomePhabricator
Feed Advanced Search

Feb 26 2015

• ajbattrick added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

I vote for an "unresolved setup issue" if you have an old MySQL version

Feb 26 2015, 2:07 PM · Support Impact, Remarkup
joshuaspence added a revision to T6916: Allow video embed in remarkup: Unknown Object (Differential Revision).
Feb 26 2015, 2:10 AM · Prioritized, Remarkup

Feb 24 2015

btrahan added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

The simplest fix for this would be to make the pre-5.5 sorting collation utf8_general_ci. Most columns with sort collations have only ASCII text (email addresses, usernames, callsigns) but these do not:

PhrictionDocument->slug
PhabricatorProject->name
ManiphestNameIndex->indexedObjectName
PhamePost->phameTitle
PhabricatorRepository->name
PhabricatorUser (name token table)->token
ManiphestTask->title
PhrictionContent->title
CustomFieldStringIndex->indexValue

Some of these would be easy to fix/degrade but it's hard for others. But it's probably cleanest overall to restrict this set of fields to 3-byte characters until 5.5, since that seems less bad than not having these columns collate letter case properly.

Feb 24 2015, 5:32 PM · Support Impact, Remarkup

Feb 21 2015

epriestley added a comment to T7337: Remarkup on Dashboard: ## This is a Header As Well.

If they're really separate, put a newline between them:

Feb 21 2015, 6:05 PM · Remarkup
devurandom added a comment to T7337: Remarkup on Dashboard: ## This is a Header As Well.

Can you make unnumbered lists count as "text"? And to solve the ambiguous case where you want an unnumbered list as an item in a numbered list, you could use indention as a hint?

Feb 21 2015, 2:26 PM · Remarkup
epriestley closed T7337: Remarkup on Dashboard: ## This is a Header As Well as Wontfix.

We'll render this as a level 2 header if there is any text following it. For example (use "View Raw" to see the markup):

Feb 21 2015, 11:13 AM · Remarkup

Feb 20 2015

chad edited projects for T7337: Remarkup on Dashboard: ## This is a Header As Well, added: Remarkup; removed Dashboards.
Feb 20 2015, 2:35 PM · Remarkup

Feb 18 2015

chad removed a project from T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems: User Delight.
Feb 18 2015, 5:31 AM · Support Impact, Remarkup

Feb 16 2015

johnny-bit added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Is upgrading as painless as a "sudo apt-get upgrade mysql" -- or am I asking for huge amounts of trouble with that level of naivete on my production install?

Feb 16 2015, 11:07 PM · Support Impact, Remarkup
epriestley added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Sorry, I pretty much have no idea.

Feb 16 2015, 10:46 PM · Support Impact, Remarkup
• mholden added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Is upgrading as painless as a "sudo apt-get upgrade mysql" -- or am I asking for huge amounts of trouble with that level of naivete on my production install?

Feb 16 2015, 10:45 PM · Support Impact, Remarkup
epriestley added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

The simplest fix for this would be to make the pre-5.5 sorting collation utf8_general_ci. Most columns with sort collations have only ASCII text (email addresses, usernames, callsigns) but these do not:

Feb 16 2015, 10:35 PM · Support Impact, Remarkup
epriestley added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Aaah, okay. Upgrading to MySQL 5.5 or newer and running bin/storage adjust will fix this. I'll look into getting it fixed for older MySQL versions.

Feb 16 2015, 10:27 PM · Support Impact, Remarkup
• mholden added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

./bin/search index --type USER had no effect.

Feb 16 2015, 10:25 PM · Support Impact, Remarkup
epriestley added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

There is also a very small chance that running this will fix it:

Feb 16 2015, 10:00 PM · Support Impact, Remarkup
epriestley added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Hmm, I'm not sure then. Can you show me the output of this?

Feb 16 2015, 9:58 PM · Support Impact, Remarkup
• mholden added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

And, my head commit is at 5a9d70707b9e16169b8a298135b36dd133e2ae

Feb 16 2015, 9:48 PM · Support Impact, Remarkup
• mholden added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

And, my head commit is at 5a9d70707b9e16169b8a298135b36dd133e2ae

Feb 16 2015, 9:48 PM · Support Impact, Remarkup
• mholden added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Nope, no adjustments

Feb 16 2015, 9:48 PM · Support Impact, Remarkup
• mholden added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

I updated about to the upstream 2 hours ago, I didn't notice any adjustments when I ran my "update.sh" script.

Feb 16 2015, 9:47 PM · Support Impact, Remarkup
epriestley added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Just a guess. I actually can't reproduce this, though, at least immediately:

Feb 16 2015, 9:46 PM · Support Impact, Remarkup
• mholden added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

:p So is that a known bug, expected behavior?

Feb 16 2015, 9:45 PM · Support Impact, Remarkup
epriestley claimed T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

I am a master sleuth.

Feb 16 2015, 9:44 PM · Support Impact, Remarkup
• mholden added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Actually yes, I believe they do

Feb 16 2015, 9:43 PM · Support Impact, Remarkup
epriestley added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Do all the problematic users have uppercase letters in their names?

Feb 16 2015, 9:43 PM · Support Impact, Remarkup
• mholden added projects to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems: Remarkup, User Delight.
Feb 16 2015, 9:43 PM · Support Impact, Remarkup

Feb 15 2015

chad updated subscribers of T5187: Make "Upload File" dialog have a vanilla file upload control.
Feb 15 2015, 12:39 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley updated subscribers of T5394: Add support for specifying heading anchor IDs.
Feb 15 2015, 12:20 AM · Remarkup
epriestley merged task T7270: Shortnames for Phriction document sections into T5394: Add support for specifying heading anchor IDs.
Feb 15 2015, 12:20 AM · Remarkup, Phriction

Feb 14 2015

epkugelmass created T7270: Shortnames for Phriction document sections.
Feb 14 2015, 11:27 PM · Remarkup, Phriction

Feb 13 2015

btrahan closed T7137: Remarkup links to wiki pages should use the wiki page title by default as Wontfix.

We currently have a consistent way of creating links where you specify a full URI for an external link and anything else is guessed to be a wiki doc, and you may optionally provide a title, else the URI is used as the title.

Feb 13 2015, 12:43 AM · Remarkup

Feb 9 2015

epriestley closed T7201: Remarkup {Fxxx,layout=inline} not actually rendered inline as Resolved by committing Restricted Diffusion Commit.
Feb 9 2015, 3:52 PM · Remarkup
qgil updated the task description for T5187: Make "Upload File" dialog have a vanilla file upload control.
Feb 9 2015, 10:28 AM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia

Feb 6 2015

matmarex added a revision to T7201: Remarkup {Fxxx,layout=inline} not actually rendered inline: Unknown Object (Differential Revision).
Feb 6 2015, 10:56 PM · Remarkup
matmarex added a comment to T7201: Remarkup {Fxxx,layout=inline} not actually rendered inline.

Screenshot from description for posterity:

Feb 6 2015, 10:48 PM · Remarkup
matmarex created T7201: Remarkup {Fxxx,layout=inline} not actually rendered inline.
Feb 6 2015, 10:47 PM · Remarkup

Feb 4 2015

chad updated subscribers of T6818: Don't match ")" in hashtags in Remarkup.
Feb 4 2015, 1:19 AM · Guides, Remarkup
chad merged task T7139: Remarkup doesn't render a tag with a following parenthesis correctly into T6818: Don't match ")" in hashtags in Remarkup.
Feb 4 2015, 1:19 AM · Remarkup
chad added a comment to T7138: Remarkup should have an "Link Wiki page" button with typeahead.

In general I think the Remarkup bar is very noob-ish, that is that the features only are useful if you are new to Phabricator. It'd be nice to build some sort of 'search typeahead shortcut' into it for referencing any object (not simply Phriction) quickly without leaving the page. I frequently have to juggle multiple tabs when looks up related tasks and diffs.

Feb 4 2015, 1:18 AM · Remarkup
hach-que created T7139: Remarkup doesn't render a tag with a following parenthesis correctly.
Feb 4 2015, 1:07 AM · Remarkup
hach-que created T7138: Remarkup should have an "Link Wiki page" button with typeahead.
Feb 4 2015, 1:04 AM · Remarkup
hach-que created T7137: Remarkup links to wiki pages should use the wiki page title by default.
Feb 4 2015, 1:03 AM · Remarkup

Jan 27 2015

matmarex added a revision to T5187: Make "Upload File" dialog have a vanilla file upload control: Unknown Object (Differential Revision).
Jan 27 2015, 6:51 AM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
matmarex claimed T5187: Make "Upload File" dialog have a vanilla file upload control.

It would be a lot simpler to use HTML 5 File API together with a regular <input type=file /> field. This won't help the IE8s of the world, but will help users of non-standard, but modern operating systems and browsers.

Jan 27 2015, 6:44 AM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia

Jan 25 2015

johnny-bit added a project to T6299: Remarkup links to objects in Phame break if a CNAME is set: Remarkup.
Jan 25 2015, 11:18 PM · Haskell.org, Remarkup, Phame

Jan 24 2015

CodeMouse92 added a comment to T5301: Inline Remarkup escaping.

I'm unable to escape the bar | to literally put it in a Remarkup table. Used both backticks and %%%|%%%.

Jan 24 2015, 12:21 AM · Remarkup

Jan 14 2015

matmarex added a comment to T6968: Bottom margin inconsistent for paragraphs/lists that are last children in comments.

Thanks!

Jan 14 2015, 8:20 PM · Remarkup
epriestley closed T6968: Bottom margin inconsistent for paragraphs/lists that are last children in comments as Resolved.

Fixed by D11382. (You can put "Fixes T6968" in your commit message to automatically close tasks when changes land.)

Jan 14 2015, 8:16 PM · Remarkup
matmarex added a comment to T6968: Bottom margin inconsistent for paragraphs/lists that are last children in comments.

Note the lack of double spacing and the glorious even margins.

Jan 14 2015, 6:57 AM · Remarkup
matmarex added a revision to T6968: Bottom margin inconsistent for paragraphs/lists that are last children in comments: Unknown Object (Differential Revision).
Jan 14 2015, 6:56 AM · Remarkup
matmarex created T6968: Bottom margin inconsistent for paragraphs/lists that are last children in comments.
Jan 14 2015, 6:38 AM · Remarkup

Jan 13 2015

epriestley renamed T6965: Disambiguate and provide better examples for "NOTE:" syntax in Remarkup documentation from Note, warning and important layouts are not parsed to Disambiguate and provide better examples for "NOTE:" syntax in Remarkup documentation.
Jan 13 2015, 11:09 PM · Documentation, Remarkup
epriestley added a comment to T6965: Disambiguate and provide better examples for "NOTE:" syntax in Remarkup documentation.

Just write this:

Jan 13 2015, 11:07 PM · Documentation, Remarkup
• pmoreau created T6965: Disambiguate and provide better examples for "NOTE:" syntax in Remarkup documentation.
Jan 13 2015, 11:05 PM · Documentation, Remarkup

Jan 12 2015

epriestley merged task T6918: Remarkup object linking for Legalpad for signee status into T5505: Plan Legalpad v2.
Jan 12 2015, 10:39 PM · Remarkup, Restricted Project
epriestley added a comment to T6918: Remarkup object linking for Legalpad for signee status.

After some discussion, this feels like it got more complicated and is largely inferior to "Signature Requests", a planned feature in T5505. I'm just going to merge this into that task.

Jan 12 2015, 10:39 PM · Remarkup, Restricted Project

Jan 9 2015

lpriestley reassigned T6916: Allow video embed in remarkup from lpriestley to nateguchi2.
Jan 9 2015, 8:49 PM · Prioritized, Remarkup
epriestley added a comment to T6918: Remarkup object linking for Legalpad for signee status.

This wouldn't leak the info (if you were not allowed to know about the signature status, the document would appear un-signed), but it might cause some confusion. Maybe using "red" for not signed, "green" for signed, and grey for "you aren't allowed to know" would resolve that.

Jan 9 2015, 6:25 PM · Remarkup, Restricted Project
• chasemp added a comment to T6918: Remarkup object linking for Legalpad for signee status.

I guess it's true that only people now who can edit a doc can see others signee status, and this leaks that info. Wanted to make note in case that's important :) I can't think of why a whether a document is signed would be private, but probably if this task is desirable it should follow the same policy logic as other mentions.

Jan 9 2015, 6:24 PM · Remarkup, Restricted Project
epriestley updated subscribers of T4190: Rebuild remarkup image proxying.

@lpriestley, if this sounds like something reasonable to you, let me know and I can walk you through it in more detail.

Jan 9 2015, 6:17 PM · Contributor Onboarding, Remarkup
nateguchi2 added a comment to T6916: Allow video embed in remarkup.

Diff here: D11297

Jan 9 2015, 5:03 PM · Prioritized, Remarkup
nateguchi2 added a comment to T6916: Allow video embed in remarkup.

Managed to get this working on our install, will bring together a Diff after testing.

Jan 9 2015, 4:08 PM · Prioritized, Remarkup
epriestley added a project to T6918: Remarkup object linking for Legalpad for signee status: Remarkup.
Jan 9 2015, 3:22 PM · Remarkup, Restricted Project
epriestley assigned T6916: Allow video embed in remarkup to lpriestley.

A while ago, we added support for the HTML5 <audio /> tag. We can take the same approach for <video />.

Jan 9 2015, 2:46 PM · Prioritized, Remarkup
nateguchi2 created T6916: Allow video embed in remarkup.
Jan 9 2015, 2:19 PM · Prioritized, Remarkup

Jan 5 2015

richardvanvelzen added a comment to T6823: Remove default highlighting of source code as PHP?.

I would like a configuration option, but I'm fine either way. I took me some time to get used to.

Jan 5 2015, 6:29 PM · Remarkup
epriestley closed T6823: Remove default highlighting of source code as PHP? as Resolved.

This is in HEAD now. I'll keep an ear out for complaints; the behavior has mostly seemed reasonable to me so far.

Jan 5 2015, 5:08 PM · Remarkup
nateguchi2 updated subscribers of T5187: Make "Upload File" dialog have a vanilla file upload control.

+1 for mobile browsers

Jan 5 2015, 2:01 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia

Jan 1 2015

atlight added a comment to T5397: Literal block doesn't work inside tables.

Similar issue: backticks don't escape the pipe in table syntax.

Jan 1 2015, 9:07 AM · Remarkup

Dec 30 2014

epriestley added a comment to T6818: Don't match ")" in hashtags in Remarkup.

For posterity, T6819 discusses the Guides issue specifically.

Dec 30 2014, 11:49 PM · Guides, Remarkup
epriestley added a revision to T6823: Remove default highlighting of source code as PHP?: Restricted Differential Revision.
Dec 30 2014, 6:23 PM · Remarkup
epriestley added a comment to T6823: Remove default highlighting of source code as PHP?.

There's a "Plain Text" option in paste that stops highlighting in Paste.

Dec 30 2014, 6:16 PM · Remarkup
btrahan added a comment to T6823: Remove default highlighting of source code as PHP?.

Paste should get a "no highlight option" the user can select if its not there already.

Dec 30 2014, 6:04 PM · Remarkup
chad added projects to T6445: Rendering SVG images: Remarkup, Files.
Dec 30 2014, 5:25 PM · Wikimedia, Restricted Project, Files
chad placed T5698: Github-style Remarkup previews on a checked-in resource up for grabs.
Dec 30 2014, 5:13 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
richardvanvelzen added a comment to T6823: Remove default highlighting of source code as PHP?.

I'm not entirely sure that no highlighting by default is always reasonable. For example, the company I work at developers mainly PHP, and pretty much all code snippets we write in comments, tasks, etc. are PHP.

Dec 30 2014, 12:50 PM · Remarkup
epriestley added a comment to T6823: Remove default highlighting of source code as PHP?.

this means to use what the user selects when creating the paste? if so, also agreezy

Dec 30 2014, 10:44 AM · Remarkup
btrahan added a comment to T6823: Remove default highlighting of source code as PHP?.
  • If the block is in an inline comment on a diff, default to the language implied by the file (for instance, inlines on a .py file get Python highlighting by default).
    • agreezy
  • If the block is on a paste, default to the language of the paste.
    • this means to use what the user selects when creating the paste? if so, also agreezy
  • If the block is on a revision/commit, default to the majority / plurality language of the revision/commit? Not so sure about this one. Major issue I can think of is that a "PHP" revision may be majority/plurality HTML or CSS, and the highlighters are very different. This is probably hard to figure out, too, and could theoretically change over the course of a revision. Maybe better to leave this rule out.
    • I think inline comments should behave the same on revisions / diffs / commits -- defaulting to the language of the filename. all other comments should have no highlight by default
  • Anywhere else (no context to infer language from), don't highlight by default.
    • agreezy
Dec 30 2014, 7:17 AM · Remarkup

Dec 29 2014

chad removed a project from T4724: Some images appear with the wrong aspect ratio: Phabricator.
Dec 29 2014, 10:39 PM · Remarkup
epriestley created T6823: Remove default highlighting of source code as PHP?.
Dec 29 2014, 6:58 PM · Remarkup
epriestley added a comment to T6818: Don't match ")" in hashtags in Remarkup.

Hmm, I think it auto-reassociates because it's in the description.

Dec 29 2014, 5:07 AM · Guides, Remarkup
chad added a comment to T6818: Don't match ")" in hashtags in Remarkup.

I am unable to un-associate Guides to this task, also. haha.

Dec 29 2014, 3:00 AM · Guides, Remarkup

Dec 28 2014

epriestley created T6818: Don't match ")" in hashtags in Remarkup.
Dec 28 2014, 7:06 PM · Guides, Remarkup
epriestley added a comment to T6592: Differential history mangles bullet numbering in quoted email forward.

rPHU31e0327 partially fixed some of this. Specifically, > --- is no longer interpreted as a list item:

Dec 28 2014, 5:55 PM · Remarkup

Dec 17 2014

chad created T6775: Provide Remarkup Paste-like embed of Diffusion files/lines.
Dec 17 2014, 4:26 PM · Diffusion, Remarkup

Dec 11 2014

Florian added a comment to T5187: Make "Upload File" dialog have a vanilla file upload control.

And unhappily this doesn't solve the problem for mobile browsers :/

Dec 11 2014, 12:30 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
epriestley added a comment to T5187: Make "Upload File" dialog have a vanilla file upload control.

Copy/paste should already work in Chrome.

Dec 11 2014, 12:18 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
qgil added a comment to T5187: Make "Upload File" dialog have a vanilla file upload control.

Just a question: the copy&paste scenario is mentioned here tangentially, but as a feature is very different from a vanilla upload button. Hast it been considered? The main use case are screenshots: user takes a screenshot, it's in the clipboard, can be inserted in a textarea with a paste action. This would be equally beneficial for all users, since it's simpler than drag & drop (you don't need to open the files app to drag from).

Dec 11 2014, 7:14 AM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia

Dec 3 2014

epriestley closed T6668: Need a inline literal formating syntax as Resolved.

Assuming resolved.

Dec 3 2014, 12:04 PM · Remarkup

Dec 2 2014

jzimmerman added a comment to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).

Ideally we would not modify the RAW text at all, rather

Dec 2 2014, 7:16 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley added a comment to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).

I have a mild opinion about rendering the full URL -- I think we're better off preserving features of the input text when we can, and overall find features which discard input text to be frustrating more often than helpful. For example, if I type:

Dec 2 2014, 1:00 PM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
qgil added a comment to T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).

This request has been evolving at https://phabricator.wikimedia.org/T76095 and now we think that the good solution is to actually parse "https://secure.phabricator.com/T5378" just like T5378

Dec 2 2014, 10:33 AM · Customer Impact, Restricted Project, Restricted Project, Hovercards, Remarkup, Wikimedia
epriestley closed T6619: Bring back support for {rPcommit-hash} into Remarkup as Resolved.

Closed by commit rPa8be733e5ffe.

Dec 2 2014, 2:48 AM · Remarkup
epriestley added a revision to T6619: Bring back support for {rPcommit-hash} into Remarkup: Restricted Differential Revision.
Dec 2 2014, 1:53 AM · Remarkup

Dec 1 2014

epriestley closed T6640: [<number>] should not be interpreted as [X] in Remarkup as Resolved.

Closed by commit rPHU549aa1bf1485.

Dec 1 2014, 9:38 PM · Remarkup
epriestley added a revision to T6640: [<number>] should not be interpreted as [X] in Remarkup: Restricted Differential Revision.
Dec 1 2014, 9:35 PM · Remarkup
epriestley closed T6657: Checkboxes should not create bullet lists by default as Resolved.

Closed by commit rPe872f79f6147.

Dec 1 2014, 9:28 PM · Design, Remarkup
epriestley added a revision to T6657: Checkboxes should not create bullet lists by default: Restricted Differential Revision.
Dec 1 2014, 9:25 PM · Design, Remarkup
chad removed 2 mock(s) for T6668: Need a inline literal formating syntax: Restricted Pholio Mock, Restricted Pholio Mock.
Dec 1 2014, 4:54 PM · Remarkup
epriestley added a comment to T6668: Need a inline literal formating syntax.

You can use remarkup.ignored-object-names to ignore specific object names like T1 and P2 if they're common in your organization. If you don't have a use case beyond that, we probably won't pursue this.

Dec 1 2014, 4:08 PM · Remarkup