Page MenuHomePhabricator
Feed Advanced Search

Dec 8 2014

richardvanvelzen added a comment to T6389: Ship TShirt.

spongebob

Dec 8 2014, 10:29 PM · Public & Media Relations
richardvanvelzen added a comment to T6710: Support "timeout" in vanilla MySQL connections.

There seems to be no other way than setting the timeout via ini_set().

Dec 8 2014, 10:26 PM · Infrastructure

Dec 5 2014

richardvanvelzen added a comment to T6699: Inline comments on a revision don't appear in the timeline.

Confirmed to work, thanks!

Dec 5 2014, 7:48 PM · Differential
richardvanvelzen added a comment to T6699: Inline comments on a revision don't appear in the timeline.

We are at 0c37f8db4b82 right now, which includes that commit as well.

Dec 5 2014, 11:52 AM · Differential
richardvanvelzen added a comment to T6687: differential's `date time` space is narrow a bit..

You can check if the optimizelegibility is indeed the cause by disabling it via the web inspector. It is the issue for me, at least.

Dec 5 2014, 8:41 AM · Differential
richardvanvelzen created T6699: Inline comments on a revision don't appear in the timeline.
Dec 5 2014, 8:39 AM · Differential

Dec 4 2014

richardvanvelzen added a comment to T6687: differential's `date time` space is narrow a bit..

This is due to a bug in Chrome (most likely) which makes text-rendering: optimizeLegibility behave very strangely.

Dec 4 2014, 12:00 PM · Differential

Dec 3 2014

richardvanvelzen added a comment to T6675: Profile GC costs in XHProf.

Qafoolabs mentions a "proposed timing API" in a pull request. I can't seem to find anything about anything having been proposed, but it might be worthwhile to keep that in mind.

Dec 3 2014, 11:36 AM · XHProf

Dec 2 2014

richardvanvelzen added a comment to T6675: Profile GC costs in XHProf.

I do see that gc_runs and collected are available (via GC_G(...)) unconditionally? It's not much, but it's more than is available now.

Dec 2 2014, 7:03 PM · XHProf
richardvanvelzen added a comment to T6675: Profile GC costs in XHProf.

Pretty sure you've been across the same path as I was, but I want to share my findings just in case someone can find a way to use it:

Dec 2 2014, 6:27 PM · XHProf

Nov 19 2014

richardvanvelzen added a comment to T6592: Differential history mangles bullet numbering in quoted email forward.

Ah, no - I was wrong. It's because of the ---- line from the quoted section (- indicates a list item too). Observe:

> --
> Hello
> 1. One
> 2. Two

Hello

  1. One
  2. Two
Nov 19 2014, 7:31 PM · Remarkup
richardvanvelzen added a comment to T6592: Differential history mangles bullet numbering in quoted email forward.

I'm guessing that this is a side-effect from rPHU0db4b149c4e0. Strange though. :/

Nov 19 2014, 7:21 PM · Remarkup

Nov 7 2014

anton.vladimirov awarded T4139: Add support for desktop notifications a Like token.
Nov 7 2014, 10:56 PM · Aphlict

Nov 6 2014

richardvanvelzen added a comment to T6348: Windows 7: arc diff --nolint --nounit not working.

Specific link to the source, for future reference: http://git.php.net/?p=php-src.git;a=blob;f=ext/standard/exec.c;h=6106fe2c86bb687979e36e2070a99283cc0a0878;hb=HEAD#l365

Nov 6 2014, 4:03 PM · Arcanist, Windows
richardvanvelzen added a comment to T6112: Arcanist can not upload binaries when use Mercurial on Windows.

See T6348 for details on why this happens. escapeshellarg under Windows removed % signs.

Nov 6 2014, 12:54 PM · Mercurial, Arcanist

Nov 5 2014

richardvanvelzen added a comment to T6473: Provide Arcanist option to disable ANSI colours / Disable ANSI colours on Windows.

I believe the check for TERM should be fine. However, for reference, the Symfony framework uses a slightly simpler check - and will probably behave saner in most of these cases to do go wrong.

Nov 5 2014, 10:02 AM · libphutil, Arcanist

Oct 23 2014

richardvanvelzen added a revision to T6348: Windows 7: arc diff --nolint --nounit not working: Unknown Object (Differential Revision).
Oct 23 2014, 7:59 PM · Arcanist, Windows
richardvanvelzen added a comment to T6348: Windows 7: arc diff --nolint --nounit not working.

Basically, double quotes disappear when passed through escapeshellarg. The command for history basically becomes:

Oct 23 2014, 7:54 PM · Arcanist, Windows
richardvanvelzen claimed T6348: Windows 7: arc diff --nolint --nounit not working.

The history support is useful. I might be able to find out what's happening.

Oct 23 2014, 7:40 PM · Arcanist, Windows
richardvanvelzen added a revision to T6377: [remarkup] Allow specifying start number of an ordered list: Unknown Object (Differential Revision).
Oct 23 2014, 7:24 PM · Remarkup

Oct 16 2014

richardvanvelzen renamed T6331: Closing a revision via a commit generates superfluous "mention" in Task from Closing a revision via a commit generates superfluous "mention" to Closing a revision via a commit generates superfluous "mention" in Task.
Oct 16 2014, 10:07 PM · Transactions, Diffusion
richardvanvelzen added a comment to T6331: Closing a revision via a commit generates superfluous "mention" in Task.

Oh, I notice I forgot to mention it was about a task :/ My apologies for
that.

Oct 16 2014, 4:05 PM · Transactions, Diffusion
richardvanvelzen added a comment to T6331: Closing a revision via a commit generates superfluous "mention" in Task.

I've now seen the same issue over several commits, leading me to believe
that it's not a fluke.

Oct 16 2014, 2:52 PM · Transactions, Diffusion
richardvanvelzen updated the task description for T6331: Closing a revision via a commit generates superfluous "mention" in Task.
Oct 16 2014, 1:12 PM · Transactions, Diffusion
richardvanvelzen created T6331: Closing a revision via a commit generates superfluous "mention" in Task.
Oct 16 2014, 1:12 PM · Transactions, Diffusion

Oct 4 2014

richardvanvelzen added a comment to T6243: Detect MySQL when ONLY_FULL_GROUP_BY is enabled.

It's not very rare, it's just that MySQL (by default) will allow non-standard behavior for the GROUP BY clause.

Oct 4 2014, 3:27 PM · Support Impact

Sep 22 2014

richardvanvelzen added a comment to T6154: XHPAST fails to recognise some syntax errors.

A related case with try..catch..finally (see D10337) works in the same way as @epriestley described. However, in that case it's easy to fix. This may be less trivial, but still worth fixing.

Sep 22 2014, 8:42 PM · XHPAST

Sep 12 2014

richardvanvelzen added a comment to T5368: Update page title to display notification count.

Having the favicon also change would be very cool. I usually have my phabricator tab pinned, which means that I don't see the title.

Sep 12 2014, 10:08 AM · Badge Awarded, Aphlict

Sep 2 2014

richardvanvelzen added a comment to T6003: Support non-Latin scripts in usernames.
  • However, I'm not sure if there's an agreed-upon or standard way to canonicalize combining marks.
Sep 2 2014, 6:56 AM · Wikimedia, People

Aug 22 2014

richardvanvelzen added a revision to T4334: Support PHP5.4+ syntax in XHPAST: Unknown Object (Differential Revision).
Aug 22 2014, 12:50 PM · XHPAST

Aug 21 2014

richardvanvelzen added a comment to T4334: Support PHP5.4+ syntax in XHPAST.

@epriestley: could you take a look at the comment above? I'd push out a diff but for some reason the values of the tokens change when I rebuild xhpast.

Aug 21 2014, 9:57 AM · XHPAST

Jul 30 2014

richardvanvelzen added a comment to T5745: Unable to post only inline comments to an audit.

Verified to work, thanks!

Jul 30 2014, 6:21 PM · Phabricator, Audit
richardvanvelzen created T5745: Unable to post only inline comments to an audit.
Jul 30 2014, 11:27 AM · Phabricator, Audit

Jul 18 2014

richardvanvelzen added a comment to T4334: Support PHP5.4+ syntax in XHPAST.

Catches are optional when you have a while. This small diff fixes that:

Jul 18 2014, 7:27 AM · XHPAST

Jul 15 2014

maroux awarded T4139: Add support for desktop notifications a Like token.
Jul 15 2014, 1:55 AM · Aphlict

Jul 13 2014

richardvanvelzen updated the task description for T5613: Duplicate branch name causes diffusion to crash.
Jul 13 2014, 11:50 AM · Diffusion, Phabricator
richardvanvelzen assigned T5613: Duplicate branch name causes diffusion to crash to epriestley.
Jul 13 2014, 11:50 AM · Diffusion, Phabricator
richardvanvelzen created T5613: Duplicate branch name causes diffusion to crash.
Jul 13 2014, 11:44 AM · Diffusion, Phabricator

Jun 24 2014

richardvanvelzen created T5465: Differential workboard panel is not pretty.
Jun 24 2014, 7:15 PM · Dashboards

Jun 23 2014

richardvanvelzen added a comment to T5431: Arcanist User Guide: Windows: wrong command line key for Sublime Text.

Well, I seem to remember it wrong; when I close the new-commit file in Sublime Text now, arc continues as it should.

Jun 23 2014, 5:34 PM · Arcanist, Windows
richardvanvelzen added a comment to T5431: Arcanist User Guide: Windows: wrong command line key for Sublime Text.

If I recall correctly, I had the same kind-of issue. The file opened in an already opened instance, and arc would only continue if I closed the entire instance. Adding -n helped in that only the new instance had to be closed.

Jun 23 2014, 5:17 PM · Arcanist, Windows

Jun 17 2014

richardvanvelzen edited this Maniphest Task.
Jun 17 2014, 12:13 PM · XHPAST, Arcanist
richardvanvelzen edited this Maniphest Task.
Jun 17 2014, 11:53 AM · Arcanist
richardvanvelzen closed T5086: "arc feature" and "arc bookmark" do not handle 'no bookmarks' correctly as Resolved.

Closed by commit rARC3201239e85ea.

Jun 17 2014, 11:53 AM · Arcanist

Jun 16 2014

richardvanvelzen edited this Maniphest Task.
Jun 16 2014, 10:54 PM · Arcanist
richardvanvelzen edited this Maniphest Task.
Jun 16 2014, 10:05 PM · XHPAST, Arcanist

Jun 5 2014

richardvanvelzen closed T4395: ArcanistPhpcsLinter issue with msdos and cygwin as Resolved.

Closed by commit rPHU3fe4daa19d2c.

Jun 5 2014, 4:41 PM · Arcanist, Windows
richardvanvelzen edited this Maniphest Task.
Jun 5 2014, 4:41 PM · Arcanist, Windows

Jun 4 2014

richardvanvelzen edited P1170 trace.
Jun 4 2014, 7:41 PM

Jun 2 2014

richardvanvelzen edited this Maniphest Task.
Jun 2 2014, 8:59 PM · XHPAST, Windows
richardvanvelzen edited this Maniphest Task.
Jun 2 2014, 8:59 PM · Arcanist, Windows

May 12 2014

richardvanvelzen added a comment to T4395: ArcanistPhpcsLinter issue with msdos and cygwin.

The fix @epriestley mentioned, indeed.

May 12 2014, 6:33 PM · Arcanist, Windows

May 11 2014

richardvanvelzen added a comment to T4395: ArcanistPhpcsLinter issue with msdos and cygwin.

I can confirm that your fix makes the problem go away at my Windows pc. Nice :)

May 11 2014, 8:24 PM · Arcanist, Windows

May 1 2014

richardvanvelzen created T4936: Phame is not accessible on a custom domain without `policy.allow-public`.
May 1 2014, 12:54 PM · Phame

Apr 23 2014

nicereddy awarded T4139: Add support for desktop notifications a Like token.
Apr 23 2014, 11:57 PM · Aphlict

Feb 20 2014

richardvanvelzen assigned T4466: Custom fields in maniphest get updated even when they haven't changed to epriestley.
Feb 20 2014, 10:10 PM · Custom Fields

Feb 7 2014

richardvanvelzen added a comment to T4387: Investigate replacing uses of `hg grep`/`hg manifest` with `hg locate`.

The hg grep search doesn't seem to be too slow. Also, by replacing it with a hg locate command you lose the line numbers which seems to be a shame.

Feb 7 2014, 12:22 PM · Diffusion
richardvanvelzen edited this Maniphest Task.
Feb 7 2014, 11:44 AM · Diffusion

Jan 30 2014

richardvanvelzen edited this Maniphest Task.
Jan 30 2014, 10:37 AM · Diffusion

Jan 28 2014

richardvanvelzen edited P1052 Fork of P1051 no_op.diff.
Jan 28 2014, 8:30 AM

Dec 3 2013

krisbuist awarded T4139: Add support for desktop notifications a Like token.
Dec 3 2013, 8:51 AM · Aphlict

Nov 29 2013

richardvanvelzen edited this Maniphest Task.
Nov 29 2013, 1:07 PM · libphutil
richardvanvelzen raised the priority of T4177: daemons leave lots of error because of closed STDOUT and STDERR from to Needs Triage.
Nov 29 2013, 1:03 PM · libphutil

Nov 20 2013

richardvanvelzen updated subscribers of T4139: Add support for desktop notifications.
Nov 20 2013, 9:13 PM · Aphlict
richardvanvelzen raised the priority of T4139: Add support for desktop notifications from to Needs Triage.
Nov 20 2013, 9:12 PM · Aphlict

Nov 18 2013

richardvanvelzen raised the priority of T4123: Cascade "Analyze Query Plans" in to subrequests from to Needs Triage.
Nov 18 2013, 8:59 PM · Phabricator