Page MenuHomePhabricator

Addressing PHP8 incompatibilities - Diffusion, Drydock, Harbormastor
Needs ReviewPublic

Authored by cspeckmim on Jun 5 2023, 1:11 PM.
Referenced Files
F13288276: D21873.diff
Tue, Jun 4, 10:06 AM
F13276298: D21873.diff
Fri, May 31, 5:48 AM
F13275131: D21873.diff
Fri, May 31, 4:25 AM
F13275119: D21873.id52178.diff
Fri, May 31, 4:25 AM
F13275114: D21873.id52179.diff
Fri, May 31, 4:24 AM
F13275108: D21873.id52180.diff
Fri, May 31, 4:24 AM
F13275070: D21873.diff
Fri, May 31, 4:22 AM
F13274964: D21873.diff
Fri, May 31, 4:15 AM
Restricted Owners Package


Group Reviewers
Blessed Reviewers

Fixing a few more null-string issues.

Test Plan
  • I used the search icon next to a Repository field to list and locate diffusion repositories
  • I modified a repository's default branch name to something, something else, empty, something else - and verified the history page for the repository displayed properly
  • I modified a repository's staging area and view the history of the repository verified the history page displayed properly
  • I created and edited several Almanac resources (all the available different types), and several Drydock Blueprints, one for Almanac Host and one for Working Copy
  • Visited all the UIExample views

Diff Detail

rP Phabricator
Lint Passed
Tests Passed
Build Status
Buildable 25835
Build 35663: arc lint + arc unit

Event Timeline

cspeckmim held this revision as a draft.
Owners added a subscriber: Restricted Owners Package.Jun 5 2023, 1:11 PM
cspeckmim retitled this revision from Addressing PHP8 incompatibilities - Miscellaneous to Addressing PHP8 incompatibilities - Diffusion, Drydock, Harbormastor.Jun 6 2023, 1:45 AM
cspeckmim edited the test plan for this revision. (Show Details)

Found a few things while running through tests. Revert change to DifferentialAuditorsField as it doesn't appear to be necessary (anymore?).

Found two more quick issues

  • Adding search results to dashboard hit an error
  • Viewing the prototype calendar event failed after creating an event