Paths

Table of Contentst

Fix visibility of the `LiskDAO::willWriteData` method
ClosedPublic
Actions

Authored by joshuaspence on Jan 15 2015, 12:35 PM.

Tags

None

Referenced Files

	F15566472: D11409.id.diff
	Thu, May 1, 8:22 PM

	F15562437: D11409.id27410.diff
	Wed, Apr 30, 2:26 AM

	F15547144: D11409.id27410.diff
	Sat, Apr 26, 6:18 PM

	F15547143: D11409.id27400.diff
	Sat, Apr 26, 6:18 PM

	F15547142: D11409.id.diff
	Sat, Apr 26, 6:18 PM

	F15541100: D11409.diff
	Fri, Apr 25, 10:47 AM

	F15526416: D11409.id27410.diff
	Mon, Apr 21, 8:49 PM

	F15520958: D11409.id.diff
	Sun, Apr 20, 9:39 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6822: Fix methods which override other methods with the wrong visibility

Commits

Restricted Diffusion Commit
rP378d4380d381: Fix visibility of the `LiskDAO::willWriteData` method

Summary

Ref T6822.

Test Plan

grep. This method is only called from LiskDAO::update().

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27400.Jan 15 2015, 12:35 PM

joshuaspence retitled this revision from to Fix visibility of the `LiskDAO::willWriteData` method.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 15 2015, 12:35 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 15 2015, 2:21 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 15 2015, 2:21 PM

Closed by commit rP378d4380d381: Fix visibility of the `LiskDAO::willWriteData` method (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 15 2015, 7:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

releeph/

storage/

ReleephBranch.php

2 lines

Diff 27410

View Options

src/applications/releeph/storage/ReleephBranch.php

Fix visibility of the `LiskDAO::willWriteData` methodClosedPublicActions