Page MenuHomePhabricator
Differential D11249

Fix method visibility for `AphrontFormControl` methods
ClosedPublic
Actions

Authored by joshuaspence on Jan 6 2015, 10:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 1:04 PM
Unknown Object (File)
Wed, Dec 18, 3:22 AM
Unknown Object (File)
Mon, Dec 9, 1:17 PM
Unknown Object (File)
Mon, Dec 9, 11:15 AM
Unknown Object (File)
Thu, Dec 5, 3:35 PM
Unknown Object (File)
Thu, Dec 5, 3:26 AM
Unknown Object (File)
Wed, Dec 4, 7:29 AM
Unknown Object (File)
Mon, Dec 2, 3:49 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
Restricted Diffusion Commit
rP7756484a000c: Fix method visibility for `AphrontFormControl` methods
Summary

Ref T6822.

Test Plan

Visual inspection. These methods are only called from within the AphrontFormControl class.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26995.Jan 6 2015, 10:58 AM
joshuaspence retitled this revision from to Fix method visibility for `AphrontFormControl` methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 6 2015, 10:58 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence edited the test plan for this revision. (Show Details)Jan 6 2015, 12:18 PM
joshuaspence edited edge metadata.
epriestley accepted this revision.Jan 6 2015, 2:47 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 6 2015, 2:47 PM
Closed by commit rP7756484a000c: Fix method visibility for `AphrontFormControl` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 6 2015, 8:37 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
flag/
view/
4 lines
releeph/
view/
branch/
4 lines
request/
4 lines

Diff 27025

View Options

src/applications/flag/view/PhabricatorFlagSelectControl.php

Loading...
View Options

src/applications/releeph/view/branch/ReleephBranchPreviewView.php

Loading...
View Options

src/applications/releeph/view/request/ReleephRequestTypeaheadControl.php

Loading...
Phabricator · Built by Phacility