Page MenuHomePhabricator

Fix method visibility for `PhabricatorPolicyAwareQuery` subclasses
ClosedPublic

Authored by joshuaspence on Jan 13 2015, 11:45 AM.
Tags
None
Referenced Files
F12841553: D11367.id27315.diff
Thu, Mar 28, 9:15 PM
F12841552: D11367.id27300.diff
Thu, Mar 28, 9:15 PM
F12840951: D11367.id.diff
Thu, Mar 28, 8:52 PM
Unknown Object (File)
Thu, Mar 28, 1:14 AM
Unknown Object (File)
Tue, Mar 19, 4:31 AM
Unknown Object (File)
Tue, Mar 5, 5:37 AM
Unknown Object (File)
Feb 9 2024, 3:13 AM
Unknown Object (File)
Feb 2 2024, 5:06 PM

Details

Summary

Ref T6822.

Test Plan

grep for the following:

  • ->willFilterPage(
  • ->loadPage(
  • ->didFilterPage(
  • ->getReversePaging(
  • ->didFilterPage(
  • ->willExecute(
  • ->nextPage(

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Fix method visibility for polciy query.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.

Nice, this one's a big one since misusing this API violates policies.

This revision is now accepted and ready to land.Jan 13 2015, 1:36 PM
joshuaspence retitled this revision from Fix method visibility for polciy query to Fix method visibility for `PhabricatorPolicyAwareQuery` subclasses.Jan 13 2015, 7:55 PM
joshuaspence updated this object.
joshuaspence edited edge metadata.
This revision was automatically updated to reflect the committed changes.