Paths

Table of Contentst

Differential D11240

Fix visibility of `AphrontBarView::getDefaultColor()` methods
ClosedPublic
Actions

Authored by joshuaspence on Jan 6 2015, 10:30 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6822: Fix methods which override other methods with the wrong visibility

Commits

Restricted Diffusion Commit
rP0715bce4a1b6: Fix visibility of `AphrontBarView::getDefaultColor()` methods

Summary

Ref T6822.

Test Plan

Visual inspection. This method is only called from within the AphrontBarView class.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26986.Jan 6 2015, 10:30 AM

joshuaspence retitled this revision from to Fix visibility of `AphrontBarView::getDefaultColor()` methods.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 6 2015, 10:30 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence edited the test plan for this revision. (Show Details)Jan 6 2015, 12:28 PM

joshuaspence edited edge metadata.

epriestley accepted this revision.Jan 6 2015, 2:50 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 6 2015, 2:50 PM

Closed by commit rP0715bce4a1b6: Fix visibility of `AphrontBarView::getDefaultColor()` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 6 2015, 8:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

widget/

bars/

AphrontGlyphBarView.php

2 lines

AphrontProgressBarView.php

2 lines

Diff 27032

View Options

src/view/widget/bars/AphrontGlyphBarView.php