Paths

Table of Contentst

Differential D11239

Fix visibility of the `ArcanistLintEngine::buildLinters()` method
ClosedPublic
Actions

Authored by joshuaspence on Jan 6 2015, 10:28 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6822: Fix methods which override other methods with the wrong visibility

Commits

rARCcd591318ca65: Fix visibility of the `ArcanistLintEngine::buildLinters()` method

Summary

Ref T6822. This method needs to be public so that it can be called from ArcanistLintersWorkflow.

Test Plan

Ran arc linters.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 26985.Jan 6 2015, 10:28 AM

joshuaspence retitled this revision from to Fix visibility of the `ArcanistLintEngine::buildLinters()` method.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 6 2015, 10:28 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence edited the test plan for this revision. (Show Details)Jan 6 2015, 12:29 PM

joshuaspence edited edge metadata.

epriestley accepted this revision.Jan 6 2015, 2:50 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 6 2015, 2:50 PM

Closed by commit rARCcd591318ca65: Fix visibility of the `ArcanistLintEngine::buildLinters()` method (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 6 2015, 8:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

engine/

ArcanistLintEngine.php

2 lines

ArcanistUnitTestableLintEngine.php

2 lines

Diff 27035

View Options

src/lint/engine/ArcanistLintEngine.php