Page MenuHomePhabricator
Differential D11370

Fix visiblity of `LiskDAO::getConfiguration()`
ClosedPublic
Actions

Authored by joshuaspence on Jan 13 2015, 11:51 AM.
Tags
None
Referenced Files
F15584002: D11370.diff
Thu, May 8, 1:02 AM
F15583714: D11370.diff
Wed, May 7, 11:19 PM
F15572275: D11370.id27303.diff
Mon, May 5, 1:24 PM
F15569402: D11370.id27303.largetrue.diff
Sat, May 3, 10:31 PM
F15554480: D11370.id27303.diff
Mon, Apr 28, 7:14 AM
F15532493: D11370.id27310.diff
Wed, Apr 23, 4:00 PM
F15528331: D11370.id27310.diff
Tue, Apr 22, 10:27 AM
F15527670: D11370.id.largetrue.diff
Tue, Apr 22, 5:38 AM
View All Files
Subscribers
epriestley
hach-que
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
Restricted Diffusion Commit
rPd6b882a804c7: Fix visiblity of `LiskDAO::getConfiguration()`
Summary

Ref T6822.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27303.Jan 13 2015, 11:51 AM
joshuaspence retitled this revision from to Fix visiblity of `LiskDAO::getConfiguration()`.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 13 2015, 11:51 AM
Herald added subscribers: epriestley, Korvin, hach-que. · View Herald Transcript
epriestley accepted this revision.Jan 13 2015, 1:37 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 13 2015, 1:37 PM
Closed by commit rPd6b882a804c7: Fix visiblity of `LiskDAO::getConfiguration()` (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 13 2015, 7:54 PM
This revision was automatically updated to reflect the committed changes.

Large Diff

This large diff affects 181 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
storage/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
audit/
storage/
2 lines
auth/
storage/
2 lines
2 lines
2 lines
2 lines
2 lines
cache/
storage/
2 lines
calendar/
storage/
2 lines
2 lines
chatlog/
storage/
2 lines
2 lines
conduit/
storage/
2 lines
2 lines
2 lines
2 lines
config/
storage/
2 lines
conpherence/
storage/
2 lines
2 lines
2 lines
2 lines
countdown/
storage/
2 lines
daemon/
storage/
2 lines
2 lines
dashboard/
storage/
2 lines
2 lines
2 lines
differential/
storage/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
diviner/
storage/
2 lines
2 lines
2 lines
doorkeeper/
storage/
2 lines
draft/
storage/
2 lines
drydock/
storage/
2 lines
2 lines
2 lines
2 lines
fact/
storage/
2 lines
2 lines
2 lines
2 lines
feed/
storage/
2 lines
2 lines
files/
storage/
2 lines
2 lines
2 lines
2 lines
flag/
storage/
2 lines
fund/
storage/
2 lines
2 lines
harbormaster/
storage/
2 lines
2 lines
2 lines
2 lines
2 lines
build/
2 lines
2 lines
2 lines
2 lines
2 lines
configuration/
2 lines
2 lines
herald/
storage/
2 lines
2 lines
legalpad/
storage/
2 lines
2 lines
2 lines
2 lines
macro/
storage/
2 lines
mailinglists/
storage/
2 lines
maniphest/
storage/
2 lines
2 lines
metamta/
storage/
2 lines
2 lines
notification/
storage/
2 lines
nuance/
storage/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
oauthserver/
storage/
2 lines
2 lines
2 lines
2 lines
owners/
storage/
2 lines
2 lines
2 lines
passphrase/
storage/
2 lines
2 lines
paste/
storage/
2 lines
2 lines
people/
storage/
2 lines
2 lines
2 lines
2 lines
2 lines
phame/
storage/
2 lines
2 lines
phlux/
storage/
2 lines
pholio/
storage/
2 lines
2 lines
2 lines
phortune/
storage/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
phpast/
storage/
2 lines
phragment/
storage/
2 lines
2 lines
2 lines
2 lines
phrequent/
storage/
2 lines
phriction/
storage/
2 lines
2 lines
policy/
storage/
2 lines
ponder/
storage/
2 lines
2 lines
project/
storage/
2 lines
2 lines
2 lines
2 lines
releeph/
storage/
2 lines
2 lines
2 lines
repository/
storage/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
search/
storage/
2 lines
2 lines
document/
2 lines
2 lines
2 lines
settings/
storage/
2 lines
slowvote/
storage/
2 lines
2 lines
2 lines
system/
storage/
2 lines
2 lines
tokens/
storage/
2 lines
2 lines
2 lines
transactions/
storage/
2 lines
2 lines
xhprof/
storage/
2 lines
infrastructure/
customfield/
storage/
2 lines
2 lines
2 lines
2 lines
daemon/
workers/
storage/
2 lines
2 lines
2 lines
2 lines
sms/
storage/
2 lines
storage/
lisk/
2 lines
__tests__/
2 lines

Diff 27310

View Options

src/applications/almanac/storage/AlmanacBinding.php

View Options

src/applications/almanac/storage/AlmanacDevice.php

View Options

src/applications/almanac/storage/AlmanacInterface.php

View Options

src/applications/almanac/storage/AlmanacNetwork.php

View Options

src/applications/almanac/storage/AlmanacProperty.php

View Options

src/applications/almanac/storage/AlmanacService.php

View Options

src/applications/audit/storage/PhabricatorAuditTransactionComment.php

View Options

src/applications/auth/storage/PhabricatorAuthFactorConfig.php

View Options

src/applications/auth/storage/PhabricatorAuthProviderConfig.php

View Options

src/applications/auth/storage/PhabricatorAuthSSHKey.php

View Options

src/applications/auth/storage/PhabricatorAuthSession.php

View Options

src/applications/auth/storage/PhabricatorAuthTemporaryToken.php

View Options

src/applications/cache/storage/PhabricatorMarkupCache.php

View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

View Options

src/applications/calendar/storage/PhabricatorCalendarHoliday.php

View Options

src/applications/chatlog/storage/PhabricatorChatLogChannel.php

View Options

src/applications/chatlog/storage/PhabricatorChatLogEvent.php

View Options

src/applications/conduit/storage/PhabricatorConduitCertificateToken.php

View Options

src/applications/conduit/storage/PhabricatorConduitConnectionLog.php

View Options

src/applications/conduit/storage/PhabricatorConduitMethodCallLog.php

View Options

src/applications/conduit/storage/PhabricatorConduitToken.php

View Options

src/applications/config/storage/PhabricatorConfigEntry.php

View Options

src/applications/conpherence/storage/ConpherenceIndex.php

View Options

src/applications/conpherence/storage/ConpherenceParticipant.php

View Options

src/applications/conpherence/storage/ConpherenceThread.php

View Options

src/applications/conpherence/storage/ConpherenceTransactionComment.php

View Options

src/applications/countdown/storage/PhabricatorCountdown.php

View Options

src/applications/daemon/storage/PhabricatorDaemonLog.php

View Options

src/applications/daemon/storage/PhabricatorDaemonLogEvent.php

View Options

src/applications/dashboard/storage/PhabricatorDashboard.php

View Options

src/applications/dashboard/storage/PhabricatorDashboardInstall.php

View Options

src/applications/dashboard/storage/PhabricatorDashboardPanel.php

View Options

src/applications/differential/storage/DifferentialAffectedPath.php

View Options

src/applications/differential/storage/DifferentialDiff.php

View Options

src/applications/differential/storage/DifferentialDraft.php

View Options

src/applications/differential/storage/DifferentialHunkLegacy.php

View Options

src/applications/differential/storage/DifferentialHunkModern.php

View Options

src/applications/differential/storage/DifferentialRevision.php

View Options

src/applications/differential/storage/DifferentialTransactionComment.php

View Options

src/applications/diviner/storage/DivinerLiveAtom.php

View Options

src/applications/diviner/storage/DivinerLiveBook.php

View Options

src/applications/diviner/storage/DivinerLiveSymbol.php

View Options

src/applications/doorkeeper/storage/DoorkeeperExternalObject.php

View Options

src/applications/draft/storage/PhabricatorDraft.php

View Options

src/applications/drydock/storage/DrydockBlueprint.php

View Options

src/applications/drydock/storage/DrydockLease.php

View Options

src/applications/drydock/storage/DrydockLog.php

View Options

src/applications/drydock/storage/DrydockResource.php

View Options

src/applications/fact/storage/PhabricatorFactAggregate.php

View Options

src/applications/fact/storage/PhabricatorFactCursor.php

View Options

src/applications/fact/storage/PhabricatorFactDAO.php

View Options

src/applications/fact/storage/PhabricatorFactRaw.php

View Options

src/applications/feed/storage/PhabricatorFeedStoryData.php

View Options

src/applications/feed/storage/PhabricatorFeedStoryReference.php

View Options

src/applications/files/storage/PhabricatorFile.php

View Options

src/applications/files/storage/PhabricatorFileStorageBlob.php

View Options

src/applications/files/storage/PhabricatorFileTransactionComment.php

View Options

src/applications/files/storage/PhabricatorTransformedFile.php

View Options

src/applications/flag/storage/PhabricatorFlag.php

View Options

src/applications/fund/storage/FundBacker.php

View Options

src/applications/fund/storage/FundInitiative.php

View Options

src/applications/harbormaster/storage/HarbormasterBuildCommand.php

View Options

src/applications/harbormaster/storage/HarbormasterBuildMessage.php

View Options

src/applications/harbormaster/storage/HarbormasterBuildable.php

View Options

src/applications/harbormaster/storage/HarbormasterObject.php

View Options

src/applications/harbormaster/storage/HarbormasterScratchTable.php

View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildArtifact.php

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildItem.php

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

View Options

src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php

View Options

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php

View Options

src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php

View Options

src/applications/herald/storage/HeraldRule.php

View Options

src/applications/herald/storage/HeraldRuleEdit.php

View Options

src/applications/legalpad/storage/LegalpadDocument.php

View Options

src/applications/legalpad/storage/LegalpadDocumentBody.php

View Options

src/applications/legalpad/storage/LegalpadDocumentSignature.php

View Options

src/applications/legalpad/storage/LegalpadTransactionComment.php

View Options

src/applications/macro/storage/PhabricatorFileImageMacro.php

View Options

src/applications/mailinglists/storage/PhabricatorMetaMTAMailingList.php

View Options

src/applications/maniphest/storage/ManiphestNameIndex.php

View Options

src/applications/maniphest/storage/ManiphestTask.php

View Options

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

View Options

src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php

View Options

src/applications/notification/storage/PhabricatorFeedStoryNotification.php

View Options

src/applications/nuance/storage/NuanceItem.php

View Options

src/applications/nuance/storage/NuanceQueue.php

View Options

src/applications/nuance/storage/NuanceQueueItem.php

View Options

src/applications/nuance/storage/NuanceRequestor.php

View Options

src/applications/nuance/storage/NuanceRequestorSource.php

View Options

src/applications/nuance/storage/NuanceSource.php

View Options

src/applications/oauthserver/storage/PhabricatorOAuthClientAuthorization.php

View Options

src/applications/oauthserver/storage/PhabricatorOAuthServerAccessToken.php

View Options

src/applications/oauthserver/storage/PhabricatorOAuthServerAuthorizationCode.php

View Options

src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php

View Options

src/applications/owners/storage/PhabricatorOwnersOwner.php

View Options

src/applications/owners/storage/PhabricatorOwnersPackage.php

View Options

src/applications/owners/storage/PhabricatorOwnersPath.php

View Options

src/applications/passphrase/storage/PassphraseCredential.php

View Options

src/applications/passphrase/storage/PassphraseSecret.php

View Options

src/applications/paste/storage/PhabricatorPaste.php

View Options

src/applications/paste/storage/PhabricatorPasteTransactionComment.php

View Options

src/applications/people/storage/PhabricatorExternalAccount.php

View Options

src/applications/people/storage/PhabricatorUser.php

View Options

src/applications/people/storage/PhabricatorUserEmail.php

View Options

src/applications/people/storage/PhabricatorUserLog.php

View Options

src/applications/people/storage/PhabricatorUserProfile.php

View Options

src/applications/phame/storage/PhameBlog.php

View Options

src/applications/phame/storage/PhamePost.php

View Options

src/applications/phlux/storage/PhluxVariable.php

View Options

src/applications/pholio/storage/PholioImage.php

View Options

src/applications/pholio/storage/PholioMock.php

View Options

src/applications/pholio/storage/PholioTransactionComment.php

View Options

src/applications/phortune/storage/PhortuneAccount.php

View Options

src/applications/phortune/storage/PhortuneCart.php

View Options

src/applications/phortune/storage/PhortuneCharge.php

View Options

src/applications/phortune/storage/PhortuneMerchant.php

View Options

src/applications/phortune/storage/PhortunePaymentMethod.php

View Options

src/applications/phortune/storage/PhortunePaymentProviderConfig.php

View Options

src/applications/phortune/storage/PhortuneProduct.php

View Options

src/applications/phortune/storage/PhortunePurchase.php

View Options

src/applications/phpast/storage/PhabricatorXHPASTViewParseTree.php

View Options

src/applications/phragment/storage/PhragmentFragment.php

View Options

src/applications/phragment/storage/PhragmentFragmentVersion.php

View Options

src/applications/phragment/storage/PhragmentSnapshot.php

View Options

src/applications/phragment/storage/PhragmentSnapshotChild.php

View Options

src/applications/phrequent/storage/PhrequentUserTime.php

View Options

src/applications/phriction/storage/PhrictionContent.php

View Options

src/applications/phriction/storage/PhrictionDocument.php

View Options

src/applications/policy/storage/PhabricatorPolicy.php

View Options

src/applications/ponder/storage/PonderAnswer.php

View Options

src/applications/ponder/storage/PonderQuestion.php

View Options

src/applications/project/storage/PhabricatorProject.php

View Options

src/applications/project/storage/PhabricatorProjectColumn.php

View Options

src/applications/project/storage/PhabricatorProjectColumnPosition.php

View Options

src/applications/project/storage/PhabricatorProjectSlug.php

View Options

src/applications/releeph/storage/ReleephBranch.php

View Options

src/applications/releeph/storage/ReleephProject.php

View Options

src/applications/releeph/storage/ReleephRequest.php

View Options

src/applications/repository/storage/PhabricatorRepository.php

View Options

src/applications/repository/storage/PhabricatorRepositoryArcanistProject.php

View Options

src/applications/repository/storage/PhabricatorRepositoryAuditRequest.php

View Options

src/applications/repository/storage/PhabricatorRepositoryBranch.php

View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

View Options

src/applications/repository/storage/PhabricatorRepositoryCommitData.php

View Options

src/applications/repository/storage/PhabricatorRepositoryMirror.php

View Options

src/applications/repository/storage/PhabricatorRepositoryPushEvent.php

View Options

src/applications/repository/storage/PhabricatorRepositoryPushLog.php

View Options

src/applications/repository/storage/PhabricatorRepositoryRefCursor.php

View Options

src/applications/repository/storage/PhabricatorRepositoryStatusMessage.php

View Options

src/applications/repository/storage/PhabricatorRepositorySymbol.php

View Options

src/applications/repository/storage/PhabricatorRepositoryVCSPassword.php

View Options

src/applications/search/storage/PhabricatorNamedQuery.php

View Options

src/applications/search/storage/PhabricatorSavedQuery.php

View Options

src/applications/search/storage/document/PhabricatorSearchDocument.php

View Options

src/applications/search/storage/document/PhabricatorSearchDocumentField.php

View Options

src/applications/search/storage/document/PhabricatorSearchDocumentRelationship.php

View Options

src/applications/settings/storage/PhabricatorUserPreferences.php

View Options

src/applications/slowvote/storage/PhabricatorSlowvoteChoice.php

View Options

src/applications/slowvote/storage/PhabricatorSlowvoteOption.php

View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

View Options

src/applications/system/storage/PhabricatorSystemActionLog.php

View Options

src/applications/system/storage/PhabricatorSystemDestructionLog.php

View Options

src/applications/tokens/storage/PhabricatorToken.php

View Options

src/applications/tokens/storage/PhabricatorTokenCount.php

View Options

src/applications/tokens/storage/PhabricatorTokenGiven.php

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

View Options

src/applications/transactions/storage/PhabricatorApplicationTransactionComment.php

View Options

src/applications/xhprof/storage/PhabricatorXHProfSample.php

View Options

src/infrastructure/customfield/storage/PhabricatorCustomFieldIndexStorage.php

View Options

src/infrastructure/customfield/storage/PhabricatorCustomFieldNumericIndexStorage.php

View Options

src/infrastructure/customfield/storage/PhabricatorCustomFieldStorage.php

View Options

src/infrastructure/customfield/storage/PhabricatorCustomFieldStringIndexStorage.php

View Options

src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php

View Options

src/infrastructure/daemon/workers/storage/PhabricatorWorkerArchiveTask.php

View Options

src/infrastructure/daemon/workers/storage/PhabricatorWorkerTask.php

View Options

src/infrastructure/daemon/workers/storage/PhabricatorWorkerTaskData.php

View Options

src/infrastructure/sms/storage/PhabricatorSMS.php

View Options

src/infrastructure/storage/lisk/LiskDAO.php

View Options

src/infrastructure/storage/lisk/__tests__/LiskIsolationTestDAO.php

Phabricator · Built by Phacility