Fix visibility for `DifferentialManiphestTasksField::readValueFromRevision`
ClosedPublic
Actions

Authored by joshuaspence on Jan 13 2015, 11:33 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6822: Fix methods which override other methods with the wrong visibility

Commits

Restricted Diffusion Commit
rP346d9707075a: Fix visibility for `DifferentialManiphestTasksField::readValueFromRevision`

Summary

Ref T6822.

Test Plan

grep for ->readValueFromRevision(.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27297.Jan 13 2015, 11:33 AM

joshuaspence retitled this revision from to Fix visibility for `DifferentialManiphestTasksField::readValueFromRevision`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 13 2015, 11:33 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 13 2015, 1:35 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 13 2015, 1:35 PM

Closed by commit rP346d9707075a: Fix visibility for `DifferentialManiphestTasksField::readValueFromRevision` (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 13 2015, 8:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialManiphestTasksField.php

2 lines

Diff 27319

View Options

src/applications/differential/customfield/DifferentialManiphestTasksField.php

Fix visibility for `DifferentialManiphestTasksField::readValueFromRevision`ClosedPublicActions