Page MenuHomePhabricator
Differential D11406

Fix visibility of the `PhabricatorWorker::doWork()` methods
ClosedPublic
Actions

Authored by joshuaspence on Jan 15 2015, 12:30 PM.
Tags
None
Referenced Files
F18336229: D11406.diff
Mon, Aug 25, 10:21 AM
F18200245: D11406.id27397.diff
Mon, Aug 18, 4:52 AM
F18095793: D11406.id27413.diff
Fri, Aug 8, 2:31 AM
F18090039: D11406.id27413.diff
Wed, Aug 6, 1:48 PM
F17947892: D11406.id.diff
Thu, Jul 31, 7:13 PM
F17936104: D11406.diff
Wed, Jul 30, 11:57 PM
Unknown Object (File)
May 25 2025, 6:08 AM
Unknown Object (File)
May 6 2025, 7:05 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
Restricted Diffusion Commit
rP94b96ae53319: Fix visibility of the `PhabricatorWorker::doWork()` methods
Summary

Ref T6822. This method is only called from within the PhabricatorWorker::executeTask() and PhabricatorWorker::scheduleTask() methods.

Test Plan

grepped for ->doWork.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27397.Jan 15 2015, 12:30 PM
joshuaspence retitled this revision from to Fix visibility of the `PhabricatorWorker::doWork()` methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 15 2015, 12:30 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 15 2015, 2:21 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2015, 2:21 PM
Closed by commit rP94b96ae53319: Fix visibility of the `PhabricatorWorker::doWork()` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 15 2015, 8:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 27413

View Options

src/applications/harbormaster/worker/HarbormasterBuildWorker.php

Loading...
View Options

src/applications/harbormaster/worker/HarbormasterTargetWorker.php

Loading...
View Options

src/applications/metamta/PhabricatorMetaMTAWorker.php

Loading...
View Options

src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php

Loading...
View Options

src/applications/repository/worker/PhabricatorRepositoryPushMailWorker.php

Loading...
View Options

src/applications/search/worker/PhabricatorSearchWorker.php

Loading...
View Options

src/infrastructure/sms/worker/PhabricatorSMSDemultiplexWorker.php

Loading...
View Options

src/infrastructure/sms/worker/PhabricatorSMSSendWorker.php

Loading...
Phabricator · Built by Phacility