Differential D11414

Fix visibility of the `ArcanistPhpcsLinter::getMandatoryFlags` method
ClosedPublic
Actions

Authored by joshuaspence on Jan 15 2015, 8:14 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6822: Fix methods which override other methods with the wrong visibility

Commits

rARC8173ea3eea73: Fix visibility of the `ArcanistPhpcsLinter::getMandatoryFlags` method

Summary

Ref T6822.

Test Plan

All the cool linters are doing it.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27415.Jan 15 2015, 8:14 PM

joshuaspence retitled this revision from to Fix visibility of the `ArcanistPhpcsLinter::getMandatoryFlags` method.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 15 2015, 8:14 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 15 2015, 8:34 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 15 2015, 8:34 PM

Closed by commit rARC8173ea3eea73: Fix visibility of the `ArcanistPhpcsLinter::getMandatoryFlags` method (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 15 2015, 8:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistPhpcsLinter.php

2 lines

Diff 27419

View Options

src/lint/linter/ArcanistPhpcsLinter.php

Fix visibility of the `ArcanistPhpcsLinter::getMandatoryFlags` methodClosedPublicActions