Change `LiskDAO::generatePHID` to be `public`
ClosedPublic
Actions

Authored by joshuaspence on Jan 13 2015, 11:07 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6822: Fix methods which override other methods with the wrong visibility

Commits

Restricted Diffusion Commit
rP36e0d080a789: Change `LiskDAO::generatePHID` to be `public`

Summary

Ref T6822. There are a bunch of places where we call $something->generatePHID(...) externally (outside of the class). Therefore, these methods need to be public.

Test Plan

I wouldn't expect increasing method visibility to break anything.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27296.Jan 13 2015, 11:07 AM

joshuaspence retitled this revision from to Change `LiskDAO::generatePHID` to be `public`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 13 2015, 11:07 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Jan 13 2015, 1:35 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 13 2015, 1:35 PM

Closed by commit rP36e0d080a789: Change `LiskDAO::generatePHID` to be `public` (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 13 2015, 8:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

storage/

lisk/

LiskDAO.php

2 lines

Diff 27321

View Options

src/infrastructure/storage/lisk/LiskDAO.php

Change `LiskDAO::generatePHID` to be `public`ClosedPublicActions