Page MenuHomePhabricator
Differential D11407

Fix visibility of `ConduitAPIMethod::execute` methods
ClosedPublic
Actions

Authored by joshuaspence on Jan 15 2015, 12:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 12:53 AM
Unknown Object (File)
Fri, Dec 13, 1:57 AM
Unknown Object (File)
Thu, Dec 12, 6:43 PM
Unknown Object (File)
Thu, Dec 12, 1:36 AM
Unknown Object (File)
Wed, Dec 11, 4:58 PM
Unknown Object (File)
Wed, Dec 11, 12:42 PM
Unknown Object (File)
Sun, Dec 8, 4:33 PM
Unknown Object (File)
Sun, Dec 8, 10:35 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T6822: Fix methods which override other methods with the wrong visibility
Commits
Restricted Diffusion Commit
rPa76b161c7ff0: Fix visibility of `ConduitAPIMethod::execute` methods
Summary

Ref T6822. These methods should be protected.

Test Plan

grep

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 27398.Jan 15 2015, 12:32 PM
joshuaspence retitled this revision from to Fix visibility of `ConduitAPIMethod::execute` methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T6822: Fix methods which override other methods with the wrong visibility.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 15 2015, 12:32 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Jan 15 2015, 2:21 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 15 2015, 2:21 PM
joshuaspence updated this object.Jan 15 2015, 7:57 PM
joshuaspence edited edge metadata.
Closed by commit rPa76b161c7ff0: Fix visibility of `ConduitAPIMethod::execute` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 15 2015, 8:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
tokens/
conduit/
2 lines
2 lines
2 lines

Diff 27411

View Options

src/applications/tokens/conduit/TokenGiveConduitAPIMethod.php

Loading...
View Options

src/applications/tokens/conduit/TokenGivenConduitAPIMethod.php

Loading...
View Options

src/applications/tokens/conduit/TokenQueryConduitAPIMethod.php

Loading...
Phabricator · Built by Phacility