Page MenuHomePhabricator

Fix visibility of some `LiskDAO` methods
ClosedPublic

Authored by joshuaspence on Jan 15 2015, 12:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 12, 11:50 PM
Unknown Object (File)
Fri, Feb 2, 2:11 AM
Unknown Object (File)
Sat, Jan 27, 11:26 AM
Unknown Object (File)
Jan 12 2024, 5:17 AM
Unknown Object (File)
Dec 26 2023, 7:52 AM
Unknown Object (File)
Dec 25 2023, 12:29 PM
Unknown Object (File)
Nov 30 2023, 4:43 AM
Unknown Object (File)
Nov 25 2023, 9:46 AM
Subscribers

Details

Summary

Ref T6822.

Test Plan

Ran unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Fix visibility of some `LiskDAO` methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/infrastructure/storage/lisk/__tests__/LiskIsolationTestCase.php
48–51

Since this is on a dedicated test object anyway, and we're testing the test-behavior of the test object, maybe consider defining a public method which calls the protected method instead of bypassing access.

On the other hand, that would make the test less pure. I'm not sure if the sanctity of the test or the sanctity of the visibility keyword is greater. O woe!

This revision is now accepted and ready to land.Jan 15 2015, 2:25 PM
src/infrastructure/storage/lisk/__tests__/LiskIsolationTestCase.php
48–51

I'm just going to leave this as is for now, mainly because I am not good at naming things.

This revision was automatically updated to reflect the committed changes.