Page MenuHomePhabricator

Diffusion (v3)Milestone
ActivePublic

Recent Activity

Mon, May 25

epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

Committer identities ... they're currently stored in a JSON blob so there's no efficient way to query them.

Mon, May 25, 2:26 PM · Customer Impact, Diffusion (v3)
sshannin added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

That was sufficient to get what I needed, thanks so much.

Mon, May 25, 2:15 PM · Customer Impact, Diffusion (v3)

Sun, May 24

epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

Is there a way to find which object(s) an (unmapped) identity was discovered on?

Sun, May 24, 2:16 PM · Customer Impact, Diffusion (v3)

Sat, May 23

sshannin added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

Is there a way to find which object(s) an (unmapped) identity was discovered on? After a rebuild-identities, I have an empty string identity and a couple asdf-style garbage ones. I'd like to find the source of them and either fix them there or see the context to understand the appropriate identity mapping.

Sat, May 23, 6:31 PM · Customer Impact, Diffusion (v3)

Apr 24 2020

epriestley added a revision to T4369: Phabricator HTTP repository hosting has fairly severe scalability limits: D21165: Parse "multipart/form-data" bodies even if "enable_post_data_reading" is on.
Apr 24 2020, 6:10 PM · Diffusion (v3), Restricted Project

Mar 6 2020

epriestley added a subtask for T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable: T13500: During startup, guarantee "(string)1.23" is "1.23", not "1,23".
Mar 6 2020, 5:53 PM · Diffusion (v3)

Feb 28 2020

epriestley added a comment to T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.

See https://discourse.phabricator-community.org/t/data-truncated-when-pushing-into-repository/3586/ for what is likely to be a related issue.

Feb 28 2020, 2:54 PM · Diffusion (v3)

Nov 20 2019

jonah214 added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

Perfect; thanks!

Nov 20 2019, 1:14 PM · Customer Impact, Diffusion (v3)
epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

In the general case:

Nov 20 2019, 7:00 AM · Customer Impact, Diffusion (v3)
jonah214 added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

Sorry if this is a stupid question, but now that this is done, how do I actually map between Phabricator users and VCS user strings, in an existing Diffusion repo?

Nov 20 2019, 3:34 AM · Customer Impact, Diffusion (v3)

Nov 19 2019

epriestley closed T12164: Put an indirection layer between author/committer strings and user accounts as Resolved.

I think this doesn't have anything actionable left, see T13444 for some followups. This feature probably isn't 100% perfect quite yet, but I think remaining work is just cleanup.

Nov 19 2019, 8:37 PM · Customer Impact, Diffusion (v3)

Nov 4 2019

epriestley added a subtask for T12164: Put an indirection layer between author/committer strings and user accounts: T13444: Provide a standalone script entry point for resolving a repository identity.
Nov 4 2019, 8:24 PM · Customer Impact, Diffusion (v3)

Oct 31 2019

epriestley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D20881: Show repository information (and use repository identities) in commit hovercards.
Oct 31 2019, 3:59 PM · Customer Impact, Diffusion (v3)

May 23 2019

epriestley removed a project from T10667: Improve ambiguity when resolving commits that appear in multiple repositories: Remarkup.
May 23 2019, 2:48 PM · Diffusion (v3)

Apr 19 2019

avivey added a comment to T6722: Support "Create similar repository..." in Diffusion.

I think a more powerful approach is to support some kind of "templates", so that we can create a new "Android App" repo or "COM Module" repo directly, similar to how IDEs have project templates.

Apr 19 2019, 7:44 PM · Diffusion (v3), Restricted Project

Apr 15 2019

epriestley closed T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches as Resolved.

I think this is effectively resolved by T13277.

Apr 15 2019, 4:38 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald
epriestley added a parent task for T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches: T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".
Apr 15 2019, 4:31 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald

Apr 14 2019

epriestley closed T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs as Resolved.

See D20419 and T13277.

Apr 14 2019, 6:46 PM · Diffusion (v3), Restricted Project, Mail, Haskell.org, Bug Report
epriestley added a revision to T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs: D20419: Do not publish/notify about commits which are not reachable from any "Autoclose" ref.
Apr 14 2019, 6:39 PM · Diffusion (v3), Restricted Project, Mail, Haskell.org, Bug Report
epriestley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D20418: Use repository identities, not denormalized strings, to identify authors for "Revision closed by commit X" stories.
Apr 14 2019, 5:51 PM · Customer Impact, Diffusion (v3)

Feb 28 2019

epriestley updated the task description for T12164: Put an indirection layer between author/committer strings and user accounts.
Feb 28 2019, 5:29 PM · Customer Impact, Diffusion (v3)

Jan 28 2019

epriestley added a revision to T4369: Phabricator HTTP repository hosting has fairly severe scalability limits: D20046: Read "$_POST" before hooking the profiler, and remove "aphront.default-application-configuration-class".
Jan 28 2019, 7:09 PM · Diffusion (v3), Restricted Project

Nov 21 2018

epriestley added a parent task for T10964: When a branch in Diffusion is not tracked, the UI should be explicit about it: T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Nov 21 2018, 5:05 PM · Diffusion
epriestley updated the task description for T10964: When a branch in Diffusion is not tracked, the UI should be explicit about it.
Nov 21 2018, 5:04 PM · Diffusion

Nov 9 2018

JoyceBabu added a comment to T11314: Observe Mode + GitHub has weird mail interactions due to pull request refs.

I would like to add another use case where this would be beneficial.

Nov 9 2018, 7:23 AM · Diffusion (v3), Restricted Project, Mail, Haskell.org, Bug Report

Sep 24 2018

epriestley closed T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist as Resolved.

Piece by piece, this was effectively untangled. Differential largely moved forward; Arcanist has a path forward in T13098 (although it's ultimately a "major version" sort of change), and Diffusion stuff has settled into relatively actionable plans in, e.g., T13075.

Sep 24 2018, 3:46 PM · Diffusion (v3), Arcanist, Differential
epriestley added a parent task for T12010: Untangle the Gordian Knot of iterating on Differential/Diffusion/Arcanist: T13098: Plans: Arcanist toolsets and extensions.
Sep 24 2018, 3:36 PM · Diffusion (v3), Arcanist, Differential

Aug 13 2018

amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D19580: Update DiffusionLastModifiedController to use identities.
Aug 13 2018, 11:42 PM · Customer Impact, Diffusion (v3)
amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D19492: Start changing DiffusionCommitController to use identities.
Aug 13 2018, 10:36 PM · Customer Impact, Diffusion (v3)

Aug 11 2018

epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

I did rebuild-identities on every instance

Aug 11 2018, 1:56 PM · Customer Impact, Diffusion (v3)
epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

The "activity" migration went to production just now. I expect all production instances just bailed out, since I ran rebuild-identities some time ago, but I'll verify that:

Aug 11 2018, 1:53 PM · Customer Impact, Diffusion (v3)

Aug 9 2018

amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D19497: Add migration to encourage rebuilding repository identities.
Aug 9 2018, 7:32 PM · Customer Impact, Diffusion (v3)

Jun 23 2018

amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D19506: Add --quiet flag to rebuild-identities.
Jun 23 2018, 7:46 PM · Customer Impact, Diffusion (v3)
amckinley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

just wanted to give you some reference data (your mileage may vary), I have 2 Phabricator instances with multiple git repos

one has ~300,000 commits ( a mixture of read-only (mirrors) and hosted repos), the other ~200,000 (all hosted)

in both cases I ran rebuild-identities after doing the Week25 upgrade

time ./bin/repository rebuild-identities --all

it took

21 minutes on the one with 300,000 commits and
16 minutes on the one with 200,000

Can't help but think that this was most likely limited by the speed of the terminal output.

Hope that helps others

Jun 23 2018, 7:39 PM · Customer Impact, Diffusion (v3)
mydeveloperday added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

just wanted to give you some reference data (your mileage may vary), I have 2 Phabricator instances with multiple git repos

Jun 23 2018, 4:49 PM · Customer Impact, Diffusion (v3)

Jun 12 2018

amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D19491: Attach identities to commits and users to identities.
Jun 12 2018, 9:10 PM · Customer Impact, Diffusion (v3)
epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

I deployed D19484 and db010, db024 and db025 finished up with no issues.

Jun 12 2018, 9:07 PM · Customer Impact, Diffusion (v3)
epriestley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D19484: Make re-running `rebuild-identities` a bit faster and add a little progress information.
Jun 12 2018, 2:08 PM · Customer Impact, Diffusion (v3)
epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

These hosts ultimately timed out on the initial rebuild-identities: db010, db024, db025.

Jun 12 2018, 1:55 PM · Customer Impact, Diffusion (v3)

Jun 8 2018

epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

From T13152 -- none of this is too important, just didn't want to lose it when I close that:

Jun 8 2018, 1:52 PM · Customer Impact, Diffusion (v3)

May 10 2018

amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D19443: Assign RepositoryIdentity objects to commits.
May 10 2018, 1:45 AM · Customer Impact, Diffusion (v3)

May 5 2018

amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D19429: Add controllers/search/edit engine functionality to RepositoryIdentity.
May 5 2018, 3:24 AM · Customer Impact, Diffusion (v3)

May 1 2018

amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: D19423: Begin building out RepositoryIdentity indirection layer.
May 1 2018, 8:36 PM · Customer Impact, Diffusion (v3)

Apr 30 2018

epriestley assigned T12164: Put an indirection layer between author/committer strings and user accounts to amckinley.
Apr 30 2018, 10:15 PM · Customer Impact, Diffusion (v3)
epriestley added a comment to T12164: Put an indirection layer between author/committer strings and user accounts.

See PHI594, where a real user had the same human name as an external user from another project.

Apr 30 2018, 10:15 PM · Customer Impact, Diffusion (v3)

Feb 14 2018

epriestley merged T8747: "Path Does Not Exist" error caused by not standard characters into T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.
Feb 14 2018, 1:25 AM · Diffusion (v3)

Feb 4 2018

epriestley added a revision to T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable: D18990: Add some sytem locale utilities to libphutil.
Feb 4 2018, 3:53 PM · Diffusion (v3)
epriestley added a comment to T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.

D18988 addresses the issue from D18105 (git grep 🐑 fails) more directly by calling @setlocale(LC_ALL, 'en_US.UTF-8') unconditionally during startup. The motivating case in T13060 is:

Feb 4 2018, 2:59 PM · Diffusion (v3)

Jan 27 2018

epriestley moved T11767: Unify email patch byte/line/time limit behaviors across Differential/Diffusion from Backlog to Future on the Mail board.
Jan 27 2018, 9:56 PM · Diffusion (v3), Differential, Mail
epriestley closed T12033: Large diffs can still repeatedly fail to insert as Resolved.

This is resolved as far as I'm aware. See also T11767 (improvements to these limits), PHI125 (similar issue with non-UTF8 attachments failing to insert) and T13053 (planning).

Jan 27 2018, 9:55 PM · Diffusion (v3), Restricted Project, Mail, Differential, Bug Report