Page MenuHomePhabricator

DiffusionProject
ActivePublic

Milestones

    • Milestone

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

Source code thing.

Recent Activity

Today

epriestley added a comment to T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".

One minor issue with this is that there's some duplication when the commit Fixes Txxx and the associated revision already has the edge (which is very common if the commit Fixes Txxx, because the revision almost always also Fixes Txxx):

Mon, Feb 24, 9:00 PM · Maniphest, Differential, Diffusion
epriestley closed T5028: Commit message text formatting in remote git repository (SSH) is not preserved as Resolved by committing rP785f3c98da3a: Extract raw commit messages from Git more faithfully across Git versions.
Mon, Feb 24, 8:37 PM · Diffusion
epriestley added a comment to T5028: Commit message text formatting in remote git repository (SSH) is not preserved.

To follow up on this:

Mon, Feb 24, 7:53 PM · Diffusion
epriestley added a revision to T5028: Commit message text formatting in remote git repository (SSH) is not preserved: D21027: Extract raw commit messages from Git more faithfully across Git versions.
Mon, Feb 24, 7:47 PM · Diffusion
epriestley added a comment to T5028: Commit message text formatting in remote git repository (SSH) is not preserved.

I can't find any changelog in any version of Git which mentions the introduction of %B. The %B behavior was introduced in this commit in March, 2010:

Mon, Feb 24, 7:21 PM · Diffusion

Thu, Feb 13

epriestley added a comment to T11968: Decide the fate of FutureGraph.

Probably require PHP 5.4 regardless.

Thu, Feb 13, 1:29 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a comment to T11968: Decide the fate of FutureGraph.

A problem in moving forward here is that we ultimately do very little complex data access in Phabricator, and what complex data access we do perform can often be faked. We likely have more use cases in Arcanist and provisioning code: API calls are slower, workflows are more parallel/interactive, and we can't just fake it all with AJAX.

Thu, Feb 13, 3:59 AM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist

Tue, Feb 4

epriestley closed T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx" as Resolved by committing rP4904d7711ea1: When publishing a commit, copy "Related Tasks" from the associated revision (if….
Tue, Feb 4, 3:05 PM · Maniphest, Differential, Diffusion

Mon, Feb 3

epriestley added a comment to T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".

I just wanted to hold it across the release cut, it's headed to master shortly.

Mon, Feb 3, 7:02 PM · Maniphest, Differential, Diffusion
swisspol added a comment to T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".

@epriestley what's blocking landing this diff?

Mon, Feb 3, 6:46 PM · Maniphest, Differential, Diffusion

Thu, Jan 30

epriestley closed T13440: Provide a richer "Revisions/Commits" UI in Maniphest as Resolved.

Sounds good. It felt slightly odd to me at first, too, but I think I also got used to it.

Thu, Jan 30, 8:16 PM · Diffusion, Differential, Maniphest
swisspol added a comment to T13440: Provide a richer "Revisions/Commits" UI in Maniphest.

It wasn't a major UI issue to start with and yes, you get used to it. I would ignore.

Thu, Jan 30, 7:37 PM · Diffusion, Differential, Maniphest
epriestley added a comment to T13440: Provide a richer "Revisions/Commits" UI in Maniphest.

The empty space means "this is a normal commit with no special audit state", and the column collapses if no commits have issues (see this task for an example). That seems fairly reasonable to me?

Thu, Jan 30, 6:42 PM · Diffusion, Differential, Maniphest
epriestley added a revision to T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx": D20961: When publishing a commit, copy "Related Tasks" from the associated revision (if one exists).
Thu, Jan 30, 6:32 PM · Maniphest, Differential, Diffusion

Jan 21 2020

epriestley added a comment to T13111: Periodically run `git prune` on Git working copies.

The logic here appears to be that gc.auto is set to some value (by default: 6,700). If the number of loose objects exceeds this threshold (technically, if the number of loose objects in objects/17/ is more than 1/256th of this value), it triggers a repack (in a comment, git repack -d -l).

Jan 21 2020, 6:00 PM · Phacility, Diffusion
epriestley added a comment to T13111: Periodically run `git prune` on Git working copies.

See PHI1613, where an install hit this warning (and resolved it by running git prune):

Jan 21 2020, 5:13 PM · Phacility, Diffusion

Jan 16 2020

epriestley closed T13479: Update "git rev-parse --show-toplevel" for Git 2.25.0 as Resolved by committing rP6ccb6a6463f7: Update "git rev-parse" invocation to work in Git 2.25.0.
Jan 16 2020, 7:39 PM · Diffusion
epriestley added a revision to T13479: Update "git rev-parse --show-toplevel" for Git 2.25.0: D20945: Update "git rev-parse" invocation to work in Git 2.25.0.
Jan 16 2020, 7:37 PM · Diffusion
epriestley triaged T13479: Update "git rev-parse --show-toplevel" for Git 2.25.0 as Low priority.
Jan 16 2020, 7:18 PM · Diffusion

Nov 25 2019

epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20927: Implement "PolicyInterface" on "UserEmail" so "EmailQuery" can load them properly.
Nov 25 2019, 11:06 PM · Diffusion

Nov 21 2019

epriestley removed a parent task for T3794: Rebuild Diffusion/Audit on top of CustomField infrastructure: T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234".
Nov 21 2019, 4:06 PM · Restricted Project, Diffusion, Custom Fields
epriestley merged T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234" into T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Nov 21 2019, 4:05 PM · Maniphest, Differential, Diffusion
epriestley added a subtask for T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx": T4211: Commits only appear in tasks if they have "Ref T1234" and not "Maniphest Tasks: T1234".
Nov 21 2019, 4:03 PM · Maniphest, Differential, Diffusion
epriestley added a parent task for T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx": T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships.
Nov 21 2019, 4:03 PM · Maniphest, Differential, Diffusion
epriestley updated the task description for T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx".
Nov 21 2019, 4:02 PM · Maniphest, Differential, Diffusion
epriestley triaged T13463: When a commit is discovered, treat the related revision's "Related Tasks" as "Ref Txxx" as Low priority.
Nov 21 2019, 4:02 PM · Maniphest, Differential, Diffusion

Nov 19 2019

epriestley claimed T13444: Provide a standalone script entry point for resolving a repository identity.
Nov 19 2019, 8:36 PM · Diffusion
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20922: Add a "--dry-run" flag to "bin/repository rebuild-identities".
Nov 19 2019, 8:34 PM · Diffusion
epriestley closed T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration, a subtask of T13444: Provide a standalone script entry point for resolving a repository identity, as Resolved.
Nov 19 2019, 6:19 PM · Diffusion
epriestley closed T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration as Resolved by committing rP63d84e0b44b7: Improve use of keys when iterating over commits in "bin/audit delete" and….
Nov 19 2019, 6:19 PM · Diffusion
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20921: Improve use of keys when iterating over commits in "bin/audit delete" and "bin/repository rebuild-identities".
Nov 19 2019, 6:10 PM · Diffusion
epriestley added a revision to T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration: D20921: Improve use of keys when iterating over commits in "bin/audit delete" and "bin/repository rebuild-identities".
Nov 19 2019, 6:10 PM · Diffusion

Nov 14 2019

epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20914: Update repository identities after all mutations to users and email addresses.
Nov 14 2019, 7:49 PM · Diffusion
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20913: Give "PhabricatorUserEmail" a PHID.
Nov 14 2019, 7:31 PM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Uhhhh, absolutely none of this works because PhabricatorUserEmail does not have a PHID.

Nov 14 2019, 7:20 PM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Another likely bug is:

Nov 14 2019, 7:05 PM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Currently, the flow here is that changes queue a daemon task.

Nov 14 2019, 6:42 PM · Diffusion
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20912: Use DestructionEngine to destroy UserEmail objects.
Nov 14 2019, 6:24 PM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Removing an email does not properly disassociate identities. This unambiguously should.

Nov 14 2019, 6:12 PM · Diffusion
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20911: Add additional flags to "bin/repository rebuild-identities" to improve flexibility.
Nov 14 2019, 5:34 AM · Diffusion
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20910: Consolidate repository identity resolution and detection code.
Nov 14 2019, 4:50 AM · Diffusion
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20909: Remove "PhabricatorEventType::TYPE_DIFFUSION_LOOKUPUSER" event.
Nov 14 2019, 4:25 AM · Diffusion
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20908: Distinguish between "Assigned" and "Effective" identity PHIDs more clearly and consistently.
Nov 14 2019, 4:09 AM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

When you set an identity to "Unassigned", we also set the effective PHID to "Unassigned". This isn't strictly incorrect, but probably makes everything more complicated than it needs to be.

Nov 14 2019, 3:22 AM · Diffusion
epriestley added a revision to T13444: Provide a standalone script entry point for resolving a repository identity: D20907: Make repository identity email address association case-insensitive.
Nov 14 2019, 3:15 AM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.
  • When you set an identity to "Unassigned", we also set the effective PHID to "Unassigned". This isn't strictly incorrect, but probably makes everything more complicated than it needs to be.
Nov 14 2019, 3:05 AM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

The internal construction with LIKE '%...' is also not great:

Nov 14 2019, 2:47 AM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Looking up identities by email address is improperly case-sensitive, because the query is a LIKE query against a binary column.

Nov 14 2019, 2:46 AM · Diffusion
epriestley added a comment to T13444: Provide a standalone script entry point for resolving a repository identity.

Here's a list of bugs I expect exist, although I haven't made it far as reproducing them yet:

Nov 14 2019, 2:41 AM · Diffusion
epriestley added a parent task for T13457: "phabricator_repository.repository_commit" table has poor keys for naive iteration: T13444: Provide a standalone script entry point for resolving a repository identity.
Nov 14 2019, 2:12 AM · Diffusion