Write patterns to "git grep" on stdin instead of passing them with "-e"
ClosedPublic
Actions

Authored by epriestley on Jun 8 2017, 12:56 PM.

Details

Reviewers

chad

Maniphest Tasks

T12807: Diffusion's "Grep File Content" doesn't work with UTF characters

Commits

rPd5163d014345: Write patterns to "git grep" on stdin instead of passing them with "-e"

Summary

Fixes T12807. Some shells may apparently mangle/strip UTF8 characters? Just dodge this whole problem by sending the pattern over stdin rather than actually figuring out the particulars.

Related tasks, like T7339 and T5554, discuss finding broader fixes for this class of issue, and this definitely isn't exactly a fully legitimate fix, but in many cases (as here) we can reasonably just avoid the problem rather than actually fixing it, at least for a long time.

Test Plan

Searched for emoji and non-emoji locally, but this worked fine (on OSX) for me before the patch too.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jun 8 2017, 12:56 PM

Harbormaster completed remote builds in B17449: Diff 43552.Jun 8 2017, 12:58 PM

epriestley mentioned this in T12807: Diffusion's "Grep File Content" doesn't work with UTF characters.Jun 8 2017, 2:48 PM

chad accepted this revision.Jun 8 2017, 10:00 PM

This revision is now accepted and ready to land.Jun 8 2017, 10:00 PM

Closed by commit rPd5163d014345: Write patterns to "git grep" on stdin instead of passing them with "-e" (authored by epriestley, committed by epriestley). · Explain WhyJun 8 2017, 10:25 PM

This revision was automatically updated to reflect the committed changes.

For completeness, T13060 eventually got to the bottom of this: if the parent process has LANG=POSIX or similar, it can not encode UTF8 characters into subprocess command lines without changing the locale setting first.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionSearchQueryConduitAPIMethod.php

7 lines

Diff 43562

View Options

src/applications/diffusion/conduit/DiffusionSearchQueryConduitAPIMethod.php

Write patterns to "git grep" on stdin instead of passing them with "-e"ClosedPublicActions